Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/
---

(Updated Sept. 16, 2016, 10:55 p.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
Vimal Sharma.


Repository: atlas


Description
---

[ATLAS-1098] Added keyword checks while creating a new tag/trait


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
6a937f4 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 4d2429e 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 01c4bfa 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 8a40110 

Diff: https://reviews.apache.org/r/51660/diff/


Testing
---

Tested with all possible keywords specified in the QueryParser, the UI loads up 
the trait definition.

UnitTests create the traitDef and the dsl search gives results


Thanks,

Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review149172
---




repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
 (line 202)


Need to delete this unwanted code. Doesn't correspond to the actual test

Please ignore.


- Apoorv Naik


On Sept. 16, 2016, 5:40 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 16, 2016, 5:40 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  6a937f4 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 4d2429e 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 01c4bfa 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  8a40110 
>   
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
>  52dcfde 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/
---

(Updated Sept. 16, 2016, 5:40 a.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
Vimal Sharma.


Changes
---

Incorporating Shwetha's patch and adding some Unit Tests for the same


Repository: atlas


Description
---

[ATLAS-1098] Added keyword checks while creating a new tag/trait


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
6a937f4 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 4d2429e 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 01c4bfa 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 8a40110 
  
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
 52dcfde 

Diff: https://reviews.apache.org/r/51660/diff/


Testing
---

Tested with all possible keywords specified in the QueryParser, the UI shows a 
red exception message stating that the type being created is a keyword


Thanks,

Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Shwetha GS]

> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 309
> > 
> >
> > This is equals check - typename equals keyword. Does it work if 
> > typename contains keyword e.g., if typename is 'isa PII'?
> > 
> > Not sure if keywords in DSL is case sensitive. You may want to verify
> 
> Apoorv Naik wrote:
> Right now this will go through.
> 
> Apoorv Naik wrote:
> I've tried changing the case but seems like the dsl is not case sensitive 
> for those keywords
> 
> Apoorv Naik wrote:
> While testing, I see that if the keyword has any prefix or suffix 
> separated by a space. The query parser doesn't break. Is that what you're 
> looking for ?
> 
> Shwetha GS wrote:
> You mean DSL is case sensitive for the keywords, so the check need not be 
> case insensitive?
> 
> Weird that the query "Table isa `isa PII`" works, but "Table isa `isa`" 
> doesn't work. As David pointed out, its good if we don't add restrictions on 
> typenames. Can you check queryparser to see if its simple enough fix?

The queries have ` around the typenames with keywords. Formatting removed them


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148651
---


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Shwetha GS]

> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 309
> > 
> >
> > This is equals check - typename equals keyword. Does it work if 
> > typename contains keyword e.g., if typename is 'isa PII'?
> > 
> > Not sure if keywords in DSL is case sensitive. You may want to verify
> 
> Apoorv Naik wrote:
> Right now this will go through.
> 
> Apoorv Naik wrote:
> I've tried changing the case but seems like the dsl is not case sensitive 
> for those keywords
> 
> Apoorv Naik wrote:
> While testing, I see that if the keyword has any prefix or suffix 
> separated by a space. The query parser doesn't break. Is that what you're 
> looking for ?

You mean DSL is case sensitive for the keywords, so the check need not be case 
insensitive?

Weird that the query "Table isa `isa PII`" works, but "Table isa `isa`" doesn't 
work. As David pointed out, its good if we don't add restrictions on typenames. 
Can you check queryparser to see if its simple enough fix?


- Shwetha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148651
---


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 309
> > 
> >
> > This is equals check - typename equals keyword. Does it work if 
> > typename contains keyword e.g., if typename is 'isa PII'?
> > 
> > Not sure if keywords in DSL is case sensitive. You may want to verify
> 
> Apoorv Naik wrote:
> Right now this will go through.
> 
> Apoorv Naik wrote:
> I've tried changing the case but seems like the dsl is not case sensitive 
> for those keywords

While testing, I see that if the keyword has any prefix or suffix separated by 
a space. The query parser doesn't break. Is that what you're looking for ?


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148651
---


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 309
> > 
> >
> > This is equals check - typename equals keyword. Does it work if 
> > typename contains keyword e.g., if typename is 'isa PII'?
> > 
> > Not sure if keywords in DSL is case sensitive. You may want to verify
> 
> Apoorv Naik wrote:
> Right now this will go through.

I've tried changing the case but seems like the dsl is not case sensitive for 
those keywords


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148651
---


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

> On Sept. 12, 2016, 8:24 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 295
> > 
> >
> > TypeSystem.verifyTypes() has all the validations. Please move this 
> > logic there.

Initially I was adding this logic in verifyTypes but looks like there has to a 
dependency change which in turn introduces a circular dependency that's the 
reason I haven't added it in verifyTypes


> On Sept. 12, 2016, 8:24 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  lines 246-247
> > 
> >
> > Can you also add tests for this?

Working on adding the tests


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148465
---


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 309
> > 
> >
> > This is equals check - typename equals keyword. Does it work if 
> > typename contains keyword e.g., if typename is 'isa PII'?
> > 
> > Not sure if keywords in DSL is case sensitive. You may want to verify

Right now this will go through.


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148651
---


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148651
---




repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
(line 309)


This is equals check - typename equals keyword. Does it work if typename 
contains keyword e.g., if typename is 'isa PII'?

Not sure if keywords in DSL is case sensitive. You may want to verify


- Shwetha GS


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Shwetha GS]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148465
---




repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
(lines 246 - 247)


Can you also add tests for this?



repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
(line 295)


TypeSystem.verifyTypes() has all the validations. Please move this logic 
there.


- Shwetha GS


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148130
---


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

> On Sept. 6, 2016, 11:20 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 296
> > 
> >
> > Is it necessary to create ImmutableList for the values in the argument? 
> > Please review.

Not using Immutable list after reviewing the use case.


> On Sept. 6, 2016, 11:20 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> >  line 306
> > 
> >
> > Check if enumDefs is null before using in for(..).
> > 
> > Please review and update other such usage here.

Added a guard condition for all the for each loops


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review147940
---


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/
---

(Updated Sept. 6, 2016, 11:27 p.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
Vimal Sharma.


Repository: atlas


Description
---

[ATLAS-1098] Added keyword checks while creating a new tag/trait


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
4d05d49 

Diff: https://reviews.apache.org/r/51660/diff/


Testing
---

Tested with all possible keywords specified in the QueryParser, the UI shows a 
red exception message stating that the type being created is a keyword


Thanks,

Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review147940
---




repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
(line 296)


Is it necessary to create ImmutableList for the values in the argument? 
Please review.



repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
(line 303)


if keywordCache is empty, none of the following for(..) loops are 
necessary. Consider moving these for(..) loops inside a 
if(keywordCacheNotEmpty() { } block.



repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
(line 306)


Check if enumDefs is null before using in for(..).

Please review and update other such usage here.



repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
(line 308)


It will help to add the keyword in the exception message; like:

  throw new AtlasException("Enum definition name is a keyword: " + 
enumDef.name);
  
Please review and update other exception messages here.


- Madhan Neethiraj


On Sept. 6, 2016, 10:07 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> ---
> 
> (Updated Sept. 6, 2016, 10:07 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
> Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  4d05d49 
> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> ---
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows 
> a red exception message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/
---

(Updated Sept. 6, 2016, 10:07 p.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
Vimal Sharma.


Repository: atlas


Description
---

[ATLAS-1098] Added keyword checks while creating a new tag/trait


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
4d05d49 

Diff: https://reviews.apache.org/r/51660/diff/


Testing
---

Tested with all possible keywords specified in the QueryParser, the UI shows a 
red exception message stating that the type being created is a keyword


Thanks,

Apoorv Naik

Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/
---

Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
Vimal Sharma.


Repository: atlas


Description
---

[ATLAS-1098] Added keyword checks while creating a new tag/trait


Diffs
-

  
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
4d05d49cc2fb9ae6f5e52d09675f3295fed8a56a 

Diff: https://reviews.apache.org/r/51660/diff/


Testing
---

Tested with all possible keywords specified in the QueryParser, the UI shows a 
red exception message stating that the type being created is a keyword


Thanks,

Apoorv Naik