Re: Including "fastavro" in release 1.9.2

2020-02-03 Thread Ismaël Mejía
+1 Having experimental features backported sounds good to enable early testing and feedback, only condition should be not breaking backwards compatibility. Probably worth to mention in the release notes and to create a JIRA + PR to enable this as the default behavior for 1.10. We have to pay

Re: Including "fastavro" in release 1.9.2

2020-02-02 Thread Driesprong, Fokko
Sounds like a plan to me. I don't have any objections. In the far future, I'd like to merge these readers, otherwise, you'll end up with many configuration permutations. This makes it challenging to test each permutation. But first having it as an option in 1.9 is a good idea, so we can battle

Re: Including "fastavro" in release 1.9.2

2020-01-31 Thread Sean Busbey
unless the RM has an objection based on where they are in the RC creation process, I say go for it. (and if there is such an issue then let's get it ready for 1.9.3) On Fri, Jan 31, 2020 at 10:29 AM Ryan Skraba wrote: > > Hello! There's a long standing PR[1][2] that provides an impressive >

Re: Including "fastavro" in release 1.9.2

2020-01-31 Thread Raymie Stata
Yes, it's time to get this in. On Fri, Jan 31, 2020 at 8:28 AM Ryan Skraba wrote: > > Hello! There's a long standing PR[1][2] that provides an impressive > performance boost to deserializing Avro. > > The author has been patient and reactive for a LONG time (thanks Martin!), > and it's inspired

Including "fastavro" in release 1.9.2

2020-01-31 Thread Ryan Skraba
Hello! There's a long standing PR[1][2] that provides an impressive performance boost to deserializing Avro. The author has been patient and reactive for a LONG time (thanks Martin!), and it's inspired some really interesting discussion. I'd like to merge and cherry-pick into release 1.9.2 --