Re: Avro 1.8.2 release

Thanks for merging the patch Ryan. Appreciate it ! On Sun, Oct 30, 2016 at 1:59 PM, Ryan Blue <rb...@netflix.com.invalid> wrote: > SG, > > I'll take a look at it. Thanks! > > rb > > On Sun, Oct 30, 2016 at 1:58 PM, S G <sg.online.em...@gmail.com> wrote: > &g

Re: Avro 1.8.2 release

Hey Ryan, Any chance https://github.com/apache/avro/pull/113 can make it to this release? Its been pending review for a couple months now. Thanks SG On Sun, Oct 30, 2016 at 1:46 PM, Ryan Blue wrote: > Hi everyone, > > I'm going to try to get a 1.8.2 release candidate out this

Re: Need review/merges for couple of pull requests

Hey Ryan, Any chance you were able to look into this (My email on Jun 6)? Thanks SG On Thu, Jun 16, 2016 at 2:05 PM, S G <sg.online.em...@gmail.com> wrote: > Doug Cutting, Ryan Blue, > > I have worked with both of you on this ticket and would appreciate your > thoughts

Re: [GitHub] avro pull request #113: AVRO-1882: ConcurrentHashMap with non-string keys fa...

Hi, Its been about a month since this PR was submitted and there has been no action on this. In total, 35 pull requests are open and pending approval/rejection/review: https://github.com/apache/avro/pulls Does anyone look at opened PRs regularly? Thanks SG On Thu, Jul 28, 2016 at 10:36 AM, S G

Re: [GitHub] avro pull request #114: AVRO-1889: Upgrade maven-shade plugin

Hi, Its been about a month since this PR was submitted and there has been no action on this. In total, 35 pull requests are open and pending approval/rejection/review: https://github.com/apache/avro/pulls Does anyone look at opened PRs regularly? Thanks SG On Thu, Jul 28, 2016 at 10:36 AM, S G

Re: [GitHub] avro pull request #114: AVRO-1889: Upgrade maven-shade plugin

Hi, I submitted this pull request sometime back. Please let me know how I can get this merged. Thanks SG On Mon, Jul 25, 2016 at 3:15 PM, sachingsachin wrote: > GitHub user sachingsachin opened a pull request: > > https://github.com/apache/avro/pull/114 > >

Re: [GitHub] avro pull request #113: AVRO-1882: ConcurrentHashMap with non-string keys fa...

Hi, I submitted this pull request and seems to have the approval of a committer. Please let me know how I can get this merged. Thanks SG On Mon, Jul 25, 2016 at 2:37 PM, sachingsachin wrote: > GitHub user sachingsachin opened a pull request: > >

Re: Unable to build clean checkout of avro from master

The problem was an older version of shade plugin in lang/java/pom.xml I changed it from 1.7.1 to 2.4.3 and everything built just fine. We should probably change this and check it in too. On Fri, Jul 8, 2016 at 5:03 PM, S G <sg.online.em...@gmail.com> wrote: > strange... I did a clean

Re: Unable to build clean checkout of avro from master

fine: > > https://paste.apache.org/iWLJ > > What if you try building from the top level rather than lang/java/avro? > > -Sean > > On Fri, Jul 8, 2016 at 4:23 PM, S G <sg.online.em...@gmail.com> wrote: > > mvn --version is as follows: > > > > Apache Mav

Re: Unable to build clean checkout of avro from master

: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.10.5", arch: "x86_64", family: "mac" On Fri, Jul 8, 2016 at 1:02 PM, Sean Busbey <bus...@cloudera.com> wrote: > Could you copy/paste the output of running "mvn --version&qu

Unable to build clean checkout of avro from master

Hi, I am unable to build a clean checkout of avro from master. Is it a known issue or I am doing something wrong? cd lang/java/avro mvn clean install [INFO] --- maven-bundle-plugin:2.5.3:bundle (default-bundle) @ avro --- [WARNING] Bundle

Re: Need review/merges for couple of pull requests

), then please help me by providing some test-case/code reference. Thanks Sachin On Mon, Jun 6, 2016 at 9:18 AM, S G <sg.online.em...@gmail.com> wrote: > > As far as I have understood the attached testcase, I think the solution in > https://github.com/apache/avro/pull/23/files

Re: Need review/merges for couple of pull requests

can bring the patch up-to-date with the latest master branch and reopen the pull request. Cheers, SG On Wed, Jun 1, 2016 at 5:36 PM, S G <sg.online.em...@gmail.com> wrote: > Thanks RB, > > But I am not sure I follow that example (Probably because there is no >

Re: Need review/merges for couple of pull requests

to use for that ID. The "reference" logical type is applied to > the class that contains a referencable datum. Then there are conversions > that replace a referenceable with its ID. > > On Wed, Jun 1, 2016 at 4:52 PM, S G <sg.online.em...@gmail.com> wrote: > > > RB

Re: Need review/merges for couple of pull requests

lt uses logical types to remove the circular > reference when writing and restore it when reading. It doesn't look like > your test adds logical types, so that's probably the issue. > > rb > > On Wed, Jun 1, 2016 at 1:51 PM, S G <sg.online.em...@gmail.com> wrote: > > > He

Re: Need review/merges for couple of pull requests

ot;, > "type" : { > "type" : "record", > "name" : "Child", > "fields" : [ { > "name" : "c", > "type" : "string" > }, { > "na

Re: [GitHub] avro pull request: AVRO-1568: Allow Java polymorphism in Avro for ...

d > running into trouble? > > rb > > On Thu, May 5, 2016 at 6:08 PM, S G <sg.online.em...@gmail.com> wrote: > > > Hey Ryan, > > > > I think the issue mentioned in > > https://issues.apache.org/jira/browse/AVRO-1568 is still present. > > > > D

Re: [GitHub] avro pull request: AVRO-1568: Allow Java polymorphism in Avro for ...

Hey Ryan, I think the issue mentioned in https://issues.apache.org/jira/browse/AVRO-1568 is still present. Do you know if logical types fixed it somehow? If not, we can work on merging the pull request in latest code-base. Thanks SG On Thu, Feb 4, 2016 at 2:53 PM, asfgit

Re: [DISCUSS] Quarterly release goal

+1 for quarterly releases ! On Sat, Apr 16, 2016 at 7:03 PM, Thiruvalluvan MG < thiru...@yahoo.com.invalid> wrote: > +1. > Thanks > Thiru > > On Sunday, 17 April 2016 5:45 AM, Ryan Blue wrote: > > > Hi everyone, > > It's been about 3 months since we released Avro 1.8.0 and

Re: Need review/merges for couple of pull requests

than add more custom code to support this. Does that sound reasonable? I'm attaching a diff with the working test code so you can take a look at the approach. Let me know what you are thinking. rb On 05/20/2015 12:05 PM, S G wrote: I am requesting some help with AVRO-695. Here are some

Re: Need review/merges for couple of pull requests

a fellow engineer in getting his patch accepted. It would encourage more participation as well as help people wanting to use Avro for circular references. Regards SG On Thu, Apr 30, 2015 at 11:12 AM, S G sg.online.em...@gmail.com wrote: Hey Ryan, Any chances we could atleast get the circular

Re: Working with github pull requests

Thanks for this summary Ryan. I have also found github to be more useful than submitting patch-files. Hope to see more PRs in future. sg On Tue, Mar 31, 2015 at 2:22 PM, Ryan Blue b...@cloudera.com wrote: Hi everyone, There have been more github pull requests lately, partly because I like

Need review/merges for couple of pull requests

Hi, I have submitted patches/pull-requests for a couple of issues. Can someone please review/commit these contributions? 1) https://issues.apache.org/jira/browse/AVRO-695 Cycle Reference Support 2) https://issues.apache.org/jira/browse/AVRO-1569 (Bug fix) ReflectData.AllowNull fails with

Need review/merges for couple of pull requests

Hi, I have submitted patches/pull-requests for couple of issues. Most of the review comments for these have also been fixed. Can someone please do the final reviews and help me commit the same? 1) https://issues.apache.org/jira/browse/AVRO-1568 Allow Java polymorphism in Avro for third-party

Merging AVRO-695: Cyclical references

Hi, Can someone please review/merge the following patch? https://issues.apache.org/jira/browse/AVRO-695 It has been reviewed and performance tested already and an issue similar to it has been already accepted in Hive. Thanks Sachin

Re: Patches requiring review for submission

Hey Ryan, I would appreciate your help on getting these patches in. Thanks Sachin On Wed, Feb 4, 2015 at 11:25 AM, S G sg.online.em...@gmail.com wrote: I have submitted a modified patch for #3 as well. Please help me review and get these committed. Thanks Sachin On Tue, Feb 3, 2015

Re: Patches requiring review for submission

I have submitted a modified patch for #3 as well. Please help me review and get these committed. Thanks Sachin On Tue, Feb 3, 2015 at 12:42 PM, S G sg.online.em...@gmail.com wrote: Thanks a lot for the useful comments Ryan. 1) https://issues.apache.org/jira/browse/AVRO-695 (Cyclical

Re: Patches requiring review for submission

Sachin On Mon, Feb 2, 2015 at 3:36 PM, Ryan Blue b...@cloudera.com wrote: On 01/26/2015 11:03 AM, S G wrote: Hi, I have submitted a couple of patches that need some review. 1) https://issues.apache.org/jira/browse/AVRO-695 (Cyclical references) This looks complicated and has a long

Patches requiring review for submission

Hi, I have submitted a couple of patches that need some review. 1) https://issues.apache.org/jira/browse/AVRO-695 (Cyclical references) 2) https://issues.apache.org/jira/browse/AVRO-680 (Non-string map keys) 3) https://issues.apache.org/jira/browse/AVRO-1554 (Supporting UUID in Avro) Would

Need review on couple of patch submissions

Hi, I would appreciate if someone could review the following submissions: 1) https://issues.apache.org/jira/browse/AVRO-695 (Performance impact for circular refs patch) 2) https://issues.apache.org/jira/browse/AVRO-680 (Performance impact for non-string map-keys patch) 3)

Need reviews on couple of patch submissions

Hi, I would appreciate if someone could review the following submissions: 1) https://issues.apache.org/jira/browse/AVRO-695 (Performance impact for circular refs patch) 2) https://issues.apache.org/jira/browse/AVRO-680 (Performance impact for non-string map-keys patch) 3)

Patches ready for review

Hi, I have incorporated the changes suggested for the following issues: 1) AVRO-680 2) AVRO-695 3) AVRO-1562 Would appreciate if someone can review these. Also, I would like to get some more views/thoughts on AVRO-1571 as well before submitting a patch. Thanks, Sachin

Re: Supporting Polymorphic fields in Avro

, 2014 at 4:40 PM, S G sg.online.em...@gmail.com wrote: Hi, We want to use Java polymorphic fields with Avro. Here is an example of the same. class Base { Integer a = 5; } class Derived extends Base { String b = Foo

Supporting Polymorphic fields in Avro

Hi, We want to use Java polymorphic fields with Avro. Here is an example of the same. class Base { Integer a = 5; } class Derived extends Base { String b = Foo; } class PolymorphicDO { Base b = new Derived(); }

Re: Release Avro 1.8.0 soon?

I have put up a question for AVRO-680 (non-string map keys) and AVRO-1554 (support for UUID and Date-types). Will appreciate if someone could answer those. Thanks Sachin On Tue, Aug 5, 2014 at 7:13 AM, Christophe Taton ta...@wibidata.com wrote: I'd be happy to see AVRO-1334 and AVRO-1550

Why are java.* classes excluded from Avro serialization?

Hi, I see that all the java classes in java.util package are completely ignored by Avro. This includes some of the very commonly used classes like: 1) java.util.Date, 2) java.util.UUID, 3) java.util.Currency and 4) java.util.Locale etc. The code that does that is in ReflectData#getFields(Class?

Review request for non-string map-keys

Hi, Could someone please review the patch non_string_map_keys4.patch for AVRO-680? (https://issues.apache.org/jira/browse/AVRO-680) There have already been some reviews and I think its very close to being frozen. The patch is complete with unit-tests and I also added one for JsonEncoder. Thanks

Review for AVRO-680 patch

Hi, Could someone please review the patch for AVRO-680? (https://issues.apache.org/jira/browse/AVRO-680) I have incorporated all the suggestions and also tested it extensively. The patch is complete with unit-tests. Thanks Sachin

Circular references and non-string map-keys patch

Hi Avro Developers, I have submitted a patch for Circular references and non-string map-keys support in Avro at https://issues.apache.org/jira/browse/AVRO-695 Can someone guide me how I can get it reviewed and commit this patch? Thanks for helping me out, Sachin