[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689909#comment-16689909
]
ASF subversion and git services commented on AVRO-1605:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673661#comment-16673661
]
ASF subversion and git services commented on AVRO-1605:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673666#comment-16673666
]
ASF subversion and git services commented on AVRO-1605:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673664#comment-16673664
]
ASF subversion and git services commented on AVRO-1605:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673667#comment-16673667
]
ASF subversion and git services commented on AVRO-1605:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673665#comment-16673665
]
ASF subversion and git services commented on AVRO-1605:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673662#comment-16673662
]
ASF subversion and git services commented on AVRO-1605:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673663#comment-16673663
]
ASF subversion and git services commented on AVRO-1605:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542364#comment-16542364
]
Ahmet Altay commented on AVRO-1605:
---
What is the status of this issue? This issue was mentioned as a
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493769#comment-16493769
]
Romain Manni-Bucau commented on AVRO-1605:
--
Hi,
it can be neat to move to javax.json API now it
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409861#comment-16409861
]
Mike Yoder commented on AVRO-1605:
--
I wanted to chime in on this issue from a security perspective. The
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282158#comment-16282158
]
Ryan Blue commented on AVRO-1605:
-
I don't think Avro should use accessors or friend packages, so I'm -1 on
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281727#comment-16281727
]
Davide Gesino commented on AVRO-1605:
-
This PR has been opened for a long time. @Ryan Blue do you think
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856011#comment-15856011
]
Gabor Szadovszky commented on AVRO-1605:
[~rdblue], do you have any additional comment here? Still
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728298#comment-15728298
]
Tom White commented on AVRO-1605:
-
I agree that the second approach is not feasible for this reason.
>
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726078#comment-15726078
]
Gabor Szadovszky commented on AVRO-1605:
Currently the classes {{ResolvingGrammarGenerator}},
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725964#comment-15725964
]
Ryan Blue commented on AVRO-1605:
-
I think the second option is the right one. Accessors can be used as an
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725006#comment-15725006
]
Gabor Szadovszky commented on AVRO-1605:
Thanks for the reply, [~rdblue].
I completely agree that
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722949#comment-15722949
]
Ryan Blue commented on AVRO-1605:
-
To keep a patch small, we can break it across multiple issues. I'd
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708893#comment-15708893
]
Gabor Szadovszky commented on AVRO-1605:
What do you think, [~rdblue]?
> Remove Jackson classes
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628478#comment-15628478
]
Gabor Szadovszky commented on AVRO-1605:
- {{Accessor.defaultValue(Field)}} is used to invoke
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620519#comment-15620519
]
Ryan Blue commented on AVRO-1605:
-
This is looking better, but I'd like to see more justification for the
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580234#comment-15580234
]
Gabor Szadovszky commented on AVRO-1605:
Removed some unnecessary calls of the Accessor. The other
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567956#comment-15567956
]
Gabor Szadovszky commented on AVRO-1605:
Thanks for the response, Ryan. Sure, it is reasonable.
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565892#comment-15565892
]
Ryan Blue commented on AVRO-1605:
-
Because I don't think accessors are a good practice, I think that we
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565867#comment-15565867
]
Ryan Blue commented on AVRO-1605:
-
[~gszadovszky], sorry about not getting back to this before now.
>
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544956#comment-15544956
]
Tom White commented on AVRO-1605:
-
I'm not sure how long the accessors would need to be there. In
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544756#comment-15544756
]
Gabor Szadovszky commented on AVRO-1605:
My understanding about this issue was to not "leak" the
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542684#comment-15542684
]
Ryan Blue commented on AVRO-1605:
-
My concern isn't that this is public; I see that these classes are in
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542678#comment-15542678
]
Tom White commented on AVRO-1605:
-
The point behind the accessors is to remove the Jackson classes from the
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542652#comment-15542652
]
Ryan Blue commented on AVRO-1605:
-
If I understand correctly, the motivation behind adding the accessors is
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542497#comment-15542497
]
Tom White commented on AVRO-1605:
-
+1. I ran all the tests and they pass. I'll commit this tomorrow unless
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533271#comment-15533271
]
Gabor Szadovszky commented on AVRO-1605:
Good point.
Found two more references left in javadoc.
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533165#comment-15533165
]
Tom White commented on AVRO-1605:
-
This looks great! If you build the javadoc are there any references left
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529342#comment-15529342
]
Gabor Szadovszky commented on AVRO-1605:
Thanks a lot, [~tomwhite].
The friend package approach
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529260#comment-15529260
]
Tom White commented on AVRO-1605:
-
I see your point. The motivation behind this change is to upgrade to
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529070#comment-15529070
]
Gabor Szadovszky commented on AVRO-1605:
I completely agree that the best way would be removing all
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528994#comment-15528994
]
Tom White commented on AVRO-1605:
-
I'm not sure it gains much to make incompatible changes to deprecated
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528821#comment-15528821
]
Gabor Szadovszky commented on AVRO-1605:
There are many public methods leaking Jackson classes
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526331#comment-15526331
]
Tom White commented on AVRO-1605:
-
I think we should remove the method. How much code needs rewriting?
>
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525473#comment-15525473
]
Gabor Szadovszky commented on AVRO-1605:
Thanks, [~tomwhite]. The purpose is clear.
The question
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525366#comment-15525366
]
Tom White commented on AVRO-1605:
-
The goal with this is to remove the Jackson classes from the public API
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522922#comment-15522922
]
Gabor Szadovszky commented on AVRO-1605:
Thanks for the link, [~tomwhite]. Now, it's clear. :)
How
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522733#comment-15522733
]
Tom White commented on AVRO-1605:
-
Although very rare, backward incompatible changes to the API are
[
https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522493#comment-15522493
]
Gabor Szadovszky commented on AVRO-1605:
I do not know (and failed to find info about) the
45 matches
Mail list logo
