The vote has passed with 3 binding +1s, no 0s or -1s.
On Tue, Nov 20, 2018 at 2:15 PM Kenneth Knowles wrote:
> +1 then.
>
> Thanks for the detailed explanation and links. It will be great to start
> using these and gaining experience with the vendored artifacts.
>
> Kenn
>
> On Tue, Nov 20,
+1 then.
Thanks for the detailed explanation and links. It will be great to start
using these and gaining experience with the vendored artifacts.
Kenn
On Tue, Nov 20, 2018 at 11:27 AM Lukasz Cwik wrote:
> I also looked for documentation as to how this information is used but
> couldn't find
I also looked for documentation as to how this information is used but
couldn't find anything beyond configuring the Maven archive plugin[1].
These seem to be benign since we have been publishing them with
beam-sdks-java-core since at least the 2.0.0 release[2].
I believe these files appear
I notice in the vendored Guava jar there is:
META-INF/maven/com.google.guava/guava/pom.xml
META-INF/maven/com.google.guava/guava/pom.properties
Are these expected? If not, are they benign? I haven't found any
documentation for what these contents actually mean or do.
There are many more in the
It would be nice to have a build task that allows to create the source
artifacts locally, if we cannot publish them.
+1 for the release
On Fri, Nov 16, 2018 at 7:48 AM Lukasz Cwik wrote:
> I have been relying on the Intellij's ability to decompile the class
> files, its not as good as the
I have been relying on the Intellij's ability to decompile the class files,
its not as good as the original source for sure.
On Fri, Nov 16, 2018 at 3:26 AM Maximilian Michels wrote:
> +1
>
> We decided not to publish source files for now. The main reason are
> possible legal issues with
+1
We decided not to publish source files for now. The main reason are
possible legal issues with publishing relocated source code.
On 16.11.18 05:24, Thomas Weise wrote:
Thanks for driving this. Did we reach a conclusion regarding publishing
relocated source artifacts? Debugging would be
Thanks for driving this. Did we reach a conclusion regarding publishing
relocated source artifacts? Debugging would be painful without (unless
manually installed in the local repo).
On Thu, Nov 15, 2018 at 6:05 PM Lukasz Cwik wrote:
> Please review and vote on the release candidate #1 for the
Please review and vote on the release candidate #1 for the vendored
artifacts gRPC 1.13.1 and Guava 20.0:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The creation of these artifacts are the outcome of the discussion about
vendoring[1].
The
