[Vote] Publishing new website designs

2021-02-05 Thread Griselda Cuevas
Hi Everyone, The new designs for the Beam website are ready to be published in PR #13871 [1], so I'd like to start a vote to merge this PR into the master repo. Considering that this PR could get stale very quickly, we're looking to follow the 72h voting period starting Monday, if there are minor

Re: Not running tests that need DirectRunner in core?

2021-02-05 Thread Kyle Weaver
Shouldn't the runner only be needed at runtime? On Fri, Feb 5, 2021 at 10:09 AM Daniel Collins wrote: > Ah looks like its a bit harder than this. But I'll try to make it work for > building all of beam locally then get back to you with a working PR. > > On Fri, Feb 5, 2021 at 1:07 PM Daniel

Re: Not running tests that need DirectRunner in core?

2021-02-05 Thread Daniel Collins
Ah looks like its a bit harder than this. But I'll try to make it work for building all of beam locally then get back to you with a working PR. On Fri, Feb 5, 2021 at 1:07 PM Daniel Collins wrote: > https://github.com/apache/beam/pull/13903 > > On Fri, Feb 5, 2021 at 12:48 PM Robert Bradshaw >

Re: Not running tests that need DirectRunner in core?

2021-02-05 Thread Daniel Collins
https://github.com/apache/beam/pull/13903 On Fri, Feb 5, 2021 at 12:48 PM Robert Bradshaw wrote: > When we were using maven rather than gradle, it was impossible to make the > direct runner a dependency for core tests without making the direct runner > a dependency for core itself (which was

Re: Not running tests that need DirectRunner in core?

2021-02-05 Thread Robert Bradshaw
When we were using maven rather than gradle, it was impossible to make the direct runner a dependency for core tests without making the direct runner a dependency for core itself (which was cyclic). I would be super happy if this got fixed; having to jump through hoops to run the majority of core

Not running tests that need DirectRunner in core?

2021-02-05 Thread Daniel Collins
Hello all, It looks like no tests in sdks/java/core will run if they need a runner (They'll use CrashingRunner instead), and if they are annotated with @Category(NeedsRunner.class), they will be excluded from the test rule. Does anyone know the reason for this? It appears rather old (> 3 years),