Re: Beam SQL Alias issue while using With Clause

2023-03-02 Thread Andrew Pilloud via dev
Hi Talat, I managed to turn your test case into something against Calcite. It looks like there is a bug affecting tables that contain one or more single element structs and no multi element structs. I've sent the details to the Calcite mailing list here.

Re: Review ask for Flink Runner Backlog Metric Bug Fix

2023-02-23 Thread Andrew Pilloud via dev
The bot says there are no reviewers for Flink. Possibly you'll find a volunteer to review it here? On Thu, Feb 23, 2023 at 4:47 PM Talat Uyarer via dev wrote: > Hi, > > I created a bugfix for Flink Runner backlog metrics. I asked OWNERs and > try to run assign reviewer command. But I am not

Re: Beam SQL Alias issue while using With Clause

2023-02-10 Thread Andrew Pilloud via dev
I have a test case that I believe should reproduce this on both head and 2.43 but it ends up with a different logical plan. Can you provide your input types? We have a class of issues around compex types https://github.com/apache/beam/issues/19009 I don't believe the

Re: OpenJDK8 / OpenJDK11 container deprecation

2023-02-07 Thread Andrew Pilloud via dev
This sounds reasonable to me as well. I've made swaps like this in the past, the base image of each is probably a bigger factor than the JDK. The openjdk images were based on Debian 11. The default eclipse-temurin images are based on Ubuntu 22.04 with an alpine option. Ubuntu is a Debian

Re: Beam SQL Alias issue while using With Clause

2023-02-02 Thread Andrew Pilloud via dev
It looks like Calcite stopped considering field names in RelNode equality as of Calcite 2.22 (which we use in Beam v2.34.0+). This can result in a planner state where two nodes that only differ by field name are considered equivalent. I have a fix for Beam in

Re: Beam SQL Alias issue while using With Clause

2023-01-27 Thread Andrew Pilloud via dev
Also this is at very least a Beam bug. You can file a Beam issue if you want, otherwise I will when I get back. Andrew On Fri, Jan 27, 2023 at 11:27 AM Andrew Pilloud wrote: > Hi Talat, > > I did get your test case running and added some logging to > RexProgramBuilder.mergePrograms. There is

Re: Beam SQL Alias issue while using With Clause

2023-01-27 Thread Andrew Pilloud via dev
Hi Talat, I did get your test case running and added some logging to RexProgramBuilder.mergePrograms. There is only one merge that occurs during the test and it has an output type of RecordType(JavaType(int) ID, JavaType(class java.lang.String) V). This does seem like the correct output name but

Re: Beam SQL Alias issue while using With Clause

2023-01-25 Thread Andrew Pilloud via dev
Yes, that worked. The issue does not occur if I disable all of the following planner rules: CoreRules.FILTER_CALC_MERGE, CoreRules.PROJECT_CALC_MERGE, LogicalCalcMergeRule.INSTANCE (which wraps CoreRules.CALC_MERGE), and BeamCalcMergeRule.INSTANCE (which wraps CoreRules.CALC_MERGE). All the

Re: Beam SQL Alias issue while using With Clause

2023-01-24 Thread Andrew Pilloud via dev
+dev@beam.apache.org I tried reproducing this but was not successful, the output schema was as expected. I added the following to BeamSqlMultipleSchemasTest.java at head. (I did discover that PAssert.that(result).containsInAnyOrder(output) doesn't validate column names however.) @Test

Re: [Proposal] Change to Default PubsubMessage Coder

2022-12-19 Thread Andrew Pilloud via dev
I think the Dataflow update concern is the biggest concern and as you point out that can be easily overcome. I generally believe that users who aren't setting the coder don't actually care as long as it works, so changing the default across Beam versions seems relatively low risk. Another

Re: [Proposal] Adopt a Beam I/O Standard

2022-12-16 Thread Andrew Pilloud via dev
y >>> >>> On 13 Dec 2022, at 04:32, Chamikara Jayalath via dev < >>> dev@beam.apache.org> wrote: >>> >>> Yeah, I don't think either finalized or documented (in the Website) the >>> previous iteration. This doc seems to contain details f

Re: [Proposal] Adopt a Beam I/O Standard

2022-12-12 Thread Andrew Pilloud via dev
I believe the previous iteration was here: https://lists.apache.org/thread/3o8glwkn70kqjrf6wm4dyf8bt27s52hk The associated docs are: https://s.apache.org/beam-io-api-standard-documentation https://s.apache.org/beam-io-api-standard This is missing all the relational stuff that was in those docs,

Re: Performance and Cost benchmarking

2022-09-26 Thread Andrew Pilloud via dev
Hi Pranav, I left some comments on your design. Your doc discusses a bunch of details about infrastructure such as testing frameworks, automation, and performance databases, but doesn't describe how it will fit in with our existing infrastructure (Load Tests, Nexmark, Jenkins, InfluxDB, Grafina).