[GitHub] brooklyn-server pull request: Add configuration option to SSH sens...

Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/127#issuecomment-215317250 LGTM; only a couple of very minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] brooklyn-server pull request: Add configuration option to SSH sens...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/127#discussion_r61376470 --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/ssh/SshCommandSensor.java --- @@ -104,7 +107,7 @@ public String get() {

Build failed in Jenkins: brooklyn-master-windows #85

See -- [...truncated 46767 lines...] [JENKINS] Archiving F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\brooklyn-core-0.10.0-SNAPSHOT-sources.jar to

Jenkins build is back to stable : brooklyn-master-build #159

See

[GitHub] brooklyn-client pull request: Adds support for Plugins

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/18#discussion_r61289948 --- Diff: command_runner/runner.go --- @@ -29,14 +30,22 @@ type Runner interface { RunSubCmdByName(cmdName string, subCommand string, c

Build failed in Jenkins: brooklyn-master-windows #84

See -- [...truncated 47068 lines...] Compressed 785.50 KB of artifacts by 93.7% relative to #22 [JENKINS] Archiving

[GitHub] brooklyn-client pull request: Adds support for Plugins

Github user geomacy commented on the pull request: https://github.com/apache/brooklyn-client/pull/18#issuecomment-215131383 Oh - one final final comment - once this has all settled we'll need to add some good developer docs. --- If your project is set up for it, you can reply to

[GitHub] brooklyn-client pull request: Adds support for Plugins

Github user geomacy commented on the pull request: https://github.com/apache/brooklyn-client/pull/18#issuecomment-215129387 That's my comments, for what they're worth. One last more philosophical one - at present the way the plugins work is that you can execute commands on `br`

[GitHub] brooklyn-client pull request: Adds support for Plugins

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/18#discussion_r61283407 --- Diff: io/config.go --- @@ -24,27 +24,53 @@ import ( "path/filepath" "github.com/apache/brooklyn-client/error_handler" +

Jenkins build is unstable: brooklyn-master-build #158

See

[GitHub] brooklyn-server pull request: Add configuration option to SSH sens...

Github user grkvlt commented on the pull request: https://github.com/apache/brooklyn-server/pull/127#issuecomment-215120974 I have left the default for the new `TRIM` option as `false` to keep existing behaviour. Should be pretty safe to merge. @aledsage WDYT? --- If your project is

[GitHub] brooklyn-client pull request: Adds support for Plugins

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/18#discussion_r61277670 --- Diff: command_runner/runner.go --- @@ -29,14 +30,22 @@ type Runner interface { RunSubCmdByName(cmdName string, subCommand string, c

[GitHub] brooklyn-client pull request: Adds support for Plugins

Github user geomacy commented on the pull request: https://github.com/apache/brooklyn-client/pull/18#issuecomment-215113957 Running the sample plugin gives ``` $ br sample-command Running the sample plugin 0 Id Name StatusLocation 1 uaOpKnP6

[GitHub] brooklyn-client pull request: Adds support for Plugins

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/18#discussion_r61274582 --- Diff: br/brooklyn.go --- @@ -19,45 +19,73 @@ package main import ( + "fmt" "github.com/apache/brooklyn-client/app"

[GitHub] brooklyn-client pull request: Adds support for Plugins

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/18#discussion_r61272247 --- Diff: commands/install-plugin.go --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] brooklyn-client pull request: Adds support for Plugins

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/18#discussion_r61271120 --- Diff: commands/install-plugin.go --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: 0.9.x branch

Yes, I think Aled's right. The `0.9.x` branch is for all releases made from 0.9.0-SNAPSHOT, and they should be identified by tags on the commits for particular release versions. So development continues on master and we pull in the required hotfix and patch commits to 0.9.x from there. Same model

[GitHub] brooklyn-server pull request: Wait to start windows parameter.

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the