Re: Call for release: Brooklyn 0.10.0

2016-11-16 Thread Svetoslav Neykov
This is going to be the first release that actually works in Karaf. The docs are still assuming classic though so I suggest we keep recommending the classic distribution for 0.10.0. For next release let's plan on updating the docs and switching the recommended distribution to the Karaf based

[GitHub] brooklyn-docs pull request #126: Use brooklyn user for easier copy

2016-11-16 Thread neykov
GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-docs/pull/126 Use brooklyn user for easier copy The brooklyn user is the most common one used for running instances (created by the rpm & deb packages). You can merge this pull request into a Git

[GitHub] brooklyn-docs pull request #124: tidy curl args

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs issue #124: tidy curl args

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-docs/pull/124 Thanks, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Created] (BROOKLYN-389) Allow users to customize startup scripts behaviour

2016-11-16 Thread Svetoslav Neykov (JIRA)
Svetoslav Neykov created BROOKLYN-389: - Summary: Allow users to customize startup scripts behaviour Key: BROOKLYN-389 URL: https://issues.apache.org/jira/browse/BROOKLYN-389 Project: Brooklyn

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672938#comment-15672938 ] ASF GitHub Bot commented on BROOKLYN-345: - Github user neykov commented on the issue:

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/440 Failing jenkins tests: ``` Failed tests: ConfigNestedYamlTest.testCatalogParameterFromSuperYamlTypeAsSoftware:90->doTestWithBlueprint:101->checkEntity:122 missing 'field'

[GitHub] brooklyn-server issue #396: [WIP] A test to check rebind when bundle prefixe...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/396 Superseded by https://github.com/apache/brooklyn-server/pull/442, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] brooklyn-server pull request #396: [WIP] A test to check rebind when bundle ...

2016-11-16 Thread neykov
Github user neykov closed the pull request at: https://github.com/apache/brooklyn-server/pull/396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Jenkins build is back to normal : brooklyn-master-build #527

2016-11-16 Thread Apache Jenkins Server
See

[jira] [Commented] (BROOKLYN-379) Rebind error when entity type references pre-installed OSGi bundle

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672063#comment-15672063 ] ASF GitHub Bot commented on BROOKLYN-379: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server pull request #442: BROOKLYN-379: Fix rebind when bundle pref...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/442#discussion_r88356229 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/OsgiClassPrefixer.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the

[jira] [Commented] (BROOKLYN-379) Rebind error when entity type references pre-installed OSGi bundle

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672057#comment-15672057 ] ASF GitHub Bot commented on BROOKLYN-379: - GitHub user aledsage opened a pull request:

[GitHub] brooklyn-server issue #396: [WIP] A test to check rebind when bundle prefixe...

2016-11-16 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/396 @neykov This is replaced by https://github.com/apache/brooklyn-server/pull/442 - do you want to close this PR? --- If your project is set up for it, you can reply to this email and have

[GitHub] brooklyn-server pull request #442: BROOKLYN-379: Fix rebind when bundle pref...

2016-11-16 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/442 BROOKLYN-379: Fix rebind when bundle prefixes are used to load classes This replaces https://github.com/apache/brooklyn-server/pull/396 See also

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88353667 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88353338 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88352921 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88352692 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0

[GitHub] brooklyn-server pull request #441: Fixing HttpResponse headers value

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/441#discussion_r88349432 --- Diff: core/src/test/java/org/apache/brooklyn/util/executor/HttpExecutorImplTest.java --- @@ -71,6 +75,36 @@ public void afterMethod() throws

[GitHub] brooklyn-server pull request #434: More brooklyn-server integration tests fi...

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #434: More brooklyn-server integration tests fixes

2016-11-16 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/434 LGTM; merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Jenkins build is back to normal : brooklyn-server-master #341

2016-11-16 Thread Apache Jenkins Server
See

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671643#comment-15671643 ] ASF GitHub Bot commented on BROOKLYN-345: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server pull request #440: BROOKLYN-345: persist brooklyn.parameters...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/440#discussion_r88331232 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ServiceFailureDetectorYamlTest.java --- @@ -0,0 +1,189 @@ +/*

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671576#comment-15671576 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-server pull request #435: BROOKLYN-325: alert if provisioning/termi...

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671573#comment-15671573 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on the issue:

[GitHub] brooklyn-server issue #435: BROOKLYN-325: alert if provisioning/termination ...

2016-11-16 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/435 Thanks, I'll not include clearing the indicators in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (BROOKLYN-382) Catalog takes long time to load in web-console

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671178#comment-15671178 ] ASF GitHub Bot commented on BROOKLYN-382: - Github user aledsage commented on the issue:

[jira] [Commented] (BROOKLYN-382) Catalog takes long time to load in web-console

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671186#comment-15671186 ] ASF GitHub Bot commented on BROOKLYN-382: - Github user neykov commented on the issue:

[GitHub] brooklyn-server pull request #423: BROOKLYN-382: get-catalog performance imp...

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #423: BROOKLYN-382: get-catalog performance improvemen...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/423 Thanks @aledsage. Looks good, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server issue #435: BROOKLYN-325: alert if provisioning/termination ...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/435 Good to merge. I'll leave it to you to decide whether to clean the indicators in start/restart in this PR. Or leave it to the user to do it from the UI. --- If your project is set up for

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671155#comment-15671155 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user neykov commented on the issue:

[GitHub] brooklyn-server pull request #435: BROOKLYN-325: alert if provisioning/termi...

2016-11-16 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/435#discussion_r88292103 --- Diff: core/src/main/resources/org/apache/brooklyn/core/mgmt/persist/deserializingClassRenames.properties --- @@ -1434,3 +1434,5 @@

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671148#comment-15671148 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user neykov commented on a diff in the pull

[GitHub] brooklyn-server pull request #435: BROOKLYN-325: alert if provisioning/termi...

2016-11-16 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/435#discussion_r88292901 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/BasicEntityRebindSupport.java --- @@ -245,14 +249,52 @@ protected void

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671133#comment-15671133 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user neykov commented on a diff in the pull

[GitHub] brooklyn-server pull request #423: BROOKLYN-382: get-catalog performance imp...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/423#discussion_r88290994 --- Diff: parent/pom.xml --- @@ -1395,42 +1395,32 @@ +Performance +

[jira] [Commented] (BROOKLYN-382) Catalog takes long time to load in web-console

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671120#comment-15671120 ] ASF GitHub Bot commented on BROOKLYN-382: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-ui issue #37: request and set the csrf header protection added to b...

2016-11-16 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-ui/pull/37 +1 looks good to me to the best of my knowledge. See comment on apache/brooklyn-server#430. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server issue #430: Use CSRF headers

2016-11-16 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/430 To the best of my knowledge this looks good, from visual inspection and from test. (A malicious web page posting to the server got the 401 response generated by the CSRF filter.) +1 ---

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671075#comment-15671075 ] ASF GitHub Bot commented on BROOKLYN-345: - Github user neykov commented on a diff in the pull

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671080#comment-15671080 ] ASF GitHub Bot commented on BROOKLYN-345: - Github user neykov commented on the issue:

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/440 Finished review. Happy to merge after resolving the "lost default overrides" problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] brooklyn-server pull request #440: BROOKLYN-345: persist brooklyn.parameters...

2016-11-16 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/440#discussion_r88287453 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/time/Time.java --- @@ -157,7 +157,7 @@ public static String makeTimeStringRounded(long

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671069#comment-15671069 ] ASF GitHub Bot commented on BROOKLYN-345: - Github user neykov commented on a diff in the pull

[GitHub] brooklyn-server pull request #440: BROOKLYN-345: persist brooklyn.parameters...

2016-11-16 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/440#discussion_r88286904 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceFailureDetector.java --- @@ -230,6 +237,7 @@ protected void setActualState(Maybe

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671066#comment-15671066 ] ASF GitHub Bot commented on BROOKLYN-345: - Github user neykov commented on a diff in the pull

[GitHub] brooklyn-server pull request #440: BROOKLYN-345: persist brooklyn.parameters...

2016-11-16 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/440#discussion_r88286511 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceFailureDetector.java --- @@ -230,6 +237,7 @@ protected void setActualState(Maybe

[GitHub] brooklyn-library pull request #75: ZooKeeper ensemble fixes

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-library issue #75: ZooKeeper ensemble fixes

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-library/pull/75 Thanks for reviewing and testing @drigodwin. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671019#comment-15671019 ] ASF GitHub Bot commented on BROOKLYN-345: - Github user neykov commented on a diff in the pull

[GitHub] brooklyn-server pull request #440: BROOKLYN-345: persist brooklyn.parameters...

2016-11-16 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/440#discussion_r88283163 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/BasicEntityMemento.java --- @@ -139,17 +142,28 @@ protected

[GitHub] brooklyn-library issue #75: ZooKeeper ensemble fixes

2016-11-16 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-library/pull/75 Looks good & tested on AWS. We probably also need to extend the tests at [brooklyn-zookeeper-ensemble](https://github.com/brooklyncentral/brooklyn-zookeeper-ensemble/) at some point to

Re: Call for release: Brooklyn 0.10.0

2016-11-16 Thread Alex Heneveld
i find swift too slow as a persistence endpoint in any case; it doesn't seem to be designed for the high-transaction rate we do. would losing swift hurt anyone? what are the other 2.0.0 changes/risks? the reason i push for this is that i've several times hit problems with brooklyn using

Re: Call for release: Brooklyn 0.10.0

2016-11-16 Thread Svetoslav Neykov
> I am happy to do the release again this time, but it would probably be wise > for somebody else to do it this time (with me providing whatever support is > needed - pairing etc.) I'd be happy to do the release with your help Richard. Svet. > On 16.11.2016 г., at 16:43, Richard Downer

Re: Call for release: Brooklyn 0.10.0

2016-11-16 Thread Aled Sage
Hi all, I favour towards a 0.11.0 for jclouds 2.0.0 soon, with 0.10.0 depending on jclouds 1.9.2. That allows users to have a stable release if they want to keep using 1.9.2 (e.g. if things break in 2.0.0, or they want to update more leisurely), but other users can get 2.0.0 once we've had

[jira] [Commented] (BROOKLYN-359) Remove from docs SL Object Store

2016-11-16 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670910#comment-15670910 ] Aled Sage commented on BROOKLYN-359: I'd prefer that we find a way to get SoftLayer object store

[jira] [Commented] (BROOKLYN-382) Catalog takes long time to load in web-console

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670888#comment-15670888 ] ASF GitHub Bot commented on BROOKLYN-382: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server pull request #423: BROOKLYN-382: get-catalog performance imp...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/423#discussion_r88271432 --- Diff: parent/pom.xml --- @@ -1395,42 +1395,32 @@ +Performance +

[GitHub] brooklyn-server pull request #423: BROOKLYN-382: get-catalog performance imp...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/423#discussion_r88269005 --- Diff: core/src/test/java/org/apache/brooklyn/location/ssh/SshMachineLocationPerformanceTest.java --- @@ -79,7 +78,7 @@ public void

[jira] [Commented] (BROOKLYN-382) Catalog takes long time to load in web-console

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670856#comment-15670856 ] ASF GitHub Bot commented on BROOKLYN-382: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server pull request #423: BROOKLYN-382: get-catalog performance imp...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/423#discussion_r88268211 --- Diff: core/src/test/java/org/apache/brooklyn/core/test/qa/performance/EntityPerformanceLongevityTest.java --- @@ -21,7 +21,7 @@ import

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670775#comment-15670775 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on the issue:

[GitHub] brooklyn-server issue #435: BROOKLYN-325: alert if provisioning/termination ...

2016-11-16 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/435 @neykov comments addressed in the new final commit (and rebased against master). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670768#comment-15670768 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server pull request #435: BROOKLYN-325: alert if provisioning/termi...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/435#discussion_r88262033 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/internal/AttributesInternal.java --- @@ -0,0 +1,52 @@ +/* + * or more

Re: Call for release: Brooklyn 0.10.0

2016-11-16 Thread Alex Heneveld
There have been a lot of improvements to jclouds since their 1.9.2 release. Unless there are big issues with using 2.0.0 that would get my vote. Best Alex On 16/11/2016 07:26, Andrea Turli wrote: +1 Svet, FYI I'm working on #409 and #415 now that jclouds 2.0 is official released.

[GitHub] brooklyn-server pull request #440: BROOKLYN-345: persist brooklyn.parameters...

2016-11-16 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/440#discussion_r88249200 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ServiceFailureDetectorYamlTest.java --- @@ -0,0 +1,189 @@ +/* +

Re: Call for release: Brooklyn 0.10.0

2016-11-16 Thread Richard Downer
Hi all, On 16 November 2016 at 11:22, Aled Sage wrote: > Hi all, > > It's far past time that we did a Brooklyn 0.10.0 release! I suggest we aim > for that soon. > Definitely agree - our last release was in April, so about seven months ago. We certainly wouldn't want to

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670570#comment-15670570 ] ASF GitHub Bot commented on BROOKLYN-345: - Github user neykov commented on a diff in the pull

Re: Call for release: Brooklyn 0.10.0

2016-11-16 Thread Andrea Turli
+1 Svet, FYI I'm working on #409 and #415 now that jclouds 2.0 is official released. Andrea On 16 November 2016 at 12:33, Svetoslav Neykov < svetoslav.ney...@cloudsoftcorp.com> wrote: > Is including jclouds 2.0 too big of a change to consider, what do people > think? > If that's considered

[GitHub] brooklyn-server issue #300: Location DSL Updates

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/300 @ahgittin I think `$brooklyn:location()` should be referencing the `MachineLocation`. Blocking until available. Perhaps we could add `.getParent()` to get the "location spec". --- If your

[GitHub] brooklyn-server pull request #441: Fixing HttpResponse headers value

2016-11-16 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/brooklyn-server/pull/441 Fixing HttpResponse headers value You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-server fix/http-response Alternatively you

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670532#comment-15670532 ] ASF GitHub Bot commented on BROOKLYN-345: - Github user neykov commented on the issue:

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/440 Compile time errors in the jenkins build: ``` [ERROR]

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670495#comment-15670495 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server pull request #435: BROOKLYN-325: alert if provisioning/termi...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/435#discussion_r88242774 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/BasicEntityRebindSupport.java --- @@ -245,14 +249,52 @@ protected void

[GitHub] brooklyn-docs pull request #117: Winrm4j client diagnostic hints

2016-11-16 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/117#discussion_r88240860 --- Diff: guide/yaml/winrm/client.md --- @@ -0,0 +1,125 @@ +--- +title: Winrm4j Client +layout: website-normal +--- + +##

[GitHub] brooklyn-server issue #407: App defaults to requiring all children up

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/407 Saw a failure of `ApplicationLifecycleStateTest.testChildFailuresOnStartButWithQuorumCausesAppToSucceed` in the [windows

[GitHub] brooklyn-server pull request #429: BasicJcloudsLocationCustomizer is an Enti...

2016-11-16 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/429#discussion_r88238338 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BasicJcloudsLocationCustomizer.java --- @@ -18,19 +18,72 @@ */

[GitHub] brooklyn-server pull request #429: BasicJcloudsLocationCustomizer is an Enti...

2016-11-16 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/429#discussion_r88238075 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BasicJcloudsLocationCustomizer.java --- @@ -18,19 +18,73 @@ */

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670402#comment-15670402 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user neykov commented on a diff in the pull

[GitHub] brooklyn-server pull request #435: BROOKLYN-325: alert if provisioning/termi...

2016-11-16 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/435#discussion_r88233310 --- Diff: core/src/main/resources/org/apache/brooklyn/core/mgmt/persist/deserializingClassRenames.properties --- @@ -1434,3 +1434,5 @@

[jira] [Commented] (BROOKLYN-383) REST api serialization of sensor value that is a Task can cause StackOveflowError

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670396#comment-15670396 ] ASF GitHub Bot commented on BROOKLYN-383: - Github user neykov commented on the issue:

[GitHub] brooklyn-server issue #424: BROOKLYN-383: fix json serialisation of tasks

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/424 Nice one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] brooklyn-server issue #429: BasicJcloudsLocationCustomizer is an EntityIniti...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/429 Would be useful to test applying the initializer to an existing entity (before it's started obviously). To add an initializer to an entity just call its `apply` method on the entity. The

[GitHub] brooklyn-server pull request #429: BasicJcloudsLocationCustomizer is an Enti...

2016-11-16 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/429#discussion_r88228823 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/BasicJcloudsLocationCustomizerTest.java --- @@ -0,0 +1,81 @@ +/*

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670339#comment-15670339 ] ASF GitHub Bot commented on BROOKLYN-345: - GitHub user aledsage opened a pull request:

[GitHub] brooklyn-server pull request #440: BROOKLYN-345: persist brooklyn.parameters...

2016-11-16 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/440 BROOKLYN-345: persist brooklyn.parameters (fixes ServiceFailureDetector rebind) You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-11-16 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670344#comment-15670344 ] Aled Sage commented on BROOKLYN-345: The underlying problem was actually more serious! We were not

[jira] [Commented] (BROOKLYN-383) REST api serialization of sensor value that is a Task can cause StackOveflowError

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670316#comment-15670316 ] ASF GitHub Bot commented on BROOKLYN-383: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-server pull request #424: BROOKLYN-383: fix json serialisation of t...

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-383) REST api serialization of sensor value that is a Task can cause StackOveflowError

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670314#comment-15670314 ] ASF GitHub Bot commented on BROOKLYN-383: - Github user sjcorbett commented on the issue:

[GitHub] brooklyn-server issue #424: BROOKLYN-383: fix json serialisation of tasks

2016-11-16 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/424 Looks good to me, happy to merge as-is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server pull request #436: Set default JVM memory settings for the b...

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #436: Set default JVM memory settings for the build

2016-11-16 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/436 Looks good. Will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #429: BasicJcloudsLocationCustomizer is an EntityIniti...

2016-11-16 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/429 @neykov thanks for your comments. I've removed `params` and added a test that confirms that the initialiser is applied to cluster members. Can you clarify what you meant when you said

  1   2   >