Jenkins build is back to normal : brooklyn-library-master #343

2017-06-28 Thread Apache Jenkins Server
See

Build failed in Jenkins: brooklyn-master-build #1136

2017-06-28 Thread Apache Jenkins Server
See -- [...truncated 3.28 MB...] 2017-06-29 01:00:47,898 INFO TESTNG INVOKING: "Surefire test" - org.apache.brooklyn.core.mgmt.persist.DeserializingClassRenamesProviderTest.testRen

[jira] [Resolved] (BROOKLYN-520) NullPointerException thrown when type missing in yaml blueprint

2017-06-28 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-520. Resolution: Fixed Assignee: Aled Sage Fix Version/s: 0.12.0 > NullPointerException

[jira] [Commented] (BROOKLYN-520) NullPointerException thrown when type missing in yaml blueprint

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067328#comment-16067328 ] ASF GitHub Bot commented on BROOKLYN-520: - Github user asfgit closed the pull re

[jira] [Commented] (BROOKLYN-520) NullPointerException thrown when type missing in yaml blueprint

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067325#comment-16067325 ] ASF GitHub Bot commented on BROOKLYN-520: - Github user aledsage commented on the

[GitHub] brooklyn-server pull request #747: BROOKLYN-520: better error if type missin...

2017-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/747 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server issue #747: BROOKLYN-520: better error if type missing

2017-06-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/747 Thanks @Graeme-Miller - merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[jira] [Commented] (BROOKLYN-440) More efficient thread usage for ssh execution

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067316#comment-16067316 ] ASF GitHub Bot commented on BROOKLYN-440: - Github user aledsage commented on the

[GitHub] brooklyn-server issue #731: BROOKLYN-440: ssh not use StreamGobbler for logg...

2017-06-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/731 @neykov @geomacy thanks for comments - I've added another commit to address those. Could you review again please? --- If your project is set up for it, you can reply to this email and have

[GitHub] brooklyn-server issue #734: Support ConfigKey deprecated names

2017-06-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/734 @geomacy comments addressed (except where I responded explicitly to your comment). I've added two commits on top of the original - could you review those please? --- If your project is se

[GitHub] brooklyn-server issue #748: Catalog internal references

2017-06-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/748 @neykov does that make sense to you? you did much of this so want to make sure we aren't missing important things! --- If your project is set up for it, you can reply to this email and ha

[GitHub] brooklyn-server issue #748: Catalog internal references

2017-06-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/748 good points -- i agree with @aledsage about discouraging this type of reference i think what we want to support is: * `items: [ URL, ... ]` where `URL` points at another `b

[GitHub] brooklyn-server pull request #748: Catalog internal references

2017-06-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/748#discussion_r124596582 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ReferencedYamlTest.java --- @@ -127,13 +127,63 @@ public void testYam

[GitHub] brooklyn-server pull request #748: Catalog internal references

2017-06-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/748#discussion_r124596197 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ReferencedYamlTest.java --- @@ -127,13 +127,63 @@ public void testYam

[GitHub] brooklyn-server pull request #748: Catalog internal references

2017-06-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/748#discussion_r124597929 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ReferencedYamlTest.java --- @@ -142,7 +192,7 @@ public void testYamlU

[jira] [Commented] (BROOKLYN-520) NullPointerException thrown when type missing in yaml blueprint

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066831#comment-16066831 ] ASF GitHub Bot commented on BROOKLYN-520: - Github user aledsage commented on a d

[GitHub] brooklyn-server pull request #747: BROOKLYN-520: better error if type missin...

2017-06-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/747#discussion_r124592211 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java --- @@ -130,6 +13

[jira] [Commented] (BROOKLYN-520) NullPointerException thrown when type missing in yaml blueprint

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066826#comment-16066826 ] ASF GitHub Bot commented on BROOKLYN-520: - Github user aledsage commented on the

[GitHub] brooklyn-server issue #747: BROOKLYN-520: better error if type missing

2017-06-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/747 test failure was caused by a bug in jenkins, it seems! ``` ERROR: Processing failed due to a bug in the code. Please report this to jenkinsci-us...@googlegroups.com hudson.remoti

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

2017-06-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r124586077 --- Diff: core/src/test/java/org/apache/brooklyn/core/config/ConfigKeyDeprecationRebindTest.java --- @@ -0,0 +1,373 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

2017-06-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r124584831 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractLocation.java --- @@ -215,6 +216,16 @@ public AbstractLocation configure(Map

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

2017-06-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r124582410 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java --- @@ -518,6 +574,46 @@ protected Object getStringKey(String key,

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

2017-06-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r124580007 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java --- @@ -507,6 +525,44 @@ protected Object getStringKey(String key,

[GitHub] brooklyn-server pull request #748: Catalog internal references

2017-06-28 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/748 Catalog internal references Add/update some test cases for internal references in catalog BOMs, one working, two failing but marked WIP so this is safe to merge Working on fixing

[GitHub] brooklyn-server pull request #747: BROOKLYN-520: better error if type missin...

2017-06-28 Thread Graeme-Miller
Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/747#discussion_r124574322 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java --- @@ -130,

[jira] [Commented] (BROOKLYN-520) NullPointerException thrown when type missing in yaml blueprint

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066706#comment-16066706 ] ASF GitHub Bot commented on BROOKLYN-520: - Github user Graeme-Miller commented o

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

2017-06-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r124574299 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -365,6 +384,7 @@ public boolean isValueValid(T value) {

[jira] [Commented] (BROOKLYN-520) NullPointerException thrown when type missing in yaml blueprint

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066701#comment-16066701 ] ASF GitHub Bot commented on BROOKLYN-520: - GitHub user aledsage opened a pull re

[GitHub] brooklyn-server pull request #747: BROOKLYN-520: better error if type missin...

2017-06-28 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/747 BROOKLYN-520: better error if type missing You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-520 Alte

[GitHub] brooklyn-docs issue #198: [WIP] Versioning

2017-06-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-docs/pull/198 Thanks for great review comments. All but one incorporated, including discussion about equality @geomacy . The one that isn't is the statement about it "may" use co-bundling for sea

[jira] [Created] (BROOKLYN-520) NullPointerException thrown when type missing in yaml blueprint

2017-06-28 Thread Aled Sage (JIRA)
Aled Sage created BROOKLYN-520: -- Summary: NullPointerException thrown when type missing in yaml blueprint Key: BROOKLYN-520 URL: https://issues.apache.org/jira/browse/BROOKLYN-520 Project: Brooklyn

[GitHub] brooklyn-server pull request #746: [WIP] Auto wrap YAML BOMs as catalog bund...

2017-06-28 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/746 [WIP] Auto wrap YAML BOMs as catalog bundles Wraps pure-YAML BOMs uploaded to catalog in a bundle, creating a name and version if needed. This allows us to see all items added as

[GitHub] brooklyn-docs pull request #198: [WIP] Versioning

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/198#discussion_r124515823 --- Diff: guide/blueprints/catalog/versioning.md --- @@ -3,18 +3,130 @@ title: Versioning layout: website-normal --- -### Versioni

[GitHub] brooklyn-server issue #743: Version new rules

2017-06-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/743 Updated with fixes to upstream PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] brooklyn-server issue #740: New versioning rules prep

2017-06-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/740 i've cleaned up several things, but multiple discussion threads remain: > DefaultMaven2OsgiConverter different for recommended versions it is the same, isn't it? that's th

[GitHub] brooklyn-server pull request #740: New versioning rules prep

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/740#discussion_r124513379 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/BrooklynVersionSyntax.java --- @@ -84,4 +89,100 @@ public static boolean isVali

[GitHub] brooklyn-server pull request #740: New versioning rules prep

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/740#discussion_r124512975 --- Diff: utils/common/src/test/java/org/apache/brooklyn/util/text/VersionComparatorTest.java --- @@ -56,40 +35,51 @@ public void testSnapshotSuff

[GitHub] brooklyn-server pull request #740: New versioning rules prep

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/740#discussion_r124512462 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/VersionComparator.java --- @@ -56,149 +56,69 @@ public static boolean isSnapsho

[GitHub] brooklyn-server pull request #740: New versioning rules prep

2017-06-28 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/740#discussion_r124512308 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/VersionComparator.java --- @@ -56,149 +56,69 @@ public static boolean isSnapshot

[GitHub] brooklyn-server pull request #740: New versioning rules prep

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/740#discussion_r124511859 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/VersionComparator.java --- @@ -56,149 +56,69 @@ public static boolean isSnapsho

[GitHub] brooklyn-server pull request #740: New versioning rules prep

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/740#discussion_r124511689 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/VersionComparator.java --- @@ -56,149 +56,69 @@ public static boolean isSnapsho

[GitHub] brooklyn-server pull request #740: New versioning rules prep

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/740#discussion_r124511380 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/VersionComparator.java --- @@ -56,149 +56,69 @@ public static boolean isSnapsho

[GitHub] brooklyn-server pull request #740: New versioning rules prep

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/740#discussion_r124510504 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/NaturalOrderComparator.java --- @@ -140,6 +147,32 @@ public int compare(String

[GitHub] brooklyn-server pull request #737: Clean up inference around parsing `name:v...

2017-06-28 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/737#discussion_r124510037 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -855,24 +893,50 @@ private boolean attemptT

[GitHub] brooklyn-server pull request #740: New versioning rules prep

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/740#discussion_r124509326 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/NaturalOrderComparator.java --- @@ -140,6 +147,32 @@ public int compare(String

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

2017-06-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/737 great comments here @geomacy , addressed all except where commented above; moving on to #740 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #737: Clean up inference around parsing `name:v...

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/737#discussion_r124508624 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -855,24 +893,50 @@ private boolean attempt

[GitHub] brooklyn-server pull request #737: Clean up inference around parsing `name:v...

2017-06-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/737#discussion_r124508303 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -601,14 +602,34 @@ private void collectCat