[GitHub] brooklyn-server pull request #864: Separate dumper class

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/864 Separate dumper class Move all `Entities.dumpInfo` to `Dumper`, deprecating the methods in `Entities`. Previously, `Entities` was too much of a dumping ground for lots of methods

[GitHub] brooklyn-server pull request #863: Fix ManagementNodeStateListener

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/863 Fix ManagementNodeStateListener Wait for rebind to complete before notifying of ‘MASTER’. Otherwise if the listener does things like listing the apps, it might get back an empty list.

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 Failed again, this time when running `org.apache.brooklyn.entity.machine.MachineEntityJcloudsRebindTest.testRebind`: ``` java.lang.AssertionError: failed succeeds-eventually, 75

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 Test failure looked unrelated, and I couldn't reproduce locally (or see why this would fail!): ``` java.lang.AssertionError: failed succeeds-eventually, 21 attempts, 3001ms

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---

Jenkins build is back to normal : brooklyn-server-master #769

See

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/852 ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/859 @aledsage Build failure seems related: ``` [ERROR]

Re: [PROPOSAL] Split Brooklyn website and documentation

+1 I really like GitBook, really great work! Thomas and Richard! Splitting it is also a good idea. Thanks! On 16 October 2017 at 16:35, Thomas Bouron wrote: > Hi all. > > I pushed a PR[1] for the split. I went down this road because I think the > docs should

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/859 Yup @aledsage, LGTM. ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 Thanks @tbouron - I've added back the location.getConfig method that I accidentally deleted. I squashed that commit, so we won't have a weird deletion in our history. I've also

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r145067746 --- Diff: api/src/main/java/org/apache/brooklyn/api/location/Location.java --- @@ -89,29 +86,6 @@ boolean containsLocation(Location

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r145067457 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/osgi/BundleMaker.java --- @@ -110,8 +110,6 @@ public File

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r145066673 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityPredicates.java --- @@ -488,11 +482,6 @@ public String toString() {

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r145064284 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityPredicates.java --- @@ -454,12 +454,6 @@ public String toString() {

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r145063507 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUtils.java --- @@ -112,8 +112,8 @@ public static

[GitHub] brooklyn-server issue #852: Merge initial catalog and persisted catalog

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/852 Thanks @tbouron - incorporated comments; once jenkins confirms it builds then I'll merge it. ---