Build failed in Jenkins: brooklyn-master-build #823

See -- [...truncated 2057 lines...] 2017-02-14 04:08:51,015 INFO TESTNG PASSED: "Surefire test" - org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testQuoting() finished in 1 ms 2017-02-14

Build failed in Jenkins: brooklyn-master-build #822

See -- [...truncated 2051 lines...] 2017-02-14 00:55:38,783 INFO TESTNG INVOKING: "Surefire test" - org.apache.brooklyn.util.text.QuotedStringTokenizerTest.testTokenizing() 2017-02-14 00:55:38,783

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100937270 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterUnwrappingTest.java --- @@ -309,7 +298,7 @@

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100936874 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterUnwrappingTest.java --- @@ -146,8 +151,9 @@

[GitHub] brooklyn-server issue #462: Inherit config default values

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/462 ^^ and neykov's comments re `SpecParameterForInheritance` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100846590 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100846344 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[GitHub] brooklyn-server issue #462: Inherit config default values

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/462 more updates; now just need to: * fix the bug geomacy found * rewview comments from neykov re SpecParameterUnwrappingTest.java --- If your project is set up for it,

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100844827 --- Diff: api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java --- @@ -147,27 +147,28 @@ public SpecT

[GitHub] brooklyn-server issue #462: Inherit config default values

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/462 @geomacy good find in your failing test [above](https://github.com/apache/brooklyn-server/pull/462#issuecomment-270408039) -- we do not filter out hidden ancestor config keys whenever we

[GitHub] brooklyn-server issue #462: Inherit config default values

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/462 failure appears non-deterministic and i think unrelated ``` Tests run: 2036, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 328.296 sec <<< FAILURE! - in TestSuite

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863859#comment-15863859 ] ASF GitHub Bot commented on BROOKLYN-433: - Github user tbouron commented on the issue:

[GitHub] brooklyn-server issue #558: BROOKLYN-433: regex/obj config key constraint in...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/558 @aledsage In that case, LGTM 👍 Would be great to follow up after this PR is merged to make the REST API return more information about the constraint (and modify the UI to react

[GitHub] brooklyn-server issue #462: Inherit config default values

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/462 Thanks for such great comments. Nearly done, should finish today. Sorry I dropped the ball on this. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100810977 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BrooklynObjectInternal.java --- @@ -152,8 +152,8 @@ /** This is currently

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100810871 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -170,12 +324,103 @@ public String

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100810442 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -28,51 +32,188 @@ import

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100810106 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -170,12 +324,103 @@ public String

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100808284 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -170,12 +324,103 @@ public String

[jira] [Commented] (BROOKLYN-421) Catalog libraries: externalized config for basic-auth credentials in url (via YAML)

[ https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863773#comment-15863773 ] ASF GitHub Bot commented on BROOKLYN-421: - Github user geomacy commented on the issue:

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100808041 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -170,12 +324,103 @@ public String

[GitHub] brooklyn-server issue #551: BROOKLYN-421: Adds DSL for $brooklyn:urlEncode(....

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/551 Actually I take it back - having looked more carefully at the spec for that j.n.URI constructor I think the above is a perfectly valid use. --- If your project is set up for it, you can

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100807828 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -82,9 +223,17 @@ public InheritanceMode

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100806157 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -28,51 +32,188 @@ import

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100805561 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -28,51 +32,188 @@ import

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863746#comment-15863746 ] ASF GitHub Bot commented on BROOKLYN-433: - Github user aledsage commented on the issue:

[GitHub] brooklyn-server issue #558: BROOKLYN-433: regex/obj config key constraint in...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/558 @tbouron It's validated server-side. Longer term, we should improve the validation errors + warnings that the server-side sends back, along with the info needed for content-assist. That's

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100802788 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/guava/Maybe.java --- @@ -457,6 +457,8 @@ public boolean equals(Object obj) {

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100798508 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/guava/Maybe.java --- @@ -457,6 +457,8 @@ public boolean equals(Object obj) {

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100796966 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -227,13 +234,30 @@ public String toString() {

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100796950 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -227,13 +234,30 @@ public String toString() {

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100796338 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/EntityManagementUtils.java --- @@ -255,8 +255,9 @@ private static void

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100795903 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java --- @@ -403,8

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100795410 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java --- @@ -28,51 +32,188 @@ import

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100789705 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -404,7 +431,126 @@ public static void

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863634#comment-15863634 ] ASF GitHub Bot commented on BROOKLYN-433: - Github user tbouron commented on the issue:

[GitHub] brooklyn-server issue #558: BROOKLYN-433: regex/obj config key constraint in...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/558 @neykov Depends how that is currently implemented: are we doing this validation client or server side? Although in this particular case, doing this validation client side would require

[GitHub] brooklyn-server pull request #462: Inherit config default values

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/462#discussion_r100786370 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/internal/AbstractConfigMapImpl.java --- @@ -397,48 +397,83 @@ protected

[GitHub] brooklyn-server issue #558: BROOKLYN-433: regex/obj config key constraint in...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/558 cc @tbouron - should we add support in UI as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863595#comment-15863595 ] ASF GitHub Bot commented on BROOKLYN-433: - Github user neykov commented on the issue:

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863584#comment-15863584 ] ASF GitHub Bot commented on BROOKLYN-433: - Github user bostko commented on a diff in the pull

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863583#comment-15863583 ] ASF GitHub Bot commented on BROOKLYN-433: - Github user bostko commented on a diff in the pull

[GitHub] brooklyn-server pull request #558: BROOKLYN-433: regex/obj config key constr...

Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/558#discussion_r100783030 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -310,6 +317,41 @@ private static Predicate

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863457#comment-15863457 ] ASF GitHub Bot commented on BROOKLYN-433: - GitHub user aledsage opened a pull request:

[GitHub] brooklyn-server pull request #547: [WIP] CXF upgrade

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/547#discussion_r100776337 --- Diff: pom.xml --- @@ -117,8 +117,10 @@ 2.3.0_3 2.7.5 -3.1.4 -4.4.1 +

[GitHub] brooklyn-library issue #73: bump http version

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-library/pull/73 NB now depends on https://github.com/apache/brooklyn-server/pull/547 (as https://github.com/apache/brooklyn-server/pull/362 was closed in favour of that) --- If your project is set up for

[GitHub] brooklyn-server pull request #362: bump httpcomponents versions

Github user ahgittin closed the pull request at: https://github.com/apache/brooklyn-server/pull/362 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #362: bump httpcomponents versions

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/362 #547 is a better more holistic fix; closing here in preference to that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] brooklyn-server pull request #558: BROOKLYN-433: regex/obj config key constr...

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/558 BROOKLYN-433: regex/obj config key constraint in yaml Docs PR will follow, to update the constraints section in

[GitHub] brooklyn-server issue #554: Ensured the \n character is escaped when escapin...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/554 Agree @geomacy. Haven't realised it's still treated as a single string value. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] brooklyn-server pull request #557: transfer icons from catalog items to enti...

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/557 transfer icons from catalog items to entities and set icons on the common `server` and `cluster` items previously while we do a lot to support icons and send detail via the API,