Build failed in Jenkins: brooklyn-master-build #874

2017-02-28 Thread Apache Jenkins Server
See -- [...truncated 6.87 MB...] [JENKINS] Archiving

Jenkins build is back to stable : brooklyn-master-build #873

2017-02-28 Thread Apache Jenkins Server
See

Jenkins build is unstable: brooklyn-master-build #872

2017-02-28 Thread Apache Jenkins Server
See

[GitHub] brooklyn-server issue #560: Attempted non-determinate test fixes

2017-02-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/560 @aledsage I didn't pull in #485 for fun. The simplest fix for some of the failures involves building an intermediate bundle thus > Builds on #485 (using an intermediate JAR) for

[GitHub] brooklyn-server issue #560: Attempted non-determinate test fixes

2017-02-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/560 Wow, I wasn't expecting to see this set of commits of file-edits based on the name of the PR and the description! It would be great to review + merge your improvements for

[GitHub] brooklyn-server pull request #574: don't NPE fail is application is GC'd at ...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #574: don't NPE fail is application is GC'd at same ti...

2017-02-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/574 LGTM; merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-server pull request #571: Better error reporting

2017-02-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/571#discussion_r103570592 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java --- @@ -374,7 +378,13 @@ public Response

[GitHub] brooklyn-server issue #485: `BundleMaker` utility routines making it easy to...

2017-02-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/485 @ahgittin (cc @neykov @geomacy) see https://github.com/apache/brooklyn-server/pull/576, for the part of this PR that adds the `BundleMaker` (without the REST api changes). What do you

[GitHub] brooklyn-server pull request #576: BundleMaker (part1)

2017-02-28 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/576 BundleMaker (part1) This is extracted from https://github.com/apache/brooklyn-server/pull/485 - it excludes the changes to the REST api; it improves test coverage and fixes a couple of

[GitHub] brooklyn-server pull request #318: Delete most deprecated methods from PortF...

2017-02-28 Thread sjcorbett
Github user sjcorbett closed the pull request at: https://github.com/apache/brooklyn-server/pull/318 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #485: `BundleMaker` utility routines making it easy to...

2017-02-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/485 @ahgittin agree there is 100% support on the direction. There was push-back on what exactly the REST API piece should look like: * @geomacy suggested that we should only support

[GitHub] brooklyn-server issue #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/480 @aledsage I think I've addressed these comments, TY; but now merge conflicts with #155 are hurting; as noted there I think we should revert that. --- If your project is set up for it, you

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103505398 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -512,6 +559,24 @@ public Object call() throws Exception

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103504542 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -352,33 +357,73 @@ public T get() {

[GitHub] brooklyn-server issue #558: BROOKLYN-433: regex/obj config key constraint in...

2017-02-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/558 Docs PR now merged - https://github.com/apache/brooklyn-docs/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888452#comment-15888452 ] ASF GitHub Bot commented on BROOKLYN-433: - Github user aledsage commented on the issue:

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888445#comment-15888445 ] ASF GitHub Bot commented on BROOKLYN-433: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-server issue #562: Provide a scratchpad area per management context

2017-02-28 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/562 Good point about casts, updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-docs pull request #151: BROOKLYN-433: docs for yaml config key cons...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103500728 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -352,33 +357,73 @@ public T get() {

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103500687 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -96,7 +98,50 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103498263 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -96,7 +98,50 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103499754 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -96,7 +98,50 @@ public ExecutionManager

[GitHub] brooklyn-server issue #338: Support nested catalog item definitions - testCa...

2017-02-28 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/338 Thanks @ahgittin and @neykov for comments; I will try to address the remaining items as noted above (https://github.com/apache/brooklyn-server/pull/338#issuecomment-281950519) soon.

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103494117 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java --- @@ -554,15 +562,55 @@

[GitHub] brooklyn-server issue #338: Support nested catalog item definitions - testCa...

2017-02-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/338 Very cool. Haven't reviewed in depth but looks on point at a high level. A few specific comments: * this will conflict with https://github.com/apache/brooklyn-server/pull/573 --

[GitHub] brooklyn-server issue #563: [WIP] Don't SO_REUSEADDR when probing for availa...

2017-02-28 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/563 Using non-`SO_REUSEADDR` sockets seems to work fine on the apache build slaves. On the other hand it prevents us from re-binding to the same port after restarting Brooklyn, so not ideal.

[GitHub] brooklyn-server pull request #562: Provide a scratchpad area per management ...

2017-02-28 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/562#discussion_r103490624 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/BrooklynCampPlatform.java --- @@ -65,7 +65,7 @@ public

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888351#comment-15888351 ] ASF GitHub Bot commented on BROOKLYN-433: - Github user nakomis commented on the issue:

[GitHub] brooklyn-docs issue #151: BROOKLYN-433: docs for yaml config key constraints

2017-02-28 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-docs/pull/151 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] brooklyn-server pull request #575: Clean up location metadata and OSGi packa...

2017-02-28 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/575 Clean up location metadata and OSGi packaging Discovered when trying to use the REST API that we didn't get much of the location detail we might want; in particular we didn't have info on

[jira] [Commented] (BROOKLYN-433) YAML-based config constraint to support regex

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888329#comment-15888329 ] ASF GitHub Bot commented on BROOKLYN-433: - GitHub user aledsage opened a pull request:

[jira] [Commented] (BROOKLYN-445) Search path and meaning of catalogItemId is overloaded

2017-02-28 Thread Svetoslav Neykov (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888330#comment-15888330 ] Svetoslav Neykov commented on BROOKLYN-445: --- [~alex.heneveld] See

[GitHub] brooklyn-docs pull request #151: BROOKLYN-433: docs for yaml config key cons...

2017-02-28 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-docs/pull/151 BROOKLYN-433: docs for yaml config key constraints You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-docs BROOKLYN-433

[GitHub] brooklyn-server issue #155: [WIP] Add DSL support for calling effectors in Y...

2017-02-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/155 right, so the use case is one entity wanting to get information from another. is there no way this can be accommodated using sensors? my philosophical objection is that we're introducing

[GitHub] brooklyn-server issue #562: Provide a scratchpad area per management context

2017-02-28 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/562 @geomacy Addressed comments, can you take another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-server issue #155: [WIP] Add DSL support for calling effectors in Y...

2017-02-28 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/155 I agree this should probably not have been marked as a WIP @ahgittin . This initially came about through work on the CA entity in clocker, there was no good way to share keys between

[GitHub] brooklyn-server issue #155: [WIP] Add DSL support for calling effectors in Y...

2017-02-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/155 Ouch -- I don't think this is a good idea. Apologies, I hadn't reviewed it because it was marked `[WIP]` -- in any case we shouldn't be merging WIPs :). My main objections are as

[GitHub] brooklyn-server pull request #155: [WIP] Add DSL support for calling effecto...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-444) Effector call works from GUI but fails from CLI

2017-02-28 Thread Geoff Macartney (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888160#comment-15888160 ] Geoff Macartney commented on BROOKLYN-444: -- I've investigated this and the problem lies in the

[GitHub] brooklyn-server issue #155: [WIP] Add DSL support for calling effectors in Y...

2017-02-28 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/155 @drigodwin I had to pull in https://github.com/grkvlt/brooklyn-server/pull/2 manually but it is there in 70d9aca so could you have a look please? --- If your project is set up for it, you

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103461269 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -352,33 +357,73 @@ public T get() {

[GitHub] brooklyn-server issue #480: Config self reference fix

2017-02-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/480 @aledsage Thanks for thorough comments. I'll review this afternoon and revert with whether to merge or not. One high level comment: `Task` instances _should_ be left running,

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103454836 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -352,33 +357,73 @@ public T get() {

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103446823 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -96,7 +98,50 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103439058 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java --- @@ -554,15 +562,55 @@

[GitHub] brooklyn-server pull request #564: Winrm CmdFeed

2017-02-28 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/564#discussion_r103459565 --- Diff: core/src/main/java/org/apache/brooklyn/feed/CommandPollConfig.java --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103455566 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -512,6 +559,24 @@ public Object call() throws Exception

[GitHub] brooklyn-server pull request #564: Winrm CmdFeed

2017-02-28 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/564#discussion_r103460271 --- Diff: software/winrm/src/main/java/org/apache/brooklyn/feed/windows/CmdFeed.java --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #564: Winrm CmdFeed

2017-02-28 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/564#discussion_r103459790 --- Diff: core/src/main/java/org/apache/brooklyn/feed/ssh/SshPollConfig.java --- @@ -18,183 +18,21 @@ */ package

[GitHub] brooklyn-server pull request #564: Winrm CmdFeed

2017-02-28 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/564#discussion_r103460429 --- Diff: software/winrm/src/test/java/org/apache/brooklyn/feed/windows/WinRmFeedIntegrationTest.java --- @@ -0,0 +1,262 @@ +/* + *

[GitHub] brooklyn-server pull request #564: Winrm CmdFeed

2017-02-28 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/564#discussion_r103451547 --- Diff: core/src/main/java/org/apache/brooklyn/feed/AbstractCommandFeed.java --- @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] brooklyn-server pull request #564: Winrm CmdFeed

2017-02-28 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/564#discussion_r103455492 --- Diff: core/src/main/java/org/apache/brooklyn/feed/AbstractCommandFeed.java --- @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] brooklyn-server pull request #564: Winrm CmdFeed

2017-02-28 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/564#discussion_r103450036 --- Diff: core/src/main/java/org/apache/brooklyn/feed/AbstractCommandFeed.java --- @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] brooklyn-library pull request #91: Updated "hello-world-sql" example webapp ...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103448474 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -96,7 +98,50 @@ public ExecutionManager

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103452425 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -352,33 +357,73 @@ public T get() {

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103455943 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java --- @@ -512,6 +559,24 @@ public Object call() throws Exception

[GitHub] brooklyn-server pull request #480: Config self reference fix

2017-02-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/480#discussion_r103447467 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionContext.java --- @@ -96,7 +98,50 @@ public ExecutionManager

[jira] [Commented] (BROOKLYN-445) Search path and meaning of catalogItemId is overloaded

2017-02-28 Thread Alex Heneveld (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887951#comment-15887951 ] Alex Heneveld commented on BROOKLYN-445: A simple fix is to prevent the call to set the catalog

[jira] [Commented] (BROOKLYN-445) Search path and meaning of catalogItemId is overloaded

2017-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887941#comment-15887941 ] ASF GitHub Bot commented on BROOKLYN-445: - GitHub user ahgittin opened a pull request:

[GitHub] brooklyn-server pull request #574: don't NPE fail is application is GC'd at ...

2017-02-28 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/574 don't NPE fail is application is GC'd at same time as location i think we want to make sure a record is generated, even if it is incomplete You can merge this pull request into a Git

[GitHub] brooklyn-server pull request #573: Do not runtime-inherit catalog item

2017-02-28 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/573 Do not runtime-inherit catalog item fixes https://issues.apache.org/jira/browse/BROOKLYN-445 and failing tests included here means catalog BOMs should be written such that any

[jira] [Created] (BROOKLYN-446) Constructor ScheduledTask(Map, Task) is broken

2017-02-28 Thread Svetoslav Neykov (JIRA)
Svetoslav Neykov created BROOKLYN-446: - Summary: Constructor ScheduledTask(Map, Task) is broken Key: BROOKLYN-446 URL: https://issues.apache.org/jira/browse/BROOKLYN-446 Project: Brooklyn

[jira] [Created] (BROOKLYN-445) Search path and meaning of catalogItemId is overloaded

2017-02-28 Thread Alex Heneveld (JIRA)
Alex Heneveld created BROOKLYN-445: -- Summary: Search path and meaning of catalogItemId is overloaded Key: BROOKLYN-445 URL: https://issues.apache.org/jira/browse/BROOKLYN-445 Project: Brooklyn

[GitHub] brooklyn-server pull request #572: Increase timeout in ReachableSocketFinder...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #572: Increase timeout in ReachableSocketFinderTest

2017-02-28 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/572 +1 Looks good to me, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature