[jira] [Commented] (BROOKLYN-503) Shell.env should work with SaltEntity

2017-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145603#comment-16145603 ] ASF GitHub Bot commented on BROOKLYN-503: - GitHub user tbouron opened a pull request:

[GitHub] brooklyn-library pull request #123: Convert AnsibleEntity and SaltEntity to ...

2017-08-29 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/123 Convert AnsibleEntity and SaltEntity to be real SoftwareProcess # Background Salt and Ansible are currently installed by Brooklyn and: - are used in masterless mode - use

[GitHub] brooklyn-server issue #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/799 Thanks @aledsage - all addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135829424 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiManager.java --- @@ -135,14 +141,76 @@ synchronized void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135829275 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -379,26 +388,89 @@ private synchronized void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135829210 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -379,26 +388,89 @@ private synchronized void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135827259 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -1464,8 +1495,8 @@ public void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135826869 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -1034,25 +1065,21 @@ private String

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135826843 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -553,6 +559,7 @@ private void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135825675 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -496,15 +500,17 @@ public static

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135825448 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -112,7 +112,7 @@ import

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135825312 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlEntityOsgiTypeRegistryTest.java --- @@ -36,15

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135824194 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/RebindOsgiTest.java --- @@ -490,7 +494,46 @@ public void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135761046 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlEntityOsgiTypeRegistryTest.java --- @@ -36,15

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135778904 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -379,26 +388,89 @@ private synchronized void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135762127 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -496,15 +500,17 @@ public static

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135784417 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiManager.java --- @@ -135,14 +141,76 @@ synchronized void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135764988 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -1034,25 +1065,21 @@ private String

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135766866 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -1464,8 +1495,8 @@ public void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135760626 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/RebindOsgiTest.java --- @@ -490,7 +494,46 @@ public void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135762383 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -553,6 +559,7 @@ private void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135778715 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -379,26 +388,89 @@ private synchronized void

[GitHub] brooklyn-server pull request #799: Uninstall bundles on error

2017-08-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/799#discussion_r135761929 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -112,7 +112,7 @@ import

[GitHub] brooklyn-library pull request #122: Fix MariaDBNode default mirrorUrl

2017-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #363: YOML = YAML object mapping language [BIG!]

2017-08-29 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/363 Updated for merge conflicts. Fixes access to `AddSensor.params`. Also incorporates latest OSGi works (https://github.com/apache/brooklyn-server/pull/799 - not yet merged but including a

[GitHub] brooklyn-server issue #799: Uninstall bundles on error

2017-08-29 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/799 merged in master and added one more commit which prevents some infinite recursive loops in type validation --- If your project is set up for it, you can reply to this email and have your