[GitHub] brooklyn-server pull request #818: More on adjunct highlights

Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138696197 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void setUniqueTag(String

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138690532 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void setUniqueTag(String

Jenkins build is back to normal : brooklyn-server-master #728

See

[GitHub] brooklyn-server issue #822: New periodic and scheduled effector policies

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/822 (yaml could be used in a test :nudge:) ---

[GitHub] brooklyn-server issue #822: New periodic and scheduled effector policies

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/822 cool @grkvlt - wonder if you could do two things: * merge #818 here for testing and follow the pattern there to set trigger and action highlights * include a YAML illustrating

[GitHub] brooklyn-server pull request #812: use external config in examples

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/812 ---

[GitHub] brooklyn-server pull request #822: New periodic and scheduled effector polic...

GitHub user grkvlt opened a pull request: https://github.com/apache/brooklyn-server/pull/822 New periodic and scheduled effector policies You can merge this pull request into a Git repository by running: $ git pull https://github.com/grkvlt/brooklyn-server

[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity

Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/750 Thanks for the review @aledsage, I will update appropriately. The use case is for blueprints like Kubernetes, which would be able to add a new `KubernetesLocation` or similar. ---

[GitHub] brooklyn-docs issue #209: explain and use the `brooklyn-demo-sample` externa...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-docs/pull/209 @drigodwin @aledsage merged the upstream PRs -- is this good to go? (and if you could have a quick look at #208 i'd be obliged!) ---

[GitHub] brooklyn-library pull request #124: use external config provider for demo pa...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/124 ---

[GitHub] brooklyn-library pull request #126: Highlights and load

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-library/pull/126 Highlights and load uses https://github.com/apache/brooklyn-server/pull/818 to add highlights for software-specific entities. also adds new perf test. You can merge this pull request

[GitHub] brooklyn-server pull request #817: Optimizations

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/817 ---

[GitHub] brooklyn-docs pull request #211: Update _azure-ARM.md

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/211 ---

[GitHub] brooklyn-server issue #821: REST API for accessing adjuncts (including highl...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/821 These are the API calls, for reference. The `Entity Policy` and `Entity Policy Config` resources shown at bottom are now redundant (and deprecated).

[GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/821 REST API for accessing adjuncts (including highlights) NB: builds on #810 and #818, review and merge those first This is then just one commit (currently) which: * adds an

Build failed in Jenkins: brooklyn-server-master #727

See Changes: [alex.heneveld] use type registry when confirming catalog on startup [alex.heneveld] only search in legacy catalog items in a couple other places --

[GitHub] brooklyn-server pull request #820: use type registry when confirming catalog...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/820 ---

[GitHub] brooklyn-server issue #820: use type registry when confirming catalog on sta...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/820 brooklyn CLI gives error in some startup configurations with #814 and this is minor so committing before review but review welcome ---

[GitHub] brooklyn-server pull request #820: use type registry when confirming catalog...

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/820 use type registry when confirming catalog on startup prevents errors trying to check legacy catalog items #814 caused legacy CI instances to be created for TR items which could

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138651745 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138642145 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138642446 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138642216 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138642085 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/818#discussion_r138638872 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -568,6 +570,98 @@ public void

[GitHub] brooklyn-server issue #812: use external config in examples

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/812 Good point re examples pointing to master. Will add password in script. But we should probably change links in example to point at specific branches too. ---

[GitHub] brooklyn-server issue #817: Optimizations

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/817 good comments @aledsage - thx - will apply both and merge ---

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138632642 --- Diff: guide/ops/security-guidelines.md --- @@ -37,7 +37,7 @@ relevant mount points, disks and directories. For credential storage,

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138628703 --- Diff: guide/ops/configuration/brooklyn_cfg.md --- @@ -214,7 +204,7 @@ or See [HTTPS Configuration](https.html) for general information

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138631625 --- Diff: guide/ops/high-availability/high-availability-supplemental.md --- @@ -12,34 +12,46 @@ and provides an example of how to configure a pair of

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138628440 --- Diff: guide/ops/configuration/brooklyn_cfg.md --- @@ -33,7 +28,7 @@ brooklyn.webconsole.security.user.admin.password=AdminPassw0rd

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138631452 --- Diff: guide/ops/high-availability/high-availability-supplemental.md --- @@ -12,34 +12,46 @@ and provides an example of how to configure a pair of

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138633409 --- Diff: guide/start/running.md --- @@ -182,7 +182,7 @@ Apache Brooklyn should now have been installed and be running as a system servic $

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138629659 --- Diff: guide/ops/configuration/https.md --- @@ -21,7 +21,7 @@ The passwords above should be changed to your own values. Omit those arguments

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138631937 --- Diff: guide/ops/high-availability/high-availability-supplemental.md --- @@ -12,34 +12,46 @@ and provides an example of how to configure a pair of

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138633009 --- Diff: guide/start/brooklyn.properties --- @@ -17,7 +17,7 @@ # under the License. # # This is Brooklyn's dot-properties file. -#

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138633481 --- Diff: guide/start/running.md --- @@ -205,19 +205,19 @@ The application should then output its logs to `/var/log/brooklyn/apache-brookly Now

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138629521 --- Diff: guide/ops/configuration/cors.md --- @@ -0,0 +1,45 @@ +--- +title: CORS Configuration +layout: website-normal +--- +

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138633454 --- Diff: guide/start/running.md --- @@ -195,7 +195,7 @@ Apache Brooklyn should now have been installed and be running as a system servic $ sudo

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/210#discussion_r138631341 --- Diff: guide/ops/high-availability/high-availability-supplemental.md --- @@ -12,34 +12,46 @@ and provides an example of how to configure a pair of

[GitHub] brooklyn-library pull request #124: use external config provider for demo pa...

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/124#discussion_r138633960 --- Diff: examples/simple-web-cluster/src/main/resources/visitors-creation-script.sql --- @@ -19,18 +19,22 @@ create database visitors;

[GitHub] brooklyn-dist issue #105: Update Brooklyn vagrant

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/105 retest this please ---

[GitHub] brooklyn-dist issue #104: Improve RPM/DEB packages

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-dist/pull/104 @drigodwin Comment addressed except for the `Depends` package (see my comment above) ---

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138617661 --- Diff: karaf/apache-brooklyn/src/main/filtered-resources/etc/brooklyn.cfg --- @@ -0,0 +1,24 @@

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138617340 --- Diff: deb-packaging/deb/control/control --- @@ -19,6 +19,6 @@ Version: [[version]] Section: misc Priority: optional Architecture:

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138614635 --- Diff: shared-packaging/src/main/resources/service/systemd/brooklyn.service --- @@ -22,12 +22,16 @@

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138611933 --- Diff: karaf/apache-brooklyn/src/main/filtered-resources/etc/brooklyn.cfg --- @@ -0,0 +1,24 @@

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138614755 --- Diff: shared-packaging/src/main/resources/service/upstart/rpm/brooklyn.conf --- @@ -30,13 +31,14 @@ pre-start script end script

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138608902 --- Diff: deb-packaging/deb/control/control --- @@ -19,6 +19,6 @@ Version: [[version]] Section: misc Priority: optional Architecture:

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138607380 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138607947 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138606936 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138607171 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #750: Adds a policy to create locations from an...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/750#discussion_r138608438 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java --- @@ -0,0 +1,288 @@ +/* + * Licensed to

[GitHub] brooklyn-server issue #812: use external config in examples

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/812 @m4rkmckenna there is a "file-based exteranl config supplier" you can use for dev (`PropertiesFileExternalConfigSupplier`), and then switch to Vault or whatever when you're ready.

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138606016 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Aggregator.java --- @@ -65,18 +66,22 @@ "'list' (the

[GitHub] brooklyn-library pull request #125: Improve config and entity descriptions

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/125 ---

[GitHub] brooklyn-library issue #125: Improve config and entity descriptions

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/125 Thanks @m4rkmckenna - merging now. ---

[GitHub] brooklyn-server issue #819: Improve config key descriptions

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/819 Thanks @tbouron - comments addressed. @drigodwin I believe you were also looking at this? Ready to merge? ---

[GitHub] brooklyn-server issue #818: More on adjunct highlights

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/818 Now has highlights on most things. ---

[GitHub] brooklyn-server pull request #814: Fix back compat of catalog java api

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/814 ---

[GitHub] brooklyn-server issue #812: use external config in examples

Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/812 Ignore me ... It was never added. But i do think the flow i mentioned above would be incredibly useful ---

[GitHub] brooklyn-server pull request #817: Optimizations

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/817#discussion_r138592431 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/guava/TypeTokens.java --- @@ -24,6 +24,14 @@ public class TypeTokens {

[GitHub] brooklyn-server pull request #817: Optimizations

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/817#discussion_r138591570 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/guava/TypeTokens.java --- @@ -68,5 +85,19 @@ public static Class

[GitHub] brooklyn-server pull request #805: Modify jcloudsLocation.releaseNode

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/805 ---

[GitHub] brooklyn-dist pull request #103: Make karaf release the primary one

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/103 ---

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138585632 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabric.java --- @@ -50,13 +51,20 @@ + "for each given

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138584451 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Attributes.java --- @@ -52,11 +52,15 @@ // TODO these should switch to

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138584470 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Attributes.java --- @@ -52,11 +52,15 @@ // TODO these should switch to

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138585654 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabric.java --- @@ -50,13 +51,20 @@ + "for each given

[GitHub] brooklyn-library pull request #125: Improve config and entity descriptions

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-library/pull/125 Improve config and entity descriptions You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-library

[GitHub] brooklyn-server issue #812: use external config in examples

Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/812 @ahgittin I think @neykov added a file based external config provider for this, That enable users to configure for development and then swap to a "proper" config provider. You could

[GitHub] brooklyn-server pull request #812: use external config in examples

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/812#discussion_r138582530 --- Diff: camp/camp-brooklyn/src/test/resources/visitors-creation-script.sql --- @@ -19,18 +19,22 @@ create database visitors; use

[GitHub] brooklyn-server issue #819: Improve config key descriptions

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/819 retest this please ---

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/819 Improve config key descriptions See individual commits for details. Note the last two commits make significant changes to config: * remove the default for `launch.command` of

[GitHub] brooklyn-server issue #813: Added highlights to policy endpoint

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/813 @m4rkmckenna re your general comment, a human client will use this to understand what's going on. currently adjuncts (policies etc) are opaque unless you look at logs or tasks (or code).

[GitHub] brooklyn-server issue #818: More on adjunct highlights

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/818 See https://github.com/apache/brooklyn-server/pull/818/commits/5ae9c41c1dc8d2884598a2375581d2c4dc14ce14#diff-0724222c7ef44a5337e1e8f44d9d5faeR114 for illustration of what I mean by an

[GitHub] brooklyn-server pull request #818: More on adjunct highlights

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/818 More on adjunct highlights Applies #813 to a policy (`ServiceRestarter`) to see how it works. As reported there it works good, REST and persistence acting as expected. The API

[GitHub] brooklyn-server pull request #813: Added highlights to policy endpoint

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/813 ---

[GitHub] brooklyn-server issue #813: Added highlights to policy endpoint

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/813 works a treat, did a sample impl on `ServiceRestarter`, and tested persistence too. merging this. i'll open a follow-on PR which will address the points here and show how it's used in