Jenkins build is back to normal : brooklyn-library-master #428

See

Jenkins build is back to normal : brooklyn-master-build #1221

See

[GitHub] brooklyn-server pull request #837: Fix FunctionSensor’s rebind

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/837 Fix FunctionSensor’s rebind It was trying to serialise the TypeCoercions function. We don’t need that - it coerces automatically. This is important: the brooklyn master

[GitHub] brooklyn-dist pull request #108: Fix release scripts

GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-dist/pull/108 Fix release scripts This makes the following changes to the release scripts: * Fixes a typo in the maven version which is installed * Doesn't copy over the local gpg keyring

[DISCUSS] Release Apache Brooklyn 0.12.0

This thread is for discussions related to the release vote. I should clarify what we are looking for in a release vote. Particularly, we are looking for people to download,validate, and test the release. Only if you are satisfied that the artifacts are correct and the quality is high enough,

[VOTE] Release Apache Brooklyn 0.12.0 [rc2]

This is to call for a vote for the release of Apache Brooklyn 0.12.0. This release comprises of a source code distribution, and a corresponding binary distribution, and Maven artifacts. The source and binary distributions, including signatures, digests, etc. can be found at:

Re: REST API: bundles + types + subtypes endpoints

I guess I can live with that. It means that /v1/catalog is quite different from /v2/catalog, but I suppose a difference like that between a /v1 and a /v2 of an API isn't very remarkable. what do you say to /v2/catalog// list every type in the registry (most up to date version)

[jira] [Created] (BROOKLYN-538) IllegalArgumentException parsing (null?) json response in http feed

Aled Sage created BROOKLYN-538: -- Summary: IllegalArgumentException parsing (null?) json response in http feed Key: BROOKLYN-538 URL: https://issues.apache.org/jira/browse/BROOKLYN-538 Project: Brooklyn

[jira] [Created] (BROOKLYN-537) NPE listing catalog items

Aled Sage created BROOKLYN-537: -- Summary: NPE listing catalog items Key: BROOKLYN-537 URL: https://issues.apache.org/jira/browse/BROOKLYN-537 Project: Brooklyn Issue Type: Bug

Re: REST API: bundles + types + subtypes endpoints

Hi all, For `/subtypes` versus `/types`, it's not really about code duplication. It's that the API is unclear because it's not obvious what the difference/similarity is. If I saw two endpoints like that (without looking at the code), I'd assume they were for different things. If I saw query

Re: REST API: bundles + types + subtypes endpoints

My two cents - 0. Keep /bundles API PR separate from /type and do /bundles now 1. While I like '/catalog' for being more meaningful than '/type', I think what the type registry does is sufficiently different from the classic catalog that it needs a new name in the API. 1.1. /type would be my

[GitHub] brooklyn-server pull request #836: REST call to get activities on an adjunct

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/836 REST call to get activities on an adjunct A single small commit to get via REST the activities related to an adjunct, and descendant tasks. This depends on #810, #816, and #818

[GitHub] brooklyn-server pull request #835: Tasks subsystem improvements - adjuncts, ...

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/835 Tasks subsystem improvements - adjuncts, names, efficiency, GC * Adjuncts' tasks run in their context with tag so can be found more easily * Better naming of tasks across the board (so

[GitHub] brooklyn-server issue #810: REST API for bundles, types, and subtypes

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/810 For template versus application, we can defer that (as long as we're not making pain for ourselves in this api; I don't think we are). Good to separate things into more PRs. UIs that want

Re: REST API: bundles + types + subtypes endpoints

1) like the `/catalog` name and agree with Aled about its power to communicate the idea 2 & 3) run `/v1` and `/v2` in parallel, with the latter being experimental and iterative until a 1.0 release 4) no preference Robert On 20 September 2017 at 15:45, Alex Heneveld <

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139994671 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139994133 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139993855 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139993745 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/CatalogApi.java --- @@ -47,6 +47,9 @@ import

[GitHub] brooklyn-server issue #810: REST API for bundles, types, and subtypes

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/810 Regarding other point about template v application - should that be addressed in this PR @aledsage or could it be a subsequent one? ---

[GitHub] brooklyn-server issue #810: REST API for bundles, types, and subtypes

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/810 As per ML: Aled, Thomas, Mark - thanks for the good feedback. All - There are some good suggestions which I agree deserve discussion. Specific points. (1) Should

Re: REST API: bundles + types + subtypes endpoints

Aled, Thomas, Mark - thanks for the good feedback. All - There are some good suggestions which I agree deserve discussion. Specific points. (1) Should /types and /bundles be top-level or under a /catalog prefix ? Thomas suggested the latter which also fits. My reason for doing top-level is

[GitHub] brooklyn-docs pull request #215: Update Azure ARM documentation for Azure CL...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/215 ---

[GitHub] brooklyn-docs issue #215: Update Azure ARM documentation for Azure CLI 2.0

Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-docs/pull/215 thanks @rdowner, lgtm ---

[GitHub] brooklyn-docs pull request #215: Update Azure ARM documentation for Azure CL...

GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/215 Update Azure ARM documentation for Azure CLI 2.0 The existing instructions are for Azure CLI 1.0. Searching for "Azure CLI" returns hits for 2.0 so it's likely our users will end up with CLI

[GitHub] brooklyn-dist pull request #107: Modular catalog.bom

GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/107 Modular catalog.bom This reuses each bundle's `catalog.bom` file to build global `catalog.bom`. It avoids the duplication of bom files and keep all the metadata (title,

[GitHub] brooklyn-library pull request #130: Modular catalog.bom

GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/130 Modular catalog.bom This reuses each bundle's `catalog.bom` file to build global `catalog.bom`. It replaces `karaf/catalog/src/main/resources/library-catalog-classes.bom` by

[GitHub] brooklyn-server pull request #834: Modular catalog.bom

GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/834 Modular catalog.bom This reuses each bundle's `catalog.bom` file to build global `catalog.bom`. It replaces `karaf/init/src/main/resources/catalog-classes.bom` by

Re: REST API: bundles + types + subtypes endpoints

Thanks Alex. As per my comment in the PR at https://github.com/apache/brooklyn-server/pull/810#issuecomment-330824643. --- TL;DR: Given this is a big API change and given I'm suggesting a `/v2` REST api then I wanted to raise it on the list as well. I propose we split this PR into two. The

[GitHub] brooklyn-server issue #810: REST API for bundles, types, and subtypes

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/810 TL;DR: I propose we split this PR into two. The `/bundles` part we can merge pretty quickly. However, the `/types` and `/subtypes` is too controversial - it probably deserves a `/v2/` of

Jenkins build is back to normal : brooklyn-server-master #739

See

[GitHub] brooklyn-server issue #832: Add ManagementNodeStateListener support

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/832 jenkins build failed with: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:2.5.2:install (default-install) on project brooklyn-core: Failed to

[GitHub] brooklyn-server issue #832: Add ManagementNodeStateListener support

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/832 retest this please ---

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139941230 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139938522 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139939202 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/TypeSummary.java --- @@ -0,0 +1,287 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139941076 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139940367 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/TypeApi.java --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139935349 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/TypeSummary.java --- @@ -0,0 +1,287 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r139939144 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/TypeDetail.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #833: Fix PeriodicEffectorPolicy

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/833#discussion_r139937923 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/action/AbstractScheduledEffectorPolicy.java --- @@ -101,15 +102,15 @@

[GitHub] brooklyn-library issue #129: Move chef from brooklyn-software-base to own mo...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/129 retest this please ---

[GitHub] brooklyn-server pull request #833: Fix PeriodicEffectorPolicy

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/833 ---

[GitHub] brooklyn-docs pull request #214: Document `sshMonitoring.enabled`

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/214 ---

[GitHub] brooklyn-docs issue #214: Document `sshMonitoring.enabled`

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-docs/pull/214 Thanks @drigodwin - comments incorporated and squashed into one commit. Merging now. ---

[GitHub] brooklyn-server pull request #833: Fix PeriodicEffectorPolicy

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/833#discussion_r139935880 --- Diff: policy/src/test/java/org/apache/brooklyn/policy/action/AbstractEffectorPolicyTest.java --- @@ -0,0 +1,81 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #833: Fix PeriodicEffectorPolicy

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/833#discussion_r139935476 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/action/AbstractScheduledEffectorPolicy.java --- @@ -233,8 +269,8 @@ public synchronized

[GitHub] brooklyn-server pull request #833: Fix PeriodicEffectorPolicy

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/833#discussion_r139935768 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/action/AbstractScheduledEffectorPolicy.java --- @@ -210,16 +227,35 @@ protected Duration

[GitHub] brooklyn-server pull request #833: Fix PeriodicEffectorPolicy

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/833#discussion_r139935372 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/action/ScheduledEffectorPolicy.java --- @@ -59,8 +60,8 @@ public

[GitHub] brooklyn-docs pull request #214: Document `sshMonitoring.enabled`

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/214#discussion_r139930384 --- Diff: guide/blueprints/custom-entities.md --- @@ -46,14 +46,48 @@ before running `launch.command` relative to where that file is installed (or

[GitHub] brooklyn-docs pull request #214: Document `sshMonitoring.enabled`

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/214#discussion_r139929611 --- Diff: guide/blueprints/custom-entities.md --- @@ -46,14 +46,48 @@ before running `launch.command` relative to where that file is installed (or

[GitHub] brooklyn-server issue #830: Add support for kubernetes helm

Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-server/pull/830 retest this please ---

[GitHub] brooklyn-server pull request #832: Add ManagementNodeStateListener support

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/832#discussion_r139903337 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/ManagementNodeStateListenerManager.java --- @@ -0,0 +1,175 @@ +/*