GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/171
Use login port for ssh
Currently we assume port 22 for ssh unless a
portforwarder has been configured. This uses the getLoginPort
from nodemetadata to determine the ssh port
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/214#discussion_r68134027
--- Diff:
core/src/test/java/org/apache/brooklyn/util/core/xstream/XmlUtilTest.java ---
@@ -20,15 +20,65 @@
import static
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/214
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1169#issuecomment-176694764
I think I've made all the changes that I've been asked for. If everything
is ok then please let me know if I should squash my commits before merging
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1169#issuecomment-174955669
@ahgittin I'm a bit confused about brooklyn's new structure. If I want to
extend abstractyamltest so that I can write a yaml test for this then either
GitHub user duncangrant opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1169
Create Password Sensor
A simple initialiser for creating passwords in yaml as a sensor
Added a password generating function in the Identifiers class which uses
Github user duncangrant commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1169#issuecomment-175027320
@neykov The nice thing about yaml is it becomes an example of how to use
something that you know works because it has been tested so I'll probably keep
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/153#discussion_r64358268
--- Diff:
core/src/test/java/org/apache/brooklyn/core/effector/script/ScriptEffectorTest.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/33#discussion_r62303117
--- Diff:
software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java
---
@@ -328,9 +340,39
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/33#discussion_r62302094
--- Diff:
software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java
---
@@ -328,9 +340,39
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/135
Remove feature brookly-software-cm
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duncangrant/brooklyn-server
fix/karaf-cm
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/271
I've tested this - all seems to work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-library/pull/53
I've tested this - all seems to work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-dist/pull/41
I've tested this - all seems to work
Tested compiling, running in amp and karaf
Checked entities available as expected in catalog
Ran some entities (mariadb crate)
---
If your
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74493525
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74493342
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/292
@aledsage I've done the renaming and fixed the merge conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-docs/pull/91
Fix typo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duncangrant/brooklyn-docs fix-typo
Alternatively you can review and apply
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-docs/pull/90
Added more policies to policies page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duncangrant/brooklyn-docs update-policies-docs
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/89#discussion_r70506491
--- Diff: guide/ops/troubleshooting/deployment.md ---
@@ -75,6 +75,58 @@ There are many possible reasons for this ssh failure,
which include
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-docs/pull/85
Split locations docs into more sections
It is difficult to find the details for AWS softlayer in the
locations doc as you have to scroll a long way so this commit
splits them
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/292
Shared location customizer
A location customizer that creates a single shared security group for each
entity it is applied to as well as an individual entity. The shared entity
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/292
I've removed some whitespace and squashed commits. @grkvlt Do you think we
can merge this now?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/544
@geomacy I read that as more of an open question for which there was only
one response (from @googlielmo ) in favour. I'm personally don't like the idea
of making this configurable
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/544
Prefer centos 7
As discusson on the Apache Brooklyn discussion mailing list this PR updates
BrooklynImageChooser to prefer centos over ubuntu
You can merge this pull request
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/544
I've removed the code that selects the latest centos so that it behaves as
before - with no preference for any version of centos
---
If your project is set up for it, you can reply
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/544
@aledsage I've tried to take into account your comments and I've written
some unit tests to assert the logic etc. I think that I've probably made it
harder to make it configurable so
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/92#discussion_r101529086
--- Diff:
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/couchdb/CouchDBNodeSshDriver.java
---
@@ -198,24 +211,36 @@ public
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/42#discussion_r75463853
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -0,0 +1,62 @@
+
+
+http://karaf.apache.org/xmlns/features/v1.2.0
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/319#discussion_r77517736
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java
---
@@ -65,38 +64,28
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/319
Why are you using the SharedLocationSecurityGroupCustomizer in
NetworkingEffectors? The SharedLocationSecurityGroupCustomizer is intended as
a cut-down
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/319#discussion_r77518183
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/319#discussion_r77522771
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/InboundPortsJcloudsLocationCustomizer.java
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/319#discussion_r77539548
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/319
How do I test this?
I tried:
`location:
aws-central-centos7
services:
- type: org.apache.brooklyn.entity.software.base.EmptySoftwareProcess
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/361
Add disable flag to shared sg customizer
This flag allows the shared sg to be disabled in yaml
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/371
One instance of customizer at each customize step
Change so that getCustomizers is only called once during provisioning.
This ensures that only a single instance of a customizer
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-dist/pull/43
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-dist/pull/43
688 [sshd-SshClient[309e345f]-nio2-thread-2] WARN
org.apache.sshd.client.keyverifier.AcceptAllServerKeyVerifier - Server at
[/127.0.0.1:8101, RSA, 01:98:f4:32:32:dc:49:8c:62:c6:c7:31:75
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-dist/pull/43
When I run bin/stop I get:
Unable to find port...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/361#discussion_r81350227
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-docs/pull/115
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/501#discussion_r93614592
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1484,6 +1493,48 @@ public Template
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/609
HttpCommandEffector allows string payload
Also fixed integration tests that failing due to https://httpbin
You can merge this pull request into a Git repository by running:
$ git
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/610#discussion_r107880463
--- Diff:
core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorHttpBinTest.java
---
@@ -38,42 +54,93 @@
import
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/636#discussion_r111569328
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java ---
@@ -621,6 +621,7 @@ private static Object getFlag(Map
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/636#discussion_r111567843
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java ---
@@ -621,6 +621,7 @@ private static Object getFlag(Map
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/789#discussion_r131145665
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -485,6 +491,17 @@ protected void doStart
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/790#discussion_r131340473
--- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java ---
@@ -228,6 +235,25 @@ public Builder httpExecutor(HttpExecutor val
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/790
Could you update the description to explain what this does in a bit more
detail please?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/790#discussion_r131342918
--- Diff:
core/src/test/java/org/apache/brooklyn/feed/http/HttpFeedTest.java ---
@@ -360,7 +364,90 @@ public void
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/784
LGTM - needs minidev missing requirement issue fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-docs/pull/175
Document fix for SSLException close_notify
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duncangrant/brooklyn-docs close_notify
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/745
Tested with a location with no virtual network set but with
overrideAuthenticateSudo set to true.
Tested with a specified virtual network.
---
If your project is set up
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/575#discussion_r114517277
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/BasicLocationRegistry.java
---
@@ -372,7 +377,10 @@ public final Location
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-library/pull/105
change config for 2.0.0
Use the chttpd section for binding ip and setting port
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/684
That's a nice example of java 8ifyng code. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/862
Fix npr when reading streamed bundle
This happens when there is an existing unmanaged bundle with the same id
and a replacement bundle is uploaded without the force flag
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/812
Should we make it easier to disable the provider? That way a "live"
deployment of amp would prevent it's use. So if a developer forgets to update
their yaml to use a rea
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/805
Should the same change be applied to killMachine( as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/863
This looks reasonable to me and improves testing. I think we should
consider how much of this should be covered in the user docs as we make it all
seem quite simple here
https
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/900
Fix VSP stop/start when ssh monitoring disabled
When stop / starting a VanillaSoftwareProcess with ssh monitoring the
process will never be marked as healthy after a stop start
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-library/pull/137
Update openssl prior to installing nodejs
Changes to how nodejs/npm packaged on centos mean we need to do this
Fix recommended here:
https://stackoverflow.com/questions
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/881#discussion_r149190906
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/software/base/VanillaSoftwareProcessTest.java
---
@@ -294,4 +309,63 @@ public
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/881
Tested fairly thoroughly using a blueprint which was previously failing to
restart correctly.
---
Github user duncangrant closed the pull request at:
https://github.com/apache/brooklyn-client/pull/62
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-client/pull/62
Closing because would still panic if you ran br --help -v
---
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-client/pull/63
Fixes index out of range issue
Wasn't handling calls where there were only flag params e.g.
br -v
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-client/pull/62
Fixes index out of range issue
Wasn't handling flags properly but we can assume that there is no scope
if there are only 2 parms i.e. br param
You can merge this pull request
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/914
PR could do with a description.
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/969
@geomacy regarding the naming I don't think tags is relevant to the tests.
The mechanism for comparison could be changed later without changing the tests.
I see this as a file of tests
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/969
@ahgittin in response to your comment
https://github.com/apache/brooklyn-server/pull/969#issuecomment-396177108 I
have removed that commit from the PR as I wasn't really comfortable
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/968
@ahgittin I've tested this with a few different bom files with small
changes e.g. quotes, comments, etc. Works well. It's also nice that it's a
small change. There are a couple
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/968#discussion_r192718263
--- Diff:
core/src/main/java/org/apache/brooklyn/core/typereg/RegisteredTypes.java ---
@@ -682,27 +683,65 @@ private static String
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/969
Add registered types test
This PR follows on from #968
It adds 2 commits. The first adds tests for the functionality fixed in
#968
The second changes the logic in #968
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/961#discussion_r185488617
--- Diff: parent/pom.xml ---
@@ -1104,6 +1104,8 @@
https://brooklyn.incubator.apache.org
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/961
I wonder if it would be better to check out the repo into a subdirectory.
This is an option in jenkins but would probably need some changes around paths
in the build scripts.
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/935
@aledsage I think I've addressed all comments and mirrored the changes for
ssh drivers.
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-docs/pull/260
Merging - thanks @tbouron
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/972
I'll merge - thanks @nakomis
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-ui/pull/58
LGTM - I'll merge
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/976
@jimmycasey Thank you very much for your pull request. I'll merge that now.
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/979
Thanks for that @kemitix
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/986
This looks good to me
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/952
@andreaturli Might be worth adding a docs change to
https://brooklyn.apache.org/v/latest/locations/index.html#openstack?
---
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/952
@andreaturli No - shouldn't be part of this PR. I just wrote the comment
as a reminder.
---
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/245#discussion_r170577533
--- Diff: guide/locations/_openstack.md ---
@@ -1,23 +1,69 @@
## OpenStack
-### Apache jclouds
-Support for OpenStack
87 matches
Mail list logo
