[GitHub] brooklyn-server issue #213: TestSshCommand checks all assertions rather than...

2016-06-22 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/213 Going to merge this since it fixes the build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server pull request #224: Fix VanillaJavaApp's stdin and env

2016-06-29 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/224 Fix VanillaJavaApp's stdin and env The output from the classpath gathering step currently includes Brooklyn's "Executed ... , result: 0" info, which means that class

[GitHub] brooklyn-server issue #224: Fix VanillaJavaApp's stdin and env

2016-06-29 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/224 This affects Brooklyn 0.8.0-incubating and 0.9.0 too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-server issue #224: Fix VanillaJavaApp's stdin and env

2016-06-29 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/224 I suppose though stupid it's not a fundamental flaw since these nonsense entries will be ignored. --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-docs issue #84: Fix broken links to SSH keys docs

2016-06-30 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-docs/pull/84 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server issue #209: Test relative entities

2016-07-06 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/209 @neykov Thank you for your comments. I have removed the `testSpec` config key in favour of children, replaced the use of `Scope` with plain `DslComponents` and reworked the use of `target

[GitHub] brooklyn-server issue #209: Test relative entities

2016-07-13 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/209 I'll merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] brooklyn-server pull request #524: Misc improvements

2017-01-17 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/524 Misc improvements A bunch of things I've found useful. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sjcorbett/brooklyn-s

[GitHub] brooklyn-server issue #497: Add findOpenSocketsOnNode to ReachableSocketFind...

2017-01-18 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/497 @aledsage @neykov I have updated this pull request to hopefully get the best of both worlds. The point of contention was waiting the full timeout for a response when another check had

[GitHub] brooklyn-server pull request #497: Add findOpenSocketsOnNode to ReachableSoc...

2017-01-18 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/497#discussion_r96612584 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsUtil.java --- @@ -354,30 +355,60 @@ public static String

[GitHub] brooklyn-server pull request #497: Add findOpenSocketsOnNode to ReachableSoc...

2017-01-18 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/497#discussion_r96614971 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsUtil.java --- @@ -354,30 +355,60 @@ public static String

[GitHub] brooklyn-server issue #526: Add removeSecurityGroup by id

2017-01-19 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/526 Looks sensible. It would be good to see some tests for SecurityGroupEditor in a subsequent pull request. --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-server pull request #524: Misc improvements

2017-01-19 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/524#discussion_r96843229 --- Diff: rest/rest-server/src/main/java/org/apache/brooklyn/rest/filter/BrooklynPropertiesSecurityFilter.java --- @@ -148,8 +148,11 @@ protected

[GitHub] brooklyn-server pull request #520: Limit parallelism of start/stop steps on ...

2017-01-19 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/520#discussion_r96844228 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolverIterator.java --- @@ -0,0 +1,173 @@ +package

[GitHub] brooklyn-server pull request #520: Limit parallelism of start/stop steps on ...

2017-01-19 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/520#discussion_r96845410 --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/MaxConcurrencySensor.java --- @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #520: Limit parallelism of start/stop steps on ...

2017-01-19 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/520#discussion_r96848337 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessDriverLifecycleEffectorTasks.java --- @@ -169,7

[GitHub] brooklyn-server issue #520: Limit parallelism of start/stop steps on Softwar...

2017-01-19 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/520 Compilation fails for me with the following error: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:testCompile (default-testCompile) on

[GitHub] brooklyn-server issue #520: Limit parallelism of start/stop steps on Softwar...

2017-01-19 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/520 The bulk of these changes look good. It would help me if you gave some context for 112269ae484dcc5283d9cabc8de2e987f013e79f. --- If your project is set up for it, you can reply to this

[GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer

2017-01-19 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/529 LocationNetworkInfoCustomizer `LocationNetworkInfoCustomizer` is a special customiser used by `JcloudsLocation` to determine the address and credentials with which a location should be

[GitHub] brooklyn-server issue #520: Limit parallelism of start/stop steps on Softwar...

2017-01-19 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/520 Jenkins is failing on `SoftwareProcessEntityLatchTest.testConcurrency` and `testReleaseableLatchBlocks` By the way, can we get rid of `maxConcurrentChildCommands` when this is

[GitHub] brooklyn-library issue #87: Follow API changes in brooklyn-server#520

2017-01-20 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-library/pull/87 You need to update `ChefLifecycleEffectorTasks`, `ChefPostgreSqlLifecycle` and `org.apache.brooklyn.entity.software.base.test.mysql.DynamicToyMySqlEntityBuilder.MySqlEntityInitializer

[GitHub] brooklyn-server pull request #520: Limit parallelism of start/stop steps on ...

2017-01-20 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/520#discussion_r97049449 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessDriverLifecycleEffectorTasks.java --- @@ -169,7

[GitHub] brooklyn-server issue #532: Add missing @Override annotations and other clea...

2017-01-23 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/532 Looks good to me. Anything more to come @neykov? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] brooklyn-server issue #527: Adds test for catalog-effector from OSGi bundle

2017-01-23 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/527 Looks good. Would be nice to be able to make an assertion on the effect of the effector, but perhaps that's one for another time. --- If your project is set up for it, you can rep

[GitHub] brooklyn-server pull request #520: Limit parallelism of start/stop steps on ...

2017-01-23 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/520#discussion_r97337170 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java --- @@ -444,15

[GitHub] brooklyn-server issue #505: BROOKLYN-404: fix ConcurrentModificationExceptio...

2017-01-23 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/505 @aledsage could you rebase on master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-ui issue #36: Fix nav menu in Brooklyn API page

2017-01-23 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-ui/pull/36 @bostko could you revisit Alex and Svet's comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] brooklyn-server pull request #505: BROOKLYN-404: fix ConcurrentModificationE...

2017-01-24 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/505#discussion_r97524799 --- Diff: core/src/main/java/org/apache/brooklyn/core/internal/BrooklynProperties.java --- @@ -181,6 +181,7 @@ public static Builder

[GitHub] brooklyn-server issue #505: BROOKLYN-404: fix ConcurrentModificationExceptio...

2017-01-24 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/505 Looks good; will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server pull request #497: Add findOpenSocketsOnNode to ReachableSoc...

2017-01-24 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/497#discussion_r97561966 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/net/ReachableSocketFinder.java --- @@ -69,86 +65,113 @@ public

[GitHub] brooklyn-server pull request #497: Add findOpenSocketsOnNode to ReachableSoc...

2017-01-24 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/497#discussion_r97568128 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/net/ReachableSocketFinder.java --- @@ -69,86 +65,113 @@ public

[GitHub] brooklyn-server pull request #497: Add findOpenSocketsOnNode to ReachableSoc...

2017-01-24 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/497#discussion_r97567977 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/net/ReachableSocketFinder.java --- @@ -69,86 +65,113 @@ public

[GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer

2017-01-24 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/529#discussion_r97603990 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -625,6 +630,30 @@ public

[GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer

2017-01-24 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/529#discussion_r97610554 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2607,24 +2522,32 @@ public boolean

[GitHub] brooklyn-server issue #497: Add findOpenSocketsOnNode to ReachableSocketFind...

2017-01-26 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/497 @neykov I've updated again. Took a little reworking due to the uncertainty introduced about when the executor was allowed to shut down. Resorted to having each call to `tryReachable

[GitHub] brooklyn-server issue #520: Limit parallelism of start/stop steps on Softwar...

2017-01-26 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/520 @neykov looks good. I'm going to merge this. Could I ask you to add a couple of lines describing the new feature to the section on latches in the docs (https://brooklyn.apache.

[GitHub] brooklyn-library issue #87: Follow API changes in brooklyn-server#520

2017-01-26 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-library/pull/87 Thanks @neykov, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-library issue #88: Add missing @Override annotations and other clea...

2017-01-26 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-library/pull/88 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-library issue #88: Add missing @Override annotations and other clea...

2017-01-26 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-library/pull/88 @neykov could you rebase master once #87 is merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-server issue #541: Fix ReachableSocketFinderTest (so not time-sensi...

2017-01-27 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/541 Thanks @aledsage, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-docs issue #146: Document the latch improvements - max concurrency ...

2017-01-27 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-docs/pull/146 Thanks @neykov, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-library issue #88: Add missing @Override annotations and other clea...

2017-02-06 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-library/pull/88 Sorry @neykov. Could you rebase once more? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-library issue #72: Fix test to work on any combination of OS & eol ...

2017-02-06 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-library/pull/72 Thanks @neykov and @googlielmo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-client issue #37: Add missing @Override annotations and other clean...

2017-02-06 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-client/pull/37 Thanks @neykov. The Jenkins error has been lost to time. I've verified that the build passes locally. --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-server pull request #553: MultimapSerializer works with non-String ...

2017-02-08 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/553 MultimapSerializer works with non-String keys MultimapSerializer works with non-String keys You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] brooklyn-server issue #553: MultimapSerializer works with non-String keys

2017-02-08 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/553 Thanks @geomacy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server pull request #553: MultimapSerializer works with non-String ...

2017-02-08 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/553#discussion_r100091981 --- Diff: core/src/test/java/org/apache/brooklyn/util/core/json/MultimapSerializerTest.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #553: MultimapSerializer works with non-String ...

2017-02-08 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/553#discussion_r100092325 --- Diff: core/src/test/java/org/apache/brooklyn/util/core/json/MultimapSerializerTest.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer

2017-02-14 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/529#discussion_r101047658 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -625,6 +630,30 @@ public

[GitHub] brooklyn-server pull request #529: LocationNetworkInfoCustomizer

2017-02-15 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/529#discussion_r101334570 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BasicLocationNetworkInfoCustomizer.java --- @@ -0,0 +1,472

[GitHub] brooklyn-server issue #529: ConnectivityResolver

2017-02-22 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/529 @geomacy @neykov thanks for your thorough comments. Please see 728fb46 for changes addressing your suggestions and c9fcf15 for a simplification of `ReachableSocketFinder`. --- If your

[GitHub] brooklyn-library pull request #93: Rename jboss_logo.png jboss-logo.png.

2017-02-23 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-library/pull/93 Rename jboss_logo.png jboss-logo.png. Fixes various references to the file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sjcorbett

[GitHub] brooklyn-library pull request #91: Updated "hello-world-sql" example webapp ...

2017-02-23 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/91#discussion_r102722987 --- Diff: examples/webapps/hello-world-sql/src/main/webapp/redis.jsp --- @@ -0,0 +1,80 @@ +<%@ page import="java.util.List" %&g

[GitHub] brooklyn-library issue #91: Updated "hello-world-sql" example webapp to supp...

2017-02-23 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-library/pull/91 @justinThompson looks good thanks. I've left a couple of minor comments. Will test the feature out before merging. --- If your project is set up for it, you can reply to this emai

[GitHub] brooklyn-library pull request #91: Updated "hello-world-sql" example webapp ...

2017-02-23 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/91#discussion_r102723143 --- Diff: examples/webapps/hello-world-sql/src/main/webapp/redis.jsp --- @@ -0,0 +1,80 @@ +<%@ page import="java.util.List" %&g

[GitHub] brooklyn-server pull request #572: wip: debug ReachableSocketFinderTest.getR...

2017-02-27 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/572 wip: debug ReachableSocketFinderTest.getReachableSockets Don't merge. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sjco

[GitHub] brooklyn-server issue #572: Increase timeout in ReachableSocketFinderTest

2017-02-27 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/572 @geomacy @neykov could you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server pull request #318: Delete most deprecated methods from PortF...

2017-02-28 Thread sjcorbett
Github user sjcorbett closed the pull request at: https://github.com/apache/brooklyn-server/pull/318 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #580: Set the username for Windows locations correctly

2017-03-02 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/580 Looks good. `WinRmMachineLocationLiveTest` passed for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-ui issue #36: Updated logout step to work in karaf mode

2017-03-03 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-ui/pull/36 @bostko looks good. Will test and merge if ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server issue #578: BROOKLYN-323: Use proper WWW-Authorization heade...

2017-03-03 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/578 @bostko looks good. Will test and merge if ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] brooklyn-ui issue #36: Updated logout step to work in karaf mode

2017-03-03 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-ui/pull/36 @bostko Looks like this negatively impacts logging out of the non-Karaf distribution. After logging out I've found that: * master non-karaf: prompts for re-authentication. * m

[GitHub] brooklyn-server issue #578: BROOKLYN-323: Use proper WWW-Authorization heade...

2017-03-03 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/578 I'll leave this while brooklyn-ui#36 is still open. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-ui issue #36: Updated logout step to work in karaf mode

2017-03-06 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-ui/pull/36 @bostko thanks for the update. I've confirmed that the browser requires re-authentication in both cases. --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-server issue #374: BROOKLYN-358: karaf includes jclouds-api-swift

2017-03-07 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/374 I've run into the issues discussed above. Was either issue filed? Is Brooklyn able to persist to SoftLayer's object store? --- If your project is set up for it, you can rep

[GitHub] brooklyn-server issue #573: Do not runtime-inherit catalog item in the spec ...

2017-03-09 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/573 Regarding `RedisClusterIntegrationTest`, it specifically only failed when run through the http server. The same blueprint passed when tested with `AbstractYamlTest`. --- If your project

[GitHub] brooklyn-server pull request #590: Use boolean Options correctly in ItemList...

2017-03-13 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/590 Use boolean Options correctly in ItemLister Replaces list-objects' `--catalog-only` and `--ignore-impls` arguments with `--all-classes` and `--include-impls` respect

[GitHub] brooklyn-server pull request #592: Fix publication of EC2 host address in De...

2017-03-13 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/592 Fix publication of EC2 host address in DefaultConnectivityResolver Publish Attributes.ADDRESS before guessing the EC2 hostname. Fixes the case where host.address was set to the FQDN

[GitHub] brooklyn-server issue #592: Fix publication of EC2 host address in DefaultCo...

2017-03-13 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/592 The Jenkins failure was due to the environment: ``` Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0xd000, 536870912, 0) failed; error='C

[GitHub] brooklyn-server issue #594: Revert "add original failing test from @sjcorbet...

2017-03-15 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/594 @ahgittin In the test's current form it sounds like the qa project is sensible. Alternatively you could rephrase it to drop the use of Redis. It was coincidental that I found the pr

[GitHub] brooklyn-library issue #94: Add entity/config test via REST using redis as a...

2017-03-21 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-library/pull/94 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-dist issue #88: docker-itest: java version to 8, add chef package

2017-03-24 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-dist/pull/88 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] brooklyn-server issue #610: Various integration test fixes

2017-03-24 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/610 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-server issue #607: Improve test location rebind stub

2017-03-24 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/607 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-server issue #602: Add test illustrating SNI connection problem.

2017-03-24 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/602 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-client pull request #42: Improve login handling.

2017-04-04 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/42#discussion_r109663969 --- Diff: cli/commands/login.go --- @@ -84,7 +100,8 @@ func (cmd *Login) Run(scope scope.Scope, c *cli.Context

[GitHub] brooklyn-docs pull request #161: Documentation on greaterThan and lessThan t...

2017-04-06 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-docs/pull/161 Documentation on greaterThan and lessThan test assertions Accompanies https://github.com/apache/brooklyn-server/pull/619. You can merge this pull request into a Git repository by running

[GitHub] brooklyn-server pull request #619: Add greaterThan and lessThan test framewo...

2017-04-06 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/619#discussion_r110143902 --- Diff: test-framework/src/main/java/org/apache/brooklyn/test/framework/TestFrameworkAssertions.java --- @@ -287,140 +292,86 @@ public Boolean

[GitHub] brooklyn-server issue #616: Fixed BlobStoreContextFactoryImpl. It can now ha...

2017-04-11 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/616 @aledsage Why should `BlobStoreContextFactory` be regarded as an internal interface? It's already being used in a downstream project that this PR has broken. Should the projec

[GitHub] brooklyn-server issue #616: Fixed BlobStoreContextFactoryImpl. It can now ha...

2017-04-13 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/616 There's not a good parallel in the downstream project at the moment. It only has the config bag to use, not a location. I think I'll just take a copy of the previous version of

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-04-18 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-client/pull/42 On the current master: ``` $ ./target/bin/br login http://ldsn3e Get http://ldsn3e/v1/server/version: dial tcp: lookup ldsn3e on 66.28.0.45:53: no such host

[GitHub] brooklyn-client pull request #42: Improve login handling.

2017-04-18 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-client/pull/42#discussion_r111932687 --- Diff: cli/net/net.go --- @@ -121,15 +121,15 @@ func (net *Network) SendRequestGetStatusCode(req *http.Request) ([]byte, int, er

[GitHub] brooklyn-server issue #640: Fix address publish bug

2017-04-18 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/640 +1 to the change. I was probably being overly cautious about not triggering duplicate sensor change events (since the block will run during rebind). I'm not aware of any downs

[GitHub] brooklyn-docs issue #164: Adds documentation for bundling catalog resources ...

2017-05-04 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-docs/pull/164 @nakomis can you rebase this on master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-docs pull request #164: Adds documentation for bundling catalog res...

2017-05-04 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/164#discussion_r114828307 --- Diff: guide/ops/catalog/index.md --- @@ -371,6 +372,155 @@ increment an internal version number for the catalog item. When referencing a

[GitHub] brooklyn-docs pull request #164: Adds documentation for bundling catalog res...

2017-05-04 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/164#discussion_r114839724 --- Diff: guide/ops/catalog/index.md --- @@ -371,6 +372,155 @@ increment an internal version number for the catalog item. When referencing a

[GitHub] brooklyn-docs pull request #164: Adds documentation for bundling catalog res...

2017-05-04 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/164#discussion_r114841357 --- Diff: guide/ops/catalog/index.md --- @@ -371,6 +372,155 @@ increment an internal version number for the catalog item. When referencing a

[GitHub] brooklyn-server pull request #668: Minor CatalogResource and ApplicationReso...

2017-05-04 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/668 Minor CatalogResource and ApplicationResource fixes CatalogResource closes ZipFiles cleanly and ApplicationResource checks the invoke-effector permission before invoking the start

[GitHub] brooklyn-server pull request #651: Test speedups

2017-05-05 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/651#discussion_r114961921 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolverTest.java --- @@ -147,10 +149,9

[GitHub] brooklyn-server pull request #651: Test speedups

2017-05-05 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/651#discussion_r115023121 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolverTest.java --- @@ -147,10 +149,9

[GitHub] brooklyn-docs pull request #178: Guide to template files

2017-05-05 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-docs/pull/178 Guide to template files A full guide to using template files in blueprints. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sjcorbett

[GitHub] brooklyn-docs issue #178: Guide to template files

2017-05-08 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-docs/pull/178 @rdowner I think this is something you were looking at previously. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-docs issue #178: Guide to template files

2017-05-10 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-docs/pull/178 @drigodwin @rdowner thanks. I've addressed all your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] brooklyn-server issue #677: Adds EBS Location Customizers

2017-05-12 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/677 Is an AWS-specific feature something we want in Brooklyn or should it be provided in a self-contained repository? There's some precedent for the latter. - https://github.com/clou

[GitHub] brooklyn-server issue #677: Adds EBS Location Customizers

2017-05-12 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/677 Those projects are both licensed to Cloudsoft so are perhaps not the best examples but my question stands: should we encourage cloud-specific features in core Brooklyn? --- If your

[GitHub] brooklyn-server issue #694: Fix non-deterministic DefaultCOnnectivityResolve...

2017-05-23 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/694 See my comment on https://github.com/apache/brooklyn-server/pull/651#discussion_r114961921 for why these failures are likelier to occur with a short timeout. --- If your project is set

[GitHub] brooklyn-server issue #696: Fix DslYamlTest

2017-05-24 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/696 Looks good, thanks @aledsage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #697: Revert "Upgrade to jclouds 2.1.0-SNAPSHOT...

2017-05-24 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/697 Revert "Upgrade to jclouds 2.1.0-SNAPSHOT" This reverts commit 1259e2832829d67148a42cbbb07400cc94a06587. Apologies, I did not intend to merge this. You can merge

[GitHub] brooklyn-server pull request #760: Add DigitalOcean2 and ProfitBricks featur...

2017-07-11 Thread sjcorbett
GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-server/pull/760 Add DigitalOcean2 and ProfitBricks features to Karaf build You can merge this pull request into a Git repository by running: $ git pull https://github.com/sjcorbett/brooklyn-server

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-07-13 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-client/pull/42 @geomacy I was right on the cusp of merging this when I realised that logging out means you can't view help text: ``` $ br version 0.12.0-SNAPSHOT $ br NAME:

<    1   2   3   4   >