Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/485#discussion_r106949452
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/CatalogApi.java ---
@@ -38,27 +38,60 @@
import
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/485#discussion_r106941722
--- Diff:
rest/rest-resources/src/test/java/org/apache/brooklyn/rest/resources/CatalogResourceTest.java
---
@@ -487,6 +495,79 @@ public void
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/485
@geomacy That was my understanding as well but my tests show a different
behaviour. When I import my zip (with the above bom), `entity-1` is created
under the id `test:0.1.0` which is wrong
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/164#discussion_r110357761
--- Diff: guide/ops/catalog/index.md ---
@@ -371,6 +372,141 @@ increment an internal version number for the catalog
item.
When referencing
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/636#discussion_r111724680
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java ---
@@ -671,6 +672,15 @@ public static String
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/636#discussion_r111724623
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java ---
@@ -621,6 +621,7 @@ private static Object getFlag(Map flags
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/635#discussion_r111566723
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/CatalogResource.java
---
@@ -481,6 +498,10 @@ public
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/637
Remove deprecated REST API endpoints
This removes the deprecated REST API endpoints from Brooklyn 0.7.0. It also
fixes the launcher configuration (as the `VersionApi` has been entirely
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/635#discussion_r111555275
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/CatalogResource.java
---
@@ -331,6 +332,10 @@ public void
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/636#discussion_r111567802
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java ---
@@ -621,6 +621,7 @@ private static Object getFlag(Map flags
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/636#discussion_r111567928
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java ---
@@ -671,6 +672,15 @@ public static String
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/637
BTW, I also checked the JSGUI and it does not use any of the deprecated
call so you are good on this part
---
If your project is set up for it, you can reply to this email and have your
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/173
Update apache brooklyn website's landing page + styles
Demo is visible here: https://tbouron.github.io/brooklyn-docs/
The most visible changes are on the landing page, it matched
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/586
Tested, LGTM.
I'm just not understanding the use-case for the `deferred` in
`$brooklyn:object`, could you give a bit more details on this @aledsage ?
---
If your project is set up
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/586
@aledsage That makes sense, the example helped a lot to understand.
LGTM then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/153
Remove bash prompt so users can directly copy commands
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-docs patch-2
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/638
Add support for managing enrichers within the catalog
This allows enrichers to be registered within the Brooklyn catalog, same as
entities or policies. It allows enrichers' registration
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/635
Allow passing "latest" as version for catalog endpoints
This allow passing `latest` as the version for the following endpoints:
- `GET /v1/catalog/applications//`
- `GET /
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-client/pull/46
Removed unused class
Fixes broken jenkins builds, introduces by #45 and
https://github.com/apache/brooklyn-server/pull/637
You can merge this pull request into a Git repository by running
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/632
Tested, LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/168
Thanks @drigodwin, this looks really good indeed, it's easier to navigate
through.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/173
Addressed the comments about the logo, as discussed in the IRC channel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-dist/pull/101
+1 on log4j2, but it's personal preference
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/205
Good catch, kramdown uses `~` instead of `
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/664
Add contributing guideline and PR template
Based on the recent discussion, I created a `CONTRIBUTING.md` (taken from
[this page](https://brooklyn.apache.org/developers/how
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-dist/pull/91
Hey @mikezaccardo, looks like this option is for Java but the JRE/JDK
provided by Oracle. Does it apply for openjdk as well?
If yes, then I think it cannot hurt to add it. Although, I
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/182
Doing (1) and (2) sounds good, I'll revert the real names by flags when
it's too long/complicated.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/638
@geomacy done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/182
Enforce the use of `brooklyn.config` in yaml examples
This is related to the proposal of deprecating `@SetFromFlag` annotation,
see [email
thread](https://lists.apache.org/thread.html
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/638
Thanks for the review @geomacy! I addressed your comments and rebased on
the latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-client/pull/55
Allow catalog item to be force-updated via query string flag on the REST API
This is required by https://github.com/apache/brooklyn-server/pull/744
You can merge this pull request
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/744
Allow catalog item to be force-updated via query string flag on the REST API
# Issue
When `POST`ing a catalog item (YAML file) with an ID and version to already
exist, the REST
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/744#discussion_r123742309
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/CatalogApi.java ---
@@ -67,7 +67,7 @@
@ApiResponse(code = 400
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/194#discussion_r120547081
--- Diff: guide/blueprints/effectors.md ---
@@ -0,0 +1,167 @@
+---
+title: Effectors
+layout: website-normal
+---
+
+Effectors
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/194#discussion_r120547131
--- Diff: guide/blueprints/effectors.md ---
@@ -0,0 +1,167 @@
+---
+title: Effectors
+layout: website-normal
+---
+
+Effectors
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/194
Wouldn't be worth to document how to create enrichers from YAML?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/194
@andreaturli Ignore me, I was not really awaken when I wrote this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/664
> This particular template is onerous and patronising
Patronising, seriously? I'm speechless here. FYI @ahgittin a
`CONTRIBUTING.md` can be useful because [GitHub treats it a
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/664
Yeah, sure, whatever.
Was just trying to help but my take appears to be too "child-ish" so closing
---
If your project is set up for it, you can reply to this email and
Github user tbouron closed the pull request at:
https://github.com/apache/brooklyn-server/pull/664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/169#discussion_r114750517
--- Diff: _includes/footer.html ---
@@ -1,10 +1,10 @@
-
-Apache Brooklyn
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/169#discussion_r114750551
--- Diff: style/css/_footer.scss ---
@@ -22,6 +22,10 @@ div#footer {
background-color: $white_f5;
text-align: center;
font
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/169#discussion_r114750423
--- Diff: guide/misc/migrate-to-0.8.0.md ---
@@ -29,4 +29,4 @@ $ for x in `find . -type file` ; do sed -E -i .bak -f
/tmp/migrate.sed $x ; done
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/176
@bostko Can you reply and update your PR, based on @drigodwin's comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/119
I think having separated docs for customising locations is fine. But I
would definitely add the port-opened explicitly if we add configkeys, as
mentioned by @aledsage.
Otherwise
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/144
@bostko Can you update the PR as per as @geomacy's comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/164#discussion_r114833401
--- Diff: guide/ops/catalog/index.md ---
@@ -371,6 +372,155 @@ increment an internal version number for the catalog
item.
When referencing
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/212
I added the links for the DEB package on the download pages. This is
subject to our ability of building the DEB and RPM package for snapshot though
/cc @richardcloudsoft
---
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/212
Add update instructions for RPM/DEB and bin distribution
This requires the `paths.html` page available with #210
You can merge this pull request into a Git repository by running:
$ git
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/105#discussion_r138854462
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -38,7 +38,7 @@ default_config:
run_os_update: true
servers:
- name
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/105#discussion_r138854297
--- Diff: vagrant/src/main/vagrant/files/install_brooklyn.sh ---
@@ -48,45 +48,53 @@ fi
if [ ! "${INSTALL_FROM_LOCAL_DIST}"
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/819
@aledsage I just realised that you miss one more bom file in
`karaf/init/src/main/resources/catalog-classes.bom`. This one is the base for
the karaf distribution.
(I think we
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/819
@aledsage Ok to me ð (build failure looks unrelated)
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/810#discussion_r139111961
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/CatalogApi.java ---
@@ -47,6 +47,9 @@
import
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/213#discussion_r138928675
--- Diff: guide/blueprints/policies.md ---
@@ -100,6 +100,39 @@ The ConnectionFailureDetector is an HA policy for
monitoring an http connection
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/213#discussion_r138928146
--- Diff: guide/blueprints/policies.md ---
@@ -100,6 +100,39 @@ The ConnectionFailureDetector is an HA policy for
monitoring an http connection
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/213#discussion_r138927743
--- Diff: guide/blueprints/policies.md ---
@@ -100,6 +100,39 @@ The ConnectionFailureDetector is an HA policy for
monitoring an http connection
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/213#discussion_r138928088
--- Diff: guide/blueprints/policies.md ---
@@ -100,6 +100,39 @@ The ConnectionFailureDetector is an HA policy for
monitoring an http connection
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/213#discussion_r138928349
--- Diff: guide/blueprints/policies.md ---
@@ -100,6 +100,39 @@ The ConnectionFailureDetector is an HA policy for
monitoring an http connection
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-dist/pull/105
DO NOT MERGE YET: This requires the DEB and RPM package to be available for
SNAPSHOT version. In the meantime, #106 will do the trick to move to Karaf
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/128
@aledsage I forgot but does the endpoint
`http://localhost:8081/v1/applications/zlhibxdxxz/entities/zlhibxdxxz/children`
also returns the `iconUrl`?
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-dist/pull/106
LGTM @drigodwin.
Will comment on #105 to explain why we need this in the short term
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/128
Massive +1 @aledsage, thanks for this, LGTM.
Just one question though: Is the icon applied on the running instance if
`iconUrl` is on the catalog item level (beside the catalog `id
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/129#discussion_r139284272
--- Diff: software/cm/chef/src/main/resources/catalog.bom ---
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/128
Great news! Then it's +1 from me :)
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/129
@aledsage Just tested this with
https://github.com/apache/brooklyn-server/pull/826, works great but requires to
be rebased on the latest master + change the version in pom.xml to
`0.13.0
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/826
@aledsage Just tested this with
https://github.com/apache/brooklyn-library/pull/129, works great but requires
to be rebased on the latest master.
After that, good to merge ð
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/110#discussion_r140516203
--- Diff: release/verify_brooklyn_rc.sh ---
@@ -105,65 +115,74 @@ for ARCHIVE in $(find * -type f ! \( -name '*.asc' -o
-name '*.md5' -o -name
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-dist/pull/110
Improve verify brooklyn RC script
This does the following things:
- improve the readability of the script
- ignore the NOTICE/LICENSE files check for the DEB package
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/129
> jenkins failed with the error:
See my previous comment
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/128
@aledsage No I wouldn't. Having the`iconUrl` field returned when querying
`http://localhost:8081/v1/applications/zlhibxdxxz/entities/zlhibxdxxz` is what
we want.
Thanks
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/834
Modular catalog.bom
This reuses each bundle's `catalog.bom` file to build global `catalog.bom`.
It replaces `karaf/init/src/main/resources/catalog-classes.bom` by
`karaf/init/src/main
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-library/pull/130
Modular catalog.bom
This reuses each bundle's `catalog.bom` file to build global `catalog.bom`.
It replaces `karaf/catalog/src/main/resources/library-catalog-classes.bom` by
`karaf
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-dist/pull/107
Modular catalog.bom
This reuses each bundle's `catalog.bom` file to build global `catalog.bom`.
It avoids the duplication of bom files and keep all the metadata (title,
description
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/129
retest this please
---
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-dist/pull/109
Add LICENSE and NOTICE file back to the RPM and DEB packages
I missed to add those files in #104, as it required for releases
You can merge this pull request into a Git repository by running
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
@ahgittin I'll review #854 now. Although, there is another point that is
missing from this PR: Swagger still don't show the deprecation warning for the
entity policy endpoints
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/854
Built and tested locally without issue (compare to Jenkins). The endpoints
are now displayed in karaf mode ð
Will merge once Jenkins is happy
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/854
retest this please
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/143
Now that Brooklyn uses Karaf as default launcher, we should probably merge
this @drigodwin
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/126#discussion_r142681757
--- Diff:
software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/AbstractControllerImpl.java
---
@@ -154,6 +154,7 @@ protected void
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/126#discussion_r142683487
--- Diff:
qa/src/test/java/org/apache/brooklyn/qa/load/AbstractLoadTest.java ---
@@ -161,8 +161,8 @@ protected ManagementContext setUpPlatform
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/126#discussion_r142680872
--- Diff:
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/sharding/MongoDBRouterClusterImpl.java
---
@@ -56,12 +60,17
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/126#discussion_r142680516
--- Diff:
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/sharding/MongoDBRouterClusterImpl.java
---
@@ -56,12 +60,17
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/126#discussion_r142717711
--- Diff:
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/sharding/MongoDBRouterClusterImpl.java
---
@@ -56,12 +60,17
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/126
@ahgittin Yup, looks good but I would like Jenkins to be happy before
merging it.
Looking at the logs, looks like the failure is unrelated though
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/126#discussion_r142718981
--- Diff:
qa/src/test/java/org/apache/brooklyn/qa/load/AbstractLoadTest.java ---
@@ -161,8 +161,8 @@ protected ManagementContext setUpPlatform
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/856#discussion_r144536439
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java
---
@@ -143,6 +145,13 @@ public void
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/856#discussion_r144536427
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java
---
@@ -128,10 +128,12 @@ private
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/856#discussion_r143132638
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java
---
@@ -143,6 +145,13 @@ public void
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/856#discussion_r143132621
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java
---
@@ -128,10 +128,12 @@ private
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/856#discussion_r143132340
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java
---
@@ -103,8 +103,8 @@ private
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/222
Migrate docs to Gitbook
As per as the discussion on the ML:
https://lists.apache.org/thread.html/760a3e2fdefaff8d8ac4ea3f98a45060fbaa0d886fa57c8f44e4742e@%3Cdev.brooklyn.apache.org%3E
You
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/859
@aledsage Build failure seems related:
```
[ERROR]
/home/jenkins/jenkins-slave/workspace/brooklyn-server-pull-requests/core/src/main/java/org/apache/brooklyn/location/ssh
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/859
Yup @aledsage, LGTM.
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/135
LGTM, thanks @aledsage ð
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/859#discussion_r144589344
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUtils.java
---
@@ -112,8 +112,8 @@ public static
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/859#discussion_r144663987
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/osgi/BundleMaker.java ---
@@ -110,8 +110,6 @@ public File createJarFromClasspathDir
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/859#discussion_r144662800
--- Diff:
core/src/main/java/org/apache/brooklyn/core/entity/EntityPredicates.java ---
@@ -454,12 +454,6 @@ public String toString
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/852#discussion_r144296174
--- Diff:
api/src/main/java/org/apache/brooklyn/api/catalog/BrooklynCatalog.java ---
@@ -213,6 +213,17 @@
void addItem(CatalogItem item
201 - 300 of 655 matches
Mail list logo
