GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-client/pull/72
Switch to dep for br dependency management
Switch to `dep` for dependency management. Have meant to do this for ages,
thought it would be worthwhile before releasing 1.0.0
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-dist/pull/118
Upgrading the dockerfile-maven-plugin to 1.4.3 fixed the above for me -
have raised https://github.com/apache/brooklyn-dist/pull/130
---
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-dist/pull/130
Update dockerfile-maven-plugin to 1.4.3 to fix build problem
Building on OSX I get
```
[ERROR] Failed to execute goal
com.spotify:dockerfile-maven-plugin:1.4.0:build (default
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-dist/pull/118
hi @tbouron what did you do exactly to get round the build error above?
I'm getting
```
[ERROR] Failed to execute goal
com.spotify:dockerfile-maven-plugin:1.4.0:build (default
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/1008
Will merge this
---
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/1004#discussion_r221763463
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigParametersYamlTest.java
---
@@ -1194,6 +1199,66 @@ public
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/1002
Ha! Wish I'd looked at Aled's
[comment](https://github.com/apache/brooklyn-server/pull/1002#issuecomment-425631956)
today before I started trying to test it, then I might have avoided some
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/1002
Also worth noting what I saw last week - if you sync this and
brooklyn-ui#74, then try to build from the parent `brooklyn`, it breaks at once
with
```
[ERROR] [ERROR] Some
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/971
Happy for this to be merged and the more general improvements done
separately. How to capture/document the desire to do this? - a `//TODO`? a
BROOKLYN- issue?
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/971
hi @aledsage just checking what do you think about merging this PR?
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn/pull/15
hi @eirinikos, thanks, but I don't think you need to update the license
docs for `brooklyn-server` etc. - unless I've misunderstood @ahgittin I
believe he intends to do this as part of the license
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn/pull/15
I think it's fine to point at `brooklyn-server`. It will certainly be rare
to see an update in the top level project as it's just a parent project for the
others.
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn/pull/15
Sounds good to me @ahgittin
Yes it was my intention to update the scripts to change the licenses
elsewhere, if you are happy to pick this up as part of changes you are making
anyway
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn/pull/15
hi @eirinikos this looks good, but I do have one question. The linked CNCF
site above refers to Brooklyn's repository as `Repository
https://github.com/apache/brooklyn-server`. I'm guessing
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/971#discussion_r196149356
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -737,6 +720,130 @@ public
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/969#discussion_r193328474
--- Diff:
core/src/test/java/org/apache/brooklyn/core/typereg/RegisteredTypesTest.java ---
@@ -0,0 +1,123 @@
+package
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/969#discussion_r193327506
--- Diff:
core/src/test/java/org/apache/brooklyn/core/typereg/RegisteredTypesTest.java ---
@@ -0,0 +1,123 @@
+package
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/969#discussion_r193327856
--- Diff:
core/src/test/java/org/apache/brooklyn/core/typereg/RegisteredTypesTest.java ---
@@ -0,0 +1,123 @@
+package
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/966
p.s. also tested and confirm that `machine.` metrics don't get persisted
---
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/966#discussion_r192791782
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/StoreObjectAccessorLocking.java
---
@@ -225,6 +225,21 @@ public void
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/967
Might be worth adding some unit tests for this
---
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/967#discussion_r192711842
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java
---
@@ -194,16 +218,42 @@ private
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/967#discussion_r192716302
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java
---
@@ -106,7 +112,16 @@
@Context
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/121#discussion_r191736125
--- Diff: karaf/apache-brooklyn/src/main/resources/bin/setenv ---
@@ -85,6 +89,9 @@ export
EXTRA_JAVA_OPTS="-Dbrooklyn.location.localhost.ad
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-docs/pull/255
Fix a couple of typos
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy/brooklyn-docs master
Alternatively you can review
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/964#discussion_r191382888
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PeriodicDeltaChangeListener.java
---
@@ -527,7 +536,35 @@ private static String
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/964
https://lists.apache.org/thread.html/330d04cb1ed5058497ba3d218d54ce96433881c7ae90b0fba49fb57b@%3Cdev.brooklyn.apache.org%3E
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/962
retest this please
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/961
@duncangrant what's the benefit of doing that?
---
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/153#discussion_r185455704
--- Diff: Jenkinsfile ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/153#discussion_r185455110
--- Diff: Jenkinsfile ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/153#discussion_r185454798
--- Diff: Jenkinsfile ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/960
Just to see what happens.
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/960
The error is ```2018-04-30 11:11:04,475 WARN - JmxService couldn't start
test mbean (java.rmi.server.ExportException: Port already in use: 40124; nested
exception
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/960
@tbouron @aledsage could you have a look?
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-docs/pull/251
That looks super, by all means go ahead.
---
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-docs/pull/251
Add ApacheCon logo button to landing page
As requested by Rich Bowen:
On Mon, 9 Apr 2018 at 14:07 Rich Bowen <rbo...@apache.org> wrote:
Dear PMCs,
ApacheCon
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/68
see https://issues.apache.org/jira/browse/BROOKLYN-586
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/68
good thought
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/68
Vendor directory added per John's comments on email.
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/68
@johnmccabe can you review?
---
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-client/pull/68
Temporarily use fork of NodePrime repo
See
https://lists.apache.org/thread.html/10a74756dbeb1243928eb87c379b01ba58357a6204149d98676fa025@%3Cdev.brooklyn.apache.org%3E
Until
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-library/pull/148
JBoss from `master` fails to start but starts successfully with this PR.
Will merge.
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-docs/pull/247
ah ok grand
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-docs/pull/247
hi @rdowner, it looks like your local clone hasn't caught up past Thomas's
changes to use gitbook. Can you catch up with the latest master and check your
changes against the instructions
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/952
@andreaturli @duncangrant I agree it shouldn't be part of this PR, just
think it's worth documenting
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/673
hi @neykov I think this can be retired now as superseded by
https://github.com/apache/brooklyn-server/pull/950. Andrea cross checked
against this one before his was merged.
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/950
Looks good; have you cross checked it with
https://github.com/apache/brooklyn-server/pull/673 in case there's anything
there that is relevant?
---
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/147#discussion_r169102288
--- Diff:
software/webapp/src/test/java/org/apache/brooklyn/entity/proxy/AbstractAbstractControllerTest.java
---
@@ -0,0 +1,340
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/147#discussion_r169108985
--- Diff:
software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/AbstractControllerImpl.java
---
@@ -425,6 +443,20 @@ public void update
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
retest this please
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
Catch up to master, in particular get past
https://github.com/apache/brooklyn-server/pull/946 which fixes the failing unit
test
---
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/947#discussion_r167329657
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java
---
@@ -385,33 +384,76 @@ protected void
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
retest this please
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/947
retest this please, it's doesn't have the commit from
https://github.com/apache/brooklyn-server/pull/946
---
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-server/pull/946
Remove unnecessary tearDown step with duplicate call of method
tearDown in EffectorResourceTest is copied from elsewhere but calls
TestRendererHints.clearRegistry
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
Rebased against master
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
BTW @aledsage you may be interested in the changes to `LogWatcher` in here,
https://github.com/apache/brooklyn-server/pull/940/files#diff-5c4439a5d92984cb96dfaf613a5af72c
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
I have done some investigations of these build failures and I'm pretty sure
they're not related to my change, e.g. this failure is the same as
https://builds.apache.org/view/B/view/Brooklyn
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
retest this please, I'm pretty sure it's unrelated to this change
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
retest this please
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
Rebased against master
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
retest this please
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/67
Sounds good to me, will merge.
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
hi @ahgittin I have taken the "do not merge" off this; check out the last
two commits which add the task id to output and remove spaces. I haven't yet
included the logging o
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
Great comments @ahgittin. Some thoughts in response:
> It would seem better to me, rather than always setting a logging
diagnostic context, to deduce that information dynamica
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-dist/pull/117
WIP do not merge - Add MDC to pax logging config
See https://github.com/apache/brooklyn-server/pull/940 for details
You can merge this pull request into a Git repository by running
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
e.g. see attached debug log for creating a [three tier
webapp](https://github.com/brooklyncentral/brooklyn-three-tier-webapp):
[brooklyn.debug.log.txt](https://github.com/apache
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/933#discussion_r162954737
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/filter/LoggingResourceFilter.java
---
@@ -0,0 +1,235
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/936
Looks like these tests are catching some different behaviour - on master,
from `BundleAndTypeResourcesTest#testFilterListOfEntitiesByName`, from the
code
```
List entities
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/934
btw my comment need not hold up merging any of this, it can be done later
if appropriate
---
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/933#discussion_r161801944
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/filter/LoggingResourceFilter.java
---
@@ -0,0 +1,235
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/930#discussion_r160968622
--- Diff:
core/src/main/java/org/apache/brooklyn/location/ssh/SshMachineLocation.java ---
@@ -1016,12 +1015,8 @@ public String findPassword
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-ui/pull/51
looks ok to me, will merge it
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/909
@richardcloudsoft @andreaturli is there any reason why this shouldn't be
merged now?
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/888
Looks good to me, & tests pass. Note to readers, the description on the PR
is out of date now that @aledsage has fixed the issue. Will merge.
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-docs/pull/240
looks good to me
---
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-library/pull/144
LGTM, merging
---
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-client/pull/64
Default login port to 80/443 if not supplied
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy/brooklyn-client defaultports
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-dist/pull/111
LGTM, merging
---
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/842#discussion_r140831967
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java
---
@@ -129,58 +133,115 @@ private synchronized void init
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/842#discussion_r140833717
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java
---
@@ -129,58 +133,115 @@ private synchronized void init
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/842#discussion_r140829916
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java
---
@@ -129,58 +133,115 @@ private synchronized void init
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/791
You're right @ahgittin, the `sync` should be done before the `close`; I
have added another commit to do this.
I agree I'm not sure that the problem was caused by a failure to commit
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/809
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/808
LGTM, and the integration tests pass for me too. Will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/791
rebased against master, still haven't got round to integration tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/796
@Graeme-Miller what's the motivation for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/791
@aledsage very good questions!
I agree it's best to propagate the exception if it happens - if it's due to
a scenario like (1) where the FS can't guarantee the sync, then it's
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/791
Interesting;
```
Test Result (2 failures / -15)
org.apache.brooklyn.policy.loadbalancing.LoadBalancingPolicySoakTest.testLoadBalancingManyItemsQuickTest
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-server/pull/791
Sync file system on temp file before moving it.
See https://issues.apache.org/jira/browse/BROOKLYN-526.
This is a suggestion for a fix. Not sure how to go about testing this!
You
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/787
I have run through startup and rebind, will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/790#discussion_r131354907
--- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java ---
@@ -228,6 +235,25 @@ public Builder httpExecutor(HttpExecutor val
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/790#discussion_r131338828
--- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java ---
@@ -228,6 +235,25 @@ public Builder httpExecutor(HttpExecutor val
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/790#discussion_r131344099
--- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java ---
@@ -228,6 +235,25 @@ public Builder httpExecutor(HttpExecutor val
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/790#discussion_r131346980
--- Diff:
core/src/test/java/org/apache/brooklyn/feed/http/HttpFeedTest.java ---
@@ -360,7 +364,90 @@ public void
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/786#discussion_r131181517
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -738,6 +741,82 @@ public
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-server/pull/787
Don't validate an empty list of types.
This is so as to avoid the side effect of the "getCatalog()" in the
validate step, which does an unofficial catalog load tha
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/781
Thanks @aledsage, have updated message per your first comment. Will squash
and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/781
Build failure is Jenkins related, I think.
# There is insufficient memory for the Java Runtime Environment to
continue.
# Cannot create GC thread. Out of system
1 - 100 of 833 matches
Mail list logo
