[GitHub] brooklyn issue #20: include instructions for building outwith source control

2018-09-12 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn/pull/20 I'd rather not consider this a documentation fail that needs fixed, but a build process that needs fixed. Is there a way to supply sensible defaults for these parameters so that a build from

[GitHub] brooklyn-docs issue #265: guide/concepts: fix typos and add click-to-view-im...

2018-08-15 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-docs/pull/265 Thanks for your first contribution to Apache Brooklyn! If you haven't already comnpleted and submitted an ICLA form, please could you do this. Information can be found [here](https

[GitHub] brooklyn-server issue #975: Version bumps

2018-07-30 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/975 Got it, I understand now. And Jenkins has passed this build. I'll merge. Thanks Alex! ---

[GitHub] brooklyn-server pull request #975: Version bumps

2018-07-30 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/975#discussion_r206110391 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -274,8 +275,40 @@ mvn:org.apache.brooklyn/brooklyn-locations

[GitHub] brooklyn-server pull request #975: Version bumps

2018-07-30 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/975#discussion_r20675 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -274,8 +275,40 @@ mvn:org.apache.brooklyn/brooklyn-locations

[GitHub] brooklyn-server pull request #975: Version bumps

2018-07-30 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/975#discussion_r206111336 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -274,8 +275,40 @@ mvn:org.apache.brooklyn/brooklyn-locations

[GitHub] brooklyn-server pull request #975: Version bumps

2018-07-30 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/975#discussion_r206110119 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -274,8 +275,40 @@ mvn:org.apache.brooklyn/brooklyn-locations

[GitHub] brooklyn-server pull request #975: Version bumps

2018-07-30 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/975#discussion_r206111829 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -274,8 +275,40 @@ mvn:org.apache.brooklyn/brooklyn-locations

[GitHub] brooklyn pull request #14: Fix issue in doap_Brooklyn.rdf

2018-04-30 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn/pull/14 Fix issue in doap_Brooklyn.rdf As requested, update the DOAP file to correct an error. See [this post on the mailing list](https://lists.apache.org/thread.html

[GitHub] brooklyn-docs pull request #250: Update GSoC information page for current ph...

2018-04-09 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/250 Update GSoC information page for current phase You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner/brooklyn-docs patch-3

[GitHub] brooklyn-docs pull request #248: Update GSoC information page

2018-03-13 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/248#discussion_r174060637 --- Diff: community/gsoc.md --- @@ -15,10 +15,11 @@ for our project, or look at the [list of project ideas](http://s.apache.org/gsoc (note

[GitHub] brooklyn-docs pull request #248: Update GSoC information page

2018-03-12 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/248 Update GSoC information page Update to note that applications are now open. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner

[GitHub] brooklyn-server issue #909: Bump jclouds dependency from v2.0.2 to 2.0.3

2018-03-12 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/909 Closing, overtaken by events. ---

[GitHub] brooklyn-server pull request #909: Bump jclouds dependency from v2.0.2 to 2....

2018-03-12 Thread rdowner
Github user rdowner closed the pull request at: https://github.com/apache/brooklyn-server/pull/909 ---

[GitHub] brooklyn-docs issue #247: Fix home page installation instructions

2018-03-05 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-docs/pull/247 Ta @geomacy! :+1: ---

[GitHub] brooklyn-docs issue #247: Fix home page installation instructions

2018-03-05 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-docs/pull/247 Hi @geomacy, this PR is for the `website` branch (which uses Jekyll), not `master` (which is for the user guide, using gitbook) ---

[GitHub] brooklyn-docs pull request #247: Fix home page installation instructions

2018-03-01 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/247 Fix home page installation instructions Remove the Vagrant-based instructions, which are known to be broken in 0.12.0. Replace with .tar.gz instructions. You can merge this pull request

[GitHub] brooklyn-docs pull request #246: Add page with information about GSoC 2018

2018-02-27 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/246#discussion_r171084409 --- Diff: community/gsoc.md --- @@ -0,0 +1,60 @@ +--- +layout: website-normal +title: Google Summer of Code

[GitHub] brooklyn-docs issue #246: Add page with information about GSoC 2018

2018-02-27 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-docs/pull/246 Thanks @tbouron - I'll make the suggested changes and then merge. ---

[GitHub] brooklyn-docs pull request #246: Add page with information about GSoC 2018

2018-02-27 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/246#discussion_r171084434 --- Diff: community/gsoc.md --- @@ -0,0 +1,60 @@ +--- +layout: website-normal +title: Google Summer of Code

[GitHub] brooklyn-docs pull request #246: Add page with information about GSoC 2018

2018-02-27 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/246#discussion_r171084383 --- Diff: community/gsoc.md --- @@ -0,0 +1,60 @@ +--- +layout: website-normal +title: Google Summer of Code

[GitHub] brooklyn-docs issue #246: Add page with information about GSoC 2018

2018-02-27 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-docs/pull/246 @tbouron would appreciate it if you could give this a review, since you have also been interacting with potential students - is there anything else that should be added here? Thanks! ---

[GitHub] brooklyn-docs pull request #246: Add page with information about GSoC 2018

2018-02-27 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/246 Add page with information about GSoC 2018 Add a page to the "Community" section which describes Google Summer of Code 2018, and answers some frequently asked questions. You

[GitHub] brooklyn-docs pull request #243: Remove non-website stuff from `website` bra...

2018-02-02 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/243 Remove non-website stuff from `website` branch Note that this is a PR against `website`, **not** against `master`. Please bear this in mind when reviewing, and committer please merge

[GitHub] brooklyn-client pull request #66: Fix errors with `br catalog add` when run ...

2018-01-11 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-client/pull/66 Fix errors with `br catalog add` when run on Windows `br catalog add` has a couple of issues when it is run on Windows. These two commits fix these problems. You can merge this pull

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2018-01-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/926#discussion_r160125927 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/pool/MachinePoolPredicates.java --- @@ -82,40 +83,31 @@ public

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2018-01-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/926#discussion_r160127430 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsSshMachineLocationStubbedTest.java --- @@ -76,29 +76,12

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

2018-01-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/926#discussion_r160126361 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2609,7 +2609,7 @@ protected

[GitHub] brooklyn-server pull request #909: Bump jclouds dependency from v2.0.2 to 2....

2017-12-06 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-server/pull/909 Bump jclouds dependency from v2.0.2 to 2.0.3 Updates to use recently released jclouds minor release 2.0.2 to 2.0.3. Notable fixes for Apache Brooklyn include: - Support

[GitHub] brooklyn-server issue #906: CreatePassworkSensor: support "character groups"

2017-12-01 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/906 I'd be in favour of defining code/doc patterns where we can do this kind of stuff. Initializers are a bit of an odd case - catalog items such as entities, policies etc. are all self

[GitHub] brooklyn-server issue #906: CreatePassworkSensor: support "character groups"

2017-12-01 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/906 Thanks for the review @ahgittin. There's already a couple of `CreatePasswordSensorTest`s, so I've added a test for this specific behaviour addition. ---

[GitHub] brooklyn-server pull request #906: CreatePassworkSensor: support "character ...

2017-12-01 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-server/pull/906 CreatePassworkSensor: support "character groups" Character groups are groups like "capital letters", "numbers", etc. This option allows a blueprint to requi

[GitHub] brooklyn-docs pull request #215: Update Azure ARM documentation for Azure CL...

2017-09-20 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/215 Update Azure ARM documentation for Azure CLI 2.0 The existing instructions are for Azure CLI 1.0. Searching for "Azure CLI" returns hits for 2.0 so it's likely our users will end u

[GitHub] brooklyn-docs pull request #211: Update _azure-ARM.md

2017-09-11 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/211 Update _azure-ARM.md Provides information on some additional configuration options specific to Azue You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] brooklyn-server issue #777: Removes `FIRST` sensors on children

2017-09-07 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/777 @ahgittin this appears to go against our published deprecation policy and is known to break some blueprints. Your PR comments are making references to previous discussions, but it's

[GitHub] brooklyn-server issue #721: DynamicFabric: add support for firstMemberSpec

2017-06-19 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/721 Ready for re-review @drigodwin @aledsage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server issue #721: DynamicFabric: add support for firstMemberSpec

2017-06-19 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/721 Thanks for the comments. Sorry for the delay so far, mainly due to vacation. Having a few problems with writing a good test but will get this PR updated as soon as I can. --- If your

[GitHub] brooklyn pull request #12: Update the DOAP ("Description Of A Project") file

2017-05-31 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn/pull/12 Update the DOAP ("Description Of A Project") file Updates the list of releases and the list of maintainers (PMC) You can merge this pull request into a Git repository by running:

[GitHub] brooklyn-docs pull request #193: Update 0.11.x docs - copy from master

2017-05-31 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/193 Update 0.11.x docs - copy from master *This is a pull request to merge into the 0.11.x branch* This cherry-picks all commits from master since the 0.11.x branch up to commit b835145

[GitHub] brooklyn-docs pull request #178: Guide to template files

2017-05-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/178#discussion_r115251215 --- Diff: guide/blueprints/config-files.md --- @@ -0,0 +1,78 @@ +--- +title: Uploading Script and Configuration Files +layout: website

[GitHub] brooklyn-docs pull request #178: Guide to template files

2017-05-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/178#discussion_r115236606 --- Diff: guide/blueprints/config-files.md --- @@ -0,0 +1,78 @@ +--- +title: Uploading Script and Configuration Files +layout: website

[GitHub] brooklyn-docs pull request #178: Guide to template files

2017-05-08 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/178#discussion_r115250946 --- Diff: guide/blueprints/config-files.md --- @@ -0,0 +1,78 @@ +--- +title: Uploading Script and Configuration Files +layout: website

[GitHub] brooklyn-server issue #657: BROOKLYN-334: ascii art banner says “Apache Br...

2017-05-02 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/657 This is at risk of being a bike-shed discussion. Let's keep it simple. * The ASCII art logo is not important. If it is causing debate or trouble, then just drop completely

[GitHub] brooklyn-server pull request #632: Resolve release build failures due to opt...

2017-04-12 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-server/pull/632 Resolve release build failures due to optional JARs Some testing resources are JARs and cannot be included in the release build. Tests must be written to gracefully handle the absence

[GitHub] brooklyn-server issue #629: Fix itests

2017-04-11 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/629 Code looks good and Jenkins says OK - proceeding to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-library pull request #96: LICENSE updates

2017-04-11 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-library/pull/96 LICENSE updates You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner/brooklyn-library license-update Alternatively you can review

[GitHub] brooklyn-docs pull request #167: LICENSE updates

2017-04-11 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/167 LICENSE updates You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner/brooklyn-docs license-update Alternatively you can review

[GitHub] brooklyn-dist pull request #90: LICENSE updates

2017-04-11 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-dist/pull/90 LICENSE updates You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner/brooklyn-dist license-update Alternatively you can review

[GitHub] brooklyn pull request #10: LICENSE updates

2017-04-11 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn/pull/10 LICENSE updates You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner/brooklyn license-update Alternatively you can review and apply

[GitHub] brooklyn-docs pull request #149: Add our security advisories to public websi...

2017-02-10 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-docs/pull/149 Add our security advisories to public website You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner/brooklyn-docs security-update

[GitHub] brooklyn-server pull request #483: Use SnakeYAML SafeConstructor by default

2016-12-09 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-server/pull/483 Use SnakeYAML SafeConstructor by default Overridable by setting a system property. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-server issue #276: Effector for opening inbound ports in security g...

2016-08-17 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-server/pull/276 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-docs issue #79: Ops guides updates for monitoring and disk space

2016-06-21 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-docs/pull/79 @aledsage @drigodwin I've addressed your review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-docs pull request #79: Ops guides updates for monitoring and disk s...

2016-06-21 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/79#discussion_r67850130 --- Diff: guide/ops/starting-stopping-monitoring.md --- @@ -0,0 +1,66 @@ +--- +title: Starting, Stopping and Monitoring +layout: website

[GitHub] brooklyn-docs pull request #79: Ops guides updates for monitoring and disk s...

2016-06-21 Thread rdowner
Github user rdowner commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/79#discussion_r67849723 --- Diff: guide/ops/requirements.md --- @@ -19,6 +19,43 @@ at least 8GB RAM and 100GB disk. The disk is just for logs, a small amount of pe any

[GitHub] brooklyn-docs issue #79: Ops guides updates for monitoring and disk space

2016-06-20 Thread rdowner
Github user rdowner commented on the issue: https://github.com/apache/brooklyn-docs/pull/79 How bizarre! Branch lives on the `rdowner` repository, but I inadvertently opened the PR under the `richardcloudsoft` user -- and GitHub let me do it??!! 😖 --- If your project is set up

[GitHub] brooklyn-client pull request: move codegangsta to new urfave org

2016-05-24 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/brooklyn-client/pull/20#issuecomment-221318619 And this month's award "Most Peculiarly Named Pull Request" goes to... 😜 --- If your project is set up for it, you can reply to this emai

[GitHub] brooklyn-docs pull request: Changes on 0.9.0

2016-04-20 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/brooklyn-docs/pull/47#issuecomment-212568483 Thanks @sjcorbett, since these changes are already live on the public website (sourced from the 0.9.0 branch) they should probably be merged first! --- If your

[GitHub] brooklyn-dist pull request: Essential updates and some improvement...

2016-03-18 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/brooklyn-dist/pull/21#issuecomment-197870065 @johnmccabe @ahgittin This Vagrantfile is for the release build environment - it's not John's new Vagrantfile for end users. --- If your project is set up

[GitHub] brooklyn-server pull request: Remove DISCLAIMER remnant

2016-03-15 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-server/pull/64 Remove DISCLAIMER remnant Missed one file in my earlier attempt to clean up DISCLAIMERs. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-dist pull request: Set RPM option to allow binaries in no...

2016-03-15 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-dist/pull/20 Set RPM option to allow binaries in noarch package Our RPM package is marked as `noarch`. RPM will complain if it finds architecture-specific files in `noarch` package - therefore

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

2016-03-11 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195388591 Ok I have it working now :smile: the good news is that once I had the RPM, installing it was dead easy, and I instantly had a working, password-protected

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

2016-03-11 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195379075 Ah good point @neykov - I didn't look closely enough at that. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] brooklyn-dist pull request: Add packaging to pom modules, fix vers...

2016-03-11 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/brooklyn-dist/pull/13#issuecomment-195374544 Hi @alrick87. I am very overdue with reviewing this, especially as it was me who was championing an RPM package :flushed: I'm trying this out but I'm

[GitHub] brooklyn-ui pull request: Remove Incubator DISCLAIMER

2016-03-11 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-ui/pull/16 Remove Incubator DISCLAIMER You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner/brooklyn-ui remove-disclaimer Alternatively you can

[GitHub] brooklyn-server pull request: Remove Incubator DISCLAIMER file

2016-03-11 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-server/pull/57 Remove Incubator DISCLAIMER file You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner/brooklyn-server remove-disclaimer

[GitHub] brooklyn-dist pull request: Remove Incubator DISCLAIMER file

2016-03-11 Thread rdowner
GitHub user rdowner opened a pull request: https://github.com/apache/brooklyn-dist/pull/17 Remove Incubator DISCLAIMER file You can merge this pull request into a Git repository by running: $ git pull https://github.com/rdowner/brooklyn-dist remove-disclaimer Alternatively

[GitHub] brooklyn-client pull request: move CLI project from brooklyncentra...

2016-03-08 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/brooklyn-client/pull/1#issuecomment-193782792 The vote passed so we have a green light to merge. See the [IP Clearance record](https://incubator.apache.org/ip-clearance/brooklyn-cli.html). --- If your

[GitHub] incubator-brooklyn pull request: add getting started vagrant env t...

2016-02-02 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1170#issuecomment-178608060 @johnmccabe yes our release artifacts are a different repository which is NOT moving. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-brooklyn pull request: Getting Started with Vagrant upda...

2016-01-20 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1144#issuecomment-173178599 @johnmccabe If our official docs recommend using Vagrant then those files should be part of the Brooklyn repo IMO. It looks bad if our own documentation

[GitHub] incubator-brooklyn pull request: Update index.md

2015-12-14 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1105#issuecomment-164406018 mea culpa for not reviewing this properly... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-brooklyn pull request: Update index.md

2015-12-14 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1105#issuecomment-164405911 fixed in https://github.com/apache/incubator-brooklyn/commit/1fe871b76ebf13afeeab62772342e72cb70f7113 --- If your project is set up for it, you can reply

[GitHub] incubator-brooklyn pull request: Update index.md

2015-12-14 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1105#issuecomment-164404933 fixing this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does