Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-26 Thread 谭中意
hi,von,rc02 failed,now we are voting rc03. Gosling Von 于2019年9月27日 周五11:32写道: > Hi, > > It seems we already close to the first release in apache podling. if any > blockers exist, please let mentors know. Come on. > > Best Regards, > Von Gosling > > > On Sep 23, 2019, at 8:36 AM, tan zhongyi wrot

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-26 Thread Gosling Von
Hi, It seems we already close to the first release in apache podling. if any blockers exist, please let mentors know. Come on. Best Regards, Von Gosling > On Sep 23, 2019, at 8:36 AM, tan zhongyi wrote: > > Please make a tag, and we can go with rc03.

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-22 Thread tan zhongyi
OK, if you has merged all your change, Please make a tag, and we can go with rc03. Thanks 在 2019/9/22 下午5:53,“JiashunZhu” 写入: zhongyi, For 2,5&7, I think it is not necessary to expand the license header of boost, respecting the original license since they don't expand it either

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-22 Thread JiashunZhu
forgot to mention that I notice src/butil/linux_magic.h is referenced from linux kernel which has a GPL2.0 license, so I deleted it from source code. https://elixir.bootlin.com/linux/v5.0.21/source/include/uapi/linux/magic.h JiashunZhu 于2019年9月22日周日 下午5:53写道: > zhongyi, > > For 2,5&7, I think

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-22 Thread JiashunZhu
zhongyi, For 2,5&7, I think it is not necessary to expand the license header of boost, respecting the original license since they don't expand it either. ref: https://github.com/steinwurf/boost/blob/master/boost/smart_ptr/intrusive_ptr.hpp https://github.com/steinwurf/boost/blob/master/boost/smar

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-07 Thread Tan,Zhongyi
Hi, The block issues for rc03: 1. header missing for files under test/tools, I have submitted one merge request to fix it. 2. header file issues for files under src, jiashun will fix them 3. LGPL/GPL related files, shflags has been removed, valgrind.h is safe, so keep it So, jiashun, if

FW: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-03 Thread tan zhongyi
/butyl/third_party/rapidjson/internal/*.* MIT license, tencent copyright, it is safe, leave it 发件人: tan zhongyi 日期: 2019年9月2日 星期一 下午4:12 收件人: JiashunZhu , "Tang,Hui(EE)" , "dev@brpc.apache.org" 主题: Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-02 Thread tan zhongyi
pidjson/internal/strtod.h src/butil/unique_ptr.h 发件人: JiashunZhu 日期: 2019年8月30日 星期五 下午1:02 收件人: tan zhongyi 抄送: "dev@brpc.apache.org" 主题: Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02 OK. I will build rc3 after all problems are solved. tan zhongyi mailto:zhongyi@gmai

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-29 Thread Jean-Baptiste Onofré
-1 (binding) I will recheck on RC3. Regards JB On 29/08/2019 13:22, tan zhongyi wrote: > Thanks, tangjie, > > It seems that we have missed some third-party's file, > We need to check them again. > > -1 , vote closed as not Go. > > @JiashunZhu, we need to check these files one by one and buil

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-29 Thread JiashunZhu
OK. I will build rc3 after all problems are solved. tan zhongyi 于2019年8月29日周四 下午7:22写道: > Thanks, tangjie, > > It seems that we have missed some third-party's file, > We need to check them again. > > -1 , vote closed as not Go. > > @JiashunZhu, we need to check these files one by one and build r

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-29 Thread tan zhongyi
Thanks, tangjie, It seems that we have missed some third-party's file, We need to check them again. -1 , vote closed as not Go. @JiashunZhu, we need to check these files one by one and build rc3 later. BTW: JB, please cancel your investigation and focus on the next rc3 release , thanks 在

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-28 Thread Tang,Jie(EE)
A list of 30 files without license header, including CPP and shell, was compiled by Rat tool. 1. Rat tool will have false alarms and do some filtering work. 2. Makefile, markdown file, refer to other Apache projects without license, there is no license. This is files list: build_in_travis_ci.s

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-22 Thread Tan,Zhongyi
Hi, JB, Any feedback? Thanks 在 2019/8/19 下午9:42,“tan zhongyi” 写入: Hi, kevin & JB, Can you help to take a look, Thanks 在 2019/8/19 下午5:56,“Tan,Zhongyi” 写入: +1 binding 发自我的 iPhone > 在 2019年8月19日,17:49,JiashunZhu

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-19 Thread tan zhongyi
Hi, kevin & JB, Can you help to take a look, Thanks 在 2019/8/19 下午5:56,“Tan,Zhongyi” 写入: +1 binding 发自我的 iPhone > 在 2019年8月19日,17:49,JiashunZhu 写道: > > +1 binding. > I have checked: > > - incubating in name > > - DISCLAIMER present >

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-19 Thread Tan,Zhongyi
+1 binding 发自我的 iPhone > 在 2019年8月19日,17:49,JiashunZhu 写道: > > +1 binding. > I have checked: > > - incubating in name > > - DISCLAIMER present > > - Signature and hashes okay > > - NOTICE present > > - No unexpected binary files > > - All ASF files have correct headers > > - LICENSE is o

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-19 Thread JiashunZhu
+1 binding. I have checked: - incubating in name - DISCLAIMER present - Signature and hashes okay - NOTICE present - No unexpected binary files - All ASF files have correct headers - LICENSE is okay zhan shi 于2019年8月15日周四 下午6:57写道: > +1 > > tan zhongyi 于2019年8月14日周三 下午9:46写道: > > > > > >

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-15 Thread zhan shi
+1 tan zhongyi 于2019年8月14日周三 下午9:46写道: > > > Hi, guys, > > > > > > another round of vote begins > > > > I am pleased to be calling this vote for the release of apache > brpc(incubating) 0.9.6-rc02. > > > The source code can be found at: > > > https://dist.apache.org/repos/dist/dev/incubator/brp

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-14 Thread Tang,Jie(EE)
+1 在 2019/8/14 下午9:46,“tan zhongyi” 写入: Hi, guys, another round of vote begins I am pleased to be calling this vote for the release of apache brpc(incubating) 0.9.6-rc02. The source code can be found at: http

[VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-08-14 Thread tan zhongyi
Hi, guys, another round of vote begins I am pleased to be calling this vote for the release of apache brpc(incubating) 0.9.6-rc02. The source code can be found at: https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc02/apache-brpc-0.9.6.rc02-incubating-src.tar.gz The rele