Re: [ANNOUNCE] New committer: Stamatis Zampetakis

2019-03-14 Thread Muhammad Gelbana
Congratulations Stamatis :) Thanks for frequently answering my questions and discussing my raised topics. On Fri, Mar 15, 2019, 2:45 AM Michael Mior wrote: > No problem. I'll leave that to you then once the release is done :) > Thanks! > -- > Michael Mior > mm...@apache.org > > Le jeu. 14

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 0)

2019-03-14 Thread Julian Hyde
If I was release manager for 1.18, it’s possible that I used ‘mvn’ rather than ‘./mvnw’. I don’t recall. If so, my bad, I should have updated the release instructions. Julian On Mar 14, 2019, at 7:22 PM, Kevin Risden wrote: >> >> maven-wrapper.jar is a binary file, and we cannot have binary

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 0)

2019-03-14 Thread Kevin Risden
> > maven-wrapper.jar is a binary file, and we cannot have binary files in > source distributions. (Note that ./mvnw can bootstrap just fine without it. > Also note that it is not checked into git — I guess it is created during > the release build process.) > Hmmm that is interesting. ./mvnw

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 0)

2019-03-14 Thread Julian Hyde
PS Huge thank you to Kevin for being release manager. This has been one of our most complex releases, and I know that Kevin has put in a massive effort to get the release this far. I hope the process is over soon! > On Mar 14, 2019, at 5:51 PM, Julian Hyde wrote: > > -1 due to

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 0)

2019-03-14 Thread Julian Hyde
-1 due to .mvn/wrapper/maven-wrapper.jar maven-wrapper.jar is a binary file, and we cannot have binary files in source distributions. (Note that ./mvnw can bootstrap just fine without it. Also note that it is not checked into git — I guess it is created during the release build process.)

Re: [ANNOUNCE] New committer: Stamatis Zampetakis

2019-03-14 Thread Michael Mior
No problem. I'll leave that to you then once the release is done :) Thanks! -- Michael Mior mm...@apache.org Le jeu. 14 mars 2019 à 19:03, Stamatis Zampetakis a écrit : > > Thanks for noticing Michael. > > Actually, I started doing it at some point but then there were > inconsistencies between

Re: [ANNOUNCE] New committer: Stamatis Zampetakis

2019-03-14 Thread Stamatis Zampetakis
Thanks for noticing Michael. Actually, I started doing it at some point but then there were inconsistencies between master, site, and svn, so I decided to do it after the release where everything is in line. On Thu, Mar 14, 2019, 10:15 PM Francis Chuang wrote: > I also noticed Hongze was not

Re: Calcite-Master - Build # 1070 - Still Failing

2019-03-14 Thread Stamatis Zampetakis
I introduced this, sorry about that. The warning is present in the script but apparently I missed it. Will fix it after the release. Best, Stamatis On Thu, Mar 14, 2019, 2:44 AM Julian Hyde wrote: > There’s another thing. My build scripts check for deprecation warnings and > this one has been

Re: [ANNOUNCE] New committer: Stamatis Zampetakis

2019-03-14 Thread Francis Chuang
I also noticed Hongze was not added to the community page as well. Once Kevin releases 1.19.0, we should add both of them to the page. On 15/03/2019 2:11 am, Michael Mior wrote: I just noticed that Stamatis was never added to the community page site. Stamatis, feel free to add yourself once

Re: [VOTE] Release apache-calcite-1.19.0 (release candidate 0)

2019-03-14 Thread Vladimir Sitnikov
+1 (binding) Checksum matches, the code compiles. Release notes look ok. Thanks, Kevin Vladimir

[VOTE] Release apache-calcite-1.19.0 (release candidate 0)

2019-03-14 Thread Kevin Risden
Hi all, I have created a build for Apache Calcite 1.19.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/branch-1.19/site/_docs/history.md The commit to be voted upon:

Re: calcite https://issues.apache.org/jira/browse/CALCITE-759

2019-03-14 Thread Kevin Risden
It looks like you might have worked on this. If you follow the contributing page it walks through creating a pull request: https://calcite.apache.org/develop/#contributing The PR will automatically get linked to the JIRA. Kevin Risden On Thu, Mar 14, 2019 at 12:04 PM zxdrmz wrote: > Hi All!

calcite https://issues.apache.org/jira/browse/CALCITE-759

2019-03-14 Thread zxdrmz
Hi All! I'm working on the TO_TIMESTAMP function implementation. I had added an sub-task for this work (https://issues.apache.org/jira/browse/CALCITE-2919) I'm new to Calcite, so I don't expect everything to be done in the right way and I will be grateful if someone will take a look.

Re: [ANNOUNCE] New committer: Stamatis Zampetakis

2019-03-14 Thread Michael Mior
I just noticed that Stamatis was never added to the community page site. Stamatis, feel free to add yourself once the freeze for the current release is over. Otherwise, I'm happy to do so. -- Michael Mior mm...@apache.org Le mer. 30 janv. 2019 à 13:01, Jesus Camacho Rodriguez a écrit : > >

Re: Parantheses in RelBuilder?

2019-03-14 Thread Michael Mior
You don't explicitly create parenthesis. You just need to construct the conditions in the right order. Just construct the two parts of your OR separately and then create a new RexCall node with the OR operator where you pass in each of the two RexNodes you want to compare. -- Michael Mior

[jira] [Created] (CALCITE-2921) nullif(null,y) throws exception in verification

2019-03-14 Thread pengzhiwei (JIRA)
pengzhiwei created CALCITE-2921: --- Summary: nullif(null,y) throws exception in verification Key: CALCITE-2921 URL: https://issues.apache.org/jira/browse/CALCITE-2921 Project: Calcite Issue

Parantheses in RelBuilder?

2019-03-14 Thread Rakesh Nair
Hello, Would you mind giving me some pointers on *creating parenthesis while building a RelNode*. For example, how to build RelNode for the sample query: SELECT * FROM `persons` WHERE *(*`SALARY` >= 10 AND `SALARY` < 20*) *OR *(*`SALARY` >= 30 AND `SALARY` < 40*)* P.S. Need to know how to build