Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-23 Thread Rui Wang
Thanks everyone for participating in the vote! As of now we have received: 4 binding +1 Francis Chuang Julian Hyde Haisheng Yuan Ruben Q L 2 non-binding +1 Xiong Duan Alessandro Solimando RC0 has passed the vote and I will follow up to get it released and get release notes updated per suggest

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-22 Thread Alessandro Solimando
Hello everyone, thank you Rui for all the work as a release manager! +1 (non-binding): - checked signature and checksum: OK - ./gradlew build (copied gradlew and gradle folder from "master"): OK - visual inspection of uploaded artifacts: OK - release notes: OK (but I agree with the observations m

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-22 Thread Ruben Q L
Thanks Rui for being our release manager this time. My vote is: +1 (binding) - Checksum and signature: ok - Gradle test: ok - Calcite-based application test suite: ok - Release notes: ok, provided that fixes already mentioned get applied Best, Ruben On Wed, Dec 22, 2021 at 5:19 AM Haisheng Yua

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-21 Thread Haisheng Yuan
Thanks Rui for taking care of this release. - Verified GPG signature - OK - Verified SHA512 - OK - Checked release notes - OK - Ran gradle tests - OK Environment: macOS Big Sur, Java 17+35-LTS-2724 Gradle 7.3 +1 (binding) Thanks, Haisheng Yuan On 2021/12/21 01:27:01 Rui Wang wrote: > Hi all,

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-21 Thread Julian Hyde
Yes, push a commit right after the release. If you look at the history in git you will see that there are always one or two commits after each release, e.g. fixing the release date, publishing javadoc, updating howto. > On Dec 21, 2021, at 12:22 PM, Rui Wang wrote: > > Hi Julian, > > What is

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-21 Thread Rui Wang
Hi Julian, What is the proper way to fix release note/documentation suggestions given RC0 is under voting (I guess that does not require a RC1 cut)? just push a new commit later to fix those things? -Rui On Mon, Dec 20, 2021 at 8:29 PM Julian Hyde wrote: > Fixing the problem in the vote email

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-20 Thread Julian Hyde
Fixing the problem in the vote email previously noted by xiong duan: [ ] +1 Release this package as Apache Calcite 1.29.0 +1 Downloaded, checked hashes and signatures; compared files with git; checked LICENSE, NOTICE; ensured no binaries in the tarball; built on Ubuntu Linux, JDK 15 and Gradle

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-20 Thread Francis Chuang
My vote is: +1 (binding) - Verified GPG signature - OK - Verified SHA512 - OK - Checked release notes (https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md) - OK - Ran tests (gradle check) - OK - Spot checked Nexus artifacts - OK Environment: Gradle 7.3.2 docker con

Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-20 Thread xiong duan
+1. But some notices: 1: [ ] +1 Release this package as Apache Calcite *1.29.0 *not 1.27.0 2: I have added typos in https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e Rui Wang 于2021年12月21日周二 09:27写道: > Hi all, > > I have created a build for Apache Calcite 1.29.0,

[VOTE] Release apache-calcite-1.29.0 (release candidate 0)

2021-12-20 Thread Rui Wang
Hi all, I have created a build for Apache Calcite 1.29.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md The commit to be voted upon: https://github