Re: PR 3495 (Make single-row rels unique) Review Request

2024-01-16 Thread Julian Hyde
o that. >> >> Mihai >> >> From: Paul Jackson >> Sent: Monday, January 8, 2024 7:06 AM >> To: dev@calcite.apache.org >> Subject: Re: PR 3495 (Make single-row rels unique) Review Request >> >> Is there

Re: PR 3495 (Make single-row rels unique) Review Request

2024-01-11 Thread Paul Jackson
Budiu wrote: > > CI failed, so perhaps you can look into that. > > Mihai > > From: Paul Jackson > Sent: Monday, January 8, 2024 7:06 AM > To: dev@calcite.apache.org > Subject: Re: PR 3495 (Make single-row rels unique) Review Request

Re: PR 3495 (Make single-row rels unique) Review Request

2024-01-08 Thread Julian Hyde
get it into 1.37. On Mon, Jan 8, 2024 at 11:34 AM Mihai Budiu wrote: > > CI failed, so perhaps you can look into that. > > Mihai > > From: Paul Jackson > Sent: Monday, January 8, 2024 7:06 AM > To: dev@calcite.apache.org > Subject: R

Re: PR 3495 (Make single-row rels unique) Review Request

2024-01-08 Thread Mihai Budiu
CI failed, so perhaps you can look into that. Mihai From: Paul Jackson Sent: Monday, January 8, 2024 7:06 AM To: dev@calcite.apache.org Subject: Re: PR 3495 (Make single-row rels unique) Review Request Is there anything else to do for this PR? * https

Re: PR 3495 (Make single-row rels unique) Review Request

2024-01-08 Thread Paul Jackson
Is there anything else to do for this PR? * https://github.com/apache/calcite/pull/3495 * https://issues.apache.org/jira/browse/CALCITE-6044 Thanks, -Paul > On Nov 16, 2023, at 7:51 AM, Paul Jackson > wrote: > > This PR updates org.apache.calcite.rel.metadata areColumnsUnique, >

Re: PR 3495 (Make single-row rels unique) Review Request

2023-11-16 Thread Julian Hyde
It depends on your client. Different clients have a different notion of paragraph. Safest thing is to compose in plain text mode. Failing that, compose in rich text mode with the knowledge that it will be converted to plain text mode. Use ' * ' for bullet points, '>' for quoted text, and

Re: PR 3495 (Make single-row rels unique) Review Request

2023-11-16 Thread Paul Jackson
Thanks. Is there a trick to sending e-mails to this list so that formatting is retained? Experimenting with my client's plain-text mode: https://github.com/apache/calcite/pull/3495 https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6044 Copy/pasting your links: * 

Re: PR 3495 (Make single-row rels unique) Review Request

2023-11-16 Thread Julian Hyde
These links are easier: * https://github.com/apache/calcite/pull/3495 * https://issues.apache.org/jira/browse/CALCITE-6044 > On Nov 16, 2023, at 7:51 AM, Paul Jackson > wrote: > > This PR updates org.apache.calcite.rel.metadata areColumnsUnique, > getUniqueKeys, and getPredicates methods to

PR 3495 (Make single-row rels unique) Review Request

2023-11-16 Thread Paul Jackson
This PR updates org.apache.calcite.rel.metadata areColumnsUnique, getUniqueKeys, and getPredicates methods to account for relations that produce at most a single row: Sort (due to limit), Aggregate (due to no group by), Values (due to having a single row), and Join (when joining with one of the