The Apache Jenkins build system has built Calcite-Master (build #1048)
Status: Failure
Check console output at https://builds.apache.org/job/Calcite-Master/1048/ to
view the results.
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code
gen error for UNARY_MINUS operator call with deci…
URL: https://github.com/apache/calcite/pull/1057#discussion_r261213393
##
File path:
zabetak merged pull request #1059: [CALCITE-2859] Centralize Calcite system
properties
URL: https://github.com/apache/calcite/pull/1059
This is an automated message from the Apache Git Service.
To respond to the message,
Good job Kevin! Hope to see a cleaner PR lists.
new life!
在 2019年2月28日 +0800 AM3:36，dev@calcite.apache.org，写道：
>
> Good idea Kevin!
zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH
function
URL: https://github.com/apache/calcite/pull/1070#issuecomment-468251438
@XuQianJin-Stars Sorry for the delaying, will take a look soon.
This
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code
gen error for UNARY_MINUS operator call with deci…
URL: https://github.com/apache/calcite/pull/1057#discussion_r261217611
##
File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java
Thanks Kevin! That's an important task and one that few people are
willing to take on :)
And thanks Hongze for the pointer to Stale. Especially since other
Apache project are already using it, I'd be inclined to have a
discussion on the appropriate configuration and give it a go.
Personally, I
I would help to review some PRs this weekend，especially [1]. Hope to help and
release some of the burden.
[1]
XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH
function
URL: https://github.com/apache/calcite/pull/1070#issuecomment-468268420
> Hi @XuQianJin-Stars, could you please address Michael's comment? By
looking into MySQL's JSON_LENGTH spec[1], I also think it's no
vlsi commented on a change in pull request #1059: [CALCITE-2859] Centralize
Calcite system properties
URL: https://github.com/apache/calcite/pull/1059#discussion_r261129603
##
File path:
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
##
@@ -0,0
zabetak commented on a change in pull request #1059: [CALCITE-2859] Centralize
Calcite system properties
URL: https://github.com/apache/calcite/pull/1059#discussion_r261139530
##
File path:
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
##
@@
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code
gen error for UNARY_MINUS operator call with deci…
URL: https://github.com/apache/calcite/pull/1057#discussion_r261213916
##
File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java
zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH
function
URL: https://github.com/apache/calcite/pull/1070#issuecomment-468267253
Hi @XuQianJin-Stars, could you please address Michael's comment? By looking
into MySQL's JSON_LENGTH spec[1], I also think it's no need
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code
gen error for UNARY_MINUS operator call with deci…
URL: https://github.com/apache/calcite/pull/1057#discussion_r261215687
##
File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java
XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH
function
URL: https://github.com/apache/calcite/pull/1070#issuecomment-468221805
hi @michaelmior @zhztheplayer Thank you very much. I hope that you can take
the time to review this PR.
best
qianjin
zabetak merged pull request #950: [CALCITE-2703] Reduce code generation and
class loading overhead when executing queries in the EnumerableConvention
(Stamatis Zampetakis)
URL: https://github.com/apache/calcite/pull/950
kgyrtkirk opened a new pull request #1076: [CALCITE-2421] Generalize
simplification of self-comparisions
URL: https://github.com/apache/calcite/pull/1076
This change enables to rewrite comparisions between the same operands to a
form which relys on the nullability check of the original
zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for
UNARY_MINUS operator call with deci…
URL: https://github.com/apache/calcite/pull/1057#issuecomment-468292958
@yuqi1129 I've added some comments to the PR. Besides, please link your
commit's email address to
zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for
UNARY_MINUS operator call with deci…
URL: https://github.com/apache/calcite/pull/1057#issuecomment-468292958
@yuqi1129 I've added some comments to the PR. Besides, please link your
commit's email address to
Laurent did answer my objection and indicate he's willing to revert.
I'm ok with the provided explanation. (Although an unrelated note,
things like "Fix checkstyle error" and "Fix grammar errors" should not
be part of the final commit message.)
--
Michael Mior
mm...@apache.org
Le mer. 27 févr.
zhztheplayer closed pull request #984: [CALCITE-2593] Sometimes fails to plan
when a RelNode transform multi…
URL: https://github.com/apache/calcite/pull/984
This is an automated message from the Apache Git Service.
To
zhztheplayer commented on issue #984: [CALCITE-2593] Sometimes fails to plan
when a RelNode transform multi…
URL: https://github.com/apache/calcite/pull/984#issuecomment-468300249
Going to close this PR -- let's wait for coming into consensus in JIRA.
hsyuan opened a new pull request #1077: [CALCITE-2818] EXTRACT returns wrong
results for DATE and TIMESTAMP values before epoch
URL: https://github.com/apache/calcite/pull/1077
JIRA: https://issues.apache.org/jira/browse/CALCITE-2818
zhztheplayer commented on issue #1057: [CALCITE-2854] code gen error for
UNARY_MINUS operator call with deci…
URL: https://github.com/apache/calcite/pull/1057#issuecomment-468292958
@yuqi1129 I've added some comments to the PR. Besides, please link your
commit's email address to you
zhztheplayer closed pull request #897: [CALCITE-2648] Output collation of
EnumerableWindow is not consistent…
URL: https://github.com/apache/calcite/pull/897
This is an automated message from the Apache Git Service.
To
zhztheplayer commented on issue #897: [CALCITE-2648] Output collation of
EnumerableWindow is not consistent…
URL: https://github.com/apache/calcite/pull/897#issuecomment-468301076
I have no cue to solve the problem perfectly, closing temporarily.
zhztheplayer edited a comment on issue #897: [CALCITE-2648] Output collation of
EnumerableWindow is not consistent…
URL: https://github.com/apache/calcite/pull/897#issuecomment-468301076
I have no cue to solve the problem perfectly for now, closing temporarily.
asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema
constructor public to pass client cache object
URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254
Either this or #1036 should be merged depending on result of discussion on
siddharthteotia commented on a change in pull request #1031: CALCITE-2742:
Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER
URL: https://github.com/apache/calcite/pull/1031#discussion_r261378419
##
File path:
asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema
constructor public to pass client cache object
URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254
Either this or #1022 should be merged depending on result of discussion on
-1 Using a robot to close stale PRs is solving the wrong problem.
The main reason that we have a lot of open PRs is that we - as a community of
committers - are not putting sufficient time into reviewing. I think that we
are giving PR submitters poor service, and they are being very patient
asereda-gs commented on issue #1036: [CALCITE-2815] GeodeSchemaFactory change
to pass in clientCache using jndi
URL: https://github.com/apache/calcite/pull/1036#issuecomment-468429549
If we go JNDI route (see [dev
I am also -1 on the bot per the reasons Julian has stated.
Our problem is mainly due to PRs not being reviewed. I think an
extension to the problem is that because PRs take a while to be
reviewed, contributors sometime lose context (and can't find time to
realign themselves with the current
siddharthteotia commented on a change in pull request #1031: CALCITE-2742:
Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER
URL: https://github.com/apache/calcite/pull/1031#discussion_r261378248
##
File path:
siddharthteotia commented on a change in pull request #1031: CALCITE-2742:
Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER
URL: https://github.com/apache/calcite/pull/1031#discussion_r261378419
##
File path:
siddharthteotia commented on a change in pull request #1031: CALCITE-2742:
Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER
URL: https://github.com/apache/calcite/pull/1031#discussion_r261378619
##
File path:
julianhyde commented on a change in pull request #1059: [CALCITE-2859]
Centralize Calcite system properties
URL: https://github.com/apache/calcite/pull/1059#discussion_r261350210
##
File path:
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
##
@@
asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema
constructor public to pass client cache object
URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254
Either this or #1036 should be merged depending on result of discussion on
siddharthteotia commented on issue #1029: [CALCITE-2824] Fix invalid usage of
RexExecutorImpl
URL: https://github.com/apache/calcite/pull/1029#issuecomment-468441305
@vlsi , @laurentgo , I am not sure how exactly we can test test this. The
code change here avoids the direct casing of
risdenk commented on issue #811: Add LGTM code quality badges
URL: https://github.com/apache/calcite/pull/811#issuecomment-468460341
Not sure how I feel about this one. Based on
https://issues.apache.org/jira/browse/INFRA-17226 LGTM can't be integrated with
the build. Since INFRA is
risdenk commented on issue #811: Add LGTM code quality badges
URL: https://github.com/apache/calcite/pull/811#issuecomment-468472598
Closing this PR due to no immediate need to move forward. If LGTM and Apache
legal due to Github permissions end up working together we can look at this
risdenk closed pull request #811: Add LGTM code quality badges
URL: https://github.com/apache/calcite/pull/811
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of
LoptOptimizeJoinRule that uses the first ordering it finds
URL: https://github.com/apache/calcite/pull/1034#issuecomment-468449888
@vlsi ... we use this initially only to get some random ordering (not
possibly the
vlsi commented on issue #784: [CALCITE-2456] fix VolcanoRuleCall#match for
unordered child operand
URL: https://github.com/apache/calcite/pull/784#issuecomment-468457409
Yes it is good and committable.
This is an automated
Julian,
Overall, I agree with you Julian and Francis. Ideally, we would find
the resources among committers to review all PRs. My +1 for the bot
mainly came from a desire to keep the list of open PRs as ones which
are actively being worked on. Perhaps many of the same goals would be
accomplished
Hi,
I am following the instructions here
https://github.com/apache/calcite/tree/master/site to generate java doc for
one of my patches and running into some dependency issues. Can I get some
help in identifying the problem?
I am able to build Calcite locally. However, after running the step
I wonder if this is because is because it uses the maven:alpine image,
which uses the openjdk-8 alpine image.
Can you try changing this line
(https://github.com/apache/calcite/blob/master/site/docker-compose.yml#L31)
to just "maven" and see if it builds?
Franics
On 1/03/2019 9:23 am,
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove
Aggregate if grouping columns are unique and all functions are splittable
URL: https://github.com/apache/calcite/pull/1078#discussion_r261429146
##
File path:
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove
Aggregate if grouping columns are unique and all functions are splittable
URL: https://github.com/apache/calcite/pull/1078#discussion_r261428663
##
File path:
Francis> Our problem is mainly due to PRs not being reviewed.
Once upon a time I did try to pass over the PRs, and I added some randoms
here and there.
I'm not sure what others think of that, however we have:
17 "returned-with-feedback":
vlsi commented on issue #1034: [CALCITE-2819] Add version of
LoptOptimizeJoinRule that uses the first ordering it finds
URL: https://github.com/apache/calcite/pull/1034#issuecomment-468458376
Where do you get MultiJoins in the first place?
One thing that I think would help is to add a Github PR template [1]. We
did this for Apache Knox to help make sure that PRs follow some simple
guidelines. After the gitbox migration, PRs are automatically linked to
JIRA (which is good). I think we just had some PRs prior to gitbox
migration that
Two things that we are doing that are working:
* Use the “pull-request-available” tag for JIRA cases;
* Beat down the number of open cases with the “pull-request-available” tag in
the lead up to the release.
Let’s continue doing these.
Shall we agree a target of number of open cases with
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove
Aggregate if grouping columns are unique and all functions are splittable
URL: https://github.com/apache/calcite/pull/1078#discussion_r261430620
##
File path:
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove
Aggregate if grouping columns are unique and all functions are splittable
URL: https://github.com/apache/calcite/pull/1078#discussion_r261429313
##
File path:
julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove
Aggregate if grouping columns are unique and all functions are splittable
URL: https://github.com/apache/calcite/pull/1078#discussion_r261430446
##
File path:
siddharthteotia commented on issue #1033: [CALCITE-2820] Add a version of
AggregateReduceFunctionsRule that does not reduce SUM to SUM0
URL: https://github.com/apache/calcite/pull/1033#issuecomment-468497873
ping @vlsi , @julianhyde, @laurentgo
siddharthteotia commented on a change in pull request #1031: [CALCITE-2742]:
Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER
URL: https://github.com/apache/calcite/pull/1031#discussion_r261386852
##
File path:
julianhyde commented on a change in pull request #1031: [CALCITE-2742]: Update
RexImpTable to use DataContext to retrieve USER and SYSTEM_USER
URL: https://github.com/apache/calcite/pull/1031#discussion_r261393964
##
File path:
julianhyde commented on issue #811: Add LGTM code quality badges
URL: https://github.com/apache/calcite/pull/811#issuecomment-468467926
I'm -0 on this. Doesn't seem to be worth the effort.
The PR submitter works for the company, so we would be free advertising for
them. But our
hsyuan opened a new pull request #1078: [CALCITE-896] Remove Aggregate if
grouping columns are unique and all functions are splittable
URL: https://github.com/apache/calcite/pull/1078
JIRA: https://issues.apache.org/jira/browse/CALCITE-896
Jesus Camacho Rodriguez created CALCITE-2883:
Summary: HepPlanner subprogram may loop till getting out of memory
Key: CALCITE-2883
URL: https://issues.apache.org/jira/browse/CALCITE-2883
jcamachor opened a new pull request #1079: [CALCITE-2883] HepPlanner subprogram
may loop till getting out of memory
URL: https://github.com/apache/calcite/pull/1079
This is an automated message from the Apache Git Service.
Infra has updated the Gitbox settings for all Calcite repositories. The
notifications will now be sent to the commits@calcite.a.o list.
On 27/02/2019 9:13 pm, Francis Chuang wrote:
Hey all,
I wanted to gauge your opinions regarding the gitbox emails being sent
to the dev@ list. I am finding
risdenk commented on issue #998: Suggestion: Improvement of Autoboxing and
Unboxing
URL: https://github.com/apache/calcite/pull/998#issuecomment-468459175
Closing since there is no JIRA attached to this PR and only addresses a
single line. As @vlsi pointed out, there isn't a big reason to
risdenk closed pull request #998: Suggestion: Improvement of Autoboxing and
Unboxing
URL: https://github.com/apache/calcite/pull/998
This is an automated message from the Apache Git Service.
To respond to the message,
As of now, the open PRs and Calcite JIRAs are close enough to matching (96
vs 98). (There are a few for Avatica in the JIRA query). Thanks all those
that helped clean up.
Kevin Risden
On Thu, Feb 28, 2019 at 4:21 PM Kevin Risden wrote:
> One thing that I think would help is to add a Github PR
julianhyde commented on issue #784: [CALCITE-2456] fix VolcanoRuleCall#match
for unordered child operand
URL: https://github.com/apache/calcite/pull/784#issuecomment-468468357
+1 but please change the commit message; remove the word 'fix' and describe
the actual problem being fixed.
hsyuan commented on issue #1078: [CALCITE-896] Remove Aggregate if grouping
columns are unique and all functions are splittable
URL: https://github.com/apache/calcite/pull/1078#issuecomment-468496263
@julianhyde I have addressed your comments, thanks for the review. Can you
take another
shining created CALCITE-2882:
Summary: ConnectionProperties lose effectiveness when connection
reopen after expired
Key: CALCITE-2882
URL: https://issues.apache.org/jira/browse/CALCITE-2882
Project:
ritesh-kapoor opened a new pull request #1075: CALCITE-2881: Adding JSON_PRETTY
function support
URL: https://github.com/apache/calcite/pull/1075
This is an automated message from the Apache Git Service.
To respond to the
71 matches
Mail list logo
