Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-15 Thread Claus Ibsen
I just did a fresh rebuild with Java 11 and it worked fine git clean -dXf rm -rf org/apache/camel in my m2 repo mvn clean install -P fastinstall On Thu, Aug 15, 2019 at 8:51 AM Claus Ibsen wrote: > > Hi > > I am on java 8 and same maven 3.6.1 version > > On Thu, Aug 15, 2019 at 8:35 AM Babak

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-15 Thread Claus Ibsen
Hi I am on java 8 and same maven 3.6.1 version On Thu, Aug 15, 2019 at 8:35 AM Babak Vahdat wrote: > > Thanks Claus for fixing it! > > Those mongodb changes were missing in my PR as I somehow messed it up while > merging them from my fork. Is there a documentation about how to merge a PR >

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-15 Thread Babak Vahdat
Thanks Claus for fixing it! Those mongodb changes were missing in my PR as I somehow messed it up while merging them from my fork. Is there a documentation about how to merge a PR provided by the GitHub mirror repo into the Apache gitbox repo? I did it as the following which I am not sure if

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Claus Ibsen
Hi I have also cleaned with git clean -dXf removed my m2/repository/org/apache/camel And did a rebuild mvn clean install -P fastinstall And it worked fine, well later there is a build error with mongodb On Wed, Aug 14, 2019 at 11:53 PM Babak Vahdat wrote: > > > > > On 14 Aug 2019, at 22:14,

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Babak Vahdat
> On 14 Aug 2019, at 22:14, Babak Vahdat wrote: > > Hi Claus > > Without that change I get a compilation error about the missing class > DefinitionPropertiesPlaceholderProviderHelper in camel-core. > > Could you please delete your local m2 cache and try to build the master > branch locally

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Babak Vahdat
Hi Claus Without that change I get a compilation error about the missing class DefinitionPropertiesPlaceholderProviderHelper in camel-core. Could you please delete your local m2 cache and try to build the master branch locally without this commit? Right now I don‘t have access to my laptop,

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Andrea Cosentino
The build on CI wasn't failing. I'm +1 for reverting. Il mer 14 ago 2019, 21:49 Claus Ibsen ha scritto: > Hi Babak > > We should not have camel-apt as compile dependency as its should not > be there for regular Camel end users. > > I wonder what error you see - the code before was like it was

Re: [camel] branch master updated: fix the compilation error because of the missing DefinitionPropertiesPlaceholderProviderHelper class being generated

2019-08-14 Thread Claus Ibsen
Hi Babak We should not have camel-apt as compile dependency as its should not be there for regular Camel end users. I wonder what error you see - the code before was like it was in camel 2.x and has always been. So I wonder what error you have. IMHO we need to revert so its as before, but