Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Derek Chen-Becker
On Thu, Nov 17, 2022 at 2:01 PM Josh McKenzie wrote: > 3) Expert: Leave me alone. I tune my own GC This is increasingly not a thing. I haven't looked at ZGC, but G1 and Shenandoah provide a lot of knobs...that the collector will happily ignore if it decides it knows better :) --

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Derek Chen-Becker
I wouldn't recommend Shenandoah or ZGC, period. They're not designed for the kind of workload you'll typically see running a database (high throughput of objects that don't tenure) and both will fall over in interesting ways under high allocation rate. GenShen is intended to combine the

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Jeff Jirsa
On Thu, Nov 17, 2022 at 12:47 PM J. D. Jordan wrote: > -1 on providing a bunch of choices and forcing users to pick one. We > should have a default and it should be “good enough” for most people. The > people who want to dig in and try other gc settings can still do it, and we > could provide

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Josh McKenzie
> -1 on providing a bunch of choices and forcing users to pick one. We should > have a default and it should be “good enough” for most people. These are 2 different things (providing choices and whether we provide a default). Sounds like you're against both not having a default *and* providing

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread J. D. Jordan
-1 on providing a bunch of choices and forcing users to pick one. We should have a default and it should be “good enough” for most people. The people who want to dig in and try other gc settings can still do it, and we could provide them some profiles to start from, but there needs to be a

Re: [ANNOUNCE] Apache Cassandra 4.1-rc1 test artifact available

2022-11-17 Thread Mick Semb Wever
> > The test build of Cassandra 4.1-rc1 is available. > Our requirements for 4.1-rc were one green CI run. And no regression flakies (except the two we have waivers for). The green circleci runs are here: -

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Joseph Lynch
It seems like this is a choice most users might not know how to make? On Thu, Nov 17, 2022 at 7:06 AM Josh McKenzie wrote: > > Have we ever discussed including multiple profiles that are simple to swap > between and documented for their tested / intended use cases? > > Then the burden of having

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread C. Scott Andreas
Jon, thanks for flagging that I didn't get a reply to your question on the thread.My main point in this thread is that I don't think post-beta is an appropriate time for a major prop change like this in the release cycle. Ideally at this point in the release cycle, major contributors and large

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Joseph Lynch
I'm surprised we released 4.0 without changing the default to G1 given that many Cassandra deployments have changed the project's default because it is incorrect. I know that 7486 broke a user 7 years ago, but I think we have had a ton of testing since then in the community to build our

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Brandon Williams
On Thu, Nov 17, 2022 at 9:06 AM Josh McKenzie wrote: > > Arguably we could take it a step further and not actually allow a C* node to > startup without pointing to one of the config files from your primary config, > and provide a clean mechanism to integrate that selection on headless >

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Josh McKenzie
Have we ever discussed including multiple profiles that are simple to swap between and documented for their tested / intended use cases? Then the burden of having a “sane” default for the wild variance of workloads people use it for would be somewhat mitigated. Sure, there’s always going to be

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Jon Haddad
I noticed nobody answered my actual question - what would it take for you to be comfortable? It seems that the need to do a release is now more important than the best interests of the new user's experience - despite having plenty of *production* experience showing that what we ship isn't

[ANNOUNCE] Apache Cassandra 4.1-rc1 test artifact available

2022-11-17 Thread Mick Semb Wever
The test build of Cassandra 4.1-rc1 is available. sha1: d6822c45ae3d476bc2ff674cedf7d4107b8ca2d0 Git: https://gitbox.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/4.1-rc1-tentative Maven Artifacts:

Re: Should we change 4.1 to G1 and offheap_objects ?

2022-11-17 Thread Mick Semb Wever
Ok, wrt G1 default, this is won't go ahead for 4.1-rc1 We can revisit it for 4.1.x We have a lot of voices here adamantly positive for it, and those of us that have done the performance testing over the years know why. But being called to prove it is totally valid, if you have data to any such