[GitHub] climate pull request: CLIMATE-649 - Update CLI

2016-04-22 Thread huikyole
Github user huikyole commented on the pull request: https://github.com/apache/climate/pull/220#issuecomment-213623528 The recent piecemeal changes have been resolved all issues raised in this pull request. Therefore, I close this pull request. --- If your project is set up for it, yo

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2016-04-22 Thread huikyole
Github user huikyole closed the pull request at: https://github.com/apache/climate/pull/220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2016-02-07 Thread huikyole
Github user huikyole commented on the pull request: https://github.com/apache/climate/pull/220#issuecomment-181122299 @lewismc We decided to separate this into multiple tickets. Some of them have been already addressed. This pull request has been left for a reference. --- If your pro

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2016-02-04 Thread lewismc
Github user lewismc commented on the pull request: https://github.com/apache/climate/pull/220#issuecomment-180201521 @huikyole I take it that this issue has not been resolved and merged into master? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-10-26 Thread lewismc
Github user lewismc commented on the pull request: https://github.com/apache/climate/pull/220#issuecomment-151266681 @huikyole can you update the patch and we can reevaluate the merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-06 Thread MJJoyce
Github user MJJoyce commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36433288 --- Diff: ocw-cli/cli_app.py --- @@ -1232,11 +1180,11 @@ def settings_screen(header): if option == '4': screen.addstr(25, x/2

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-05 Thread huikyole
Github user huikyole commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36379129 --- Diff: ocw-cli/cli_app.py --- @@ -1232,11 +1180,11 @@ def settings_screen(header): if option == '4': screen.addstr(25, x/

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-05 Thread MJJoyce
Github user MJJoyce commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36377051 --- Diff: ocw-cli/cli_app.py --- @@ -1232,11 +1180,11 @@ def settings_screen(header): if option == '4': screen.addstr(25, x/2

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-05 Thread huikyole
Github user huikyole commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36363509 --- Diff: ocw-cli/cli_app.py --- @@ -1232,11 +1180,11 @@ def settings_screen(header): if option == '4': screen.addstr(25, x/

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-05 Thread MJJoyce
Github user MJJoyce commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36334213 --- Diff: ocw-cli/cli_app.py --- @@ -1232,11 +1180,11 @@ def settings_screen(header): if option == '4': screen.addstr(25, x/2

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-05 Thread MJJoyce
Github user MJJoyce commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36333951 --- Diff: ocw-cli/cli_app.py --- @@ -1138,30 +1080,36 @@ def settings_screen(header): new_start_time = screen.getstr() t

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-05 Thread MJJoyce
Github user MJJoyce commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36333923 --- Diff: ocw-cli/cli_app.py --- @@ -1138,30 +1080,36 @@ def settings_screen(header): new_start_time = screen.getstr() t

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread huikyole
Github user huikyole commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36273946 --- Diff: ocw-cli/cli_app.py --- @@ -1232,11 +1180,11 @@ def settings_screen(header): if option == '4': screen.addstr(25, x/

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread huikyole
Github user huikyole commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36273814 --- Diff: ocw-cli/cli_app.py --- @@ -1138,30 +1080,36 @@ def settings_screen(header): new_start_time = screen.getstr()

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread huikyole
Github user huikyole commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36273731 --- Diff: ocw-cli/cli_app.py --- @@ -599,123 +608,56 @@ def run_screen(model_datasets, models_info, observations_info, screen.addstr

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread huikyole
Github user huikyole commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36273612 --- Diff: ocw-cli/cli_app.py --- @@ -115,7 +119,7 @@ def load_local_model_screen(header): note = "WARNING: Model file cannot be added

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread huikyole
Github user huikyole commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36273459 --- Diff: ocw-cli/cli_app.py --- @@ -35,7 +36,10 @@ from ocw.data_source.local import load_file import ocw.utils as utils import ocw.data_sour

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread MBoustani
Github user MBoustani commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36249564 --- Diff: ocw-cli/cli_app.py --- @@ -1232,11 +1180,11 @@ def settings_screen(header): if option == '4': screen.addstr(25, x

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread MBoustani
Github user MBoustani commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36249459 --- Diff: ocw-cli/cli_app.py --- @@ -1138,30 +1080,36 @@ def settings_screen(header): new_start_time = screen.getstr()

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread MBoustani
Github user MBoustani commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36249436 --- Diff: ocw-cli/cli_app.py --- @@ -1138,30 +1080,36 @@ def settings_screen(header): new_start_time = screen.getstr()

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread MBoustani
Github user MBoustani commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36249157 --- Diff: ocw-cli/cli_app.py --- @@ -599,123 +608,56 @@ def run_screen(model_datasets, models_info, observations_info, screen.addst

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread MBoustani
Github user MBoustani commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36248860 --- Diff: ocw-cli/cli_app.py --- @@ -599,123 +608,56 @@ def run_screen(model_datasets, models_info, observations_info, screen.addst

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread MBoustani
Github user MBoustani commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36248566 --- Diff: ocw-cli/cli_app.py --- @@ -115,7 +119,7 @@ def load_local_model_screen(header): note = "WARNING: Model file cannot be adde

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-04 Thread MBoustani
Github user MBoustani commented on a diff in the pull request: https://github.com/apache/climate/pull/220#discussion_r36248396 --- Diff: ocw-cli/cli_app.py --- @@ -35,7 +36,10 @@ from ocw.data_source.local import load_file import ocw.utils as utils import ocw.data_sou

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-03 Thread OCWJenkins
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/220#issuecomment-127421333 Merged build finished. Test Passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-03 Thread OCWJenkins
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/220#issuecomment-127421204 Merged build started. Test Failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-03 Thread huikyole
GitHub user huikyole opened a pull request: https://github.com/apache/climate/pull/220 CLIMATE-649 - Update CLI Updated: cli_app.py - It is assumed that there is only one observation data - A critical bug has been fixed. Now time period does not have to be a multiple of 12.

[GitHub] climate pull request: CLIMATE-649 - Update CLI

2015-08-03 Thread OCWJenkins
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/220#issuecomment-127421195 Merged build triggered. Test Failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project