RE: Third party VR / L2 support

2015-06-23 Thread Rajesh Battala
Your views are correct in managing the 3rd party VRs I see people try to use external devices to provide network services if they see VR cannot handle the performance or stability or if the admin thinks third party providers can do well w.r.t their environment. In current cloudstack, CloudStack

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114486026 good point so backwards compatibility is a glass eye anyway;) will merge --- If your project is set up for it, you can reply to this email and have your reply

Build failed in Jenkins: simulator-singlerun #1299

2015-06-23 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1299/ -- Started by upstream project build-master-simulator build number 2116 originally caused by: Started by upstream project build-master build number 2419 originally caused by: Started by an

Build failed in Jenkins: simulator-singlerun #1298

2015-06-23 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1298/ -- Started by upstream project build-master-simulator build number 2115 originally caused by: Started by upstream project build-master build number 2418 originally caused by: Started by an

[GitHub] cloudstack pull request: Made misc changes

2015-06-23 Thread sanju1010
Github user sanju1010 closed the pull request at: https://github.com/apache/cloudstack/pull/512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114495407 @resmo can you send a doc PR so at least we can document this in release notes? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/510 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: simulator-singlerun #1300

2015-06-23 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1300/ -- Started by upstream project build-master-simulator build number 2117 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114495233 this can potentially break clients depending on the behaviour when zoneid is passed --- If your project is set up for it, you can reply to this email and have

Build failed in Jenkins: simulator-singlerun #1301

2015-06-23 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1301/ -- Started by upstream project build-master-simulator build number 2118 originally caused by: Started by upstream project build-master build number 2420 originally caused by: Started by an

[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...

2015-06-23 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/513 CLOUDSTACK-8578: implement old behaviour for listing only non-destroy… …ed VMs using state=present Also see https://github.com/apache/cloudstack/pull/510#issuecomment-114502611

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114502611 @bhaisaab Ok. I'll make a doc PR. We could probably think about extending the list API to a state e.g. `present` which returns all VMs in states `starting, running,

[GitHub] cloudstack pull request: Extend wait before retry to states other ...

2015-06-23 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/514 Extend wait before retry to states other than 'Starting' https://github.com/apache/cloudstack/pull/493 implemented wait and retry for SSVM state trying, but today there was as an occurrence

[GitHub] cloudstack pull request: findbugs: move assert to a place where it...

2015-06-23 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/515 findbugs: move assert to a place where it still makes sense You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...

2015-06-23 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/513#discussion_r33093929 --- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java --- @@ -968,7 +968,11 @@ } if (state != null) { -

[GitHub] cloudstack pull request: findbugs: move assert to a place where it...

2015-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: simulator-singlerun #1302

2015-06-23 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1302/ -- Started by upstream project build-master-simulator build number 2119 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on

Re: [cloudstack] findbugs: move assert to a place where it still makes sense (#515)

2015-06-23 Thread Rafael Fonseca
IMO, asserts should be completely removed in most classes. It's mostly used in early development stages and ACS has been production grade for quite some time. The assert statement won't even run on production, because it's disabled by default in the JVM in production runtime, and we're of course

[GitHub] cloudstack pull request: findbugs: constant fields should be final

2015-06-23 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/517 findbugs: constant fields should be final You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack findbugs-MS

Build failed in Jenkins: simulator-singlerun #1303

2015-06-23 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1303/ -- Started by upstream project build-master-simulator build number 2120 originally caused by: Started by upstream project build-master build number 2421 originally caused by: Started by an

Re: Console keyboard improvements

2015-06-23 Thread Erik Weber
Thanks for the update. I'll see how far along it is when I get home from summer vacation before I do anything else. -- Erik On Tue, Jun 23, 2015 at 1:39 PM, Anshul Gangwar anshul.gang...@citrix.com wrote: Erik, It will take around month or 2 months to hit code base. For testing purposes

[GitHub] cloudstack pull request: CLOUDSTACK-8579: Fix cleanup operation in...

2015-06-23 Thread gauravaradhye
GitHub user gauravaradhye opened a pull request: https://github.com/apache/cloudstack/pull/511 CLOUDSTACK-8579: Fix cleanup operation in few test cases Cleanup list should be declared before returning from setUpClass() so that tearDownClass() works properly. Currently the

[GitHub] cloudstack pull request: CLOUDSTACK-8579: Fix cleanup operation in...

2015-06-23 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/511#issuecomment-114467280 LGTM...Please commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8579: Fix cleanup operation in...

2015-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Made misc changes

2015-06-23 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/512#issuecomment-114469391 Test Revoke ingress rule after deploy VM ... === TestName: test_02_revokeIngressRule_AfterDeployVM | Status : SUCCESS === ok

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

2015-06-23 Thread Sanjeev N
LGTM. I am taking this patch. On Mon, Jun 22, 2015 at 6:26 PM, nitt10prashant g...@git.apache.org wrote: GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/507 CLOUDSTACK-8577: fixing script testpath_disable_enable_zone disable enable

[GitHub] cloudstack pull request: Offer a getDurationInMillis() method in t...

2015-06-23 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/516#issuecomment-114733108 Travis has failed due to a timeout. I will run the same tests (i.e. smoke/test_affinity_groups smoke/test_primary_storage) on our test environment

Build failed in Jenkins: simulator-singlerun #1305

2015-06-23 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1305/ -- Started by upstream project build-master-simulator build number 2122 originally caused by: Started by upstream project build-master build number 2422 originally caused by: Started by an

[GitHub] cloudstack pull request: Extend wait before retry to states other ...

2015-06-23 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/514#issuecomment-114732603 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Build failed in Jenkins: simulator-singlerun #1304

2015-06-23 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1304/ -- Started by upstream project build-master-simulator build number 2121 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on

Re: Build environment stability

2015-06-23 Thread Remi Bergsma
+1! Thanks guys :-) On 22 Jun 2015, at 07:38, Rajani Karuturi raj...@apache.org wrote: Thanks for all the hard work Rafeal and Daan. much needed fixes. ~Rajani On Mon, Jun 22, 2015 at 2:35 AM, Rafael Fonseca rsafons...@gmail.com wrote: Hi all, Sorry for the 100+ SPAM mails from

[GitHub] cloudstack pull request: Replace System.currentTimeMillis() by Sys...

2015-06-23 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/509 Replace System.currentTimeMillis() by System.nanoTime() - System.nanoTime() is the best way to measure elapsed time in Java. - It gives a resolution on the order of

Re: [VOTE] release candidate 4.4.4 (4.4-RC20150618T1117)

2015-06-23 Thread Remi Bergsma
Hi Daan, Thanks for fixing and testing it! After DevOpsDays Ams I will also give it a go. I can prepare a PR for the release notes and document the new setting. You can then merge it when the release passes. Or should we do this in another way? Regards, Remi On 22 Jun 2015, at 16:35, Daan

RE: question about Admin's capability to create a VM on a disabled host

2015-06-23 Thread Raja Pullela
Yes... that makes sense. Thanks Praveen! -Original Message- From: Praveen B [mailto:pbprave...@gmail.com] Sent: Monday, June 22, 2015 11:13 PM To: dev@cloudstack.apache.org Subject: Re: question about Admin's capability to create a VM on a disabled host Hi Raja, I can think of this

[GitHub] cloudstack pull request: Replace System.currentTimeMillis() by Sys...

2015-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/510 CLOUDSTACK-8578: fix listVirtualMachines does not return deleted mach… …ines when zone is specified You can merge this pull request into a Git repository by running: $ git pull

Re: [VOTE] release candidate 4.4.4 (4.4-RC20150618T1117)

2015-06-23 Thread Daan Hoogland
On Tue, Jun 23, 2015 at 9:12 AM, Remi Bergsma rberg...@schubergphilis.com wrote: I can prepare a PR for the release notes and document the new setting. You can then merge it when the release passes. Or should we do this in another way? This is fine but it is in the release even if it

[GitHub] cloudstack pull request: Replace System.currentTimeMillis() by Sys...

2015-06-23 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/509#discussion_r33018252 --- Diff: utils/src/com/cloud/utils/Profiler.java --- @@ -23,24 +23,20 @@ private Long startTickInMs; private Long stopTickInMs;

[GitHub] cloudstack pull request: Replace System.currentTimeMillis() by Sys...

2015-06-23 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/509#discussion_r33018651 --- Diff: utils/src/com/cloud/utils/Profiler.java --- @@ -23,24 +23,20 @@ private Long startTickInMs; private Long stopTickInMs;

[GitHub] cloudstack pull request: Replace System.currentTimeMillis() by Sys...

2015-06-23 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/509#discussion_r33019962 --- Diff: utils/src/com/cloud/utils/Profiler.java --- @@ -23,24 +23,20 @@ private Long startTickInMs; private Long stopTickInMs;

[GitHub] cloudstack pull request: Replace System.currentTimeMillis() by Sys...

2015-06-23 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/509#discussion_r33018426 --- Diff: utils/src/com/cloud/utils/Profiler.java --- @@ -23,24 +23,20 @@ private Long startTickInMs; private Long stopTickInMs;

Build failed in Jenkins: simulator-singlerun #1296

2015-06-23 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1296/ -- Started by upstream project build-master-simulator build number 2113 originally caused by: Started by an SCM change Started by an SCM change Started by upstream project build-master

Re: Console keyboard improvements

2015-06-23 Thread Anshul Gangwar
Hi Erik, I will be working on console keyboard support refactoring. The main purpose of this refactoring will be to enable end user to add their own keyboard mappings without need to know CloudStack code much. As of now all keyboard mappings are either into ajaxkeys.js or ajaxviewer.js.

Re: Console keyboard improvements

2015-06-23 Thread Erik Weber
Hi Anshul, Thank you for the update. Do you have a rough estimate for when this refactor might hit the codebase? I don't expect my changes to hit 4.6 due to time constraints anyway, so if your changes are around the corner I might as well wait. Do you happen to know what the easiest way to

Re: Console keyboard improvements

2015-06-23 Thread Stephan Seitz
Hi Erik, I'ld like to move in, but for the need of a german layout. Maybe we can join forces :) cheers, - Stephan Am Dienstag, den 23.06.2015, 12:24 +0200 schrieb Erik Weber: Hi, I am guessing there are more than me that's having trouble with keyboard with non-us layouts. I'd like to

Re: Console keyboard improvements

2015-06-23 Thread Anshul Gangwar
Erik, It will take around month or 2 months to hit code base. For testing purposes I will go with quickcloud. It will be easier to test that way as you can run CPVM functionality on you management server without deploying CPVM. It will save you a lot of pain.

Re: Console keyboard improvements

2015-06-23 Thread Stephan Seitz
Hi Erik, I found following link[1] useful do build a modified virtual router systemvm. I assume the very same process can be used for the console-vm. You can upload your own template to ACS and define it in the settings area via consoleproxy.system.offering [1]

Re: [VOTE] release candidate 4.4.4 (4.4-RC20150618T1117)

2015-06-23 Thread Wilder Rodrigues
Hi, Did some general tests on this release and would like to share my +1. Details below... Environment test Management Server = CentOS 7.1 1 Host XenServer 6.2 Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS === ok Test router basic setup ... ===

Console keyboard improvements

2015-06-23 Thread Erik Weber
Hi, I am guessing there are more than me that's having trouble with keyboard with non-us layouts. I'd like to improve it, atleast for my native charset. Has anyone done something like this, and have some insight into the process? I've found this [1], that to some degree explain the process. If

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114432879 why should we return machines that no longer exist? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure

2015-06-23 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/497#issuecomment-114435233 Thanks for the update @rsafonseca --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project