[GitHub] cloudstack pull request: CLOUDSTACK-8622: Reinstate working sessio...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/574#issuecomment-120256667 "page refreshes, opening multiple tabs," Nice! I also liked the String.format() calls. I should use it more as well. For some stuff stil

[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120254575 Hi @bhaisaab Code looks good and screenshot as well. :+1: Hints to test it manually? After hitting the check-box, what should I do?

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120227544 Can you add some unit tests or marvin tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Build failed in Jenkins: simulator-singlerun #1355

See -- Started by upstream project "build-master-simulator" build number 2172 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by upstr

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120222980 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8622: Reinstate working sessio...

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/574#issuecomment-120215440 This was much needed. The code looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Build failed in Jenkins: simulator-singlerun #1354

See -- Started by upstream project "build-master-simulator" build number 2171 originally caused by: Started by an SCM change Started by an SCM change Started by upstream project "build-master"

Build failed in Jenkins: build-4.5 #496

See Changes: [abhinandan.prateek] CLOUDSTACK-8624: Added the support for mysql db port and lowered the requiremnts for available disk capacity to 2.1GB VS original 5GB as it was too excessive. --

[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120149819 Screenshot:  --- If

[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/575 CLOUDSTACK-8457: Add option to authorize SAML SSO for user when adding user With SAML enabled, add user view shows option to authorize SAML SSO for a user. You can merge this pull request into

[GitHub] cloudstack pull request: CLOUDSTACK-8622: Reinstate working sessio...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/574#issuecomment-120146710 (note: single patch ensures we capture the single aim with this fix and also easy to port to other branches, 4.5/master etc.) --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8622: Reinstate working sessio...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/574#issuecomment-120146560 I reviewed https://github.com/apache/cloudstack/pull/308 and found that it needs more fixes, since that PR is slightly old now, worked on this. This aims to have a

[GitHub] cloudstack pull request: CLOUDSTACK-8622: Reinstate working sessio...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/574 CLOUDSTACK-8622: Reinstate working sessions in browser - Login is based on sessionkey HttpOnly Cookie - ApiServlet does login verification using sessionKey from both the request cookies

Build failed in Jenkins: simulator-singlerun #1353

See -- Started by upstream project "build-master-simulator" build number 2170 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by upstr

[GitHub] cloudstack pull request: coverity resource leaks

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Findbugs issues with instance acces to st...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/573 Findbugs issues with instance acces to static fields I wonder if these fields are used solely on the host or on the management server as well. If the code is running on both it is not r

Re: IRC and Slack

A bit rough, but you get the idea http://www.cloudstackforum.com/vanilla/ -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "sebgoa" > To: dev@cloudstack.apache.org > Sent: Friday, 3 July, 2015 08:27:43 > Subject: Re: IRC and Slack > S

RE: Introducing Boris Schrijver

Welcome, Boris -Original Message- From: Nux! [mailto:n...@li.nux.ro] Sent: Thursday, July 9, 2015 2:19 AM To: dev@cloudstack.apache.org Cc: bo...@pcextreme.nl Subject: Re: Introducing Boris Schrijver Welcome, Boris :-) Lucian -- Sent from the Delta quadrant using Borg technology! Nux

Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)

> On Jul 9, 2015, at 3:27 PM, David Nalley wrote: > > On Thu, Jul 9, 2015 at 4:49 AM, Rohit Yadav > wrote: > >> >> On 09-Jul-2015, at 12:50 pm, Sebastien Goasguen wrote: >> >> Let’s revert , that’s our new rule >> >> >> Since we have not voted what/how we are going to do commits, let’s tr

[GitHub] cloudstack pull request: Cleaned class “com.cloud.hypervisor.xen...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/560#issuecomment-119974151 Nice to hear that, I will be waiting for CS 4.6 now ;) If you guys will check those classes “XcpServerNetworkUsageCommandWrapper” and

Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)

On Thu, Jul 9, 2015 at 4:49 AM, Rohit Yadav wrote: > > On 09-Jul-2015, at 12:50 pm, Sebastien Goasguen wrote: > > Let’s revert , that’s our new rule > > > Since we have not voted what/how we are going to do commits, let’s treat > this more of a guideline or honour code. > Votes aren't strictl

Build failed in Jenkins: simulator-singlerun #1352

See -- Started by upstream project "build-master-simulator" build number 2169 originally caused by: Started by an SCM change Started by upstream project "build-master" build number 2456 origin

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/572 CLOUDSTACK-7539: [S3] Parallel deployment makes reference count of a … …cache in nfs secondary staging store negative(-1) old review request by Hiroki Ohashi that is planned for

[GitHub] cloudstack pull request: findbugs: write to static from instance

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: IRC and Slack

Kind Regards Giles D: +44 20 3603 0541 | M: +44 796 111 2055 giles.sir...@shapeblue.com > -Original Message- > From: Stephen Turner [mailto:stephen.tur...@citrix.com] > Sent: 06 July 2015 08:25 > To: dev@cloudstack.apache.org > Subject: RE: IRC and Slack > > -Original Message

[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/570#discussion_r34249648 --- Diff: test/integration/component/test_ps_resize_volume.py --- @@ -48,59 +51,69 @@ RESOURCE_SECONDARY_STORAGE,

Build failed in Jenkins: simulator-singlerun #1351

See -- Started by upstream project "build-master-simulator" build number 2168 originally caused by: Started by upstream project "build-master" build number 2455 originally caused by: Started

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/571 CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its… … initial start-up process If SSVM cannot be started then the existing entry is removed and a new SSVM get

Build failed in Jenkins: simulator-singlerun #1350

See -- Started by upstream project "build-master-simulator" build number 2167 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely o

[GitHub] cloudstack pull request: Config drive changes for vm migration

Github user jayapalu closed the pull request at: https://github.com/apache/cloudstack/pull/552 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request: Config drive changes for vm migration

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/552#issuecomment-119935788 Discarding this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/570#issuecomment-119930090 @DaanHoogland @bhaisaab @karuturi Could you please have a look at this one as well? :) Thanks in advance. Cheers, Wilder ---

[GitHub] cloudstack pull request: Cleaned class “com.cloud.hypervisor.xen...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/570#issuecomment-119920451 LGTM :+1: But, please, next time do it in 2 separate commits: 1 commit with file formatting 1 commit with the actual change It

[GitHub] cloudstack pull request: Cleaned class “com.cloud.hypervisor.xen...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/560#issuecomment-119919812 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Build failed in Jenkins: simulator-singlerun #1349

See -- Started by upstream project "build-master-simulator" build number 2166 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by an SC

[GitHub] cloudstack pull request: Cleaned class “com.cloud.hypervisor.xen...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/560#issuecomment-119918219 Awesome, @rafaelweingartner Thanks for fixing it. LGTM @DaanHoogland would you mind to have a look at this one as well? Ch

[GitHub] cloudstack pull request: coverity resource leaks

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/564#issuecomment-119917601 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/568#issuecomment-119917422 Looks good to me. Commented on older PR earlier. PR https://github.com/apache/cloudstack/pull/552 can be removed --- If your project is set up for it, y

[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/569#issuecomment-119913350 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

Build failed in Jenkins: simulator-4.5-singlerun #251

See -- Started by upstream project "build-4.5-simulator" build number 306 originally caused by: Started by upstream project "build-4.5" build number 495 originally caused by: Started by an

Build failed in Jenkins: package-rhel63-4.5 #291

See -- Started by upstream project "build-4.5" build number 495 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on rpmbuilder-2 i

[GitHub] cloudstack pull request: CLOUDSTACK-8615 :skip all tests in test_p...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/565#issuecomment-119905456 The changes Look Good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [PROPOSAL] Commit to master through PR only

On Thu, Jul 9, 2015 at 12:04 PM, Rohit Yadav wrote: > > On 09-Jul-2015, at 2:56 pm, Daan Hoogland wrote: > > I like the idea but think that 72 hours is way to short > > > I think 72 hours (note: no counting weekends) should be good enough, > which is the window for our release/vote process as w

4.5.2 open issues remaining

H, Can everybody look at [1] and look if further tickets can be closed. I reduced the list by 60 tickets moving inactive tickets to 'Future' and closing what I knew could be closed. The main objective of course is to get 4.5.2 out and voted in;) [1]https://issues.apache.org/jira/issues/?jql=proje

Re: [GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

LGTM!! I am taking this patch. On Thu, Jul 9, 2015 at 3:25 PM, pavanb018 wrote: > Github user pavanb018 commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pull/569#discussion_r34239937 > > --- Diff: test/integration/component/test_blocker_bugs.py --- >

Build failed in Jenkins: simulator-singlerun #1348

See -- Started by upstream project "build-master-simulator" build number 2165 originally caused by: Started by an SCM change Started by upstream project "build-master" build number 2453 origin

Re: [GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

On 09-Jul-2015, at 3:21 pm, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: I think I look good to myself as well ;} On Thu, Jul 9, 2015 at 11:44 AM, karuturi mailto:g...@git.apache.org>> wrote: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/

Re: [PROPOSAL] Commit to master through PR only

On 09-Jul-2015, at 2:56 pm, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: I like the idea but think that 72 hours is way to short I think 72 hours (note: no counting weekends) should be good enough, which is the window for our release/vote process as well. We can increase this to perh

[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/563 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

Github user pavanb018 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/569#discussion_r34239937 --- Diff: test/integration/component/test_blocker_bugs.py --- @@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self): #all it's

[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119893211 @karuturi fair point, will add a JIRA ticket tracking this. Will re-push with the JIRA ID and merge. IMO one should be able to cast reviews, the minimum two

Re: [GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

I think I look good to myself as well ;} On Thu, Jul 9, 2015 at 11:44 AM, karuturi wrote: > Github user karuturi commented on the pull request: > > https://github.com/apache/cloudstack/pull/563#issuecomment-119891522 > > +1 changes looks good. but, a jira ticket is required. Also, I dont

[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119891522 +1 changes looks good. but, a jira ticket is required. Also, I dont think you can self vote ;) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/569#discussion_r34238492 --- Diff: test/integration/component/test_blocker_bugs.py --- @@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self): #all

[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119889147 UI is not really my thing, but given the logic applied and the code itself, LGTM too. Cheers, Wilder --- If your project is set up for it, you

Re: [PROPOSAL] Commit to master through PR only

On Thu, Jul 9, 2015 at 10:51 AM, Rohit Yadav wrote: > > On 09-Jul-2015, at 2:14 pm, Rohit Yadav wrote: > > - This seems to be already failing, under the Apache way IMO there is no > way we can enforce and ensure that at least two people would review any and > every PR. There are already a growin

[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/569#issuecomment-119887574 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

Is it possible to point external Router Network on cloudstack

Hi All, My Network team allocated a Network segment 10.3.132.0/24 on VLAN 132. So is that possible to create a VM using this network without the Virtualrouter. Where it should have to point via my PhysicalRouter. Thanks, Keerthi

[GitHub] cloudstack pull request: Config drive changes for vm migration

Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/552#issuecomment-119883042 LGTM. Nice option to have config drive ISO for meta data! Migration logic looks fine. --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: CLOUDSTACK-8620 :skip test cases if rbd s...

GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/570 CLOUDSTACK-8620 :skip test cases if rbd storage is not available in l… skipping tests based on storage for lxc hype and fixing pep8 issues test result = Test increas

Re: [PROPOSAL] Commit to master through PR only

On 09-Jul-2015, at 2:14 pm, Rohit Yadav mailto:rohit.ya...@shapeblue.com>> wrote: - This seems to be already failing, under the Apache way IMO there is no way we can enforce and ensure that at least two people would review any and every PR. There are already a growing number of open PRs that w

Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)

On 09-Jul-2015, at 12:50 pm, Sebastien Goasguen mailto:run...@gmail.com>> wrote: Let’s revert , that’s our new rule Since we have not voted what/how we are going to do commits, let’s treat this more of a guideline or honour code. I’ve expressed few concersn on this rule wrt code reviewing for

Re: [PROPOSAL] Commit to master through PR only

On 07-Jul-2015, at 1:09 pm, sebgoa mailto:run...@gmail.com>> wrote: The PR should not be squashed until it's reviewed and accepted. I am only arguing for squashing it when it is accepted and before merge. For now, I would love for us to focus on the 2 LGTM and green tests (as much as we can g

[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/563#issuecomment-119875445 +1 LGTM (self) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...

On Thu, Jul 9, 2015 at 8:44 AM, pavanb018 wrote: > looks good to me pavanb018 you probably should write LGTM ;) -- Daan

[GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

GitHub user pavanb018 opened a pull request: https://github.com/apache/cloudstack/pull/569 Handling Basic Zone scenarios for starting VM in stopped state Basic Zone result: Test Deploy Virtual Machine with no startVM parameter ... === TestName: test_01_deploy_vm_no_startvm

Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)

> On Jul 9, 2015, at 4:45 AM, Rajani Karuturi wrote: > > PR #565 is also closed with one review. > > I dont agree to adding an exception. Reviewing would be one way to get > others engaged and become aware. Otherwise, they lay there untouched and > unused. > Let’s revert , that’s our new rule