[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140648456 Hi @rafaelweingartner , Master was broken yesterday when a file containing the wrong imports was merged. I reverted about 5 minutes after the merge.

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-140646781 @wilderrodrigues my bad, something went wrong while creating the pr. fixed this. --- If your project is set up for it, you can reply to this email and have yo

Re: After box restart CS 4.5.2 fails to start

2015-09-15 Thread Rohit Yadav
Did you try running cloudstack-setup-management as root user ? On 15-Sep-2015, at 8:24 pm, Keerthiraja SJ mailto:sjkeer...@gmail.com>> wrote: Hi All, Today I installed CS 4.5.2 on CentOS 6.7 and able to start the app successfully. All of a sudden the box reboot then while I started the cloudsat

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-140645828 Why do we have 2 PR with the same issue/branch/description, @bvbharatk ? I check the PR #838 and that's about something else. Could you please edit the PR de

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/828#discussion_r39598013 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java --- @@ -598,6 +601,19 @@ public static void setBasicVmConfig(Vi

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/838#issuecomment-14064 Which steps should we follow to test it, @bvbharatk ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140645427 I will add the same comment to the opened PR instead. I believe is better to follow up overt here. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/838 CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. earlier we were eating up exceptions from the lower layer which resulted in improper error messages. fixed p

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140645340 Hi @rafaelweingartner , I understood that @pedro-martins went through a hard time checking class by class, but I would not discuss credits and that k

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-15 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/837 CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. earlier we were eating up exceptions from the lower layer which resulted in improper error messages. fixed p

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

2015-09-15 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/836 CLOUDSTACK-8863: VM doesn't reconnect to internet post VR RESTART/STO… …P-START/RECREATE The ongoing ICMP request reply session is broken when the VR is down, the expectation i

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

2015-09-15 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-140644634 Tested adding ESXi 6.0 host to advanced ACS zone successfully. Session logic is working fine. @bhaisaab you might want to go ahead merge it.

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140643483 @bhaisaab it should be for 4.5 as well but It is not complete yet, unless we decide that we don't take any action on a missing report. I will make a PR for 4.5

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/832#issuecomment-140642411 Hi @borisroman Few months ago we had a thread on the list to discuss which PR flow we should have in place in order to increase ACS quality. The ide

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/828#discussion_r39597202 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java --- @@ -598,6 +601,19 @@ public static void setBasicVmConfig(VirtualMachine

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

2015-09-15 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/834#issuecomment-140641999 Reschedule time is always based on the work type. Code changes are OK. LGTM. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-140641828 Alright, let's wait for lab tests to confirm the patch and only then we should merge it. Thanks for helping test it @sateesh-chodapuneedi --- If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

2015-09-15 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/835 CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination Also changed viewer/console identifier to vm uuid + vnc port to avoid using same connection console if

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140641376 @DaanHoogland this is for just master, or also applies for 4.5; if so please send a PR for 4.5 as well. Thanks. --- If your project is set up for it, you can reply

[PROPOSAL] stable master and 4.6 release

2015-09-15 Thread Rajani Karuturi
Hi all, There is little progress on 4.6 blockers this week. To release 4.6, we all should come together and fix the blockers. In recent days, master has broken multiple times with compilation failures/regressions. If master breaks, time spent on figuring out what happened and fixing it is time *not

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

2015-09-15 Thread maneesha-p
GitHub user maneesha-p opened a pull request: https://github.com/apache/cloudstack/pull/834 CLOUDSTACK-8866 : restart.retry.interval is being used instead of migrate.retry.interval during host maintenance The frequency at which Cloudstack tries to migrate the VMs is currently contr

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

2015-09-15 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/833#issuecomment-140628293 Thanks guys. Will merge in sometime. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

2015-09-15 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-140627846 @sureshanaparti code LGTM. I will test this patch today in my lab and will get back. --- If your project is set up for it, you can reply to this ema

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-15 Thread Rajani Karuturi
I agree. Most of the blockers we see now are VR related. ~Rajani On 16-Sep-2015, at 10:15 am, Raja Pullela wrote: > I agree with jayapal, so far none of the BVTs for the hypervisors are at 100% > except for the simulator's. > Also, changes/refactoring some of the very core functionality s

RE: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-15 Thread Raja Pullela
I agree with jayapal, so far none of the BVTs for the hypervisors are at 100% except for the simulator's. Also, changes/refactoring some of the very core functionality such as VR should be thought through and thoroughly tested before being pushed as the impact will be huge and stabilization w

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39593369 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

RE: VPC router issue

2015-09-15 Thread Raja Pullela
Hi Wilder, BTW, I just checked my setup and it was passing on Sep 9th and was regressed after that. Thanks for checking this out, Raja -Original Message- From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com] Sent: Tuesday, September 15, 2015 7:12 PM To: dev@cloudstack.apache.or

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

2015-09-15 Thread harikrishna-patnala
Github user harikrishna-patnala commented on the pull request: https://github.com/apache/cloudstack/pull/833#issuecomment-140624768 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/833#issuecomment-140624682 @karuturi no need to worry on the implications, except for openswan we don't have a version reliance of a packages; and for openswan we install a specific version

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/833#issuecomment-140624609 Thanks @karuturi LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-140624485 I think Daan did not say -1 or :-1: while unit tests are welcome, does not hurt to be merciful on one or few line changes if they indeed fix a bug --- If your proj

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-15 Thread Jayapal Reddy Uradi
Hi Wilder, CLOUDSTACK-8843 This ticket is actually NOT regression. It is not implemented/tested for the basic zone VR. What I have observed in the VR refactor is that sanity testing of components the code affects is not done. Now we are spe

Re: Recurring snapshot taking full every time

2015-09-15 Thread Abhinandan Prateek
Can you check in the SMlog on the concerned host if you see any error when the plugin is being invoked ? > On 14-Sep-2015, at 5:01 pm, raja sekhar wrote: > > Hi abhinandan, > > Thanks for your reply. > We are facing the issue only for root volumes in that host. The snapshot > recurring policy fo

Re: After box restart CS 4.5.2 fails to start

2015-09-15 Thread Abhinandan Prateek
This looks like a user privilege issue. Can you make sure that you are running cloudstack with enough privileges (sudo included). > On 15-Sep-2015, at 8:24 pm, Keerthiraja SJ wrote: > > Hi All, > > Today I installed CS 4.5.2 on CentOS 6.7 and able to start the app > successfully. > > All of a su

Build failed in Jenkins: build-systemvm-master #625

2015-09-15 Thread jenkins
See Changes: [anshul.gangwar] CLOUDSTACK-8834: Fixed unable to download Template , when in multi zones [wido] CLOUDSTACK-8645: Improve logging of RBD functionality in KVM [Boris Schrijver] Replaced all occurences of Charset

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

2015-09-15 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/833#issuecomment-140554664 @karuturi Our mirror at PCextreme still hosts the Debian 7.8.0 image. http://debian.apt-get.eu/cd-images/7.8.0/i386/iso-cd/debian-7.8.0-i386-netinst.iso

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140527418 I do agree with you that removing duplicated code, reducing cyclomatic complexity and writing test case is much better. However, those tasks require certai

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

2015-09-15 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/831#issuecomment-140508485 Please note revertSnapshot for KVM has been merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140493836 I do agree that prepending "s_" to static variables is a waste of characters. Modern IDEs will signal static variables for you. It's a bit like prepending (o

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140491359 Actually, the ticket is as simple as that. It was just an exercise to an intern that is working with me in my thesis. We are doing few very small

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140487166 @rafaelweingartner Thanks for the time you spent on this. The commit header is indeed better. It now conveys what is being done. If you happen to have to cha

Re: Build failed in Jenkins: build-systemvm-master #624

2015-09-15 Thread Rajani Karuturi
Rohit, Can you review https://github.com/apache/cloudstack/pull/833 ? Thanks, ~Rajani On Tue, Sep 15, 2015 at 12:45 PM, Rajani Karuturi wrote: > ok. thanks. I will attempt a fix. > > ~Rajani > > On Tue, Sep 15, 2015 at 11:34 AM, Rohit Yadav > wrote: > >> The ISO url needs to be fixed to use 7

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

2015-09-15 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/833#issuecomment-140460941 I really dont know the implications of change it from debian-7.8.0 to debian-7.9.0. If there is a better fix available, please advise. --- If your project is set

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

2015-09-15 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/833 changed the systemvm base iso file from debian-7.8.0 to debian-7.9.0 7.8.0 url is not available(404 Error) This fixes the jenkins http://jenkins.buildacloud.org/job/build-systemvm-mast

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140423091 @wilderrodrigues conflicts solved, I tried to do a maven install, to run all tests and compile everything, but that did not work, hence there is a class mi

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140424617 Maybe the compiler is overworked and just did a cursory glance and reported back "LGTM." ;) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140423615 I completely agree with you in this Mike. We should stop churning in features when we don't even have a proper build that prevents **syntax** errors! --- If

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-15 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-140420588 @wilderrodrigues -> @DaanHoogland Didn't -1, he actually said the opposite. The screenshots where added to provide context (question from daan). I tested them to

After box restart CS 4.5.2 fails to start

2015-09-15 Thread Keerthiraja SJ
Hi All, Today I installed CS 4.5.2 on CentOS 6.7 and able to start the app successfully. All of a sudden the box reboot then while I started the cloudsatck it fails to start where I could see a different issue and ERROR on catalina.out ERROR == INFO [c.c.s.ConfigurationServerImpl] (main:nul

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/832 Replaced all occurences of Charset.forName(UTF-8) with StringUtils.getPreferredCharset(). You can merge this pull request into a Git repository by running: $ git pull https://github.co

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140404617 Right, Miguel (as you and I were discussing for that other PR with regards to tests). My point then is we especially should not be putting in this muc

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140403964 @rafaelweingartner I totally understand. Inspiration is not something that always comes when needed. Please do take your time. --- If your project is set up

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140403471 @mike-tutkowski **we** don't have an awesome suite of regression tests because **we** don't write them. And if so, we should not rely on the builds we have,

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-140403283 @remibergsma indeed. Perhaps I have been through many untested PRs today and one more just got my brain in a fuzzy state. My argument remains as the

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

2015-09-15 Thread yvsubhash
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/831 CLOUDSTACK-8850: revertSnapshot command does not work Updating the documentation before the api is actually supported You can merge this pull request into a Git repository by running: $ g

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140402029 I could say this again, but it doesn't seem like it's a popular opinion with regards to CloudStack development: If we are really "late in the game" wi

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-15 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-140400310 @wilderrodrigues Not sure if @DaanHoogland actually :-1: it, he said he wouldn't do that. It's confusing though ;-) --- If your project is set up for it, you ca

Re: VPC router issue

2015-09-15 Thread Wilder Rodrigues
6 days ago test_pc_routers.py succeeded with PR 788: https://github.com/apache/cloudstack/pull/788 It’s in the test results I put there. I’m now testing Master to verify if it’s still occurring there. I tested the PR #808 (https://github.com/apache/cloudstack/pull/805), which had a bunch of t

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-140395721 We got a :-1: from @DaanHoogland and still the PR was merged without any explanation from the author. Was it tested by anyone? ping @bhais

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140392192 "In this particular case, how is possible to get 2 LGTM without even compiling the project locally?" I was depending on the info Daan refers to and, a

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-15 Thread Wilder Rodrigues
Hi Jayapal, I would not suggest to move back to the sceptres, but focus on fixing and for every fix test it very well so we get confidence. If we start calling scripts com the python code it will have a huge chance to become a real mess! Let’s stick to it and fix it and once it’s stable we can

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/825#issuecomment-140388758 Building is passing again: [INFO] [INFO] BUILD SUCCESS [INFO] -

Reverted PR 825

2015-09-15 Thread Wilder Rodrigues
Guys, Unfortunately, PR 825 broke Master. Due to that, Remi and I just reverted it. @Boris: please fix the error and reopen the PR. Cheers, Wilder

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/825#issuecomment-140380659 Reverted by commit 6e426fa46d8cda50ec76f33429320d4590701678 --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140380153 @wilderrodrigues thanks for your comments, I have just answered your comments on PR 714. I will work on a rebase today and push it again. @miguelaf

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140379362 @wilderrodrigues I got your point, and I also hate when projects that I work start breaking as a consequence of bad/poor code. Here goes an explanation in

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/825#issuecomment-140378819 @wilderrodrigues If something breaks master, any committer can revert it in order to restore stability. I didn't verify yet, but feel free to revert and ping the

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-15 Thread Jayapal Reddy Uradi
Wilder, That is true. All these issues are because of the VR refactoring. I don’t know what are the unit test cases run on VR refactor code. VR (shell) scripts are stabilized over years and now suddenly moved to new implementation. What we have figured out is that this new implementation is do

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/825#issuecomment-140378109 @borisroman @wido Was this PR compiled locally? Master is now broken. When I try to build I get: BrocadeVcsApi.java:[378,26] error: cannot

Build failed in Jenkins: build-master-jdk18 #352

2015-09-15 Thread jenkins
See Changes: [Boris Schrijver] Replaced all occurences of Charset.forName(UTF-8) with StringUtils.getPreferredCharset(). -- [...truncated 5515 lines...] [INFO] Apache CloudStack Plugin -

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-15 Thread Wilder Rodrigues
I have the feeling that we are fixing 1 issue and created 2. Please, make sure the routers tests are executed and green before creating the PR. I will do the same. Cheers, Wilder > On 15 Sep 2015, at 14:23, Jayapal Reddy Uradi > wrote: > > Assigned to myself. > > Thanks, > Jayapal >> On 15

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-15 Thread Jayapal Reddy Uradi
Assigned to myself. Thanks, Jayapal > On 15-Sep-2015, at 2:49 pm, Raja Pullela wrote: > > Hi, > > JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843 > Can someone please pick up this ticket ? This is failing a bunch of the BVTs > tests in Basiczone. > > Thanks, > Raja

VPC router issue

2015-09-15 Thread Wilder Rodrigues
Hi all, This morning I shared a message on our Slack channel about the current issue I’m facing with VPC routers. The problem was caught by the test_vpc_routers.py tests, which are unable to verify the following: * Create a VPC with 2 Tiers, 3 VMs, 2Pub IPs, and 1 ACL * Stop the VPC router * St

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/828#issuecomment-140370176 @sureshanaparti that sounds good. Thanks for the patch. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/828#issuecomment-140369704 @sateesh-chodapuneedi These changes were successfully tested on Apple hardware. When a VM is created with guest OS as Apple Mac OS, the USB controller (EHCI+U

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

2015-09-15 Thread Wido den Hollander
On 15-09-15 13:56, Dmytro Shevchenko wrote: > Hello Wido, I saw you updated this code again. Maybe you know, what > procedure for rebuilding this library in Apache maven repository? > Because here http://repo.maven.apache.org/maven2/com/ceph/rados/ still > present only old 0.1.4 version and it's

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140368629 and later we see: ![untitled](https://cloud.githubusercontent.com/assets/2486961/9875930/82d5a148-5bb2-11e5-8687-730633f8ff36.png) We now found a po

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140367124 Hi @DaanHoogland, what I don't understand is how travis compiled and 15 days ago @rafaelweingartner said that he forgot to push 1 file. Looking at t

Build failed in Jenkins: build-master-noredist #4653

2015-09-15 Thread jenkins
See Changes: [Boris Schrijver] Replaced all occurences of Charset.forName(UTF-8) with StringUtils.getPreferredCharset(). -- [...truncated 6099 lines...] [debug] execute contextualize

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140366714 @rafaelweingartner do you think "Re-pushing the PR 714" is a good commit header? I mean when someone goes thought the commit list looking for something,

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140366106 @karuturi @remibergsma @rafaelweingartner @DaanHoogland @miguelaferreira Please, before proceeding with this PR see my comments on the previous (#71

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140365763 @wilderrodrigues I commented: "travis timeouts are unrelated. analysis passes, LGTM". So it was compiled otherwise the analysis would not have passed. What I mi

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/825 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/825#issuecomment-140361064 LGTM, thanks @borisroman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-15 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-140360164 @mike-tutkowski @DaanHoogland @karuturi @miguelaferreira @rafaelweingartner @pedro-martins First of all let me just get one thing clear: Rafael ment

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/792#issuecomment-140359521 one remark, lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/792#discussion_r39499607 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -3407,6 +3390,18 @@ public void h

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/828#issuecomment-140357559 LGTM. Can you please share more details on testing you have performed? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39498765 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39498419 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39498281 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-15 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39498235 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade453to460.java --- @@ -30,12 +30,12 @@ import com.cloud.utils.exception.CloudRuntimeException

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39497595 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-15 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39497551 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade453to460.java --- @@ -30,12 +30,12 @@ import com.cloud.utils.exception.CloudRuntimeExcep

[GitHub] cloudstack pull request: CLOUDSTACK-8858: listVolumes API fails fo...

2015-09-15 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/830 CLOUDSTACK-8858: listVolumes API fails for a particular domain with NPE. CLOUDSTACK-8858: listVolumes API fails for a particular domain with NPE. Summary: listVolumes API fails wh

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-15 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/829 CLOUDSTACK-8848: extra state to handle; no power report from host there no no real handling code now so this can be regarded as a DISCUSS item. It may well be an improvement over existing c

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-15 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/828 CLOUDSTACK-8854: Apple Mac OS/X VM get created without USB controller in ESXi hypervisors CLOUDSTACK-8854: Apple Mac OS/X VM get created without USB controller in ESXi hypervisors

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8849: Usage job should...

2015-09-15 Thread yvsubhash
GitHub user yvsubhash opened a pull request: https://github.com/apache/cloudstack/pull/827 BUG-ID: CLOUDSTACK-8849: Usage job should stop usage generation in ca… …se of any exception You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

2015-09-15 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-140339650 @remibergsma Yes its CLOUDSTACK-8844. It's already syncing the comments in the JIRA issue. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: Replaced all occurences of Charset.forNam...

2015-09-15 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/825#issuecomment-140339356 Travis failed due to a time-out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

  1   2   >