[GitHub] cloudstack pull request: CLOUDSTACK-9200: Fixed failed to delete s...

2015-12-23 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1282 CLOUDSTACK-9200: Fixed failed to delete snapshot if snapshot is stuck in Allocated state without any job associated with it https://issues.apache.org/jira/browse/CLOUDSTACK-9200

Re: Build failed in Jenkins: build-master-slowbuild #2783

2015-12-23 Thread Daan Hoogland
On Wed, Dec 23, 2015 at 7:20 AM, Sateesh Chodapuneedi < sateesh.chodapune...@citrix.com> wrote: > Daan, > Shall fix those listed in following. But unable to logon to > Jenkins.buildacloud.org, can you please help with login? > >

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166866589 Nice !+1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166866569 ![screen shot 2015-12-23 at 4 55 10 pm](https://cloud.githubusercontent.com/assets/95203/11975648/fd36c81e-a995-11e5-9fe9-9e70a25327e5.png) File name

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1249#issuecomment-166871427 @michaelandersen Can you review this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1249#issuecomment-166871327 @mandersen Can you review this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1199#issuecomment-166878523 @remibergsma can you merge these changes? thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1190#issuecomment-166878697 @remibergsma can you please check this commit and merge it in? Thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9091: Update testpath for para...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-166878921 @remibergsma can you please merge this in? Thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Build failed in Jenkins: build-master-slowbuild #2807

2015-12-23 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1041#issuecomment-166879168 LGTM - changes look pretty straightforward. @remibergsma can you please merge this in. Thanks, Raja --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9091: Update testpath for para...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-166879268 @pvr9711 Please make sure we have 2xLGTM of which at least one run the test. Will not merge without. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8996: Reducing Virual Machine ...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1010#issuecomment-166879406 @borisroman , @bhaisaab , this refactoring helps speed up BVT runs by reducing the number of VM deployments. we should get the test results to close on this PR

[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira closed the pull request at: https://github.com/apache/cloudstack/pull/1284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1285#issuecomment-166936459 I've tested this PR manually in our beta environment, however ince there is a marvin test for this functionality I would also like to run that. I haven't

[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1284#issuecomment-166936174 I've tested this PR manually in our beta environment, however ince there is a marvin test for this functionality I would also like to run that. I haven't

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-23 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/1285 Map LDAP group to Cloudstack account The LDAP plugin authenticates Cloudstack users against users in an LDAP group, and when doing so creates a Cloudstack account with the same name as

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

2015-12-23 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-166890582 good, this might also be useful for restartnetwork, see #1198 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166911537 lol @DaanHoogland . +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

2015-12-23 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1274#issuecomment-166910961 Shouldn't we log this information? Doesn't this mean that some resources could be freed up on the hypervisor? --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2015-12-23 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1276#discussion_r48350750 --- Diff: test/integration/smoke/test_vpc_vpn.py --- @@ -468,7 +500,7 @@ def get_ssh_client(self, virtual_machine, services, retries):

[GitHub] cloudstack pull request: CLOUDSTACK-9200: Fixed failed to delete s...

2015-12-23 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1282#issuecomment-166910265 How do you know if there are no jobs associated with it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166934017 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/1284 Map ldap group to Cloudstack account The LDAP plugin authenticates Cloudstack users against users in an LDAP group, and when doing so creates a Cloudstack account with the same name as

Build failed in Jenkins: build-master-slowbuild #2808

2015-12-23 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1284#issuecomment-166936278 Closing as this should have been directed at 4.7 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166955980 Works for me. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Build failed in Jenkins: build-master-slowbuild #2809

2015-12-23 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Build failed in Jenkins: build-master-slowbuild #2811

2015-12-23 Thread jenkins
See -- [...truncated 28732 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Build failed in Jenkins: build-master-slowbuild #2812

2015-12-23 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: Protocol to add scripts to a newer version of ACS

2015-12-23 Thread Rafael Weingärtner
Thanks Remi, I will use it in a PR that I am working on. BTW: I have read a few articles (software engineering baseline management of database objects) and searched for some tool to help us with ACS “schema” scripts to update the database during ACS updates. I am drafting a model that we can use

[GitHub] cloudstack pull request: CLOUDSTACK-9200: Fixed failed to delete s...

2015-12-23 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1282#issuecomment-167040721 @pdube Snapshot can be in Allocated state for a split second only in normal scenarios. If it is in Allocated state for more than that time, then it simply means

[GitHub] cloudstack pull request: CLOUDSTACK-9161: fix the quota marvin tes...

2015-12-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1240#issuecomment-167042039 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

2015-12-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-167041889 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

2015-12-23 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1274#issuecomment-167040113 @pdube That part is handled elsewhere. Here we are concerned about syncing of VM metadata. So here if the VM is not in cloud DB then we are ignoring it. --- If

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166980994 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2015-12-23 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1276#discussion_r48382355 --- Diff: test/integration/smoke/test_vpc_vpn.py --- @@ -468,7 +500,7 @@ def get_ssh_client(self, virtual_machine, services, retries):

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-166987980 @nitin-maharana, thanks for the update, I will just call your attention to a few points: First of all, why did you open a new PR? I know you

Build failed in Jenkins: build-master-slowbuild #2810

2015-12-23 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

2015-12-23 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167045587 @anshul1886 If the fix was added in 4.2, why it got missed out? Can you check the history and update? --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

2015-12-23 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167046667 @koushik-das It was merged to 4.2-forward but was not merged to master. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-23 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1285#issuecomment-167044637 @miguelaferreira Looks like this PR is going to impact the feature https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP%3A+Trust+AD+and+Auto+Import that

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

2015-12-23 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1261#issuecomment-167047897 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Build failed in Jenkins: build-master-slowbuild #2813

2015-12-23 Thread jenkins
See Changes: [Rohit Yadav] README: happy holidays! -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO]

[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...

2015-12-23 Thread priyankparihar
Github user priyankparihar closed the pull request at: https://github.com/apache/cloudstack/pull/1207 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1000#issuecomment-166879646 @remibergsma can you please merge this in? thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-166879847 @remibergsma can you please merge this in? thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/869#issuecomment-166880339 @runseb, this cannot be run via simulator. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/384#issuecomment-166880792 @remibergsma can you please comment on this PR, if it was merged ? thanks, --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-166881123 @koushik-das Github cannot display large diffs. This is how you can show it on your local checkout: ``` prId=1277 git checkout master git

[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1279#issuecomment-166883594 @bhaisaab Thanks, makes sense. Will test an upgrade and report back. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2015-12-23 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-166884395 @remibergsma What you are suggesting is to pull the commit locally and then view it using git show. But then we are loosing the benefit of viewing and in-place

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/384#issuecomment-166888535 It was not merged, see also #720. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/869#issuecomment-166888961 @pvr9711 Where is your LGTM based on? I'd like to see some background, as otherwise we don't know what you tested / reviewed. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

2015-12-23 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1283 CLOUDSTACK-4572: findHostsForMigration API does not return correct host list https://issues.apache.org/jira/browse/CLOUDSTACK-4572 Fix is missing in recent releases. The

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-23 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-166835953 Hi @sanju1010, @wilderrodrigues asked me to extend the test_vpc_vpn script and in the proces i added the other hypervisors.

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166836536 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread NuxRo
Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166837966 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

2015-12-23 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-166838925 @DaanHoogland Added a test to verify if the routers are getting updated one after the other. Test create network with redundant routers ... ===

Build failed in Jenkins: build-master-slowbuild #2806

2015-12-23 Thread jenkins
See -- [...truncated 28722 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1281 README: happy holidays! Happy holidays, let's merge this asap cc @remibergsma @DaanHoogland @wido @wilderrodrigues @abhinandanprateek @jburwell @borisroman @miguelaferreira @runseb

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread pyr
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166830690 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-23 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-166830953 Sure @koushik-das. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166833276 :+1: Happy holidays! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166833361 sure ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this