Github user michaelandersen commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48382355
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -468,7 +500,7 @@ def get_ssh_client(self, virtual_machine, services,
retries):
return ssh_client
- def create_natrule(self, vpc, vm, public_port, private_port,
public_ip, network, services=None):
+ def _create_natrule(self, vpc, vm, public_port, private_port,
public_ip, network, services=None):
--- End diff --
a matter of style i guess, i consistently changed private methods/non-tests
to be prefixed with an underscore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
