Re: Issue with VR after upgrade to 4.6.2

This means that (at least) one of the commands that are sent takes a much longer time than expected. At least it works now. Jayapal refers to the management server logs. The reason might be in there, or else in the cloud.log on the router. Regards, Remi Sent from my iPhone > On 28 Jan 2016

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-176011491 @jayapalu The test may pass, but my manual (scripted cloudmonkey) test doesn't so we need to figure out what goes wrong. See my comments above. --- If your proj

Re: Issue with VR after upgrade to 4.6.2

Jaqyapal, Can you please gimme heads up what is MS ? setting router.aggregation.command.each.timeout=60 solved issue. Hi Daniel, Please share the MS logs when the VR is going down. I want to check,  Is MS bringing down the VR ?  or VR is getting rebooted itself. Thanks, Jaqyapal On 28-Jan-2

Re: Issue with VR after upgrade to 4.6.2

Increased settings to 60. Got VR(s) up and running. Interesting. Hi Daniel, Can you please bump that setting to 15 or 20 and restart mgt server? Then start the router again. Let me know! Regards, Remi Sent from my iPhone On 28 Jan 2016, at 07:00, Daniel Mezentsev wrote: Hi Remi, Setup

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-176010507 @wido yes it was fixed. The problem was the newlines in the pattern to search for. I had not taken that in account for in the unit test. We are about to put th

Re: Issue with VR after upgrade to 4.6.2

Hi Daniel, Please share the MS logs when the VR is going down. I want to check, Is MS bringing down the VR ? or VR is getting rebooted itself. Thanks, Jaqyapal > On 28-Jan-2016, at 5:47 pm, Daniel Mezentsev wrote: > > Hi Remi, > > I just upgraded 4.6.2->4.7.1 The same issue, unable to start

Re: Issue with VR after upgrade to 4.6.2

Hi Daniel, Can you please bump that setting to 15 or 20 and restart mgt server? Then start the router again. Let me know! Regards, Remi Sent from my iPhone > On 28 Jan 2016, at 07:00, Daniel Mezentsev wrote: > > Hi Remi, > > Setup is the following > Cloudstack 4.7.1 > One cluster of XenSe

Build failed in Jenkins: build-master-slowbuild #3093

See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: Issue with VR after upgrade to 4.6.2

Hi Remi, Setup is the following Cloudstack 4.7.1 One cluster of XenServers (6.2) - 4 hosts Advanced network That 2 routers i have problems with are just DNS and DHCP providers, they are not actibe as default gateway for VMs, there are ~10-12 VMs. router.aggregation.command.each.timeout=3 Hi D

Re: Issue with VR after upgrade to 4.6.2

Hi Daniel, At what value is router.aggregation.command.each.timeout global setting? Can you tell a bit about your setup, what the router does (config) as in how many VMs, tiers, public IPs etc. Regards, Remi Sent from my iPhone > On 28 Jan 2016, at 05:18, Daniel Mezentsev wrote: > > Hi Re

Re: [PROPOSAL] Freeze everything until we get CI

Hi, I agree with Remi on the hurdles he mentioned. It is difficult to integrate 3rd party CI, If someone wants to implement their own CI, the link below gives one way to do it. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integr

Re: Issue with VR after upgrade to 4.6.2

Hi Remi, I just upgraded 4.6.2->4.7.1 The same issue, unable to start 2 VRs (out of 8 total). VR actually is started, running for 5-7 minutes, then shuting down. One thing that i noticed in the log: arping -c 1 -I eth0 -A -U -s 10.1.12.1 None What is "None" here ? Please let me know what info

[GitHub] cloudstack pull request: CLOUDSTACK-9208: Assertion Error in VM_PO...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1307#issuecomment-175963626 @bhaisaab I am still not very confident if we can remove sending stop command to when VM is in the the poweroff state (on host) and stopped state (in DB). But as @Da

Re: [PROPOSE] Dynamic inter VPC routing

HI PL, I setup two VPCs with multiple tiers and ip as per the existing addressing scheme provided by cloudstack. With Quagga on Vrs, setup zebra and ospf conf to publish the routes behind the routers. I did have to make iptable rule changes to make the LSA from quagga to work. With updated ip

Build failed in Jenkins: build-master-slowbuild #3092

See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175931632 This code that was suggested: private AccountVO createAccountVoForType(short type) { AccountVO accountVO = new AccountVO(); accoun

Build failed in Jenkins: build-master-slowbuild #3091

See -- [...truncated 28685 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: [PROPOSE] Dynamic inter VPC routing

Hi Abhinandan, I'm actually looking at how to perform routing between VPC, but in our case we still need the public interface of the VPC as it is right now. Improvement such as BGP for various public route would be helpfull. But, when it come to internal traffic between VPCs, there is 2 way that

Re: Quick note about $dayjob

good luck! Thanks a lot for your work for community and help on us. -Wei 2016年1月26日星期二，Sebastien Goasguen 写道： > Hi folks, > > As some of you might have guessed I am changing $dayjob. > > This is an exciting time for me, but it also means that I will become less > involved with CloudStack. ( I

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1342#issuecomment-175894714 add (GB) to the label. Please test it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

Re: New release manager wanted

Thanks a lot for your hard work, Remi ! 2016-01-27 14:08 GMT+01:00 Remi Bergsma : > Hi all, > > > After picking up the RM role last summer, I've had an interesting ride > with awesome results. First the release principles [1], then stabilizing > master and finally 3 releases in a row: 4.6 in No

Re: New release manager wanted

Totally agree. -Wei 2016-01-27 19:18 GMT+01:00 Wilder Rodrigues : > Thanks for ll the hard work and support, Remi! We worked quite some > weekends testing PRs in order to get them merged properly, following the > guidelines: 2 LGTM (1 being code review; 1 being integration tests) > > I hope that

Re: disable github notifications ?

Agree. Can we move to issues mailing list or create a new mailing list ? I am interested in the github PRs and comments. -Wei 2016-01-27 15:59 GMT+01:00 sebgoa : > Hi folks, > > Shall we disable github notifications to dev@ ? > > It has become quite noisy. > > On the other end you see all th

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Congrats and welcome, Boris. > [ShapeBlue] John Burwell ShapeBlue d: +44 (20) 3603 0542 | s: +1 (571) 403-2411 e: john.burw...@shapeblue.com | t: | w: www.shapeblue.com

Re: [DISCUSSION] Collab for Spring 2016

All, +1 to a collab in Montreal. I like the idea of 2-3 days of coding organized as a series of birds-of-feather type sessions. People post features/enhancements/topics of interest for a particular area, and those that are interested join them to hack through it. No slides to prepare, no passiv

Re: Quick note about $dayjob

Sebastian, Thank you for your years of dedication and leadership. Best of luck with the new company — may many unicorns be in your future. Thanks, -John > [ShapeBlue] John Burwell ShapeBlue d: +44 (20) 3603 0542 | s: +1 (571) 403-2411 e: john.burw...@sha

Re: disable github notifications ?

All, +1 to keeping the notifications coming to dev@ as it is the hub and record of all project development activity. A simple mail filter helps me sort out the notification traffic from general conversation. My filters send any message containing my username (@jburwell) directly to my inbox — f

Re: [PROPOSAL] Freeze everything until we get CI

On 01/27/2016 10:02 PM, Remi Bergsma wrote: > Hi all, > > We should keep the simple approach that was used until now: one LGTM based on > code review and one LGTM based on integration tests (that’s not the same as > 2xLGTM). > > If we care about master stability, every change has to be tested

Build failed in Jenkins: build-master-slowbuild #3090

See -- [...truncated 28675 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: [PROPOSAL] Freeze everything until we get CI

This won’t fly, you will get no hook approved. Instead, simply poll the Github API every x minutes for new PRs and then start your test. Regards, Remi On 27/01/16 21:59, "Rafael Weingärtner" wrote: >Because that would require manual work (reporting back the results), maybe >if we figure ou

Re: [PROPOSAL] Freeze everything until we get CI

Hi all, We should keep the simple approach that was used until now: one LGTM based on code review and one LGTM based on integration tests (that’s not the same as 2xLGTM). If we care about master stability, every change has to be tested for regression. Period. Things may look OK, but still brea

Re: [PROPOSAL] Freeze everything until we get CI

Because that would require manual work (reporting back the results), maybe if we figure out some way to dispatch the request to run tests with a PR against an environment. If we had a repository in which developers could register their environment to receive requests to run tests on a given PR, an

[GitHub] cloudstack pull request: CID-1338387: Deletion of method endPointS...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1124#issuecomment-175849683 @bhaisaab rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/1103#issuecomment-175848696 Thanks for the reminder Rohit. I will update this PR accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [PROPOSAL] Freeze everything until we get CI

> On Jan 27, 2016, at 9:42 PM, Rafael Weingärtner > wrote: > > +1 Sebastian, > I would ask the same as Wilder, why the rush to merge those PRs without > actual test and reviews (some LGTMs there I would not count)? They did not > seem to be that important. > > I believe that the idea to run PR

Re: [PROPOSAL] Freeze everything until we get CI

+1 Sebastian, I would ask the same as Wilder, why the rush to merge those PRs without actual test and reviews (some LGTMs there I would not count)? They did not seem to be that important. I believe that the idea to run PRs totally distributed in everyone’s environments would not be feasible today.

Re: [PROPOSAL] Freeze everything until we get CI

> On Jan 27, 2016, at 9:25 PM, Wido den Hollander wrote: > > > > On 01/27/2016 09:18 PM, Sebastien Goasguen wrote: >> Folks, >> >> How about we freeze our repo entirely until we get proper CI in place. >> >> Seems to me all the hard work from Remi and co could be lost if we start >> committ

Re: [PROPOSAL] Freeze everything until we get CI

+1 , Sebastien! From the last 12 PRs that were merged, only 2 had integration tests executed against. I don’t understand why the rush to merge things that were not properly tested. It already looks like a broken master and 4 votes to get 1 release through every 9 months. I should not make such

Re: [PROPOSAL] Freeze everything until we get CI

On 01/27/2016 09:18 PM, Sebastien Goasguen wrote: > Folks, > > How about we freeze our repo entirely until we get proper CI in place. > > Seems to me all the hard work from Remi and co could be lost if we start > committing again. > > Now Travis is not running, Jenkins fails all the time and

[PROPOSAL] Freeze everything until we get CI

Folks, How about we freeze our repo entirely until we get proper CI in place. Seems to me all the hard work from Remi and co could be lost if we start committing again. Now Travis is not running, Jenkins fails all the time and nobody cares… So how about we figure out CI now ? and not do anythi

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1274#issuecomment-175834162 @bhaisaab @pdube @DaanHoogland @koushik-das lots of LGTM here , so great. but we don't know why you LGTM'd and as far as I know no tests were run... --- If your pro

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-175833323 Folks, I did not have time to fully test the new merging process from @DaanHoogland and @remibergsma but let's assume this is good to merge should this really be mer

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-175824842 @DaanHoogland Have you been able to fix this? Code-wise it still seems good. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-175826191 Can we rebase against master (4.9)? Seems that this one is ready to merge --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-175825330 Code looks good, but I have no way of testing this since I don't have Swift... --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51040901 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path) {

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51040823 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path) {

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51040885 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path) {

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-175824353 Looks good at first, but I would like to see some UnitTests around methods. I'll comment on those inline. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51040863 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path) {

Re: disable github notifications ?

definitely, looking into it, the jenkins email are very noisy. > On Jan 27, 2016, at 8:51 PM, Nux! wrote: > > Actually it seems like we have a special mailing list (that nobody uses > probably) for git notifications - commits@ ... > http://cloudstack.apache.org/mailing-lists.html > > While I

Re: disable github notifications ?

Actually it seems like we have a special mailing list (that nobody uses probably) for git notifications - commits@ ... http://cloudstack.apache.org/mailing-lists.html While I agree filtering is the trivial solution, I wonder whether we should decide to use that ML instead or not. Lucian -- Sen

Re: disable github notifications ?

Agreed...we can use filters, if we'd like. On Wednesday, January 27, 2016, Sebastien Goasguen wrote: > Ok seems to be pretty good and quick ~consensus here, so we will leave it > as is. > > I agree that filters can be set. > > and in the spirit of adopting github but staying a ASF project, we sh

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175816413 I disagree that it would make the code more complex. That is what I meant: ``` private AccountVO createAccountVoForType(short type) {

[RESULT] disable github notifications ?

Ok seems to be pretty good and quick ~consensus here, so we will leave it as is. I agree that filters can be set. and in the spirit of adopting github but staying a ASF project, we should archive all our PR discussions on the list. so let’s not do anything then. -sebastien > On Jan 27, 2016,

Re: New release manager wanted

Thanks a lot for your work Remi, it has been a great run and the quality of ACS is the highest it has ever been. It was an excellent year with you as RM and Sebastien as VP, let's hope we can continue to live up to this standard. And let's keep master stable, of course! :) Lucian -- Sent from

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1261#issuecomment-175782752 @bhaisaab Why merge without running integration tests? How do we know this doesn't break anything else? --- If your project is set up for it, you can reply to

Re: New release manager wanted

Thanks for ll the hard work and support, Remi! We worked quite some weekends testing PRs in order to get them merged properly, following the guidelines: 2 LGTM (1 being code review; 1 being integration tests) I hope that the same principle will now be taken as a standard. Thanks again! Cheers,

Build failed in Jenkins: build-master-slowbuild #3089

See Changes: [sureshkumar.anaparti] CLOUDSTACK-8858: listVolumes API fails for a particular domain with NPE. [venkatasubhashnaidu.yedugundla] CLOUDSTACK-8850: revertSnapshot command does not work Updating the [venkatasub

Re: disable github notifications ?

+1 what Remi said. Disabling the notifications would be a pretty large hammer. I'll get in touch with Rene and try to help him out. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Remi Bergsma" > To: dev@cloudstack.apache.org > Sent:

Re: disable github notifications ?

I do not see any problem with the emails. I use filters to send the emails from @devcloudstack to a folder. I actually find them useful, most time when I review a PR, I look for PRs in the emails that GH has sent to the @dev. On Wed, Jan 27, 2016 at 4:00 PM, Daan Hoogland wrote: > I'm with Remi

Re: disable github notifications ?

I'm with Remi on this Biligual auto correct use. Read at your own risico Op 27 jan. 2016 5:15 PM schreef "Remi Bergsma" : > I say we keep the notifications. GitHub is about development and this is > the dev list, right? It really helps keeping track of what is going on. > It's way faster than cl

RE: Quick note about $dayjob

All the best Seb – I hope we’re still seeing you in London in March? Steve Roles From: Giles Sirett [mailto:giles.sir...@shapeblue.com] Sent: 27 January 2016 14:59 To: market...@cloudstack.apache.org; dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: RE: Quick note about $dayjob

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-175751878 @ProjectMoon The code is better now, well documented and with tests. LGTM. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: Add47xmessagesproperties transifex

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1098#issuecomment-175750935 Thanks @milamberspace --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack pull request: Add47xmessagesproperties transifex

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1098#issuecomment-175740240 @bhaisaab see PR #1374 #1375 and #1376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: Add47xmessagesproperties transifex

Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/1098 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cloudstack pull request: L10n update master 20160127

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1376 L10n update master 20160127 cc @remibergsma @bhaisaab @DaanHoogland You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace

[GitHub] cloudstack pull request: L10n update 4.8 20160127

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1375 L10n update 4.8 20160127 cc @remibergsma @bhaisaab @DaanHoogland You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1374 Update L10N resource files with 4.7 strings from Transifex (20160127) cc @remibergsma @bhaisaab @DaanHoogland You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-175727599 License has been added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1370#discussion_r51006290 --- Diff: engine/api/pom.xml --- @@ -38,7 +38,7 @@ org.apache.cxf cxf-bundle-jaxrs - 2.7.13 + 2.7.18

Re: disable github notifications ?

I say we keep the notifications. GitHub is about development and this is the dev list, right? It really helps keeping track of what is going on. It's way faster than clicking all PRs in GitHub IMHO. Any email client since the 1990s can do mail filtering so if it's too much, simply filter it to

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-175705151 I don't have the close button, so this one needs to be closed again. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user agneya2001 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1350#discussion_r51006727 --- Diff: framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java --- @@ -197,4 +197,58 @@ public void testProcessQuotaBalanceForAc

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1372#issuecomment-175716111 @ProjectMoon :) Github need to fix this, really annoying --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1350#discussion_r51005837 --- Diff: framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java --- @@ -197,4 +197,58 @@ public void testProcessQuotaBalanceForAcco

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1370#discussion_r51005339 --- Diff: engine/api/pom.xml --- @@ -38,7 +38,7 @@ org.apache.cxf cxf-bundle-jaxrs - 2.7.13 + 2.7.1

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1373 Fixes regarding VOLUME_DELETE events resulting from account deletion. New version of #924, but on the right branch with the commits squashed. Original pull request: Fixes regard

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175712977 @cristofolini your changes are incorporated can you review these. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1372 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1372#issuecomment-175712011 Yes.. wrong branch again. GitHub's cross-fork interface tends to be a bit confusing for me due to how it loads when you change repos. Attempt #3 coming up. --

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1372 Fixes regarding VOLUME_DELETE events resulting from account deletion. New version of #924, but on the right branch with the commits squashed. **Original pull request:** Fixes re

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1372#issuecomment-175706330 Which file is missing the license? Still don't see that in the Jenkins build. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175710627 @rafaelweingartner @bhaisaab I have taken out the duplicate account initialisation. --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1372#issuecomment-175710489 @ProjectMoon do you want to merge this only on master or since 4.6/4.7? Check the target branch of the PR. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-175708872 @nnesic since you're the author you can close this PR @ProjectMoon thanks for the new PR --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175708121 @agneya2001 how about you have a look at the test tomorrow and see if you can incorporate some of the suggestions like pull out the account from the method as a cl

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-175704775 New request is located at https://github.com/apache/cloudstack/pull/1372. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175702905 @bhaisaab I think the test cases in different methods, each one for a single and unit test is the right way to go. What I disagree is with the cre

RE: disable github notifications ?

Ok If people agree that the noise if a pain in the a** (which it is) - then I'd be +1 I guess, most active developers will be viewing GH daily anyway and my use-case is probably unusual (dev@ lurker) As Paul just said, maybe send them somewhere else so we have an "apache record" Kind Regard

Re: disable github notifications ?

One argument for that was that since github comments are relayed to dev@ any discussion in the comments also occur on dev@. If we stop that, we should also stop commenting discussion material on github imho. Erik Den onsdag 27. januar 2016 skrev Giles Sirett følgende: > Is there any other way

RE: disable github notifications ?

I have an outlook rule so that [jira] and [github] go into a separate folder - I kept missing so much otherwise. A separate mailing list for notifications could work ? Paul Angus VP Technology , ShapeBlue t: @cloudyangus e: paul.an...@shapeblue.com

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-175693496 @rafaelweingartner fair points, but it would make sense if you can comment on the diff in the context of the change. Specific to the PR I see several testX

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-175690879 LGTM, has anyone tested this other than the author? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-175692009 @ProjectMoon yes please squash them and maybe open a new PR against 4.7 (or 4.6) closing this one as github won't allow you to edit/change the source/dest branches.

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1274#issuecomment-175688521 LGTM, merging based on comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1342#issuecomment-175691303 @ustcweizhou please add the "GB" label after the string, then we can merge this. Thanks. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1342#issuecomment-175691008 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1261#issuecomment-175688349 LGTM, dead code remove nice :) Merging based on 2+LGTMs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

  1   2   3   >