[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1652 There should be only one default VPC offering, unless I am missing out something obvious :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 Also since the automated test coverage of this area is less, changes should be made after taking into account all possible scenarios. Otherwise there might be regressions in some valid

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 @jburwell The issue that has been reported is on a custom branch, probably @marcaurele needs to cherry-pick some additional commits from ACS. Master/4.9 doesn't have this issue, so in that

[GitHub] cloudstack pull request #1654: Updating pom.xml version numbers for release ...

GitHub user jburwell opened a pull request: https://github.com/apache/cloudstack/pull/1654 Updating pom.xml version numbers for release 4.8.2.0-SNAPSHOT Adopt the new four position version number for the 4.8.2.0 release. Signed-off-by: John Burwell

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1606 @kiwiflyer are there Marvin tests that verify this behavior? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1623 If possible, I would like to get this fix into 4.8.2.0/4.9.1.0, but I will be cutting the RC shortly. @ProjectMoon could you please amend your commit message to include the JIRA

[GitHub] cloudstack issue #1635: CLOUDSTACK-9451

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1635 @nathanejohnson please amend your commit message to explain the change(s) made and their motivation? --- If your project is set up for it, you can reply to this email and have your reply

Re: Compilation error "Execution cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check failed"

Hi Rohit, thank you! I am using the main master branch. I have all the latest files. I am having this problem only since last few weeks, earlier my build was running fine.I tried this and I still have the same problem. I will will install nonoss deps and try again, meanwhile, following

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1624 @ProjectMoon I would like to get this PR merged for the 4.8.2.0 release, but I need to cut an RC ASAP. Will it be possible for you to address the PR comments in time? --- If your project is

[GitHub] cloudstack issue #1591: Updating Alert codes

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1591 I would like to get this PR merged as part of the 4.8.2.0 release, but we don't have much time to get it completed. @dcarbone could you please create a JIRA ticket explaining the

[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1636 @milamberspace the Jenkins build build failed. Could you please force push the change to trigger another attempt? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1407: 4.8.0 fix i18n es

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1407 @ntavares am I correct in understanding that this PR fixes a bug in 4.8? If so, could you please rebase and retarget this PR to the 4.8 branch? The fix will be forward merged to 4.9 and

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1650 We tried macchinina template during test cases on ESX with E1000 adapter and VMs doesn't come with eth0 causing test_internal_lb.py and test_vpc_vpn.py to fail on a real hypervisor test. Has

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 @jburwell The support for passing vGPU parameters is already implemented via PR1310 which has a test case. This PR is only performance optimization by reducing an extra reconfgtask which save

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1650 @abhinandanprateek are these two test suites where we should be using ``vm.instance`` config variable instead specifying the template directly in the test suite? --- If your project is set

[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...

Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1605#discussion_r75796954 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2042,49 +2043,46 @@ protected void

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1605 @nvazquez could you please create Marvin test case to verify the use case in the PR description? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1605#discussion_r75796008 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2042,49 +2043,46 @@ protected void

[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1605#discussion_r75795908 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2042,49 +2043,46 @@ protected void

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @nvazquez could you please squash your commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1593#discussion_r75795653 --- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java --- @@ -72,7 +72,9 @@ protected boolean checkItemCountByPstmt(CheckCase checkCase) throws

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1646 @rhtyd I understand the reasoning for two commits, and it makes sense. Since you understand the process required for the forward merge, I think it makes sense for you to perform it.

[GitHub] cloudstack pull request #1653: Prevent DNS reflection attacks

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1653#discussion_r75794286 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -452,9 +452,9 @@ def fw_vpcrouter(self): self.fw.append(

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1648 @rhtyd thanks for the clarification of the commit message. However, the Travis failed for the commit. Could you please investigate and fix? --- If your project is set up for it, you can

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1643 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1643 Job ID-96 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1645 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1645 Job ID-97 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1635: CLOUDSTACK-9451

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1635 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1635 Job ID-95 --- If your project is set up for it, you can reply to this email

Eliminating Support for Ubuntu 12.04

All, PR 1647 [1] proposes dropping support for Ubuntu 12.04 from 4.9.2.0+. The primary motivation for its removal is that the age of its libvirt and qemu versions greatly complicate maintenance of the KVM integration. However, Ubuntu 12.04 will be supported until April 2017 [2]. What would

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido While I understand that it is quite old and presents maintenance challenges, it remains supported until [April 2017](https://wiki.ubuntu.com/Releases). Therefore, it would be reasonable

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1599 @rhtyd thanks for the expanded commit message. The change makes complete sense to me now. LGTM for code. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @mike-tutkowski determining the required tests to run for a PR is at the top of my TODO list. For now, I would say running all smoke tests and associated component tests on hardware would

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1634 @rhtyd the test results from blueorangutan are looking pretty good. A couple of observations: 1. The markdown for the table seems to be invalid as it is not rendering to a table

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1640 @marcaurele per @koushik-das, what is the issue with re-pointing this PR to the 4.9 release branch? When the PR is merged, it will be forward merged to master. Therefore, the concern you

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1640 @marcaurele I agree that an ``UNKNOWN`` state is proper way to handle a network partition. As an example, out-of-band management uses this approach which the management server loses

[GitHub] cloudstack pull request #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stop...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1640#discussion_r75758946 --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java --- @@ -497,7 +498,7 @@ protected Long restart(final HaWorkVO work) {

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #:

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/commit/db854a35790c77099e9f82a4e2dd77edd5be3eed#commitcomment-18732552 Don't you need to put a space in from of 0 to exclude e.g 100% packet loss ? --- If your project is set up for it, you can

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1653 Trillian test result (trillian-pr1653-36-vmware-55u3-cs49): Test completed. 32 look ok, 20 have errors Test | Result | Time --- | --- | ---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1621 Trillian test result (trillian-pr1621-31-vmware-55u3-cs49): Test completed. 40 look ok, 12 have errors Test | Result | Time --- | --- | ---

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user PaulAngus commented on the issue: https://github.com/apache/cloudstack/pull/1652 Thanks frank, would you make that change to the Nuage Network offering or shall I? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1653 Trillian test result (trillian-pr1653-34-xenserver-65sp1-cs49): Test completed. 41 look ok, 11 have errors Test | Result | Time --- | --- | ---

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1634 Trillian test result (trillian-pr1634-33-vmware-55u3-cs49): Test completed. 39 look ok, 13 have errors Test | Result | Time --- | --- | ---

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

Github user PaulAngus commented on the issue: https://github.com/apache/cloudstack/pull/1651 that works for me. I'll adjust the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Compilation error "Execution cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check failed"

Hi B, how are you building CloudStack? Which branch is it? Can you try a full clean build: mvn clean install -Dnoredist -Dsimulator -P developer,systemvm You may install nonoss dependencies from here: https://github.com/rhtyd/cloudstack-nonoss Regards. From:

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @jburwell I've kept the changes into two commits (1) for pom.xml related version changes and (2) for db upgrade path, as when doing fwd-merging this will cause conflict with other pom files so on

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo can you give me push permission on your repository once again to push the refactoring change, thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1653: Prevent DNS reflection attacks

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1653#discussion_r75715632 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -452,9 +452,9 @@ def fw_vpcrouter(self): self.fw.append(

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo np, I'll help with the refactoring fixes etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user fmaximus commented on the issue: https://github.com/apache/cloudstack/pull/1652 As Nuage plugin developer, I can't come up with any good reason why it should be default. Also I see that Redundant VPC Offering is set to be a default. Both are most likely just copied

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo understood. I am working to get you some assistance. That work for you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Compilation error "Execution cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check failed"

Hi, I am unable to compile latest source due to the following error, please can someone help me with this? [ERROR] Failed to execute goal com.mycila:license-maven-plugin:2.11:check (cloudstack-checklicence) on project cloud-plugin-network-nvp: Execution cloudstack-checklicence of goal

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user NuxRo commented on the issue: https://github.com/apache/cloudstack/pull/1653 @jburwell I am afraid I do not have the coding skills to do what you want re that variable, I am just submitting @ustcweizhou's code from that Jira issue. Right now basic/sg zones are

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo is it possible to create/update a Marvin test case to verify this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request #1653: Prevent DNS reflection attacks

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1653#discussion_r75690054 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -452,9 +452,9 @@ def fw_vpcrouter(self): self.fw.append(

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1646 @rhtyd could you please squash the commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1651 Debian returns: 1 packets transmitted, 1 packets received, 0% packet loss CentOs returns: 1 packets transmitted, 1 received, 0% packet loss, time 4ms Between those 2 we could be

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1645 @wido that seems to be the case, yes.

Re: CCC Brasil

I believe that is the old date. It should probably be updated to TBD. On Aug 22, 2016, at 2:39 AM, Erik Weber > wrote: On the web page, the date is updated to Sept 29-30, is this correct? If so, it should be advertised. -- Erik On Tue, Aug 16,

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1653 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs56sp1, centos7 mgmt + vmware55u3, ubuntu mgmt + kvmcentos7) has been kicked to run smoke tests against packages at

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1653 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1653 Job ID-94 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

Github user PaulAngus commented on the issue: https://github.com/apache/cloudstack/pull/1651 The best way to fix this would be a ping function that gets called. However, that's not something that i can personally do and this will work for (at least) Ubuntu, CentOS/RHEL and

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo thanks, fixed the branch, you may remove my access now :) @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1653 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo okay, can you grant me push access on your fork: https://github.com/NuxRo/cloudstack/tree/patch-4 and I can help fix it for you? --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user NuxRo commented on the issue: https://github.com/apache/cloudstack/pull/1653 Rohit unfortunately I do not have git setup properly, I am limited to what the github interface offers me. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo there are still several commits which have come from master; can you export the commit (git format-patch -1) and reset --hard origin/4.9 and re-apply the commit (git am ) and then git push

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user NuxRo commented on the issue: https://github.com/apache/cloudstack/pull/1653 Done? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user PaulAngus commented on the issue: https://github.com/apache/cloudstack/pull/1652 Without full understanding of the Nuage plugin, fixing the test seemed the safest path, one hopes that the nuage offering was configured that way for a good reason. --- If your project is

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 Thanks @NuxRo can you rebase against latest 4.9, looks like some more commits came in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1630: Add projectid to project details page

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1630 Manually tested, LGTM. We can merge this, the failing Travis tests are not related to the change (which is purely UI). --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user NuxRo commented on the issue: https://github.com/apache/cloudstack/pull/1653 Rohit, done, go right ahead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1643 @abhinandanprateek can you reopen/edit the PR for 4.9? thanks. LGTM. /cc @jburwell @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1634 @rhtyd a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been kicked to run smoke tests against packages at http://packages.shapeblue.com/cloudstack/pr/1634 --- If your

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1634 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido with this change will we have to host two versions of deb repository -- one built on ubuntu without systemd (such as 14.04) and one built on ubuntu with systemd (16.04+)? --- If your

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo if you can change the base-branch of the PR to 4.9, I can initiate some tests on VR/trillian. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate sc...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate script fo...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1649 Test run: python scripts/util/migrate-dynamicroles.py -d -f commands.properties Apache CloudStack Role Permission Migration Tool (c) Apache CloudStack Authors and the ASF, under

[GitHub] cloudstack issue #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate script fo...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1649 This change is limited to the migration script and does not impact CloudStack. Manual tests confirmed the fix works with both new and old commands.properties. --- If your project is set up for

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user NuxRo commented on the issue: https://github.com/apache/cloudstack/pull/1653 I've tested this in Adv zone with Security Groups and it works. Can't vouch for "pure" Adv zones. Perhaps @ustcweizhou can say more. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1648 @jburwell thanks fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1648 LGTM based on code review, the order of cleanup is fixed so that the resources are released in right order. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1648 @rhtyd could you please amend the commit message to explain the defect being fixed? It's hard to review the code without understanding the scope of the problem being addressed. --- If your

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1648 The specific tests run with simulator only, so travis test results should be acceptable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 LGTM, we need to also test for users who connect to VPN on that network (will DNS work for them as well?). --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1621 @rhtyd a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been kicked to run smoke tests against packages at http://packages.shapeblue.com/cloudstack/pr/1621 --- If your

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1621 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1620: oobm: simply change password transactional lo...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1620 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Hiding buttons based on role

Filters on action are already used for vm's. See vmActionfilter in instances.js. Also for the sections I can find a sectionPreFilter in cloudStack.js That seems to check the response of listCapabilities for 'allowusercreateprojects'. Kind Regards, Frank *Frank Maximus * Senior Software

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1593 @karuturi a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests against packages at http://packages.shapeblue.com/cloudstack/pr/1593 --- If your

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1620 Merging based on review and test results above, thanks @blueorangutan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1620 Trillian test result (trillian-pr1638-29-xenserver-65sp1-cs410): Test | Result | Time --- | --- | --- test_DeployVmAntiAffinityGroup_in_project | Success | 282.569

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1620 Trillian test result (trillian-pr1638-29-xenserver-65sp1-cs410): Test completed. 41 look ok, 11 have errors

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1651 @PaulAngus Refer to #1563. In that PR it was mentioned that ping response varies based on OS. So hard coding based on some specific environment is not the right way to fix this. --- If

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1653 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1620 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1620 LGTM on code review, have not tested it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1652 @PaulAngus Shouldn't the product code be fixed instead of the test? If the isDefault property on VPC offerings in not working then that needs to be fixed. I checked the vpc_offerings table

[GitHub] cloudstack pull request #1653: Prevent DNS reflection attacks

GitHub user NuxRo opened a pull request: https://github.com/apache/cloudstack/pull/1653 Prevent DNS reflection attacks At least in SG zones DNS on the VR is publicly accessible and as such susceptible to DNS amplification/reflection attacks. This fixes it as per

  1   2   >