[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-22 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1873 @jayapalu Thanks. Have you made changes for kvm ? I cannot find GetVmIpAddressCommand in plugins/hypervisors/kvm(actually only find it in plugins/hypervisors/xenserver/) --- If your projec

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r102651816 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus status) th

[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...

2017-02-22 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1883 There are no marvin tests available for this. The unique mac address supposed for the two different deployments. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

2017-02-22 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1883#discussion_r102651320 --- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java --- @@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long networkId

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

2017-02-22 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1883#discussion_r102651284 --- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java --- @@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long networkId

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r102650751 --- Diff: plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java --- @@ -436,7

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/927 @serg38 Thanks for filtering the error :) My tests run has been with encryption disabled. I think trillion runs with db encryption enabled. I will check on how I can decrypt the value in tests.

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r102650370 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2073,6 +2089,43 @@ protected StartAnsw

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r102649977 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -703,6 +703,16 @@ private Answer execut

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

2017-02-22 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1883#discussion_r102649918 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -83,9 +83,19 @@ public final static int DEFAULT_AUTOSCALE_POLICY_INTERVA

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-22 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @rafaelweingartner : Regarding that force commit, will surely keep that in mind in future. About keyword documentation, I had gone through several cloudstack apis (E.g. https://cloud

[GitHub] cloudstack issue #1922: CLOUDSTACK-9757: Fixed issue in traffic from additio...

2017-02-22 Thread kishankavala
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/1922 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request #838: CLOUDSTACK-8857 listProjects doesn't return ta...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/838 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #865: CLOUDSTACK-8856 Primary Storage Used(type tag ...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/865 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #838: CLOUDSTACK-8857 listProjects doesn't return tags vmst...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/838 good fix. merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] cloudstack issue #865: CLOUDSTACK-8856 Primary Storage Used(type tag with va...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/865 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/669 @anshul1886 Please address the open questions and rebase. Post the latest test results. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

Re: Jira permission to close outdated/solved tickets

2017-02-22 Thread Daan Hoogland
I should be able to give you karma Rafael, I will have a shot at it later this morning On 22/02/17 23:00, "Rafael Weingärtner" wrote: Thanks. Hahaha, if the current VP does not have karma, who will!? Actually, those were only an example I have found much more than that; I am

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1961 @nvazquez Are you looking at the test failures? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1961 Trillian test result (tid-890) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35724 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-22 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/843 @rhtyd This is basic zone related changes. In the above results failures are not related to the changes. Can you please review the changes once. --- If your project is set up for it,

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

2017-02-22 Thread jayapalu
GitHub user jayapalu reopened a pull request: https://github.com/apache/cloudstack/pull/1922 CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet Acquire ip from additional public subnet and configure nat on that ip. After this pick any from that network and acce

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

2017-02-22 Thread jayapalu
Github user jayapalu closed the pull request at: https://github.com/apache/cloudstack/pull/1922 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...

2017-02-22 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1963 @syed Are you looking to get this into 4.10? If you are not, I have this corrected in a PR scheduled for 4.11. If you are, then I think you're missing a file (SolidFireUtil). --- If you

[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...

2017-02-22 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...

2017-02-22 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/803 CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume Update the volume id in volume_store_

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

2017-02-22 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1962 @syed This LGTM. I wonder, though, if we can only check in the necessary parts (i.e. not the massive rearrangements to the imports)? --- If your project is set up for it, you can reply t

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-22 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @sureshanaparti, Can you have a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/815 Trillian test result (tid-888) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46490 seconds Marvin logs: https://github.com/blueorang

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-02-22 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-02-22 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1867 CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre… …ad if they are failed to cleanup during DeleteSnapshot command You can merge this pull request into a Git reposi

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/815 Trillian test result (tid-889) Environment: xenserver-62sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32992 seconds Marvin logs: https://github.com/blueorang

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1896 @milamberspace Should the merge to master be an empty merge? Meaning is this only for 4.9?? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1896 @rhtyd missed this one. Thanks for reminding. merging now. @milamberspace Thanks for keeping the translations updated for every release :) --- If your project is set up for it, you can re

[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

2017-02-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1841 @sateesh-chodapuneedi can you take a look at the test failures as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1885 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1379: CLOUDSTACK-8324: config drive data set/get sc...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1774 Trillian test result (tid-887) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30347 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-22 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1945 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1212 Trillian test result (tid-884) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35787 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1941 Trillian test result (tid-882) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46340 seconds Marvin logs: https://github.com/blueoran

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

2017-02-22 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1962 CLOUDSTACK-9798 - Resizing root disk fails when using SolidFire This one is easy to reproduce: 1. Create a VM with where the root disk goes to the managed solidfire 2. Stop the VM

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

2017-02-22 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/843 Trillian test result (tid-881) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46234 seconds Marvin logs: https://github.com/blueorang

Re: PRs for 4.10

2017-02-22 Thread Sergey Levitskiy
I would like to get this added https://github.com/apache/cloudstack/pull/1935 On 2/22/17, 2:33 PM, "David Mabry" wrote: I would like to see the following PRs merged: https://github.com/apache/cloudstack/pull/1915 https://github.com/apache/cloudstack/pull/1954 <- This one could

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

2017-02-22 Thread leprechau
Github user leprechau commented on the issue: https://github.com/apache/cloudstack/pull/1606 What's the current status of this PR? Is this acceptable as is? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: PRs for 4.10

2017-02-22 Thread David Mabry
I would like to see the following PRs merged: https://github.com/apache/cloudstack/pull/1915 https://github.com/apache/cloudstack/pull/1954 <- This one could be backported to 4.8/4.9 Collectively, these solve an issue that causes the VPC router to fail due to a full /var/log FS. We’ve tested t

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

2017-02-22 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1962 @mike-tutkowski This happens when you don't specify IOPS in the service offering for the VM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

Re: Jira permission to close outdated/solved tickets

2017-02-22 Thread Will Stevens
Awesome, thank you sir. *Will STEVENS* Lead Developer On Wed, Feb 22, 2017 at 5:00 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Thanks. > Hahaha, if the current VP does not have karma, who will!? > > Actually, those were only an example I have found muc

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1773 Trillian test result (tid-886) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29913 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 @rhtyd Can you please run trillian tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1253 Moved the schema changes to 4920-41000 upgrade path. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 @rhtyd Can you kick off VMware CI on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Jira permission to close outdated/solved tickets

2017-02-22 Thread Rafael Weingärtner
Thanks. Hahaha, if the current VP does not have karma, who will!? Actually, those were only an example I have found much more than that; I am adding them to a list and then I would post it here before closing them once and for all. I could use someone with karma to do the job, but I did not want t

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-22 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1948 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-22 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1948 LGTM from borisstoyanov in a commit comment (acspr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

Re: Jira permission to close outdated/solved tickets

2017-02-22 Thread Will Stevens
I closed them for you. I don't know how the karma or whatever works to give permissions on Jira, but apparently I had enough permissions. :) *Will STEVENS* Lead Developer On Wed, Feb 22, 2017 at 4:49 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > How do

Jira permission to close outdated/solved tickets

2017-02-22 Thread Rafael Weingärtner
How does one get permission to close tickets on Jira? I had some spare time today, and I was navigating through some old open tickets such as https://issues.apache.org/jira/browse/CLOUDSTACK-1805, https://issues.apache.org/jira/browse/CLOUDSTACK-8557, and https://issues.apache.org/jira/browse/CLOU

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

2017-02-22 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1963 CLOUDSTACK-9799 - Unable to create volume from snapshots with "_" in solidfire Steps to reproduce: 1. Create a volume using the SolidFire plugin 2. Take a snpshot of the volume 3.

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

2017-02-22 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1962 CLOUDSTACK-9798 - Resizing root disk fails when using SolidFire This one is easy to reproduce: 1. Create a VM with where the root disk goes to the managed solidfire 2. Stop the VM

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @BlueOrangUtan help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] cloudstack issue #351: This branch implements the CSV and native HA support ...

2017-02-22 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/351 tag:needslove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @BlueOrangUtan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-22 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:needslove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @syed the -cleanup scripts are for removing data that had been migrated, not for temporary tables. also a use case for those may be if things are done partly in the migrate script and partl

[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...

2017-02-22 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1885 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: Attaching more than 14 data volumes to an instance

2017-02-22 Thread Suresh Anaparti
Friðvin, Thanks for the suggestion. I’ll go with the schema update. - Suresh On 21/02/17, 7:02 PM, "Friðvin Logi Oddbjörnsson" wrote: On 18 February 2017 at 20:51:42, Suresh Anaparti ( suresh.anapa...@accelerite.com) wrote: I checked the limits set for VMware hypervisor and o

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

2017-02-22 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1946 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-22 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1944 seen it work in practice: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread marcaurele
Github user marcaurele commented on the issue: https://github.com/apache/cloudstack/pull/1768 @syed I would prefer to move what's inside `schema-481to490-cleanup.sql` to the end of the file `schema-481to490.sql` as it would have been the way of processing during an update from 481 to

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1768 I agree with @DaanHoogland , as @marcaurele mentioned, the only file we need to worry about is `schema-481to490-cleanup.sql` the rest of them are either empty or change the configuration where the

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: PRs for 4.10

2017-02-22 Thread Will Stevens
I would like to get this fix in: https://github.com/apache/cloudstack/pull/1907 This fix is really important because it causes routing issues when the IP, which was not cleaned up, is later used on a different VR. *Will STEVENS* Lead Developer On Wed, Feb 22, 2017 at 5:2

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-22 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1829 @anshul1886 it looks like #672 is closed so that leaves us with #1941 , Are we targeting it for 4.10? If yes, then there are some comments there which you might want to address there. If we do make

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-22 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102556528 --- Diff: server/test/com/cloud/user/DomainManagerImplTest.java --- @@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId() { As

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-22 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1951 @rhtyd If I understand correctly if we add the DB changes in 4.9.2->4.9.3 then after forward merging, upgrade from 4.9.2->4.10.0 should not have any problems with idempotency correct? --- If you

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1903 Trillian test result (tid-883) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33531 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1961 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1961 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1961 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

2017-02-22 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1907 Ok, great. Thanks for the explanation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

2017-02-22 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1907 @rafaelweingartner the only change was to remove the extra gateway verification if it was a 'guest' network because this is now handled by the code in #1871. ``` +guest_gw = s

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1961 @borisstoyanov great, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1961 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1961 Thanks for this fix @nvazquez, I'll kick marvin tests to verify it doesn't brake any other test. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1961 @blueorangurtan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] cloudstack pull request #1961: Fix for test_snapshots.py using nfs2 instead ...

2017-02-22 Thread nvazquez
GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1961 Fix for test_snapshots.py using nfs2 instead of nfs template Fix for marvin test failure introduced in #1847 Cc: @borisstoyanov @rhtyd @karuturi You can merge this pull request into

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102539843 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java --- @@ -584,18 +584,36 @@ public void defFileBasedDisk

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

2017-02-22 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1907 @swill LGTM for the changes. The changes introduced now are different from the last ones, right? Now it is basically the addition of a log and the skipping of a processing flow

[GitHub] cloudstack pull request #1953: CLOUDSTACK-9794: Unable to attach more than 1...

2017-02-22 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1953#discussion_r102539356 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-22 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102536773 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean clean

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1958 Trillian test result (tid-880) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32319 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-22 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102535697 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean clean

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-22 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102534985 --- Diff: server/test/com/cloud/user/DomainManagerImplTest.java --- @@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId() {

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

2017-02-22 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1907 I have squash merged the changes that @ustcweizhou requested. Would you mind reviewing again so we can get this important fix into 4.10. Thanks... @rafaelweingartner, it looks like I los

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-22 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102531132 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean cleanup) {

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-22 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102529801 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean cleanup) {

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-22 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102531047 --- Diff: server/test/com/cloud/user/DomainManagerImplTest.java --- @@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId() { As

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-22 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102530895 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean cleanup) {

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 Trillian test result (tid-878) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32944 seconds Marvin logs: https://github.com/blueoranguta

  1   2   3   >