Re: IP Address Discrepancy with VMware

2018-01-10 Thread Tutkowski, Mike
Thanks, Paul! > On Jan 11, 2018, at 12:49 AM, Paul Angus wrote: > > I'll have a look @ mike > > > > Kind regards, > > Paul Angus > > paul.an...@shapeblue.com > www.shapeblue.com > 53 Chandos Place, Covent Garden, London WC2N 4HSUK > @shapeblue > > > > >

RE: IP Address Discrepancy with VMware

2018-01-10 Thread Paul Angus
I'll have a look @ mike Kind regards, Paul Angus paul.an...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue -Original Message- From: Tutkowski, Mike [mailto:mike.tutkow...@netapp.com] Sent: 11 January 2018 07:31 To:

IP Address Discrepancy with VMware

2018-01-10 Thread Tutkowski, Mike
Hi, While I was running some tests related to 4.11 tonight, I noticed the following discrepancy with regards to the IP address given to a VM of mine: https://imgur.com/3ODXHNe According to CloudStack, the IP address should be 10.117.40.28. However, when I run ifconfig, I get 10.117.40.115.

Re: Which StringUtils to use?

2018-01-10 Thread Ron Wheeler
Certainly better to find the references and remove them if you can get that done in a single effort. Just a technical question: Could one not just add the Warning to the constructor? Might have to create a null (log warning only) constructor. Ron On 10/01/2018 3:58 PM, Daan Hoogland wrote:

Re: Which StringUtils to use?

2018-01-10 Thread Daan Hoogland
We can add log messages to each of the methods in StringUtils but I do not think that is a good way to go. Any method you touch you can reform or remove anyhow. On Wed, Jan 10, 2018 at 9:51 PM, Ron Wheeler wrote: > Agreed about deprecation. > A logged WARNing

Re: Which StringUtils to use?

2018-01-10 Thread Ron Wheeler
Agreed about deprecation. A logged WARNing would be detected during testing as well as at run-time. Ron On 10/01/2018 3:34 PM, Daan Hoogland wrote: Ron, we could but that would only log during compile-time, not on runtime. I am doing some analysis and commenting in Wido's ticket. On Wed, Jan

Re: cloudstack Wikipedia page

2018-01-10 Thread Ron Wheeler
Can someone update the important technical sections  - Key Features, Supported Hypervisors and Bare Metal Hosts. It looks like Cloudstack stopped being worked on in 2012. Can these sections be replaced by a link to the correct CloudStack wiki pages so we do not have to keep updating this info?

Re: Which StringUtils to use?

2018-01-10 Thread Daan Hoogland
Ron, we could but that would only log during compile-time, not on runtime. I am doing some analysis and commenting in Wido's ticket. On Wed, Jan 10, 2018 at 9:23 PM, Ron Wheeler wrote: > Is it possible to mark it as deprecated and have it log a warning when >

Re: Which StringUtils to use?

2018-01-10 Thread Ron Wheeler
Is it possible to mark it as deprecated and have it log a warning when used? Ron On 10/01/2018 2:26 PM, Daan Hoogland wrote: I think we could start with giving it an explicit non standard name like CloudStackLocalStringUtils or something a little shorter. Making sure that we prefer for these

Re: Which StringUtils to use?

2018-01-10 Thread Daan Hoogland
I think we could start with giving it an explicit non standard name like CloudStackLocalStringUtils or something a little shorter. Making sure that we prefer for these types of utils to be imported from other projects. On Wed, Jan 10, 2018 at 4:26 PM, Wido den Hollander wrote: >

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Daan Hoogland
I hope we understand each other correctly: No-one running an earlier version then 4.11 should miss out on any functionality they are using now. So if you use ipv6 and multiple cidrs now it must continue to work with no loss of functionality. see my question below. On Wed, Jan 10, 2018 at 7:06

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Ivan Kudryavtsev
Daan, yes this sounds reasonable, I suppose who would like to fix, could do custom build for himself... But still it should be aknowledged somehow, if you use several cidrs for network, don't use v6, or don't upgrade to 4.11 because things will stop running well. 11 янв. 2018 г. 1:00

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Daan Hoogland
Ivan, I was composing an answer but i think we agree: Only if that functionality worked in the past. ipv6 support is still rather new and must be considered experimental. I think we should fix it in a maintenance release and not block the release for it. If it was working before and broke, it

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Ivan Kudryavtsev
Sorry, to clarify, I mean (if I correctly understand) that if someone has a network with several CIDRs in the basic zone and, lets say, 4.9.3 upgraded to 4.11, which results that VMs stop getting DHCP announces for additional CIDRs from VR, it's a blocker thing... 2018-01-11 0:52 GMT+07:00 Ivan

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Ivan Kudryavtsev
I suppose the bug, reported by Wido prevents adding additional CIDRs to Network if IPv6 configured? If so, it's definitely a blocker thing because everyone expects it's possible, because the function is implemented in ACS. 2018-01-11 0:41 GMT+07:00 Rohit Yadav : > +1

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Rohit Yadav
+1 what Dasn said. Wido - are you seeing (upgrade) failure, or something fails to work without this fix in basic zone? From: Daan Hoogland Sent: Wednesday, January 10, 2018 10:50:22 PM To: dev Cc: Rohit Yadav Subject: Re: [DISCUSS]

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Daan Hoogland
I think that we agreed in th3 past that a blocker is either something that prevents ACS to start or upgrade, or something that breaks prior functionality. On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander wrote: > > > On 01/10/2018 05:47 PM, Rohit Yadav wrote: > >> All, >> >>

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Wido den Hollander
On 01/10/2018 05:47 PM, Rohit Yadav wrote: All, I want to thank all the reviewers, contributors and PR authors for their hard work, support and collaboration. We managed to review, test and merge more than 100 PRs towards the 4.11 milestone! Out of 11 open PRs on Monday, the list is down

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Ivan Kudryavtsev
Congratulations, waiting for RC to do UAT on our dev cloud and switching cloudstack-ui to 4.11 10 янв. 2018 г. 23:48 пользователь "Rohit Yadav" написал: > All, > > > I want to thank all the reviewers, contributors and PR authors for their > hard work, support and

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Rohit Yadav
All, I want to thank all the reviewers, contributors and PR authors for their hard work, support and collaboration. We managed to review, test and merge more than 100 PRs towards the 4.11 milestone! Out of 11 open PRs on Monday, the list is down to 2 now which were recently added features:

Re: Which StringUtils to use?

2018-01-10 Thread Wido den Hollander
On 01/10/2018 01:09 PM, Rafael Weingärtner wrote: Instead of creating a PR for that, we could do the bit by bit job (hopefully one day we finish the job). Every time we see a code using ACS's StringUtils, we check if it can be replaced by Apache's one. Yes, but that will slip from peoples

Re: How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Rafael Weingärtner
You can always use a raw SQL. On Wed, Jan 10, 2018 at 10:45 AM, Ivan Kudryavtsev wrote: > Hmmm, I don't think the math works that way, multiplication and sum are not > same order operations. Right now the only way I found is to fetch all rows > with required fields

Re: How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Marc-Aurèle Brothier
Oups, my bad, very bad actually. I had in mind you had the same speed Mhz You can always run a raw SQL query, there're a lot in the CapacityDao due to the limitation on the mix of functions + group by. On Wed, Jan 10, 2018 at 1:45 PM, Ivan Kudryavtsev wrote: > Hmmm, I

Re: How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Ivan Kudryavtsev
Hmmm, I don't think the math works that way, multiplication and sum are not same order operations. Right now the only way I found is to fetch all rows with required fields from db and do computation in the code, but it doesn't look efficient though. 10 янв. 2018 г. 19:41 пользователь "Marc-Aurèle

Re: How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Marc-Aurèle Brothier
Hmm, yeah that's what I realized after sending the email. With the DAO, you can only apply function on a single column / entity attribute, therefore it won't be possible as you want. Another way to achieve this would be to do SELECT SUM(A), SUM(B) FROM T with the DAO, and on the Java side do the

Re: How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Ivan Kudryavtsev
Hello, Marc-Aurele, thank you for the snippet, but it looks like the sum usage everywhere in the codebase. It's aggregation over single field. What I need is to pass multuplication of two fields (cores x speed) inside the sum, but I don't understand how to do it with dao... Thank you. 10 янв.

Re: How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Marc-Aurèle Brothier
Have a look here: https://github.com/apache/cloudstack/blob/master/engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java#L347 Or you can search other example in the code base with this string "Func.SUM": thttps://

Re: Which StringUtils to use?

2018-01-10 Thread Rafael Weingärtner
Instead of creating a PR for that, we could do the bit by bit job (hopefully one day we finish the job). Every time we see a code using ACS's StringUtils, we check if it can be replaced by Apache's one. On Wed, Jan 10, 2018 at 10:01 AM, Wido den Hollander wrote: > > > On

Re: Which StringUtils to use?

2018-01-10 Thread Wido den Hollander
On 01/10/2018 12:01 PM, Daan Hoogland wrote: I'd say remove as much functionality as we can from 'our' StringUtils and phase them out asap. Yes, but such a PR would be invasive and would be difficult to merge and also break a lot of other code. It's not easy since it will touch a lot,

Re: Which StringUtils to use?

2018-01-10 Thread Rafael Weingärtner
+1 to what Daan's said On Wed, Jan 10, 2018 at 9:01 AM, Daan Hoogland wrote: > I'd say remove as much functionality as we can from 'our' StringUtils and > phase them out asap. > > On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander > wrote: > > > Hi, >

Re: Which StringUtils to use?

2018-01-10 Thread Daan Hoogland
I'd say remove as much functionality as we can from 'our' StringUtils and phase them out asap. On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander wrote: > Hi, > > We have com.cloud.utils.StringUtils which has a few nice functions, but > throughout the code I also see

Which StringUtils to use?

2018-01-10 Thread Wido den Hollander
Hi, We have com.cloud.utils.StringUtils which has a few nice functions, but throughout the code I also see org.apache.commons.lang.StringUtils They both provide about the same functionality, but which one do we prefer? I'd say org.apache.commons.lang.StringUtils as that allows us to remove

Re: Squeeze another PR (#2398) in 4.11 milestone

2018-01-10 Thread Rohit Yadav
Hi all, I think the criteria for any additional PRs to be considered for 4.11.0.0 release should be: - Is it a blocker, especially blocking the release? - Is is fixing any test failures or regressions? - Is it release related, for example - packaging, systemvmtemplate, db-upgrade path

How to achieve SUM (N * M) with ACS DAO

2018-01-10 Thread Ivan Kudryavtsev
Hello, colleagues, please could anyone guide me how to implement aggregation SUM over two fields multiplication? Many thanks in advance. I'm trying to achieve: SELECT SUM(A * B) FROM T with DAO -- With best regards, Ivan Kudryavtsev Bitworks Software, Ltd. Cell: +7-923-414-1515 WWW: