Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402582
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402502
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221220936
rebase, yes. I will keep reformat and functional/technical changes
segragated, however.
funny enough the .../push run is started again this time around
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1530#issuecomment-221211912
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64353975
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -74,8 +79,9 @@ public void parse(byte[] vmdkFileContent
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64353084
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64352201
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221205073
timeouts in the before_script.sh again but I will investigate locally.
@rhtyd do you know why only continuous-integration/travis-ci/pr was run
this time
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-221202570
@swill, do you know what those errors are about? (always a dizzy feeling
when this happens)
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221190865
tnx @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221186203
@rhtyd please re-open this one, if you will.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-221185506
sure tag:easypr LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-221184807
@swill There is a question about enhanced integration testing but no code
supplied so, tag:mergeready
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-221098134
@NuxRo can you test if it is still working for you?
@ustcweizhou can you see if your fixes are still met?
@swill can you reschedule integration tests
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220988239
@NuxRo it means debugging the problem has started. what is in here now is
not much (you can review it)
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220987228
ping @swill tag:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220983955
LGTM though it remains kluncy to some extend I think this is a considerable
improvement over what we had
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223844
--- Diff: client/tomcatconf/db.properties.in ---
@@ -25,6 +25,7 @@ region.id=1
db.cloud.username=@DBUSER@
db.cloud.password=@DBPW
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223758
--- Diff: build/replace.properties ---
@@ -21,6 +21,7 @@ DBROOTPW=
MSLOG=vmops.log
APISERVERLOG=api.log
DBHOST=localhost
+DBPATH
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223544
--- Diff: engine/storage/snapshot/test/resources/db.properties ---
@@ -46,6 +47,8 @@
db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220973201
got the test to run locally with
```
ssh cs0 /data/shared/helper_scripts/cloudstack/build_run_deploy_test.sh -m
/data/git/cs1/cloudstack/setup/dev
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220976080
@nlivens supakoel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220946105
@swill, the test_scale_vm didn't error out because it wasn't run on this
version! I have lost a tiny bit of confidence in our travis runs again. I
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220943511
@swill, i had a nice weekend, thanks. The test that is failing throws a
different kind of exception if I run it on master in my bubble. I have just
pushed a
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64193717
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64179203
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220778699
the message is not in good English, other then that LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64134782
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -123,6 +123,8 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220771292
ping @ustcweizhou , does this suit Leaseweb?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64132615
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -123,6 +123,8 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64132608
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -167,7 +169,7 @@ then
fi
if [ ! -f "$customPrivKey" ]
then
-
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220742798
I might find the time but it is long since I worked with xen. Also I must
find new joy for this hobby. So no promises
---
If your project is set up for it
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220740982
Yes, I'm just not sure it is Travis or the xen plug-in.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-220739198
@swill I think it is genuine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220637398
@swill please see my comment above about the travis failures. BTW why is
there sometimes two travis runs (pr and push) and sometimes only one?
---
If your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64040574
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-220599638
LGTM, do we retest @swill?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220577391
@KrisSterckx yes you can; For instance ping @swill, @rhtyd, @koushik-das,
@remibergsma, @abhinandanprateek, @rafaelweingartner @GabrielBrascher any
reviews
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r64009630
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220529332
theare is two timeouts in the before script again and one exception in a
teardown method of a test.
@swill, are these errors repetible as well? they seem
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63997069
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-220464828
Really like the functionality so I think we must get this in. I have some
remarks about the code that I stand by even though they are not entirely to
blame on
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63961096
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCopyFileInVmCommandWrapper.java
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63960701
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -5402,4 +5402,20 @@ public
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63960622
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1298,6 +1304,27 @@ private static DiskTO
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63959786
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63959351
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63959496
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220458013
thanks @KrisSterckx, and to make it even more very clear: basically you
will only need to install acs and nuage and configure them correctly. neat. you
guys
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63955721
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/NfsImageStoreDriverImpl.java
---
@@ -0,0 +1,30 @@
+package
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220433360
@swill I must have made a booboo spliting the style parts from the test
upgrades. I will look at it over the weekend.
---
If your project is set up for it
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220375273
So @KrisSterckx what are the copile, install, configuration and runtime
dependencies that users of your plugin will encounter? What do they need to buy
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-220301483
@ustcweizhou sorry to burden you again but can you try once more?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220295965
this failed due to a jenkins config error. can you reopen it @nlivens ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-220295771
@ustcweizhou this failed due to an error in the jenkins config. can you
reopen it?
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-220281463
@swill, did this pass the (not so C)I?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63852079
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -429,60 +434,42 @@ private void validateChain(List chain
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63851517
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63851057
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-220275302
apart from some code style and convention things LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r63848658
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParserTest.java
---
@@ -144,7 +152,7 @@ public void
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r63848326
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r63848237
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r63848121
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r63847694
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -1978,11 +1978,16 @@ So if
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220031468
great Nick, can you explain your choosen path for prosterity?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63692269
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -82,7 +82,10 @@ def get_dns(self):
conf = self.cmdline
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63688438
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219996391
I don't know who uses scalevm on xen @wido... @remibergsma, do you guys?
anybosy else?
---
If your project is set up for it, you can reply to this emai
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63683861
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219993865
@swill the GLB code missing is false alarm. I had removed unused code
months ago to get rid of warnings. I am compiling a version without pedantic
formatting
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219974055
@wido the travis problems seem to be in xen functionality. I haven't got a
working xen setup atm. The eror from @swill his run is not specific to th
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219973474
tag:needslove
@swill Looking into @koushik-das remarks I noticed global loadbalancing
code different in this one compared to the previous merge commit
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219971607
@koushik-das most significantly around line 690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219971144
@koushik-das I will look at those two comment, thanks
and no, quite significant changes were done in the NetscalerResource. You
are right that a lot of
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219873858
@NuxRo the problem in @swill his CI run is new to me. The scale vm problem
is xen specific. I'd have to debug it on xen based env. My bubble currently
do
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219841186
@swill I think @ustcweizhou has a point. So at least that one commit
tag:needslove. The rest should pass our regular suite. We can also create a
Marvin
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-219816935
Why would we need this?
https://cloudstack.apache.org/api/apidocs-4.8/root_admin/addGuestOsMapping.html
Ypu can add an guest os to hypervisormapping on
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1521
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219712536
@The-Loeki maybe it makes sense to split the PR, especially on the part
where there is discussion.
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-219653710
I will rebase again, if we do want this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219543063
@swill I just reopened. was there any reason to rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-219499328
no installing the new iso should do it, but wasn't there already another
change that requires a template update?
---
If your project is set up for it
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-219495307
It only changes the iso not the template. So what do you mean @swill it is
part of the run to create a new iso and use it, right?
---
If your project is set
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219409102
@ustcweizhou the integration tests are functional tests. If there is extra
functionality to be tested please provide the test for it. And at least
describe
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63342702
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219300088
@swill can you schedule this one. Would be nice to get in before freeze.
Mine test effort failed (see dev@)
---
If your project is set up for it, you can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219274189
code looks clean. I don't understand all if it yet so I may ask questions
yet. but anaother set of eyes required;
tag:needsreview
---
If your proje
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219273429
started the integration tests on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219255024
@NuxRo, is for vmware as well or only xen?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
101 - 200 of 1880 matches
Mail list logo
