Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219252532
test_01_scale_vm failed again. Any body with the right infra to test this?
@NuxRo ?
---
If your project is set up for it, you can reply to this email and
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219238801
@rhtyd @swill @NuxRo I resolved the conflict. Looks like we want to rerun
integration tests and maybe test the dynamic service offering bit???
---
If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219210863
I am getting rebase conflicts. In a meetup today but will find some time to
resolve conflicts.
---
If your project is set up for it, you can reply to this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219209805
@NuxRo I am running the integration suite on my laptop to see what I can
do. I am not rich on clues so far.
---
If your project is set up for it, you can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-219165095
@swill why not just test against 4.6 and then merge forward? if not, we
need to rebase the branch. Pretty sure @ustcweizhou already did that in-house.
---
If
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-219163616
@syed can you close and reopen to see if the error is persistent?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-219161020
Then log the warning with just the message and add a debug statement with
the stacktrace. logging stacktraces at a level even more strict then INFO does
not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-219158465
@swill you should always count the opinion of the RM as that of a real
memeber of the community ;)
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219157668
LGTM, tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219121539
I like the first two.
The third should read something like:
CLOUDSTACK-8303 allow multiple ranges & finite lease time
the 4th and 5th I really
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219063444
:+1: maybe squash the conflict entries out?
you can rebase -i HEAD^7 and then reorder the commits. If you put the last
one at position 3 and change the
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63188515
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -66,8 +66,13 @@ def is_router(self):
def get_domain(self
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1542#issuecomment-219052329
:) no worries, just expect some review comments to this extend ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219054423
@The-Loeki those don't show in a short listing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219053999
@The-Loeki 6 commits with the same message is not helpful and indeed
confusing. Can you change them to shortly describe the individual fixes, or if
you must
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-219049934
@rhtyd @jburwell @wido @swill Are we not doing this? I see no :-1: but also
no LGTM
---
If your project is set up for it, you can reply to this email and
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1543#issuecomment-218980870
code LGTM. trusting @kiwiflyer I will probably test later but am a bit
stuck today.
---
If your project is set up for it, you can reply to this email and
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1542#issuecomment-218977461
@nvazquez I like the functional description and will probably run through
the code over the weekend but one thing struck me. A lot of this should apply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-218976339
tag:needsreview
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63140242
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +600,205
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-218887457
@swill, given that @ustcweizhou gave his ok on #1535, this one can be
merged.
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-218887203
@ntavares can you close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-218885699
CI RESULTS:
initial fails due to environmental issues all tests passed after rerun:
[1536.results.internal_lb.txt](https://github.com/apache
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-218865225
LGTM with one extra comment: This is adding a much wanted feature and not
worsening the code base we have but some bad patterns are being maintained that
we
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63083577
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +473,123
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63083834
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -289,7 +291,7 @@ public boolean
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63082184
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-218851513
@mike-tutkowski I don't mind ignoring most of the remaining comments I made
except for
- the ones about returning null.
- the renamed exception
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1450#issuecomment-218848727
tag:needsreview
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1491#issuecomment-218848337
so @swill, I may find time to review later. In the meanwhile let's use
tag:needsreview
makes sense?
---
If your project is set up f
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-218847217
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-218843734
@rodrigo93 @GabrielBrascher your comments are valid but warrant PRs on this
PR. please either submit your own PR or provide @ustcweizhou with you desired
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-218841768
I'm an ass but no. I can close and reopen however. should do the trick
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1297
CLOUDSTACK-9203 Implement security group move on updateVM API call
cherry-picked from a exoscale internal fix
Conflicts:
api/src/org/apache/cloudstack/api/command/user
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-218839589
LGTM @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218732878
@marcaurele I don't think it is related to your code either. can you
open/close your pr to see if it works. If not, maybe we need to empty the
je
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1503#issuecomment-218716828
LGTM, always better to have real json handling as opposed to string
parsing. @swill, can you schedule the integration suite on this?
---
If your project is
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1539#discussion_r62995623
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -194,10 +194,7 @@ def setUpClass(cls):
cls._cleanup
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218714480
@rhtyd the issue seems to occur in the prepare script not in the tests:
./tools/travis/before_script.sh
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1538#issuecomment-218713327
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1539#discussion_r62994401
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -194,10 +194,7 @@ def setUpClass(cls):
cls._cleanup
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218712059
@swill, I have to correct myself. The timeout is in the before_script.sh.
This is run several times without problems and then fails in a test set.
In the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-218706540
LGTM did a code walk through and I know of a production install this code
is running in.
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218699576
@rhtyd thanks, looks like @swill is right and this needs more tlc.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1483#discussion_r62985942
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -466,7 +466,7 @@ public boolean deletePrivateGateway(final
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218544251
It was stuck due to another jenkins job running. I am still not sure I saw
what I saw. when I stopped 1252, shortly after 1253 through 1256 finished.
---
If
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218542671
Good point, I am numb to travis timeouts. RM work remnance :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-218540891
Did a review, I have some remarks, some questions as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62892495
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -144,6 +145,8 @@
@Inject
SnapshotDataStoreDao
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62891804
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -209,6 +211,8 @@
@Inject
protected HostDao _hostDao
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62890825
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
---
@@ -692,12
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62890766
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
---
@@ -665,22
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62886608
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -2351,17 +2376,52 @@ public SR
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62886063
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -1792,10 +1796,26 @@ protected
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62885313
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -164,9 +165,12
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62881271
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
---
@@ -554,6 +574,51 @@ protected Void
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62881152
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
---
@@ -554,6 +574,51 @@ protected Void
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62880956
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
---
@@ -134,6 +146,14 @@
EndPointSelector
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62880949
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
---
@@ -134,6 +146,14 @@
EndPointSelector
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62880464
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -289,7 +291,7 @@ public boolean
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62880347
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -347,38 +395,87 @@ private
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62879575
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -347,38 +395,87 @@ private
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62878912
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -72,8 +77,10
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62876283
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +603,221
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62876182
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +603,221
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62876040
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62875666
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +473,123
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62875028
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +254,214
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62874090
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62872442
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62868269
--- Diff: engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java ---
@@ -260,4 +268,41 @@ public boolean remove(Long id
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62867309
--- Diff:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreInfo.java
---
@@ -36,6 +36,7 @@
static final
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-218480720
That is the rat test. it is usually right. I didn't see a new file without
license though. May one of the to with a license starting with an empty comment
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218473575
a timeout @swill. in travis that is not a good indication of not working. I
wouldn't know where to look. @rhtyd can you close and reopen?
---
If your pr
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218472093
@marcaurele instead of force push you can close and reopen after a few
seconds. This usually works as well and seves you switching windows
browser->termi
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218470411
LGTM, @swill, I am being very formal but can you queue this for integration
tests?
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218467871
@swill I closed and reopened. It started building anew but is now stuck in
the archiving phase for quite some time.
```
[INFO
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1385
CLOUDSTACK-9265 cleanup around httpclient versions
some cleanup done
- replaced HttpStatus from org.apache.commons.httpclient with that from
org.apache.http
- removed unthrown
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1385
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1385
CLOUDSTACK-9265 cleanup around httpclient versions
some cleanup done
- replaced HttpStatus from org.apache.commons.httpclient with that from
org.apache.http
- removed unthrown
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1385
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62747336
--- Diff: core/src/com/cloud/agent/api/StartupRoutingCommand.java ---
@@ -35,7 +35,7 @@
long memory;
long dom0MinMemory
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218162701
@swill I am getting to many false positives in my environment to grant it
value, can you schedule this for integration testing?
---
If your project is set up
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-217867940
@ustcweizhou, I suppose it still LGTM to you as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-217867849
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217866994
LGTM based on code, CI pending
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-217856052
@ don't thank me, I just started to check but my infra is based on KVM and
it doesn't support scalevm, so I cannot investigate further
---
If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-217839619
@nuxro I have rebased but did not get to testing. I don't trust the scalevm
problem. It might be in the test, in the test environment or in the actual
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-217839187
@nlivens thanks for the extra test effort you put into this. Can you rename
the marvin test to adhere to python naming standards (i.e. no camal case
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1532#discussion_r62482644
--- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
@@ -942,12 +942,18 @@ public T findOneBy(final SearchCriteria sc
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217829031
@marcaurele @sateesh-chodapuneedi You are both right probably more then I
will ever be so please take with a grain of salt:
```
T result = null
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1532#discussion_r62456988
--- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
@@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-217748908
@swill can we get this in. It's got 2 LGTM and was integration tested on
master and monkey tested on 4.7
---
If your project is set up for it, you can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217723457
would like to see it on 4.7 first otherwise: LGTM code reviewed and tested
CI result:
only the ping outside wolrd failure, which is not due to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1535#issuecomment-217655251
:) the one with the name '4.7'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
201 - 300 of 1880 matches
Mail list logo
