Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/632#issuecomment-125886503
LGTM except one small change suggested.
Please don't mix intended changes and pep8 fixes, you can add another
review request for pep8 fixes subsequ
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/632#discussion_r35739964
--- Diff: test/integration/smoke/test_snapshots.py ---
@@ -123,65 +126,78 @@ def test_01_snapshot_root_disk(self):
#the reqd volume
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-120846548
@runseb Sorry for delayed response, I was away for two weeks.
As said by Sanjeev, the tests were wrongly tagged. required_hardware =
"true" im
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-116523709
Need a second LGTM, anyone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/532#discussion_r8559
--- Diff: test/integration/component/test_ps_domain_limits.py ---
@@ -194,7 +194,7 @@ def setupAccounts(self):
return [FAIL, e
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/532
CLOUDSTACK-8582: Skipping unsuitable test cases for simulator
Modifying tags for test cases which shouldn't be run on simulator (Test
cases requiring download of templates/ISO
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/481#discussion_r33268358
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -115,32 +115,51 @@ def tearDownClass(cls):
raise Exception
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/521
CLOUDSTACK-8582: Modifying tag for test cases which should not be run on
simulator
The test case tries to ssh to router through host and take down the
services. This is not a right
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/519
CLOUDSTACK-8582: Tagging test cases which should not be run on simulator
accordingly
Template and ISO download test cases should not be run on simulator as they
require SSVM and
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/511
CLOUDSTACK-8579: Fix cleanup operation in few test cases
Cleanup list should be declared before returning from setUpClass() so that
tearDownClass() works properly.
Currently the
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/488#discussion_r32909733
--- Diff: test/integration/component/test_stopped_vm.py ---
@@ -53,6 +54,13 @@ def setUpClass(cls):
cls.domain = get_domain
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/480#issuecomment-114025746
Please close this review request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/153#issuecomment-113532279
@DaanHoogland Let's wait for @shwetaag to respond. The patch is not yet
updated after the review comments.
---
If your project is set up for it, yo
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-113487609
Can you please explain why the test case was failing before? Why the
cleanup was failing for volume?
---
If your project is set up for it, you can reply to
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/480#discussion_r32807101
--- Diff: test/integration/testpaths/testpath_vmlc.py ---
@@ -176,6 +176,19 @@ def setUpClass(cls):
cls.zone = get_zone(cls.apiclient
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/458#issuecomment-113099751
:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/465#issuecomment-113095669
LGTM. merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/480#discussion_r32713595
--- Diff: test/integration/testpaths/testpath_vmlc.py ---
@@ -176,6 +176,19 @@ def setUpClass(cls):
cls.zone = get_zone(cls.apiclient
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/481#discussion_r32713393
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -341,4 +339,8 @@ def test_05_storage_snapshots_limits(self
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/458#issuecomment-113091562
This is tested on HyperV and test case skipped successfully.
Test start/stop of router after addition of one guest network ... SKIP: VPC
is not
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/458
CLOUDSTACK-8527: Skipping VPC tests on HyperV
Skipping tests as VPC is not supported on HyperV
You can merge this pull request into a Git repository by running:
$ git pull https
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/391#issuecomment-111963156
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/391#discussion_r32394401
--- Diff: test/integration/component/test_browse_volumes.py ---
@@ -2473,6 +2474,9 @@ def test_11_migrate_upload_volume(self
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/391#discussion_r32393309
--- Diff: test/integration/component/test_browse_volumes.py ---
@@ -2028,6 +2028,10 @@ def test_01_Browser_volume_Life_cycle_tpath(self
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/384#discussion_r32393389
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,516 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/384#discussion_r32393382
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,516 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/384#discussion_r32393368
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,516 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/384#discussion_r32392369
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,516 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/384#discussion_r32392379
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,516 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/384#discussion_r32392375
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,516 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/391#discussion_r32392227
--- Diff: test/integration/component/test_browse_volumes.py ---
@@ -2028,6 +2028,10 @@ def test_01_Browser_volume_Life_cycle_tpath(self
Github user gauravaradhye closed the pull request at:
https://github.com/apache/cloudstack/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/390
CLOUDSTACK-8554: Fixed string conversion issue in few netscaler test cases
Fixed issue "Exception object is directly converted to lower without
converting it to s
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/382#issuecomment-110688107
Looks good, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/377
CLOUDSTACK-8546: Correcting "skip test" code in testpath_vMotion_vmware.py
Removing cls.skipTest which is not a valid way to skip a test case.
Also, instead of skippi
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/376
CLOUDSTACK-8515: Skipping snapshot test cases on HyperV and LXC
Skipping snapshot test cases as they are not supported on HyperV and LXC
You can merge this pull request into a Git
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/360#issuecomment-109868949
Done with review changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/360
CLOUDSTACK-8542: Correcting test case in test_vpc_on_host_maintenance.py
The test in the test suite is checking that when the hosts are in
maintenance state, then VPC created with start
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/359#issuecomment-109216009
Please rebase against latest master. The file looks as new file in the
commit but it's already present in the repo.
---
If your project is set up for it
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/356#issuecomment-109203466
Looks good. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/350
CLOUDSTACK-8515: Skipping snapshots tests on HyperV and LXC hypervisors
Skipping because snapshot feature is not supported on HyperV and LXC.
Also, replaced raise
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/343#issuecomment-108277011
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/343#discussion_r31596502
--- Diff: test/integration/component/test_netscaler_lb_algo.py ---
@@ -76,8 +78,12 @@ def setUpClass(cls):
cls.testdata
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/347
CLOUDSTACK:8515: Skipping snapshot test case for HyperV and LXC
Skipping snapshot test case for HyperV and LXC because snapshot is not
supported on both hypervisors.
You can merge this
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/346
CLOUDSTACK-8534: Fixed import and pep8 issues in
test_redundant_router_upgrades.py
Fixed import and pep8 issues in test_redundant_router_upgrades.py
You can merge this pull request into
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/153#discussion_r31501168
--- Diff: test/integration/component/test_escalations_templates.py ---
@@ -915,3 +968,223 @@ def test_04_copy_template(self
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/153#discussion_r31500922
--- Diff: test/integration/component/test_escalations_templates.py ---
@@ -55,23 +63,68 @@ def setUpClass(cls):
cls.hypervisor
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/153#discussion_r31501000
--- Diff: test/integration/component/test_escalations_templates.py ---
@@ -915,3 +968,223 @@ def test_04_copy_template(self
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/153#discussion_r31500783
--- Diff: test/integration/component/test_escalations_templates.py ---
@@ -915,3 +968,223 @@ def test_04_copy_template(self
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/153#discussion_r31500745
--- Diff: test/integration/component/test_escalations_templates.py ---
@@ -915,3 +968,223 @@ def test_04_copy_template(self
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/153#discussion_r31500546
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -791,6 +791,8 @@
"displaytext": "xs",
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/153#discussion_r31500491
--- Diff: test/integration/component/test_escalations_templates.py ---
@@ -55,23 +63,68 @@ def setUpClass(cls):
cls.hypervisor
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/153#issuecomment-107853053
@terbolous yes I will review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/345
CLOUDSTACK-8521: Improving logging in test case - test_egress_fw_rules.py
Removing unnecessary try catch/self.fail() because it is masking the real
exception.
You can merge this pull
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/268#issuecomment-107824833
This looks good and all review comments have been incorporated. Merging
this.
---
If your project is set up for it, you can reply to this email and have your
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/343#discussion_r31494908
--- Diff: test/integration/component/test_netscaler_lb_algo.py ---
@@ -76,8 +78,12 @@ def setUpClass(cls):
cls.testdata
Github user gauravaradhye closed the pull request at:
https://github.com/apache/cloudstack/pull/327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/327
CLOUDSTACK-8526: Use more memory for VM deployment on HyperV when SSH is
tried to VM
HyperV VMs are GUI based. So if SSH to VM is to be successful, they need at
least 1 GB memory
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/326
CLOUDSTACK-8527: Skipping VPC tests on HyperV
Skipping because VP is not supported on HyperV.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/324
CLOUDSTACK-8515: Skipping snapshot test cases for HyperV and LXC
Skipping because snapshot not supported on HyperV and LXC.
Concurrent Snapshots ... SKIP: Snapshot is not
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/322
CLOUDSTACK-8526: Use more memory for HyperV VMs in case SSH is tried to VM
VMs on HyperV are GUI based. They require at least 1 GB memory if SSH to VM
is to be tested.
Other
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/319
CLOUDSTACK-8518: Fix issues in testpath_disable_enable_zone.py
Changes:
1. Skip snapshot test cases for hyperv and LXC hypervisors
2. Include enable host script in tearDownClass so
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/312#issuecomment-105776689
Looks good, and as discusses with you, this test case has been run and it
is passing now successfully. Merging this review request.
---
If your project is
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/313
CLOUDSTACK-8516: Fixed syntax errors and pep8 issues in
testpath_storage_migration.py
Checked with pep8 and pylint. No issues now.
You can merge this pull request into a Git repository
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/311
CLOUDSTACK-8515: Skip snapshot test cases for HyperV and LXC
Skip because unsupported feature.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/309
CLOUDSTACK-8514: test_haproxy.py - Verifying router state before validating
network rules
The test case test_08_create_policy_router_stopped fails in automation runs
because the router
Github user gauravaradhye closed the pull request at:
https://github.com/apache/cloudstack/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/300
CLOUDSTACK-8445: Keep only dvs tag for test case which tests the VCenter
port groups
The test cases need to be run only on dvs configuration and not on all
advanced configurations. Hence
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/299
CLOUDSTACK-8512: Fixed test script issues in test_escalations_hosts.py
The test script has several issues related to calling base class methods
and retrieving data from database
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/298
CLOUDSTACK-8511: Moved file test_escalations_hosts.py to maint folder
The test suite contains script which disables zone/cluster and enables them
again. This should be present in maint
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/285#discussion_r30964684
--- Diff: test/integration/component/maint/testpath_disable_enable_zone.py
---
@@ -429,71 +380,1093 @@ def test_01_disable_enable_zone(self
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/285#discussion_r30964594
--- Diff: test/integration/component/maint/testpath_disable_enable_zone.py
---
@@ -429,71 +380,1093 @@ def test_01_disable_enable_zone(self
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/284
CLOUDSTACK-8492: Fix string case issue
Converted hypervisor string to lowercase to avoid dictionary key access
issues.
You can merge this pull request into a Git repository by running
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/268#issuecomment-104535446
Posting review here as I am not able to put inline review comments.
Comments in the format (line number space comment)
133 space between self
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/278#issuecomment-104519494
Can this test class be included in the same test suite that has been
previously added? (related to disabling zones etc)
---
If your project is set up for it
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/278#discussion_r30870576
--- Diff: test/integration/component/maint/testpath_disable_enable_host.py
---
@@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/278#discussion_r30870199
--- Diff: test/integration/component/maint/testpath_disable_enable_host.py
---
@@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/278#discussion_r30870172
--- Diff: test/integration/component/maint/testpath_disable_enable_host.py
---
@@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/278#discussion_r30870155
--- Diff: test/integration/component/maint/testpath_disable_enable_host.py
---
@@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/278#discussion_r30870128
--- Diff: test/integration/component/maint/testpath_disable_enable_host.py
---
@@ -0,0 +1,309 @@
+# Licensed to the Apache Software Foundation
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/279
CLOUDSTACK-8500: Adding missing key in test_data.py
The key "restartManagementServerThroughTestCase" is absent in test_data.py
while it is being used in the test cases.
You
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/276
CLOUDSTACK-8498: Including schedule as default key in recurring_snapshot
dict used to create recurring snapshot policy
Some test cases are failing because schedule key is absent in
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/272
CLOUDSTACK-8492: Fix dictionary access issue in createChecksum method
common.py
The hypervisor string is not converted to lowercase, hence it's failing for
some hypervisors while t
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/268#issuecomment-103848262
Don't know why I can't comment on the testpath file. I don't see the file
contents in the changes. Any idea why?
---
If your project is set
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/268#discussion_r30691290
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -2520,6 +2520,35 @@ def reconnect(cls, apiclient, **kwargs):
[setattr(cmd, k, v) for k
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/267
CLOUDSTACK-8394: Skipping recurring snapshot test cases for Hyperv and LXC
Snapshot feature is not supported on Hyperv and LXC hypervisors. Skipping
related test cases.
Log
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/260
CLOUDSTACK-8482: Enhacing recurring snapshots test cases
Current test cases do not verify that only maximum snapshots mentioned in
the snapshot policy are retained after minimum hours
Github user gauravaradhye closed the pull request at:
https://github.com/apache/cloudstack/pull/258
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/258
CLOUDSTACK-8481: Adding test cases for validating global limit on
concurrent snapshots
The global flag "concurrent.snapshots.threshold.perhost" defines how many
concurrent sna
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/242#issuecomment-102937596
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/242#discussion_r30315506
--- Diff: test/integration/testpaths/testpath_disable_enable_zone.py ---
@@ -0,0 +1,492 @@
+# Licensed to the Apache Software Foundation (ASF
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/242#discussion_r30315434
--- Diff: test/integration/testpaths/testpath_disable_enable_zone.py ---
@@ -0,0 +1,492 @@
+# Licensed to the Apache Software Foundation (ASF
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/242#discussion_r30315394
--- Diff: test/integration/testpaths/testpath_disable_enable_zone.py ---
@@ -0,0 +1,492 @@
+# Licensed to the Apache Software Foundation (ASF
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/251
CLOUDSTACK-8468: Correct test case in test_bugs.py
test_es_47_list_os_types_win_2012 should be run only when the global
setting "apply.allocation.algorithm.to.pods" is set to
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/242#discussion_r30214695
--- Diff: test/integration/testpaths/testpath_disable_enable_zone.py ---
@@ -0,0 +1,485 @@
+# Licensed to the Apache Software Foundation (ASF
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/242#discussion_r30214603
--- Diff: test/integration/testpaths/testpath_disable_enable_zone.py ---
@@ -0,0 +1,485 @@
+# Licensed to the Apache Software Foundation (ASF
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/242#discussion_r30214586
--- Diff: test/integration/testpaths/testpath_disable_enable_zone.py ---
@@ -0,0 +1,485 @@
+# Licensed to the Apache Software Foundation (ASF
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/242#discussion_r30214487
--- Diff: test/integration/testpaths/testpath_disable_enable_zone.py ---
@@ -0,0 +1,485 @@
+# Licensed to the Apache Software Foundation (ASF
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/242#discussion_r30214458
--- Diff: test/integration/testpaths/testpath_disable_enable_zone.py ---
@@ -0,0 +1,485 @@
+# Licensed to the Apache Software Foundation (ASF
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/242#discussion_r30214334
--- Diff: test/integration/testpaths/testpath_disable_enable_zone.py ---
@@ -0,0 +1,485 @@
+# Licensed to the Apache Software Foundation (ASF
1 - 100 of 204 matches
Mail list logo
