[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1829 Changes LGTM. As @syed mentioned there is a workaround, so won't qualify as a blocker. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1829 @syed Please check #672. There was a discussion sometimes back on dev@ and this PR was mentioned. I feel that fix is slightly better than removing the check altogether. --- If your

[GitHub] cloudstack issue #1812: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1812 OOM on HV won't happen, only cluster threshold check is skipped in case of starting a stopped VM --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1825: CLOUDSTACK-9660: NPE while destroying volumes...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/1825 CLOUDSTACK-9660: NPE while destroying volumes during 1000 VMs deploy … …and destroy tests NPE is seen as VM destroy and storage cleanup threads try to remove the same root

[GitHub] cloudstack pull request #1812: CLOUDSTACK-9650: Allow starting VMs regardles...

GitHub user koushik-das reopened a pull request: https://github.com/apache/cloudstack/pull/1812 CLOUDSTACK-9650: Allow starting VMs regardless of cpu/memory cluster.… …disablethreshold setting Introduced a global configuration flag 'cluster.threshold.enabled

[GitHub] cloudstack pull request #1812: CLOUDSTACK-9650: Allow starting VMs regardles...

Github user koushik-das closed the pull request at: https://github.com/apache/cloudstack/pull/1812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1722: CLOUDSTACK-9558 Cleanup the snapshots on the ...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1722#discussion_r91251778 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -260,11 +260,15 @@ public

[GitHub] cloudstack pull request #1722: CLOUDSTACK-9558 Cleanup the snapshots on the ...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1722#discussion_r91252165 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -260,11 +260,15 @@ public

[GitHub] cloudstack pull request #1722: CLOUDSTACK-9558 Cleanup the snapshots on the ...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1722#discussion_r91252945 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -260,11 +260,15 @@ public

[GitHub] cloudstack pull request #1794: added more guest os

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1794#discussion_r91235138 --- Diff: setup/db/db/schema-4910to41000.sql --- @@ -45,4 +45,48 @@ CREATE TABLE `cloud`.`vlan_details` ( `display` tinyint(1) NOT NULL

[GitHub] cloudstack pull request #1812: CLOUDSTACK-9650: Allow starting VMs regardles...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/1812 CLOUDSTACK-9650: Allow starting VMs regardless of cpu/memory cluster.… …disablethreshold setting Introduced a global configuration flag 'cluster.threshold.enabled'. By default

[GitHub] cloudstack issue #1738: CLOUDSTACK-9566 instance-id metadata for baremetal V...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1738 Code changes LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1727 Option 2 is definitely better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1767 @serg38 @nvazquez Thanks for the update. As I understand form some of the detail parameter examples, these are tied to the lifecycle of the entity (create/destroy or start/stop of the VM

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 @marcaurele Thats correct. In case of shared/remote storage the same disk is used to spawn a VM on another host once the VM is successfully fenced. If the fencer has successfully fenced off

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1767 @nvazquez Can you add use case details that will be addressed by these new methods? Also what kind of validation will be performed on the inputs and the state of the entity (VM or template

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 I had already mentioned in a previous comment that there is no need for this PR in 4.9/master. So that means a -1. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1586: CLOUDSTACK-9410 Data Disk shown as detached in XS

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1586 Merging as all the required LGTMs are there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1711: XenServer 7 Support

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87758702 --- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh --- @@ -72,7 +72,7 @@ else fi rm $link -f fi

[GitHub] cloudstack pull request #1711: XenServer 7 Support

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r87754997 --- Diff: scripts/vm/hypervisor/xenserver/setup_heartbeat_sr.sh --- @@ -72,7 +72,7 @@ else fi rm $link -f fi

Re: ConfigDepot vs the Config enum

ftware Developer Tel: (+354) 415 0200 j...@greenqloud.com www.greenqloud.com On Mon, Nov 7, 2016 at 11:15 AM, Koushik Das <koushik@accelerite.com> wrote: > Config enum is legacy code. For any new configuration parameters > Conf

Re: ConfigDepot vs the Config enum

Config enum is legacy code. For any new configuration parameters ConfigDepot should be used. Some of the parameters got moved from Config enum to the appropriate manager classes (where it is getting used). But there are still lot of them left to be moved. Feel free to submit a PR for moving

Re: Spring errors when creating new DAO

2016-11-03 8:15 GMT-03:00 Koushik Das <koushik@accelerite.com>: > Can you share the details about StoragePoolTagsDaoImpl class and its super > classes? Looks like in the hierarchy a default ctor is missing. > > On 03/11/16, 12:09 AM, "Nicolás V

Re: Spring errors when creating new DAO

Can you share the details about StoragePoolTagsDaoImpl class and its super classes? Looks like in the hierarchy a default ctor is missing. On 03/11/16, 12:09 AM, "Nicolás Vázquez" wrote: Hi all, I've been having troubles creating a new DAO on

[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1726 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1711: Xenserver7 Support

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1711 One small comment, rest of the code LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1711: Xenserver7 Support

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r85050747 --- Diff: setup/db/db/schema-4910to41000.sql --- @@ -35,4 +35,192 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type

[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1726#discussion_r84862649 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r84839433 --- Diff: core/src/com/cloud/agent/api/VMSnapshotTO.java --- @@ -123,4 +125,12 @@ public boolean getQuiescevm() { public void setQuiescevm

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r84841681 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -610,7 +615,11 @@ public UserVm revertToSnapshot(Long vmSnapshotId

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r84841375 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -639,10 +648,57 @@ else if (jobResult instanceof Throwable

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r84839190 --- Diff: core/src/com/cloud/agent/api/VMSnapshotTO.java --- @@ -35,6 +35,7 @@ private VMSnapshotTO parent; private List volumes

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r84839712 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java --- @@ -128,7 +128,7 @@ public

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r84839559 --- Diff: engine/schema/src/com/cloud/vm/snapshot/VMSnapshotVO.java --- @@ -248,4 +252,9 @@ public void setRemoved(Date removed) { public

[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1726#discussion_r84837338 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls

[GitHub] cloudstack pull request #1711: Xenserver7 Support

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r83789402 --- Diff: scripts/vm/hypervisor/xenserver/xenserver70/patch --- @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request #1711: Xenserver7 Support

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r83790292 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java --- @@ -0,0 +1,32

[GitHub] cloudstack pull request #1711: Xenserver7 Support

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1711#discussion_r83789828 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java --- @@ -0,0 +1,32

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1615 @jburwell Was there a discussion thread for this on dev@, didn't remember seeing one which mentions about freezing master. These issues of test stability are known and were raised

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1615 Thanks for the update @jburwell. While I agree that smoke tests needs to be stabilized, I don't quite agree to the idea of blocking master for this. Lot of commits have already gone

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1615 @jburwell @karuturi I haven't heard anything so assuming that this is good to get merged. I checked #1692 and all fixes (test and code) are related to network related functionality. So

[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1701 LGTM. Small comment on the message for running VR. "Please confirm... " is appearing twice, only one would suffice. --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1701 @rhtyd You are right, the message only makes sense for destroying running VR. So some conditional check needs to be there for displaying the proper message. Based on the discussion

[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1701 Since services are disrupted when VR is destroyed, I think it would be useful to provide a message similar to stop VR. Earlier only destroying a stopped VR was possible from UI so caller

[GitHub] cloudstack issue #1698: CLOUDSTACK-9525 add support for windows 10 guest os ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1698 Sql changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1701 @rhtyd Will destroy router show a similar message as stop router in UI? All services provided by this virtual router will be interrupted. Please confirm that you want to stop this router

[GitHub] cloudstack issue #1702: CLOUDSTACK-9535: [API] listVMSnapshots improvement

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1702 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1642 @mike-tutkowski If the LGTMs are there, this can get merged. There are lot of comments so difficult to go through all of them. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1615 I think this has all the necessary LGTMs. @karuturi @jburwell Should I go ahead and merge this? I thing fixing #1692 is fine but I see no reason to delay other PRs for that when

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1615 Yes LGTM from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r79357165 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self): # Call to verify cloud process

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 @abhinandanprateek In latest master the sequence of event described above only happens when the host has been determined as 'Down'. Refer to the below code. So the bug described won't

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1642 @mike-tutkowski Thanks for adding marvin tests. Some observations regarding the tests. I see that you have put the tests under solidfire folder. Currently is solidfire the only managed

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1615 @nvazquez @serg38 From last comment looks like there is some open item related to marvin tests. Can you please address it? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request #1670: CLOUDSTACK-9481: Convert MyISAM table to Inno...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1670#discussion_r77118387 --- Diff: setup/db/db/schema-490to491.sql --- @@ -23,3 +23,11 @@ UPDATE `cloud`.`roles` SET `description`='Default user role' WHERE `id`=4

Re: Few tables in cloudstack schema use MyISAM engine

rat...@shapeblue.com> Date: Tuesday, 30 August 2016 at 4:23 PM To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org> Cc: Rajani Karuturi <raj...@apache.org>, Raja Pullela <raja.pull...@accelerite.com>, Koushik Das <koushik@accelerite.com> Subject: Fe

[GitHub] cloudstack issue #1586: CLOUDSTACK-9410 Data Disk shown as detached in XS

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1586 code change LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1622#discussion_r76589032 --- Diff: api/src/org/apache/cloudstack/api/response/TemplateResponse.java --- @@ -347,4 +351,11 @@ public String getZoneId() { return

[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1622#discussion_r76588913 --- Diff: api/src/org/apache/cloudstack/api/response/TemplateResponse.java --- @@ -169,6 +169,10 @@ @Param(description = "additiona

[GitHub] cloudstack pull request #1618: Now returning os info with the list snapshot ...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1618#discussion_r76588305 --- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java --- @@ -102,6 +102,14 @@ @Param(description = "indicates wh

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1606 @leprechau You may add an unit test as well for NetUtils.validateGuestCidr(). Check NetUtilsTest.java, there is already an existing test for 192.168. --- If your project is set up

[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1618 Please add/modify Marvin tests based on these scenarios. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1618: Now returning os info with the list snapshot ...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1618#discussion_r76588109 --- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java --- @@ -199,4 +207,20 @@ public boolean isRevertable() { public

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 @marcaurele > What is the reason to try fencing off VMs when the MS is not able to determine its state? I cannot see a good reason so far but you seem to think there is at le

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1651 @rhtyd Please go through #1563 as mentioned in my previous comment to get the context. As @serg38 also mentioned the response differs between debian and centos which needs to be addressed

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1652 There should be only one default VPC offering, unless I am missing out something obvious :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 Also since the automated test coverage of this area is less, changes should be made after taking into account all possible scenarios. Otherwise there might be regressions in some valid

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 @jburwell The issue that has been reported is on a custom branch, probably @marcaurele needs to cherry-pick some additional commits from ACS. Master/4.9 doesn't have this issue, so

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1651 @PaulAngus Refer to #1563. In that PR it was mentioned that ping response varies based on OS. So hard coding based on some specific environment is not the right way to fix

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1652 @PaulAngus Shouldn't the product code be fixed instead of the test? If the isDefault property on VPC offerings in not working then that needs to be fixed. I checked the vpc_offerings table

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 Please use a proper ACS release for reporting bugs. In your case you may have to do some additional cherry-picks. "Schedule restart" does multiple tasks. There i

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 @marcaurele Based on the initial few lines of the logs the agent went to Alert state. srv02 2016-08-08 11:56:03,895 DEBUG [agent.manager.AgentManagerImpl] (AgentTaskPool-16:ctx

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1640 @marcaurele Can you share the MS logs for this issue? We need to understand the exact cause for restart of VM? When an agent/host is detected as 'Down', CS tries to check if VMs

[GitHub] cloudstack pull request #1611: marvin: deploy clusters in separate threads

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1611#discussion_r75071072 --- Diff: tools/marvin/marvin/deployDataCenter.py --- @@ -224,6 +225,15 @@ def createClusters(self, clusters, zoneId, podId, vmwareDc=None

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1615 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r73283060 --- Diff: setup/db/db/schema-481to490.sql --- @@ -545,3 +545,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervis

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r73281219 --- Diff: engine/schema/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDaoImpl.java --- @@ -16,7 +16,7 @@ * specific language

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r73118447 --- Diff: engine/schema/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDetailVO.java --- @@ -23,61 +23,61 @@ import

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r73118335 --- Diff: setup/db/db/schema-481to490.sql --- @@ -545,3 +545,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervis

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r73118216 --- Diff: setup/db/db/schema-481to490.sql --- @@ -545,3 +545,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervis

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r73114913 --- Diff: engine/schema/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDaoImpl.java --- @@ -16,7 +16,7 @@ * specific language

[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1563#issuecomment-222643203 Thanks @nitt10prashant for the making the changes. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1563#issuecomment-222104760 Changes LGTM. Now the expected ping response can be configured in test_data based on OS type. @nitt10prashant Please post the test execution result

[GitHub] cloudstack pull request: CLOUDSTACK-9388: Remove string conversion...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1561#issuecomment-221821063 Simple change. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-221218765 LGTM. In some of the *Command.java and *Annswer.java classes, simple member types has been replaced with types defined in the Nuage VSP library. As long as all

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1494#discussion_r64358114 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java --- @@ -19,173 +19,43

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1556#issuecomment-221202485 Simple changes. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220615109 @swill nothing outstanding on this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r64015658 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -429,60 +434,42 @@ private void validateChain(List chain

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220562852 @nvazquez Thanks for the fix. As @DaanHoogland mentioned please add license header to the newly added file. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-220558485 @swill The failures are not related to this PR. The failure in test_internal_lb.py is due to some cleanup issue. The network deletion failed most probably

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

Congrats Will And thanks Sebastien -Koushik On 19/05/16, 12:26 PM, "Sebastien Goasguen" wrote: >Morning Everyone, > >Yesterday at the ASF board meeting, the board passed the resolution making >Will Stevens the new Vice President of the Apache CloudStack project. > >Join me

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r63829633 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -429,60 +434,42 @@ private void validateChain(List chain

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r63828871 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -341,179 +350,172 @@ public SslCertResponse createCertResponse

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

Github user koushik-das closed the pull request at: https://github.com/apache/cloudstack/pull/1251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-219945994 @DaanHoogland Not able to see diffs for NetscalerResource.java, are the changes mostly related to adding 'final' keyword? Provided some comments, rest

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r63655432 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -341,179 +350,172 @@ public SslCertResponse createCertResponse

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r63655061 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -341,179 +350,172 @@ public SslCertResponse createCertResponse

[GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1437#issuecomment-219696525 @anshul1886 @anshulgangwar Can you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-219692208 @nvazquez I am not too familiar with the VMware specific code, rest of the code looks ok. Also a comment on #1361 when this feature was initially added

<    1   2   3   4   5   6   7   8   9   >