[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2016-01-12 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1276#issuecomment-170863132 ping @sanju1010 @wido @terbolous --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2016-01-11 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1276#discussion_r49317967 --- Diff: test/integration/smoke/test_vpc_vpn.py --- @@ -494,9 +526,411 @@ def create_natrule(self, vpc, vm, public_port, private_port

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2016-01-11 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1276#issuecomment-170543474 just ran the test again after adding the validateList method: command: ``` osetests --with-marvin --marvin-config=/data/shared/marvin/mct

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2016-01-11 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1276#issuecomment-170636254 ping @DaanHoogland --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2016-01-07 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1276#discussion_r49099622 --- Diff: test/integration/smoke/test_vpc_vpn.py --- @@ -494,9 +526,411 @@ def create_natrule(self, vpc, vm, public_port, private_port

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2015-12-23 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1276#discussion_r48382355 --- Diff: test/integration/smoke/test_vpc_vpn.py --- @@ -468,7 +500,7 @@ def get_ssh_client(self, virtual_machine, services, retries

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-23 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-166835953 Hi @sanju1010, @wilderrodrigues asked me to extend the test_vpc_vpn script and in the proces i added the other hypervisors. https://github.com/apache

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2015-12-22 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1276#issuecomment-166714201 As for: > Is there a timing issue possible where both routers would be in the same state? If so, it might be good to > throw an exception

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2015-12-22 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1276#discussion_r48288107 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -916,6 +916,9 @@ protected void

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2015-12-22 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1276#discussion_r48290122 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -916,6 +916,9 @@ protected void

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2015-12-22 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1276#discussion_r48286045 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -916,6 +916,9 @@ protected void

[GitHub] cloudstack pull request: FIX Site2SiteVPN on redundant VPC

2015-12-22 Thread michaelandersen
GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/1275 FIX Site2SiteVPN on redundant VPC This PR: - fixes starting of Site2Site VPN on redundant VPC - fixes Site2Site VPN state checking on redundant VPC - improves

[GitHub] cloudstack pull request: FIX Site2SiteVPN on redundant VPC

2015-12-22 Thread michaelandersen
Github user michaelandersen closed the pull request at: https://github.com/apache/cloudstack/pull/1275 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request: FIX Site2SiteVPN on redundant VPC

2015-12-22 Thread michaelandersen
GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/1276 FIX Site2SiteVPN on redundant VPC This PR: - fixes starting of Site2Site VPN on redundant VPC - fixes Site2Site VPN state checking on redundant VPC - improves

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

2015-12-10 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1204#issuecomment-163539898 Ran tests on Xenserver 6.2: Results: ``` Test to verify access to loadbalancer haproxy admin stats page ... === TestName

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936 Gotcha. We could add templates for the other hypervisors (vmware and hyperv) from http://dl.openvm.eu/cloudstack/macchinina/x86_64/ And remove

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162522267 ping @sanju1010 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162545461 Hi Sanju, Isn't it the point of the test to verify this exact connectivity? But I any case I don't believe connectivity is the reason

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162520027 Just tested this on 4.6.1-SNAPSHOT with the command: ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-xen1.cfg -a tags

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162651522 So removed my last comment about field 7 to 6. We need to choose 1 type of template os for both kvm and xen and base the test on that. @sanju1010

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

2015-11-03 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1028#issuecomment-153338369 Tested change on a KVM hypervisor: Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS === ok

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

2015-11-03 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1028#issuecomment-153338103 @sanjeevneelarapu please review once build checks are completed --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

2015-11-03 Thread michaelandersen
GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/1028 smoke/test_vpc_vpn: Add template wait & refactor - Added a wait for template download as the test was failing in some environments - Removed debug timer in setup and tear

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

2015-11-03 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1028#issuecomment-153338894 executed tests with: nosetests --with-marvin --marvin-config=./mct-zone1-kvm1.cfg -a tags=advanced test_vpc_vpn.py --- If your project is set up

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

2015-11-03 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1028#issuecomment-153604321 changed the required_hardware tag to true and rebased to master and retested: nosetests --with-marvin --marvin-config=../../../mct-zone1-kvm1.cfg

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

2015-11-03 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1028#discussion_r43748177 --- Diff: test/integration/smoke/test_vpc_vpn.py --- @@ -570,127 +584,139 @@ def test_vpc_site2site_vpn(self): finally

[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...

2015-10-23 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/971#issuecomment-150571635 ran the following test: ``` nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=../../../mct-zone1-kvm1.cfg -a tags=advanced

[GitHub] cloudstack pull request: Fix template not ready error

2015-10-23 Thread michaelandersen
GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/971 Fix template not ready error Add wait for template download Refactored template section of services You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Improve marvin test site2site VPN

2015-10-22 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/952#issuecomment-150173017 The exceptions: error: [Errno 113] No route to host error: [Errno 111] Connection refused until ===SSH to Host 192.168.23.12 port : 22

[GitHub] cloudstack pull request: Improve marvin test site2site VPN

2015-10-21 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/952#issuecomment-150027934 thanks for testing @miguelaferreira and @wilderrodrigues for chasing this pr haven't seen this type of report before but looking at the combination

[GitHub] cloudstack pull request: CLOUDSTACK-8971 - Improve the current tes...

2015-10-21 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/957#issuecomment-149805301 yes @wilderrodrigues it is most likely an environment issue. don't wait on me for this PR. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8933 - Improve the current tes...

2015-10-20 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/957#issuecomment-149500308 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8971 - Improve the current tes...

2015-10-20 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/957#issuecomment-149706192 @remibergsma @wilderrodrigues LGTM'ed this one too soon, was a bit too enthusiastic. sorry about that. Ran the test just now, but it's failing

[GitHub] cloudstack pull request: CLOUDSTACK-8971 - Improve the current tes...

2015-10-20 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/957#issuecomment-149706469 requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): cs2.cloud.lan requests.packages.urllib3.connectionpool: DEBUG: &quo

[GitHub] cloudstack pull request: Improve marvin test site2site VPN

2015-10-20 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/952#issuecomment-149694171 @remibergsma: why another run? Jenkins (and travis) is green --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8971 - Improve the current tes...

2015-10-20 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/957#issuecomment-149706996 from the mgt server log: WARN [c.c.a.d.ParamGenericValidationWorker] (709693495@qtp-265638379-0:ctx-dfba94e8 ctx-8090674b ctx-c8da340d) Received

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

2015-10-19 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149192133 @remibergsma @wilderrodrigues can you guys have a look when the build tests are finished? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

2015-10-19 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149190264 fixed the first test === Marvin Init Logging Successful=== Successfully created account: test-TestInternalLb-SG7Y3N, id: d64ee2ea

[GitHub] cloudstack pull request: Improve marvin test site2site VPN

2015-10-19 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/952#issuecomment-149238771 run with: nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=/data/shared/marvin/mct-zone1-kvm1.cfg -a tags=advanced test

[GitHub] cloudstack pull request: Improve marvin test site2site VPN

2015-10-19 Thread michaelandersen
GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/952 Improve marvin test site2site VPN Add optional fields: iprange and fordisplay to Marvin base.py class method Vpn.create Add optional field: passive to Marvin base.py class method

[GitHub] cloudstack pull request: CLOUDSTACK-8952 - The redundant routers a...

2015-10-19 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/940#issuecomment-149314829 Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS

[GitHub] cloudstack pull request: CLOUDSTACK-8952 - The redundant routers a...

2015-10-19 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/940#issuecomment-149317876 nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=../../../mct-zone1-kvm1.cfg -a tags=advanced test_vpc_vpn.py Test Remote

[GitHub] cloudstack pull request: CLOUDSTACK-8952 - The redundant routers a...

2015-10-19 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/940#issuecomment-149317933 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

2015-10-15 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148340689 nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=/data/shared/marvin/mct-zone1-kvm1.cfg -a tags=advanced test/integration/smoke

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

2015-10-15 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148341058 squashed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

2015-10-15 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148337473 there should be a rule: ACCEPT tcp -- anywhere anywhere state NEW tcp dpt:8081 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

2015-10-15 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148337333 the admin stats test fails because of a iptables misconfiguration on the ILBVM: === Marvin Init Logging Successful=== Successfully created account

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

2015-10-14 Thread michaelandersen
GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/933 Refactored & Added Internal LB smoke test Added 1VPC 2TIER internal lb roundrobin test Added 1VPC 1TIER internal lb admin stats test Refactored existing test Th

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-26 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/692#issuecomment-134932710 verified that conntrackd starts on redundant vpc routers. LGTM in that respect. Design wise i feel we need to refactor this, naming