Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-166714201
As for:
> Is there a timing issue possible where both routers would be in the same
state? If so, it might be good to > throw an exception before doing any
operations (i.e. if the loop exits, and no routers were found to be MASTER).
A dual MASTER state should not be possible, but even if it occurred it
would, in this context worst case, trigger a vpn state check on both routers.
> I would suggest adding a test that turns one of the routers off, and
then seeing if the VPN connection works correctly.
This makes sense and i will manually verify and if possible automate this
tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
