Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
Test lgtm, based on the test results I'm seeing no new failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1764
Thanks @marcaurele
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@mike-tutkowski you please fix the git commit summary (not the PR summary)
in the requested format? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
Test LGTM. @abhinandanprateek @murali-reddy can you give a final
review/lgtm?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1726#discussion_r90594621
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){
if
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@swill @jayapalu thanks for your work, can you rebase against latest
master, fix the conflicts. Also use the JIRA id in the git commit summary.
---
If your project is set up for it, you can
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1795
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1796
@sudhansu7 this may be useful, can you at least change the PR's base branch
to 4.9?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1798
@marcaurele one of the component tests have failed, please have a look
and/or push -f to rekick Travis.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1804
@nitin-maharana this looks useful, can you change the base branch for the
PR to 4.9, rebase your PR branch against 4.9? Can you add a marvin test for
this?
---
If your project is set up for it
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1805
Nice fix, @sudhansu7 this looks useful, can you change the base branch for
the PR to 4.9, rebase your PR branch against 4.9?
---
If your project is set up for it, you can reply to this email and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1794
@karuturi ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
Thanks @syed I'll go ahead and merge this, as the changes confirm. I'm okay
that moving (4.10+) fwd we've `.vhd` extension in snapshot files.
---
If your project is set up for it
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r90590680
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
@@ -100,36 +100,25 @@ protected
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
Tests look good so far, I'm waiting for a vmware specific test run to
complete. Some failures in kvm, xen are known intermittent failures.
---
If your project is set up for it, you can rep
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@murali-reddy can you have a look at why private_gw failed again for vmware?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
Test LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1257
@sureshanaparti sorry, this is a restricted command to avoid resource abuse
issues.
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Travis is failing due to an env issue in their VMs, I'm investigating it
with #1806
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1618
Thanks @ProjectMoon
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1622
Thanks @ProjectMoon
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1566
LGTM. Thanks @ProjectMoon
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1806
travis: cleanup apt before installing packages
This aims at fixing recent Travis failures.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1799
CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55
- Upgrades Maven dependency version to v1.55
- Fixes bountycastle usages and issues
- Adds timeout to jetty/annotation scanning
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/828
I looked at the failure, all of them are environment related or known
intermittent failures. I'll proceed with merging this. LGTM.
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@abhinandanprateek @murali-reddy @jburwell this may be useful for 4.9/lts,
would you like to review?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
LGTM. Travis failure was due to an intermittent issue with oobm test, which
has been fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@jburwell the issue was with an intermittent test that sometimes fail when
clocks get skewed in virtualized environment: `
HypervisorUtilsTest.checkVolumeFileForActivityTest:68 Didn't block
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
Thanks @jburwell I'll get this re-tested against both Travis and Trillian.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1799
CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55
- Upgrades Maven dependency version to v1.55
- Fixes bountycastle usages and issues
- Adds timeout to jetty/annotation scanning
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@mike-tutkowski @nvazquez @syed ping, it seems there were some changes on
master due to which snapshot file names on xenserver now have `.vhd` extension
which was not seen in 4.8, 4.9 branches. I
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
LGTM, we found the issue happens only in master branch (ref #1754). The fix
is applicable only on master, the PR's base branch has been fixed and test has
been verified manually by @borissto
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@blueorangutan test matrix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@jburwell good to have this, not sure how many people maybe using
container/docker based mgmt servers?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@jburwell I've fixed couple of more issues, and the issues from your code
review. Thanks for your comments.
@blueorangutan package
---
If your project is set up for it, you can rep
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/828
Thanks @sureshanaparti
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90405628
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -245,48 +245,48 @@ public void runUploadSslCertSelfSignedNoPassword
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90405645
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90404501
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90404400
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90404197
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90404003
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90403899
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90403957
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90403775
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90403174
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90402863
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90402626
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90402608
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90402383
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -240,68 +245,71 @@ public void deleteSslCert(DeleteSslCertCmd
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90401765
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -150,26 +155,26 @@ public SslCertResponse uploadSslCert(UploadSslCertCmd
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90399606
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90399065
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90399018
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90398972
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90398722
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90398614
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90397919
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90397788
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90397502
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/828
@sureshanaparti @sateesh-chodapuneedi this looks like a useful patch, can
you change the base branch of your PR to 4.9?
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1794
@karuturi ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90394494
--- Diff: api/src/com/cloud/network/Network.java ---
@@ -215,6 +216,8 @@ public static Provider getProvider(String providerName)
{
public
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/828
LGTM.
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1803
LGTM, @nitin-maharana can you rebase and change PR's base branch to 4.9.
This is a small and useful change.
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1802
LGTM, let's wait for the result.
@blueorangutan test centos7 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
I'm seeing no new errors except for `test_06_download_detached_volume` and
`test_01_create_template`. @prashanthvarma can you have a look, they may be
intermittent in nature.
@jbu
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@borisstoyanov can you have a look at failure in
`test_01_snapshot_root_disk`?
@jburwell Jenkins is not reliable, with my latest fix Travis will do
noredist build checks and RAT-license
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1801
LGTM. Thanks @murali-reddy I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90227580
--- Diff: client/pom.xml ---
@@ -168,6 +168,11 @@
org.apache.cloudstack
+ cloud-plugin-network-vsp
--- End diff
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@blueorangutan test centos7 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220642
--- Diff: engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java ---
@@ -142,6 +142,9 @@
@Column(name="supports_strech
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220265
--- Diff:
api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java ---
@@ -120,6 +120,10 @@
@Param(description = "true if ne
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220227
--- Diff: api/src/org/apache/cloudstack/api/ApiConstants.java ---
@@ -639,6 +639,7 @@
public static final String READ_ONLY = "rea
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90221275
--- Diff: setup/db/db/schema-4910to41000.sql ---
@@ -45,4 +45,6 @@ CREATE TABLE `cloud`.`vlan_details` (
`display` tinyint(1) NOT NULL DEFAULT 1
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220849
--- Diff: api/src/com/cloud/network/Network.java ---
@@ -215,6 +216,8 @@ public static Provider getProvider(String providerName)
{
public
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90221096
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -2968,8 +2939,45 @@ public Vlan doInTransaction(final TransactionStatus
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90220410
--- Diff: client/pom.xml ---
@@ -168,6 +168,11 @@
org.apache.cloudstack
+ cloud-plugin-network-vsp
--- End diff
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90221150
--- Diff: server/src/com/cloud/network/NetworkModelImpl.java ---
@@ -1558,6 +1558,32 @@ public boolean checkIpForService(IpAddress userIp,
Service service
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma @fmaximus @nlivens thanks, I've kicked some tests. I'll be
willing to merge the PR once they pass and we've no outstanding review items.
---
If your project is set
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1320
@nitin-maharana yes, the master branch is JSP free now. The UI is purely
JS/html/css based.
Yes, you'll need to add new keys only to the l10n (localisation) specific
files and use them i
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1511
I'll close this PR in favour of PR #1799
@jburwell I'll fixed the issues you've reviewed in #1799 thanks
---
If your project is set up for it, you can reply to this email and
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1801
@murali-reddy can you use a JIRA id in the git commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1638
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
LGTM.
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1638
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1799
CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55
- Upgrades Maven dependency version to v1.55
- Fixes bountycastle usages and issues
- Adds timeout to jetty/annotation scanning
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan test matrix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
701 - 800 of 2445 matches
Mail list logo