Re: PR's and the 2 LGTM Story

ng them for instant review. Works almost all > of the time. > Indeed. Use Slack/IRC/Phones or what ever suites. Talk and resolve these things. Wido > Regard, Remi > > Sent from my iPhone > >> On 14 Dec 2015, at 17:41, Daan Hoogland <daan.hoogl...@gmail.com> w

[GitHub] cloudstack pull request: CLOUDSTACK-9141: Validate userdata for va...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1220 CLOUDSTACK-9141: Validate userdata for valid base64 This prevents the userdata from going through the stack completely and finding out very late in the process that it is invalid data. You

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1200#discussion_r47093362 --- Diff: core/src/com/cloud/agent/api/RebootCommand.java --- @@ -19,29 +19,25 @@ package com.cloud.agent.api; -import

Re: Better way to do development for SSVM agent code

e SSVM and: $ killall java That will restart the SSVM daemon with the new JAR and you can test it quickly. Wido > Thanks, > -Syed >

[GitHub] cloudstack pull request: [4.6/4.6.1] IMPORTANT for 4.6.1 release -...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1149#issuecomment-161709051 Seems good, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [VOTE] Apache CloudStack 4.6.1

+0 from me. I verified that all the sources build properly and the Debian packages look good. Waiting for test results before my final vote comes in. Boris will run tests and based on that result I will vote. Wido On 11/30/2015 11:12 PM, Remi Bergsma wrote: > Hi all, > > I've create

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9022: keep Destroyed v...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1145#issuecomment-160903564 I would swear I saw this code before. Dejavu moment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9022: keep Destroyed v...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1145#issuecomment-160915928 LGTM based on the code. Seems sane to me. @bhaisaab This seems like a feature, so I don't think it's supposed to go into 4.5? --- If your project is set up

[GitHub] cloudstack pull request: Show Agent name in Ping response

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1143#issuecomment-160679884 @pdube Thanks! I didn't know that existed :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Show Agent name in Ping response

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1143 Show Agent name in Ping response Before: DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Handler-4:null) Ping from 66 After: DEBUG [c.c.a.m.AgentManagerImpl

Re: Package Repositories

seems like applying the full attention of the community to test them > would certainly a good thing for users. > Shall we ask for packages.cloudstack.org then? Wido > Thanks, > -John > > [1]: http://packages.shapeblue.com/cloudstack/upstream > > — > John Burwell > VP So

[GitHub] cloudstack pull request: Removed the PlannerBase class because it ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1108#issuecomment-160599664 Code seems good, waiting for @borisroman to come up with test results --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9080: Resource limits for Prim...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1107#issuecomment-160600074 The fix seems good to me. I can't run the Marvin tests, but it looks good to me --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1121#issuecomment-160559759 LGTM based on the code. I don't see any real issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-160648931 @borisroman @DaanHoogland Anybody else? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-160649027 Still working on this one. However, I need to get stuff into libvirt-java upstream. Working on that here: https://github.com/wido/libvirt-java/commits/qemu-guest

Re: Package Repositories

nclude > noredis libraries. > The debs don't I think. I never checked the RPMs. Wido > > [1] > http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.6.0/upgrade/upgrade-4.4.html#cloudstack-rpm-repository > [2] > http://docs.cloudstack.apache.org/projects/

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1121#discussion_r46089169 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java --- @@ -419,7 +419,7 @@ public String toString

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1121#discussion_r46089207 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java --- @@ -761,6 +766,10 @@ public String toString

Re: 4.6 release

On 11/20/2015 02:04 PM, Paul Angus wrote: > http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.6.0/upgrade/upgrade-4.5.html#hypervisor-vmware > states: > 'Warning > For VMware hypervisor CloudStack management server packages must be build > using “noredist”. Refer to

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1069#issuecomment-158403924 The fix seems good to me. I would like to LGTM, but I can't test JavaScript that easily. Isn't there a lint-check for JS? --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9076: Changed ownership of dir...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1095#issuecomment-158328758 Seems to be a spacing issue? Keep in mind that the debian/rules files uses TABs and not spaces. With space it will fail. --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1083#issuecomment-158328981 LGTM. Reviewed the code and looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1038#issuecomment-157987945 I would like to give a LGTM, but my JavaScript skills aren't that good. The small Java changes look good to me. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1083#issuecomment-157657472 Initially it looks good, but with S3 it's very hard to test this. At a first glance the code looks good. Much better then it was --- If your project is set up

Re: [KVM] NPE when createVolume by a snapshot whose source volume is deleted

le and get rid of the dependency? > > Or give the volume info in CopyCommand even if the volume is deleted? > I don't have a clear answer, but we should always prevent NPEs :) Wido > > > -- > > Qian > >

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-156360759 @ustcweizhou Yes, it does. See the patches I posted above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

+1 (binding) from me. I've verified that 4.6.0 works and I tested ACS 4.6.0 with Boris as he described below. Our tests were all with Basic Networking and KVM. Wido On 13-11-15 14:10, Boris Schrijver wrote: > Hi all, > > Hereby my vote for ACS 4.6.0 based on branch 4.6.0-RC2015

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-156067993 @DaanHoogland Thanks! Now, that failure has nothing to do with this Python code :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-156161390 @ustcweizhou Could you close this PR? #985 has some new patches which use libvirt. Some of your code also went in there :) --- If your project is set up for it, you

[GitHub] cloudstack pull request: Shuffling the password to avoid having a ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1058#issuecomment-155702537 LGTM to me. Simple fix to make passwords more secure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-155444641 "Apache CloudStack Server" has failed says Jenkins. I don't see a failed test though? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1051#issuecomment-155444948 LGTM Trivial fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-155353598 Pylint result: ``` Global evaluation - Your code has been rated at 6.48/10 (previous run: 6.48/10, +0.00) ``` I also

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1054 CLOUDSTACK-8818: Use MySQL native connector with Python MySQLdb has been deprecated and is also not supported in Python 3. mysql.connector is a connector written in Python which talks

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-155054417 I've just send a patch upstream to libvirt-java so that we can use Libvirt for sending commands to Instances: https://www.redhat.com/archives/libvir-list/2015

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155153126 I saw this in action today. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-155098762 I justed pushed a new commit which uses libvirt-java for the communication with the Guest Agent. The build will fail since this patch for libvirt-java has

[GitHub] cloudstack pull request: CLOUDSTACK-9029: Proper support to identi...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1033#issuecomment-155099155 @Carles-Figuerola Understood. Don't mind my comment. In that case, LGTM. Code seems good. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1049#issuecomment-155347860 Since all tests are still passing and based on the code a LGTM from me. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155001934 @DaanHoogland @borisroman Fully agree, the UI is currently not the best, but this change can go in. I want to LGTM, but it's hard to test. The code seems fine

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-155004607 I'm going to take a look at this via @borisroman today. I'm also working on a patch for libvirt-java, since using those bindings you can also send Qemu Guest

[GitHub] cloudstack pull request: CLOUDSTACK-5822: keep user-added sshkeys ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1044#issuecomment-155003768 Looks good, sane commit. I agree with @NuxRo that cloud-init is imho the way forward. We probably want to ditch these legacy scripts at some point

[GitHub] cloudstack pull request: CLOUDSTACK-9045: Corrected mount point fo...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1047#issuecomment-155001549 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9029: Proper support to identi...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1033#issuecomment-155005631 Isn't it safer to execute lsb_release -r and parse that output? ``` [root@n01 ~]# lsb_release -r Release:7.1.1503 [root@n01

[GitHub] cloudstack pull request: Fix some small UI bugs

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155005958 Based on the code a LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [ANNOUNCE] New committer: Boris Schrijver

Congrats Boris! Welcome to the club :) On 11/09/2015 07:31 AM, Rajani Karuturi wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Boris Schrijver to become a committer and we are pleased to > announce that he has accepted. > > Boris is an active code contributor,

Re: [RFC] Metrics views for CloudStack UI

OUDSTACK-9020 > JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-9020 > PR: https://github.com/apache/cloudstack/pull/1038 > > Comments and suggestions? > Overall it looks very good, but I personally would like to see the amount of Instances per Zone/Host in a Quick overview

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-154403884 @ustcweizhou I looked at the code more closely and it looks good. However, I would still vote for having the Agent port always enabled. This saves a lot

[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1039#discussion_r44132316 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -107,7 +107,8 @@ def checkHostName(): bash("chown cloud.cloud /var/run/cloud

[GitHub] cloudstack pull request: CLOUDSTACK-9040: Use Tomcat6 for Debian p...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1040#issuecomment-154161203 LGTM We can deal with other Tomcat versions later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153668057 So I wrote #985 which adds a channel by default to all guests. The question is, how do we proceed. Which one goes in? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153674330 @ustcweizhou Ah, I see indeed. So the discussion is: - Do we enable the port by default? I would say yes. (Less code!) - Do we enable the port

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153664875 @ustcweizhou I don't see the difference personally, as a admin you already have full access to the Instance if you want to. But this PR conflicts with mine

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153667850 @sspans Indeed. Users can stop/disable the agent or even block specific commands if they wish to. As CloudStack we don't control what's in the Instance, so it's

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1029#issuecomment-153669733 Seems good! Great to see this :) Some tests are failing though, could you look into that? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1024#issuecomment-153311038 Seems like a good fix to me. Can't test it manually at this moment though --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-153312402 @DaanHoogland @ustcweizhou Overall it seems good! It's just hard to test this since it can break migration of VMs and you also have to deal with all the versions

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43734401 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreVMSnapshotCommandWrapper.java --- @@ -0,0 +1,103

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43734254 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java --- @@ -0,0 +1,108

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43734224 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java --- @@ -0,0 +1,108

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-153369869 @DaanHoogland I meant the version of libvirt running on the HV which is out of our control. I still vote for no longer supporting Ubuntu 12.04 for that reason

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153370288 Overall this seems OK, but I personally think that we can enable it by default on all KVM guests. It doesn't hurt to add the port. We can detect if the port

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43733925 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,197 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/864#discussion_r43605651 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1090,8 +1091,8 @@ public void orchestrateStart(final String vmUuid

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152998269 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1012#issuecomment-152721837 @rafaelweingartner Can you tell me what the output of java.io.tmpdir is on Windows? I'll look into your comment --- If your project is set up for it, you

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1005#issuecomment-152462532 @DaanHoogland I don't like them either, but these paths are currently hardcoded in LibvirtComputingResource and I want to verify that they don't change and break some

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152460936 @ustcweizhou Which version of libvirt are you using? If you use libvirt 1.0.6 or newer, you can omit the path='...' attribute of the element, and libvirt

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1005#issuecomment-152453969 @borisroman Fixed, that was indeed the problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Build fails on LocalTemplateDownloadTest

On 29-10-15 15:36, Josh Harshman wrote: > Build environment isn't Windows, it's Ubuntu 14.04 that I am getting this > build failure on. > Is there something special about the /tmp on your system? Eg not enough space for example. Wido > ____

[GitHub] cloudstack pull request: CLOUDSTACK-8677: use wrapper classes for ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/987#issuecomment-152505938 @borisroman Can we run the tests on this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152494985 @ustcweizhou @remibergsma I just pushed a new version of the commit. On Ubuntu AppArmor needs to be disabled since the default profile for libvirt doesn't

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1005#issuecomment-152501126 @DaanHoogland I've just pushed a version with a comment in there to explain what I'm doing Code-wise nothing changed --- If your project is set up

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1012 Use java.io.tmpdir instead of hardcoded /tmp This was submitted earlier in PR #884 but that did not merge properly. This is a new PR with the same change. You can merge this pull

Re: Building SNAPSHOT debian packages

oblem when > building unstable debs? > I did, but usually I worked around it a bit. I usually never build debs for testing purposes, they are only build after a release. Wido > Jeff >

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1012#issuecomment-152541675 @DaanHoogland I think it was @SudharmaJain As long as the build still works on Linux/Mac we didn't break anything. I'm positive it's now also fixed on Windows

Re: New PMC member: Erik Weber

Congrats! Welcome :) On 30-10-15 15:01, Giles Sirett wrote: > All > The PMC is delighted to announce that we have asked Erik weber to join the > PMC and he has accepted > > Please join me in congratulating Erik > > Kind Regards > Giles > > D: +44 20 3603 0541 | M:

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152188711 Hmm, ok. That should be allowed. Since we want the Guest tools also to be supported on SSVMs to control them properly. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152157162 @borisroman Could you give this PR a spin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1005 kvm: Add UnitTests for LibvirtUtilitiesHelper These were lacking, but this helper is used in various places inside the KVM code. Some simple tests to verify the helper is doing what

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1004#issuecomment-152157062 Isn't 4.5 closed for features? I know this might sound picky, but as far as I know we are only supposed to fix bugs in a point release. --- If your project is set up

Re: Hyper-V clock on KVM node - CLOUDSTACK-8978

y else knows, but I can't tell for sure. Wido > Code Snip: > //for rhel 6.5 and above, hyperv enlightment feature is added > /* > * if (vmTO.getOs().contains("Windows Server 2008") && hostOsVersion != null > && ((hostOsVersion.first() == 6 &&

Re: Build fails on LocalTemplateDownloadTest

ted, but due to the code, but I merged it without the proper permissions. We would have to merge this one in to fix it. Wido > > > ---snip--- > > [INFO] Apache CloudStack Framework - IPC . SUCCESS [5.250s] > [INFO] Apache CloudStack Cloud Engine SU

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-152114694 @remibergsma ping? ^^ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-152134450 LGTM now DEB is included --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152149949 My only concern is, IPv6 is coming as well into CS, are we also going to display that address? For now this seems fine with me, but adding more columns later on makes

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151836172 @remibergsma Hmm, was SELinux enabled on that system? Can't see any reason why it wouldn't work. All the directories exist. Do you by any chance have the XML

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151871826 @remibergsma Ok, that is odd. A proper XML should look like

[GitHub] cloudstack pull request: CLOUDSTACk-9002: VM deployment is success...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/995#issuecomment-151784319 Seems good to me, but while we are working on this. Any way we can Unit Test this? Looking at the code it's possible. If you could just write a test

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/991#issuecomment-151784718 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8999: Don't override res...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/990#issuecomment-151784690 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9000: logrotate cloudsta...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/993#issuecomment-151791418 @bhaisaab With systemd we no longer write a out and err file. We did this with JSVC, but now it's send to stdout and stderr which is then picked up by journald

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/992#issuecomment-151778449 Why only RPM and not for DEB? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9000: logrotate cloudsta...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/993#issuecomment-151778493 Why only RPM and not for DEB? Keep in mind though that with systemd this is no longer valid --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151412595 @ustcweizhou I think we shouldn't want a enable/disable flag in the agent.properties, it should work for anybody. That we already have a lot of commands being

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-151412107 Is there any way we can test this automatically? I think there is no Unit Test for this, right? I currently don't have a setup to test this, but can you

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151442130 @DaanHoogland Indeed, that is the case. The problems I had were with libvirt, not the bindings. libvirt-java is distributed via Maven and we include it in our

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/985 CLOUDSTACK-8715: Add VirtIO channel to all Instances for the Qemu Gue… …st Agent This commit adds a additional VirtIO channel with the name 'org.qemu.guest_agent.0' to all

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151444216 LGTM Nice feature indeed :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

<    4   5   6   7   8   9   10   11   12   13   >