[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1293#issuecomment-172248684 LGTM :+1: Been running in beta for a couple of weeks now, no problems! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1293#issuecomment-172247195 Tested it and works well in our environment. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49748364 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraCheckHealthCommandWrapper.java --- @@ -0,0

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49730831 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -821,9 +819,9 @@ protected boolean handleDisconnectWit

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49728823 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -821,9 +819,9 @@ protected boolean handleDisconnectWithI

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49728579 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraCheckHealthCommandWrapper.java --- @@ -0,0

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49713222 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -821,9 +819,9 @@ protected boolean handleDisconnectWit

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49679998 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -821,9 +819,9 @@ protected boolean handleDisconnectWithI

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49679830 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraCheckHealthCommandWrapper.java --- @@ -0,0

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1293#issuecomment-167586479 I've built the entire project running the existing and additional unit tests. I've also deployed this jar into our beta environment to check that it wound't

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/1293 Add Health Check Command to NSX plugin The NSX plugin does not support the HeathCheckCommand. Instead it fakes a PingCommand as a call tot he control cluster status API. However, we

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1292#issuecomment-167586010 closing since this should not target master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user miguelaferreira closed the pull request at: https://github.com/apache/cloudstack/pull/1292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/1292 Add Health Check Command to NSX plugin The NSX plugin does not support the HeathCheckCommand. Instead it fakes a PingCommand as a call tot he control cluster status API. However, we