[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-05-26 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-221985483 ### ACS CI BVT Run **Sumarry:** Build Number 59 Hypervisor xenserver NetworkType Advanced Passed=71 Failed=2 Skipped=3

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-05-09 Thread alexandrelimassantana
Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-217840055 Is there a test already to check if the ip ranges release method is called? If there is none, I think it should be added --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-216221247 Good idea in general. @ustcweizhou please rebase against latest master tag:needlove --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-04-06 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-206245883 @bvbharatk Looks like test_01_vpc_privategw_acl has been failing for sometime based on the report. Should this be moved to the list of known test issues?

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-03-23 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-200251321 @DaanHoogland Like kishan said we need to look at the failed tests and if needed check the reason for failure. Logs can be obtained using the link and the

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-03-22 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-200185858 @DaanHoogland Failed tests are the ones which we should be looking at. integration.smoke.test_privategw_acl.TestPrivateGwACL is the only failed test in

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-03-22 Thread Daan Hoogland
Bharat et al, >From this report, I find it difficult to get a feel for the quality of the pr. Clearly some of the failures are not related to this PR but are some related? Can you give some guidance as to how to read the report? Biligual auto correct use. Read at your own risico Op 22 mrt.

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-03-22 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-199767590 ### ACS CI BVT Run **Sumarry:** Build Number 118 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=13 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-02-05 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1357#discussion_r52076608 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId) {

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-02-05 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1357#discussion_r52021538 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId) {

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-02-05 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1357#discussion_r52094345 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId) {

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-02-05 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1357#discussion_r52095108 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId) {

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-01-22 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1357#discussion_r50616343 --- Diff: engine/components-api/src/com/cloud/configuration/ConfigurationManager.java --- @@ -219,6 +219,8 @@ Vlan

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-01-22 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1357#discussion_r50616271 --- Diff: server/test/com/cloud/vpc/MockConfigurationManagerImpl.java --- @@ -456,6 +456,15 @@ public void createDefaultSystemNetworks(long

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-01-21 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1357 CLOUDSTACK-8958: release dedicated ip range in domain removal We are able to assign didacated vlan ip ranges after the merge of CLOUDSTACK-8958. These ip ranges need to be released