Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-202951746
@pedro-martins Thanks for the review but I don't want to make this change
because (a) it'll mix two intents into on PR - fixing the bug *and* improving
the logging -
Github user pedro-martins commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1451#discussion_r57537243
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java ---
@@ -180,7 +179,7 @@ private Answer applyConfig(NetworkEl
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-202164340
@alexandrelimassantana Ah, I see that now. Thanks for the clarification! :)
---
If your project is set up for it, you can reply to this email and have your
rep
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-202161988
@cristofolini there is no _timeout_ variable in the scope you commented.
His change is valid because _VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT_ is mapped
Github user cristofolini commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1451#discussion_r57535012
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java ---
@@ -180,7 +179,7 @@ private Answer applyConfig(NetworkEle
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-201620444
@alexandrelimassantana Agreed, thanks for the review. I've added a commit
removing the prototype with the default. That has allowed me to remove that if
altogether an
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-201610435
@insom with this changes there is still one place where the applyConfigToVR
is not provided with this timeout parameter (line 183, same class). This
f
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-201246728
@insom any chance you can supply some test-mech?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/1451
CLOUDSTACK-9319: Use timeout when applying config to virtual router
From the [JIRA
issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9319):
> The timeout parameter is not passed do
