Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-221861017
Can I get one more review on this one? I think we are basically set
otherwise. Thx...
---
If your project is set up for it, you can reply to this email and have you
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-221780994
@swill Resolved the merge conflicts. They were because of import statements.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-221763988
This one needs some work. We have merge conflicts and we need another code
review.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r64009630
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private Plug
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r6362
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private PlugNi
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63997069
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private Plug
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63988259
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63988285
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1298,6 +1304,27 @@ private static DiskTO get
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63988200
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private PlugNi
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-220464828
Really like the functionality so I think we must get this in. I have some
remarks about the code that I stand by even though they are not entirely to
blame on @
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63961096
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCopyFileInVmCommandWrapper.java
---
@@ -0,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63960701
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -5402,4 +5402,20 @@ public boolea
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63960622
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1298,6 +1304,27 @@ private static DiskTO g
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63959786
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63959351
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private Plug
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63959496
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-220447959
I think with @milamberspace's review, we are only missing one code review
to get this one in. Thanks everyone...
---
If your project is set up for it, you can reply
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-220446031
LGTM.
Tested manually with a real test deployment of CS49, with my French azerty
keyboard: works fine.
---
If your project is set up for it, you ca
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-220025191
This shows that it does not break anything, but I don't think we have any
verification that this feature works as expected yet...
---
If your project is set up for it
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-220024998
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 4h 18m 27s
```
**Summary of the pr
GitHub user anshul1886 reopened a pull request:
https://github.com/apache/cloudstack/pull/669
Made the adding new keyboard language support easier
https://issues.apache.org/jira/browse/CLOUDSTACK-8665
This branch has implemented following improvements in console proxy
keybo
Github user anshul1886 closed the pull request at:
https://github.com/apache/cloudstack/pull/669
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-219918785
@swill They are failing on a test which don't even exist in source code.
That test is in PR #1360 which is not yet merged so looks like some cleanup
issue.
---
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-219793270
@anshul1886 can you review the Jenkin errors and close and reopen the PR if
they do not seem relevant to kick off the Jenkins run again. Thx...
---
If your project i
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-219672865
@milamberspace Added the localisation key in message.properties and now
using it in consoleKeyboardOptions
---
If your project is set up for it, you can reply to
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63469835
--- Diff: ui/consoleKeyboardOptions.jsp ---
@@ -0,0 +1,24 @@
+<%--
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-219620496
@swill Rebased against the current master and also squashed the commits
into one.
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-219129109
Thanks @anshul1886. Keep in mind that the freeze date for 4.9 is Monday
next week.
---
If your project is set up for it, you can reply to this email and have your
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-218980649
@swill Its showing lot of conflicts currently and will take some time to
resolve those. Will update PR once I will get some time.
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-218869670
This PR currently have merge conflicts. Can you rebase please? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-216186163
@anshul1886 please rebase against latest master and share status of your PR
This looks like an interesting PR we should have
---
If your project is set up for it,
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-175664522
@sedukull @anshul1886 please rebase against latest branch and help re-review
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-131683677
@sedukull , Can you give a LGTM now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36952117
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
+
--- End di
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36949815
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
+
--- End
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36839282
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
+
--- End di
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36833745
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
+
--- End
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36832023
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
+
--- End di
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36711314
--- Diff: systemvm/js/ajaxviewer.js ---
@@ -184,7 +205,7 @@ KeyboardMapper.prototype = {
if(eventType == AjaxViewer.KEY_UP && (c
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r3676
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cm
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710980
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cm
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710950
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNi
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710924
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710619
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705867
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705320
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705202
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNicA
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705033
--- Diff: systemvm/js/ajaxviewer.js ---
@@ -184,7 +205,7 @@ KeyboardMapper.prototype = {
if(eventType == AjaxViewer.KEY_UP && (cod
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36704745
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cmds
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36612869
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36612463
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNi
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36612331
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cm
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611905
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cm
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611661
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611512
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNicA
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611296
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611238
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cmds
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611175
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cmds
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611140
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNi
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611046
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO get
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611014
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO get
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609308
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNicA
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609278
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609212
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609071
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO getIs
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609019
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO getIs
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36608900
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/669
Made the adding new keyboard language support easier
This branch has implemented following improvements in console proxy
keyboard language support
1) ajaxviewer.js and ajaxkeys.js ar
68 matches
Mail list logo
